From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH igt] igt/prime_mmap_coherency: Only assert correct usage of sync API Date: Tue, 17 Oct 2017 15:05:29 +0300 Message-ID: <20171017120529.GQ10981@intel.com> References: <20171011095629.19163-1-chris@chris-wilson.co.uk> <150823703227.6894.17870258747245341139@mail.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 138086E64E for ; Tue, 17 Oct 2017 12:05:39 +0000 (UTC) Content-Disposition: inline In-Reply-To: <150823703227.6894.17870258747245341139@mail.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBPY3QgMTcsIDIwMTcgYXQgMTE6NDM6NTJBTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IFF1b3RpbmcgQ2hyaXMgV2lsc29uICgyMDE3LTEwLTExIDEwOjU2OjI5KQo+ID4gSWdu b3JlIHRoZSB1bmV4cGVjdGVkIHN1Y2Nlc3Mgd2hlbiB0aGUgQ1BVIGNhY2hlIGlzIHJhbmRvbWx5 IGZsdXNoZWQKPiA+IHRoYXQgbWFrZXMgIWxsYyBhcHBlYXIgdG8gd29yayB3aXRob3V0IHN5bmMu IEl0IGhhcHBlbnMsIHRoZSBjcHUgY2FjaGUKPiA+IGlzIGEgZmlja2xlIGJlYXN0IHRoYXQgd2Ug ZG8gbm90IGhhdmUgc29sZSBjb250cm9sIG92ZXIuIEluc3RlYWQgbGltaXQKPiA+IHRoZSB0ZXN0 IHRvIGRldGVjdCBmYWlsdXJlcyB3aGVuIHRoZSBBUEkgaXMgYmVpbmcgYWRoZXJlZCB0by4KPiA+ IAo+ID4gQnVnemlsbGE6IGh0dHBzOi8vYnVncy5mcmVlZGVza3RvcC5vcmcvc2hvd19idWcuY2dp P2lkPTEwMzE2OAo+ID4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13 aWxzb24uY28udWs+Cj4gCj4gUGluZz8KClJhdGlvbmFsZSBtYWtlcyBzZW5zZS4KClJldmlld2Vk LWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgoKPiAK PiA+IC0tLQo+ID4gIHRlc3RzL3ByaW1lX21tYXBfY29oZXJlbmN5LmMgfCA3MSArKysrKysrKysr KysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAy MiBpbnNlcnRpb25zKCspLCA0OSBkZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL3Rl c3RzL3ByaW1lX21tYXBfY29oZXJlbmN5LmMgYi90ZXN0cy9wcmltZV9tbWFwX2NvaGVyZW5jeS5j Cj4gPiBpbmRleCA5ODMxZDc3NS4uYTIxM2FjMGYgMTAwNjQ0Cj4gPiAtLS0gYS90ZXN0cy9wcmlt ZV9tbWFwX2NvaGVyZW5jeS5jCj4gPiArKysgYi90ZXN0cy9wcmltZV9tbWFwX2NvaGVyZW5jeS5j Cj4gPiBAQCAtMzQsMTAgKzM0LDcgQEAKPiA+ICBJR1RfVEVTVF9ERVNDUklQVElPTigiVGVzdCBk bWEtYnVmIG1tYXAgb24gIWxsYyBwbGF0Zm9ybXMgbW9zdGx5IGFuZCBwcm92b2tlIgo+ID4gICAg ICAgICAgICAgICAgICIgY29oZXJlbmN5IGJ1Z3Mgc28gd2Uga25vdyBmb3Igc3VyZSB3aGVyZSB3 ZSBuZWVkIHRoZSBzeW5jIGlvY3Rscy4iKTsKPiA+ICAKPiA+IC0jZGVmaW5lIFJPVU5EUyAyMAo+ ID4gLQo+ID4gIGludCBmZDsKPiA+IC1pbnQgc3RhbGUgPSAwOwo+ID4gIHN0YXRpYyBkcm1faW50 ZWxfYnVmbWdyICpidWZtZ3I7Cj4gPiAgc3RydWN0IGludGVsX2JhdGNoYnVmZmVyICpiYXRjaDsK PiA+ICBzdGF0aWMgaW50IHdpZHRoID0gMTAyNCwgaGVpZ2h0ID0gMTAyNDsKPiA+IEBAIC00OSwx MyArNDYsMTQgQEAgc3RhdGljIGludCB3aWR0aCA9IDEwMjQsIGhlaWdodCA9IDEwMjQ7Cj4gPiAg ICogICAzLiB3cml0ZSAnMSdzLCBpbiBHVFQgZG9tYWluLgo+ID4gICAqICAgNC4gcmVhZCBhZ2Fp biB0aHJvdWdoIHRoZSBtYXBwZWQgZG1hLWJ1Zi4KPiA+ICAgKi8KPiA+IC1zdGF0aWMgdm9pZCB0 ZXN0X3JlYWRfZmx1c2goYm9vbCBleHBlY3Rfc3RhbGVfY2FjaGUpCj4gPiArc3RhdGljIGludCB0 ZXN0X3JlYWRfZmx1c2godm9pZCkKPiA+ICB7Cj4gPiAgICAgICAgIGRybV9pbnRlbF9ibyAqYm9f MTsKPiA+ICAgICAgICAgZHJtX2ludGVsX2JvICpib18yOwo+ID4gICAgICAgICB1aW50MzJfdCAq cHRyX2NwdTsKPiA+ICAgICAgICAgdWludDMyX3QgKnB0cl9ndHQ7Cj4gPiAgICAgICAgIGludCBk bWFfYnVmX2ZkLCBpOwo+ID4gKyAgICAgICBpbnQgc3RhbGUgPSAwOwo+ID4gIAo+ID4gICAgICAg ICBib18xID0gZHJtX2ludGVsX2JvX2FsbG9jKGJ1Zm1nciwgIkJPIDEiLCB3aWR0aCAqIGhlaWdo dCAqIDQsIDQwOTYpOwo+ID4gIAo+ID4gQEAgLTk0LDE4ICs5MiwxNiBAQCBzdGF0aWMgdm9pZCB0 ZXN0X3JlYWRfZmx1c2goYm9vbCBleHBlY3Rfc3RhbGVfY2FjaGUpCj4gPiAgICAgICAgICAqIHN0 YWxlIGNhY2hlbGluZXMgZnJvbSBzdGVwICMyIHN1cnZpdmUgKG1vc3RseSwgYSBmZXcgd2lsbCBi ZSBldmljdGVkKQo+ID4gICAgICAgICAgKiB1bnRpbCB3ZSB0cnkgdG8gcmVhZCB0aGVtIGFnYWlu IGluIHN0ZXAgIzQuIFRoaXMgYmVoYXZpb3IgY291bGQgYmUgZml4ZWQKPiA+ICAgICAgICAgICog YnkgZmx1c2ggQ1BVIHJlYWQgcmlnaHQgYmVmb3JlIGFjY2Vzc2luZyB0aGUgQ1BVIHBvaW50ZXIg Ki8KPiA+IC0gICAgICAgaWYgKCFleHBlY3Rfc3RhbGVfY2FjaGUpCj4gPiAtICAgICAgICAgICAg ICAgcHJpbWVfc3luY19zdGFydChkbWFfYnVmX2ZkLCBmYWxzZSk7Cj4gPiArICAgICAgIHByaW1l X3N5bmNfc3RhcnQoZG1hX2J1Zl9mZCwgZmFsc2UpOwo+ID4gIAo+ID4gICAgICAgICBmb3IgKGkg PSAwOyBpIDwgKHdpZHRoICogaGVpZ2h0KSAvIDQ7IGkrKykKPiA+IC0gICAgICAgICAgICAgICBp ZiAocHRyX2NwdVtpXSAhPSAweGM1YzVjNWM1KSB7Cj4gPiAtICAgICAgICAgICAgICAgICAgICAg ICBpZ3Rfd2Fybl9vbl9mKCFleHBlY3Rfc3RhbGVfY2FjaGUsCj4gPiAtICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAiRm91bmQgMHglMDh4IGF0IG9mZnNldCAweCUwOHhcbiIsIHB0 cl9jcHVbaV0sIGkpOwo+ID4gKyAgICAgICAgICAgICAgIGlmIChwdHJfY3B1W2ldICE9IDB4YzVj NWM1YzUpCj4gPiAgICAgICAgICAgICAgICAgICAgICAgICBzdGFsZSsrOwo+ID4gLSAgICAgICAg ICAgICAgIH0KPiA+ICAKPiA+ICAgICAgICAgZHJtX2ludGVsX2JvX3VucmVmZXJlbmNlKGJvXzEp Owo+ID4gICAgICAgICBtdW5tYXAocHRyX2NwdSwgd2lkdGggKiBoZWlnaHQpOwo+ID4gKwo+ID4g KyAgICAgICByZXR1cm4gc3RhbGU7Cj4gPiAgfQo+ID4gIAo+ID4gIC8qCj4gPiBAQCAtMTE1LDEz ICsxMTEsMTQgQEAgc3RhdGljIHZvaWQgdGVzdF9yZWFkX2ZsdXNoKGJvb2wgZXhwZWN0X3N0YWxl X2NhY2hlKQo+ID4gICAqICAgMy4gY29weSBCTyAxIHRvIG5ldyBCTyAyLCBpbiBHVFQgZG9tYWlu Lgo+ID4gICAqICAgNC4gcmVhZCB2aWEgZG1hLWJ1ZiBtbWFwIEJPIDIuCj4gPiAgICovCj4gPiAt c3RhdGljIHZvaWQgdGVzdF93cml0ZV9mbHVzaChib29sIGV4cGVjdF9zdGFsZV9jYWNoZSkKPiA+ ICtzdGF0aWMgaW50IHRlc3Rfd3JpdGVfZmx1c2godm9pZCkKPiA+ICB7Cj4gPiAgICAgICAgIGRy bV9pbnRlbF9ibyAqYm9fMTsKPiA+ICAgICAgICAgZHJtX2ludGVsX2JvICpib18yOwo+ID4gICAg ICAgICB1aW50MzJfdCAqcHRyX2NwdTsKPiA+ICAgICAgICAgdWludDMyX3QgKnB0cjJfY3B1Owo+ ID4gICAgICAgICBpbnQgZG1hX2J1Zl9mZCwgZG1hX2J1ZjJfZmQsIGk7Cj4gPiArICAgICAgIGlu dCBzdGFsZSA9IDA7Cj4gPiAgCj4gPiAgICAgICAgIGJvXzEgPSBkcm1faW50ZWxfYm9fYWxsb2Mo YnVmbWdyLCAiQk8gMSIsIHdpZHRoICogaGVpZ2h0ICogNCwgNDA5Nik7Cj4gPiAgCj4gPiBAQCAt MTQzLDggKzE0MCw3IEBAIHN0YXRpYyB2b2lkIHRlc3Rfd3JpdGVfZmx1c2goYm9vbCBleHBlY3Rf c3RhbGVfY2FjaGUpCj4gPiAgCj4gPiAgICAgICAgIC8qIFRoaXMgaXMgdGhlIG1haW4gcG9pbnQg b2YgdGhpcyB0ZXN0OiAhbGxjIGh3IHJlcXVpcmVzIGEgY2FjaGUgd3JpdGUKPiA+ICAgICAgICAg ICogZmx1c2ggcmlnaHQgaGVyZSAoZXhwbGFpbmVkIGluIHN0ZXAgIzQpLiAqLwo+ID4gLSAgICAg ICBpZiAoIWV4cGVjdF9zdGFsZV9jYWNoZSkKPiA+IC0gICAgICAgICAgICAgICBwcmltZV9zeW5j X3N0YXJ0KGRtYV9idWZfZmQsIHRydWUpOwo+ID4gKyAgICAgICBwcmltZV9zeW5jX3N0YXJ0KGRt YV9idWZfZmQsIHRydWUpOwo+ID4gIAo+ID4gICAgICAgICBtZW1zZXQocHRyX2NwdSwgMHgxMSwg d2lkdGggKiBoZWlnaHQpOwo+ID4gIAo+ID4gQEAgLTE2NCwxNSArMTYwLDE0IEBAIHN0YXRpYyB2 b2lkIHRlc3Rfd3JpdGVfZmx1c2goYm9vbCBleHBlY3Rfc3RhbGVfY2FjaGUpCj4gPiAgICAgICAg IGlndF9hc3NlcnQocHRyMl9jcHUgIT0gTUFQX0ZBSUxFRCk7Cj4gPiAgCj4gPiAgICAgICAgIGZv ciAoaSA9IDA7IGkgPCAod2lkdGggKiBoZWlnaHQpIC8gNDsgaSsrKQo+ID4gLSAgICAgICAgICAg ICAgIGlmIChwdHIyX2NwdVtpXSAhPSAweDExMTExMTExKSB7Cj4gPiAtICAgICAgICAgICAgICAg ICAgICAgICBpZ3Rfd2Fybl9vbl9mKCFleHBlY3Rfc3RhbGVfY2FjaGUsCj4gPiAtICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICJGb3VuZCAweCUwOHggYXQgb2Zmc2V0IDB4JTA4 eFxuIiwgcHRyMl9jcHVbaV0sIGkpOwo+ID4gKyAgICAgICAgICAgICAgIGlmIChwdHIyX2NwdVtp XSAhPSAweDExMTExMTExKQo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgc3RhbGUrKzsKPiA+ IC0gICAgICAgICAgICAgICB9Cj4gPiAgCj4gPiAgICAgICAgIGRybV9pbnRlbF9ib191bnJlZmVy ZW5jZShib18xKTsKPiA+ICAgICAgICAgZHJtX2ludGVsX2JvX3VucmVmZXJlbmNlKGJvXzIpOwo+ ID4gICAgICAgICBtdW5tYXAocHRyX2NwdSwgd2lkdGggKiBoZWlnaHQpOwo+ID4gKwo+ID4gKyAg ICAgICByZXR1cm4gc3RhbGU7Cj4gPiAgfQo+ID4gIAo+ID4gIHN0YXRpYyB2b2lkIGJsaXRfYW5k X2NtcCh2b2lkKQo+ID4gQEAgLTI3OSw3ICsyNzQsNiBAQCBzdGF0aWMgdm9pZCB0ZXN0X2lvY3Rs X2Vycm9ycyh2b2lkKQo+ID4gIAo+ID4gIGludCBtYWluKGludCBhcmdjLCBjaGFyICoqYXJndikK PiA+ICB7Cj4gPiAtICAgICAgIGludCBpOwo+ID4gICAgICAgICBpZ3Rfc3VidGVzdF9pbml0KGFy Z2MsIGFyZ3YpOwo+ID4gIAo+ID4gICAgICAgICBpZ3RfZml4dHVyZSB7Cj4gPiBAQCAtMjkzLDQx ICsyODcsMjAgQEAgaW50IG1haW4oaW50IGFyZ2MsIGNoYXIgKiphcmd2KQo+ID4gICAgICAgICAv KiBDYWNoZSBjb2hlcmVuY3kgYW5kIHRoZSBldmljdGlvbiBhcmUgcHJldHR5IG11Y2ggdW5wcmVk aWN0YWJsZSwgc28KPiA+ICAgICAgICAgICogcmVwcm9kdWNpbmcgYm9pbHMgZG93biB0byB0cmlh bCBhbmQgZXJyb3IgdG8gaGl0IGRpZmZlcmVudCBzY2VuYXJpb3MuCj4gPiAgICAgICAgICAqIFRP RE86IFdlIG1heSB3YW50IHRvIGltcHJvdmUgdGVzdHMgYSBiaXQgYnkgcGlja2luZyByYW5kb20g c3VicmFuZ2VzLiAqLwo+ID4gLSAgICAgICBpZ3RfaW5mbygiJWQgcm91bmRzIGZvciBlYWNoIHRl c3RcbiIsIFJPVU5EUyk7Cj4gPiAgICAgICAgIGlndF9zdWJ0ZXN0KCJyZWFkIikgewo+ID4gLSAg ICAgICAgICAgICAgIHN0YWxlID0gMDsKPiA+IC0gICAgICAgICAgICAgICBpZ3RfaW5mbygiZXhl cmNpc2luZyByZWFkIGZsdXNoXG4iKTsKPiA+IC0gICAgICAgICAgICAgICBmb3IgKGkgPSAwOyBp IDwgUk9VTkRTOyBpKyspCj4gPiAtICAgICAgICAgICAgICAgICAgICAgICB0ZXN0X3JlYWRfZmx1 c2goZmFsc2UpOwo+ID4gLSAgICAgICAgICAgICAgIGlndF9mYWlsX29uX2Yoc3RhbGUsICJudW0g b2Ygc3RhbGUgY2FjaGUgbGluZXMgJWRcbiIsIHN0YWxlKTsKPiA+IC0gICAgICAgfQo+ID4gLQo+ ID4gLSAgICAgICAvKiBPbmx5IGZvciAhbGxjIHBsYXRmb3JtcyAqLwo+ID4gLSAgICAgICBpZ3Rf c3VidGVzdCgicmVhZC1hbmQtZmFpbCIpIHsKPiA+IC0gICAgICAgICAgICAgICBpZ3RfcmVxdWly ZSghZ2VtX2hhc19sbGMoZmQpKTsKPiA+IC0gICAgICAgICAgICAgICBzdGFsZSA9IDA7Cj4gPiAt ICAgICAgICAgICAgICAgaWd0X2luZm8oImV4ZXJjaXNpbmcgcmVhZCBmbHVzaCBhbmQgZXhwZWN0 IHRvIGZhaWwgb24gIWxsY1xuIik7Cj4gPiAtICAgICAgICAgICAgICAgZm9yIChpID0gMDsgaSA8 IFJPVU5EUzsgaSsrKQo+ID4gLSAgICAgICAgICAgICAgICAgICAgICAgdGVzdF9yZWFkX2ZsdXNo KHRydWUpOwo+ID4gLSAgICAgICAgICAgICAgIGlndF9mYWlsX29uX2YoIXN0YWxlLCAiY291bGRu J3QgZmluZCBhbnkgc3RhbGUgY2FjaGUgbGluZXNcbiIpOwo+ID4gKyAgICAgICAgICAgICAgIGln dF91bnRpbF90aW1lb3V0KDUpIHsKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgIGludCBzdGFs ZSA9IHRlc3RfcmVhZF9mbHVzaCgpOwo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgaWd0X2Zh aWxfb25fZihzdGFsZSwKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg Im51bSBvZiBzdGFsZSBjYWNoZSBsaW5lcyAlZFxuIiwgc3RhbGUpOwo+ID4gKyAgICAgICAgICAg ICAgIH0KPiA+ICAgICAgICAgfQo+ID4gIAo+ID4gICAgICAgICBpZ3Rfc3VidGVzdCgid3JpdGUi KSB7Cj4gPiAtICAgICAgICAgICAgICAgc3RhbGUgPSAwOwo+ID4gLSAgICAgICAgICAgICAgIGln dF9pbmZvKCJleGVyY2lzaW5nIHdyaXRlIGZsdXNoXG4iKTsKPiA+IC0gICAgICAgICAgICAgICBm b3IgKGkgPSAwOyBpIDwgUk9VTkRTOyBpKyspCj4gPiAtICAgICAgICAgICAgICAgICAgICAgICB0 ZXN0X3dyaXRlX2ZsdXNoKGZhbHNlKTsKPiA+IC0gICAgICAgICAgICAgICBpZ3RfZmFpbF9vbl9m KHN0YWxlLCAibnVtIG9mIHN0YWxlIGNhY2hlIGxpbmVzICVkXG4iLCBzdGFsZSk7Cj4gPiAtICAg ICAgIH0KPiA+IC0KPiA+IC0gICAgICAgLyogT25seSBmb3IgIWxsYyBwbGF0Zm9ybXMgKi8KPiA+ IC0gICAgICAgaWd0X3N1YnRlc3QoIndyaXRlLWFuZC1mYWlsIikgewo+ID4gLSAgICAgICAgICAg ICAgIGlndF9yZXF1aXJlKCFnZW1faGFzX2xsYyhmZCkpOwo+ID4gLSAgICAgICAgICAgICAgIHN0 YWxlID0gMDsKPiA+IC0gICAgICAgICAgICAgICBpZ3RfaW5mbygiZXhlcmNpc2luZyB3cml0ZSBm bHVzaCBhbmQgZXhwZWN0IHRvIGZhaWwgb24gIWxsY1xuIik7Cj4gPiAtICAgICAgICAgICAgICAg Zm9yIChpID0gMDsgaSA8IFJPVU5EUzsgaSsrKQo+ID4gLSAgICAgICAgICAgICAgICAgICAgICAg dGVzdF93cml0ZV9mbHVzaCh0cnVlKTsKPiA+IC0gICAgICAgICAgICAgICBpZ3RfZmFpbF9vbl9m KCFzdGFsZSwgImNvdWxkbid0IGZpbmQgYW55IHN0YWxlIGNhY2hlIGxpbmVzXG4iKTsKPiA+ICsg ICAgICAgICAgICAgICBpZ3RfdW50aWxfdGltZW91dCg1KSB7Cj4gPiArICAgICAgICAgICAgICAg ICAgICAgICBpbnQgc3RhbGUgPSB0ZXN0X3dyaXRlX2ZsdXNoKCk7Cj4gPiArICAgICAgICAgICAg ICAgICAgICAgICBpZ3RfZmFpbF9vbl9mKHN0YWxlLAo+ID4gKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAibnVtIG9mIHN0YWxlIGNhY2hlIGxpbmVzICVkXG4iLCBzdGFsZSk7 Cj4gPiArICAgICAgICAgICAgICAgfQo+ID4gICAgICAgICB9Cj4gPiAgCj4gPiAgICAgICAgIGln dF9zdWJ0ZXN0KCJpb2N0bC1lcnJvcnMiKSB7Cj4gPiAtLSAKPiA+IDIuMTUuMC5yYzAKPiA+IAo+ IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAoKLS0g ClZpbGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vaW50ZWwtZ2Z4Cg==