From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/atomic-helper: check that drivers call drm_crtc_vblank_off Date: Tue, 17 Oct 2017 18:11:52 +0300 Message-ID: <20171017151152.GU10981@intel.com> References: <20171017145939.438-1-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20171017145939.438-1-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: Daniel Vetter , Intel Graphics Development , DRI Development List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBPY3QgMTcsIDIwMTcgYXQgMDQ6NTk6MzlQTSArMDIwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBBdCBsZWFzdCB3aGVuIHRoZXkgaGF2ZSB2Ymxhbmsgc3VwcG9ydCB0aGV5IG5lZWQg dG8gY2FsbCB0aGlzLCBvciB0aGUKPiB2YmxhbmsgY29yZSB3aWxsIGhhcHBpbHkgY2FsbCBpbnRv IHRoZWlyIGNydGMtPmVuYWJsZV92YmxhbmsgY2FsbGJhY2sKPiBldmVuIHdoZW4gdGhlIGNydGMg aXMgb2ZmLiBXaGljaCBsZWFkcyB0byBhIGJvb20gd2hlbiB0aGUgY2xvY2tzIGFyZQo+IG9mZiBv biBtb3N0IGhhcmR3YXJlIChiZXNpZGVzIHRoZSBpbmV2aXRhYmxlIGNvbmZ1c2lvbiBpbiB0aGUK PiBib29rLWtlZXBpbmcpLgo+IAo+IFRoZSBjb25zaXN0ZW5jeSBjaGVja3MgaW4gZHJtX3ZibGFu ay5jIHdpbGwgdGhlbiBtYWtlIHN1cmUgdGhhdAo+IHZibGFua19vZmYvb24gY2FsbHMgYXJlIGJh bGFuY2VkLCBhbmQgaWYgZHJpdmVycyBmb3JnZXQgdG8gcmUtZW5hYmxlCj4gaXQgYWxsIHRoZSBj b21taXRzIHdpbGwgc3RhbGwsIHNvIEkgdGhpbmsgd2UncmUgY292ZXJlZC4KPiAKPiBJdCdkIGJl IG5pY2UgdG8gYmUgYWJsZSB0byBwbGFjZSB0aGlzIGNoZWNrIG91dHNpZGUgb2YgY29tbWl0IGhl bHBlcnMsCj4gYnV0IHRoYSdzIG5vdCByZWFsbHkgcG9zc2libGUgKGR1ZSB0byBub25ibG9ja2lu ZyBjb21taXRzIGFuZCBhbGwKPiB0aGF0KS4gUGxhY2luZyBpdCBpbnRvIGF0b21pYyBoZWxwZXJz IHNob3VsZCBhdCBsZWFzdCBjb3ZlciBtb3N0Cj4gZHJpdmVycy4KPiAKPiBBbHNvIG5vdGUgdGhh dCB2Ymxhbmsgc3VwcG9ydCBpcyBzdGlsbCBvcHRpb25hbCAoZm9yIHZpcnR1YWwgZHJpdmVycywK PiB3aGljaCB0ZW5kIHRvIG5vdCBoYXZlIHRoaXMpLCBjaGVjayBmb3IgdGhhdC4KPiAKPiBDYzog Um9iIENsYXJrIDxyb2JkY2xhcmtAZ21haWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IERhbmllbCBW ZXR0ZXIgPGRhbmllbC52ZXR0ZXJAaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0v ZHJtX2F0b21pY19oZWxwZXIuYyB8IDkgKysrKysrKysrCj4gIDEgZmlsZSBjaGFuZ2VkLCA5IGlu c2VydGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNf aGVscGVyLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYwo+IGluZGV4IGFl NTZkOTE0MzNmZi4uY2M5YzAxNzNlMDc1IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9k cm1fYXRvbWljX2hlbHBlci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVs cGVyLmMKPiBAQCAtODYwLDYgKzg2MCw3IEBAIGRpc2FibGVfb3V0cHV0cyhzdHJ1Y3QgZHJtX2Rl dmljZSAqZGV2LCBzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqb2xkX3N0YXRlKQo+ICAKPiAgCWZv cl9lYWNoX29sZG5ld19jcnRjX2luX3N0YXRlKG9sZF9zdGF0ZSwgY3J0Yywgb2xkX2NydGNfc3Rh dGUsIG5ld19jcnRjX3N0YXRlLCBpKSB7Cj4gIAkJY29uc3Qgc3RydWN0IGRybV9jcnRjX2hlbHBl cl9mdW5jcyAqZnVuY3M7Cj4gKwkJaW50IHJldDsKPiAgCj4gIAkJLyogU2h1dCBkb3duIGV2ZXJ5 dGhpbmcgdGhhdCBuZWVkcyBhIGZ1bGwgbW9kZXNldC4gKi8KPiAgCQlpZiAoIWRybV9hdG9taWNf Y3J0Y19uZWVkc19tb2Rlc2V0KG5ld19jcnRjX3N0YXRlKSkKPiBAQCAtODgzLDYgKzg4NCwxNCBA QCBkaXNhYmxlX291dHB1dHMoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgc3RydWN0IGRybV9hdG9t aWNfc3RhdGUgKm9sZF9zdGF0ZSkKPiAgCQkJZnVuY3MtPmRpc2FibGUoY3J0Yyk7Cj4gIAkJZWxz ZQo+ICAJCQlmdW5jcy0+ZHBtcyhjcnRjLCBEUk1fTU9ERV9EUE1TX09GRik7Cj4gKwo+ICsJCWlm ICghKGRldi0+aXJxX2VuYWJsZWQgJiYgZGV2LT5udW1fY3J0Y3MpKQoKbnVtX2NydGNzIGNvbmZ1 c2VkIG1lLiBNYXliZSB3ZSBzaG91bGQgcmVuYW1lIGl0IHRvIG51bV92YmxhbmtfY3J0Y3Mgb3IK c29tZXRoaW5nLi4uCgo+ICsJCQljb250aW51ZTsKPiArCj4gKwkJcmV0ID0gZHJtX2NydGNfdmJs YW5rX2dldChjcnRjKTsKPiArCQlXQVJOX09OQ0UocmV0ICE9IC1FSU5WQUwsICJkcml2ZXIgZm9y Z290IHRvIGNhbGwgZHJtX2NydGNfdmJsYW5rX29mZigpXG4iKTsKPiArCQlpZiAocmV0KQoKcmV0 PT0wIHByZXN1bWFibHkKCj4gKwkJCWRybV9jcnRjX3ZibGFua19wdXQoY3J0Yyk7Cj4gIAl9Cj4g IH0KPiAgCj4gLS0gCj4gMi4xNC4xCj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxp c3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFp bGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK