From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v3 11/22] drm/i915/cnl: Move GT and Display workarounds from init_clock_gating Date: Wed, 18 Oct 2017 15:44:57 +0300 Message-ID: <20171018124457.GH10981@intel.com> References: <1507928056-6966-1-git-send-email-oscar.mateo@intel.com> <1507928056-6966-12-git-send-email-oscar.mateo@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 232726E250 for ; Wed, 18 Oct 2017 12:45:02 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1507928056-6966-12-git-send-email-oscar.mateo@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Oscar Mateo Cc: intel-gfx@lists.freedesktop.org, Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBPY3QgMTMsIDIwMTcgYXQgMDE6NTQ6MDVQTSAtMDcwMCwgT3NjYXIgTWF0ZW8gd3Jv dGU6Cj4gVG8gdGhlaXIgcmlnaHRmdWwgcGxhY2UgaW5zaWRlIGludGVsX3dvcmthcm91bmRzLmMK PiAKPiBTaWduZWQtb2ZmLWJ5OiBPc2NhciBNYXRlbyA8b3NjYXIubWF0ZW9AaW50ZWwuY29tPgo+ IENjOiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28udml2aUBpbnRlbC5jb20+Cj4gQ2M6IENocmlzIFdp bHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IENjOiBNaWthIEt1b3BwYWxhIDxtaWth Lmt1b3BwYWxhQGxpbnV4LmludGVsLmNvbT4KPiBDYzogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5z eXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfcG0uYyAgICAgICAgICB8IDMyICstLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4g IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3dvcmthcm91bmRzLmMgfCAyNiArKysrKysrKysr KysrKysrKysrKysrKysrLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDI2IGluc2VydGlvbnMoKyksIDMy IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9wbS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+IGluZGV4IGU0YjM5MDQu LjNmOTJiZWQxIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMK PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wbS5jCj4gQEAgLTg1MDksMzYgKzg1 MDksNiBAQCBzdGF0aWMgdm9pZCBjbnBfaW5pdF9jbG9ja19nYXRpbmcoc3RydWN0IGRybV9pOTE1 X3ByaXZhdGUgKmRldl9wcml2KQo+ICAJCSAgIENOUF9QV01fQ0dFX0dBVElOR19ESVNBQkxFKTsK PiAgfQo+ICAKPiAtc3RhdGljIHZvaWQgY25sX2luaXRfY2xvY2tfZ2F0aW5nKHN0cnVjdCBkcm1f aTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAtewo+IC0JdTMyIHZhbDsKPiAtCWNucF9pbml0X2Ns b2NrX2dhdGluZyhkZXZfcHJpdik7Cj4gLQo+IC0JLyogVGhpcyBpcyBub3QgYW4gV2EuIEVuYWJs ZSBmb3IgYmV0dGVyIGltYWdlIHF1YWxpdHkgKi8KPiAtCUk5MTVfV1JJVEUoXzNEX0NISUNLRU4z LAo+IC0JCSAgIF9NQVNLRURfQklUX0VOQUJMRShfM0RfQ0hJQ0tFTjNfQUFfTElORV9RVUFMSVRZ X0ZJWF9FTkFCTEUpKTsKPiAtCj4gLQkvKiBXYUVuYWJsZUNoaWNrZW5EQ1BSOmNubCAqLwo+IC0J STkxNV9XUklURShHRU44X0NISUNLRU5fRENQUl8xLAo+IC0JCSAgIEk5MTVfUkVBRChHRU44X0NI SUNLRU5fRENQUl8xKSB8IE1BU0tfV0FLRU1FTSk7Cj4gLQo+IC0JLyogV2FGYmNXYWtlTWVtT246 Y25sICovCj4gLQlJOTE1X1dSSVRFKERJU1BfQVJCX0NUTCwgSTkxNV9SRUFEKERJU1BfQVJCX0NU TCkgfAo+IC0JCSAgIERJU1BfRkJDX01FTU9SWV9XQUtFKTsKPiAtCj4gLQkvKiBXYVNhcmJVbml0 Q2xvY2tHYXRpbmdEaXNhYmxlOmNubCAocHJlLXByb2QpICovCj4gLQlpZiAoSVNfQ05MX1JFVklE KGRldl9wcml2LCBDTkxfUkVWSURfQTAsIENOTF9SRVZJRF9CMCkpCj4gLQkJSTkxNV9XUklURShT TElDRV9VTklUX0xFVkVMX0NMS0dBVEUsCj4gLQkJCSAgIEk5MTVfUkVBRChTTElDRV9VTklUX0xF VkVMX0NMS0dBVEUpIHwKPiAtCQkJICAgU0FSQlVOSVRfQ0xLR0FURV9ESVMpOwo+IC0KPiAtCS8q IERpc3BsYXkgV0EgIzExMzM6IFdhRmJjU2tpcFNlZ21lbnRzOmNubCAqLwo+IC0JdmFsID0gSTkx NV9SRUFEKElMS19EUEZDX0NISUNLRU4pOwo+IC0JdmFsICY9IH5HTEtfU0tJUF9TRUdfQ09VTlRf TUFTSzsKPiAtCXZhbCB8PSBHTEtfU0tJUF9TRUdfRU4gfCBHTEtfU0tJUF9TRUdfQ09VTlQoMSk7 Cj4gLQlJOTE1X1dSSVRFKElMS19EUEZDX0NISUNLRU4sIHZhbCk7Cj4gLX0KPiAtCj4gIHN0YXRp YyB2b2lkIGNmbF9pbml0X2Nsb2NrX2dhdGluZyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2 X3ByaXYpCj4gIHsKPiAgCWNucF9pbml0X2Nsb2NrX2dhdGluZyhkZXZfcHJpdik7Cj4gQEAgLTkw MzAsNyArOTAwMCw3IEBAIHN0YXRpYyB2b2lkIG5vcF9pbml0X2Nsb2NrX2dhdGluZyhzdHJ1Y3Qg ZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gIHZvaWQgaW50ZWxfaW5pdF9jbG9ja19nYXRp bmdfaG9va3Moc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICB7Cj4gIAlpZiAo SVNfQ0FOTk9OTEFLRShkZXZfcHJpdikpCj4gLQkJZGV2X3ByaXYtPmRpc3BsYXkuaW5pdF9jbG9j a19nYXRpbmcgPSBjbmxfaW5pdF9jbG9ja19nYXRpbmc7Cj4gKwkJZGV2X3ByaXYtPmRpc3BsYXku aW5pdF9jbG9ja19nYXRpbmcgPSBub3BfaW5pdF9jbG9ja19nYXRpbmc7Cj4gIAllbHNlIGlmIChJ U19DT0ZGRUVMQUtFKGRldl9wcml2KSkKPiAgCQlkZXZfcHJpdi0+ZGlzcGxheS5pbml0X2Nsb2Nr X2dhdGluZyA9IGNmbF9pbml0X2Nsb2NrX2dhdGluZzsKPiAgCWVsc2UgaWYgKElTX1NLWUxBS0Uo ZGV2X3ByaXYpKQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF93b3Jr YXJvdW5kcy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfd29ya2Fyb3VuZHMuYwo+IGlu ZGV4IGFlYTkzOTEuLjIyMmY0NWMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfd29ya2Fyb3VuZHMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3dv cmthcm91bmRzLmMKPiBAQCAtNzI0LDYgKzcyNCwxMCBAQCBzdGF0aWMgaW50IGNmbF9ndF93b3Jr YXJvdW5kc19pbml0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgCj4gIHN0 YXRpYyBpbnQgY25sX2d0X3dvcmthcm91bmRzX2luaXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg KmRldl9wcml2KQo+ICB7Cj4gKwkvKiBUaGlzIGlzIG5vdCBhbiBXYS4gRW5hYmxlIGZvciBiZXR0 ZXIgaW1hZ2UgcXVhbGl0eSAqLwo+ICsJR1RfV0FfU0VUX0JJVF9NQVNLRUQoXzNEX0NISUNLRU4z LAo+ICsJCQkgICAgIF8zRF9DSElDS0VOM19BQV9MSU5FX1FVQUxJVFlfRklYX0VOQUJMRSk7Cj4g Kwo+ICAJLyogV2FEaXNhYmxlSTJtQ3ljbGVPbldSUG9ydDpjbmwgKHByZS1wcm9kKSAqLwo+ICAJ aWYgKElTX0NOTF9SRVZJRChkZXZfcHJpdiwgQ05MX1JFVklEX0IwLCBDTkxfUkVWSURfQjApKQo+ ICAJCUdUX1dBX1NFVF9CSVQoR0FNVF9DSEtOX0JJVF9SRUcsCj4gQEAgLTg1Niw2ICs4NjAsMjcg QEAgc3RhdGljIGludCBjZmxfZGlzcGxheV93b3JrYXJvdW5kc19pbml0KHN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdikKPiAgCj4gIHN0YXRpYyBpbnQgY25sX2Rpc3BsYXlfd29ya2Fy b3VuZHNfaW5pdChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gIHsKPiArCWlm IChIQVNfUENIX0NOUChkZXZfcHJpdikpIHsKPiArCQkvKiBXYSAjMTE4MSAqLwo+ICsJCURJU1BM QVlfV0FfU0VUX0JJVChTT1VUSF9EU1BDTEtfR0FURV9ELAo+ICsJCQkJICAgQ05QX1BXTV9DR0Vf R0FUSU5HX0RJU0FCTEUpOwo+ICsJfQoKV2hlcmUgZGlkIHRoaXMgY29tZSBmcm9tPwoKPiArCj4g KwkvKiBXYUVuYWJsZUNoaWNrZW5EQ1BSOmNubCAqLwo+ICsJRElTUExBWV9XQV9TRVRfQklUKEdF TjhfQ0hJQ0tFTl9EQ1BSXzEsIE1BU0tfV0FLRU1FTSk7Cj4gKwo+ICsJLyogV2FGYmNXYWtlTWVt T246Y25sICovCj4gKwlESVNQTEFZX1dBX1NFVF9CSVQoRElTUF9BUkJfQ1RMLCBESVNQX0ZCQ19N RU1PUllfV0FLRSk7Cj4gKwo+ICsJLyogV2FTYXJiVW5pdENsb2NrR2F0aW5nRGlzYWJsZTpjbmwg KHByZS1wcm9kKSAqLwo+ICsJaWYgKElTX0NOTF9SRVZJRChkZXZfcHJpdiwgQ05MX1JFVklEX0Ew LCBDTkxfUkVWSURfQjApKQo+ICsJCURJU1BMQVlfV0FfU0VUX0JJVChTTElDRV9VTklUX0xFVkVM X0NMS0dBVEUsCj4gKwkJCQkgICBTQVJCVU5JVF9DTEtHQVRFX0RJUyk7CgpUaGF0IGRvZXNuJ3Qg bG9vayBsaWtlIGRpc3BsYXkgdG8gbWUuCgo+ICsKPiArCS8qIERpc3BsYXkgV0EgIzExMzM6IFdh RmJjU2tpcFNlZ21lbnRzOmNubCAqLwo+ICsJRElTUExBWV9XQV9TRVRfRklFTEQoSUxLX0RQRkNf Q0hJQ0tFTiwgR0xLX1NLSVBfU0VHX0NPVU5UX01BU0ssCj4gKwkJCSAgICAgR0xLX1NLSVBfU0VH X0VOIHwgR0xLX1NLSVBfU0VHX0NPVU5UKDEpKTsKPiArCj4gIAlyZXR1cm4gMDsKPiAgfQo+ICAK PiBAQCAtODYzLDcgKzg4OCw2IEBAIHN0YXRpYyBpbnQgZGlzcGxheV93b3JrYXJvdW5kc19pbml0 KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgewo+ICAJaW50IGVycjsKPiAg Cj4gLQlESVNQTEFZX1dBX1NFVF9CSVQoX01NSU8oMCksIDApOyAvKiBzaHV0IHVwIGdjYyB0ZW1w b3JhcmlseSAqLwo+ICAJZGV2X3ByaXYtPndvcmthcm91bmRzLmRpc3BsYXlfd2FfY291bnQgPSAw Owo+ICAKPiAgCWlmIChJTlRFTF9HRU4oZGV2X3ByaXYpIDwgOCkKPiAtLSAKPiAxLjkuMQoKLS0g ClZpbGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vaW50ZWwtZ2Z4Cg==