From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 09/10] drm/i915: Unify error handling for missing DDI buf trans tables Date: Wed, 18 Oct 2017 21:15:09 +0300 Message-ID: <20171018181509.GQ10981@intel.com> References: <20171016145705.11780-1-ville.syrjala@linux.intel.com> <20171016145705.11780-10-ville.syrjala@linux.intel.com> <20171018174142.GE31581@jausmus-gentoo-dev6.jf.intel.com> <20171018175240.GO10981@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id DA5E16E01F for ; Wed, 18 Oct 2017 18:15:13 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20171018175240.GO10981@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: James Ausmus Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBPY3QgMTgsIDIwMTcgYXQgMDg6NTI6NDBQTSArMDMwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IE9uIFdlZCwgT2N0IDE4LCAyMDE3IGF0IDEwOjQxOjQ0QU0gLTA3MDAsIEphbWVz IEF1c211cyB3cm90ZToKPiA+IE9uIE1vbiwgT2N0IDE2LCAyMDE3IGF0IDA1OjU3OjA0UE0gKzAz MDAsIFZpbGxlIFN5cmphbGEgd3JvdGU6Cj4gPiA+IEZyb206IFZpbGxlIFN5cmrDpGzDpCA8dmls bGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPiA+IAo+ID4gPiBIYW5kbGUgbWlzc2luZyBi dWYgdHJhbnMgdGFibGVzLCBvciBvdXQgb2YgYm91bmRzIGJ1ZiB0cmFucyBsZXZlbHMKPiA+ID4g dGhlIHNhbWUgd2F5IGV2ZXJ5d2hlcmUuIFRoZXNlIHNob3VsZCBuZXZlciBiZSBoaXQgdW5kZXIg bm9ybWFsCj4gPiA+IGNvbmRpdGlvbnMsIGJ1dCBsZXQncyBwbGF5IGl0IHNhZmUgZm9yIG5vdy4K PiA+ID4gCj4gPiA+IFNpZ25lZC1vZmYtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFs YUBsaW51eC5pbnRlbC5jb20+Cj4gPiA+IC0tLQo+ID4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZGRpLmMgfCAyNSArKysrKysrKysrKysrKysrKysrKy0tLS0tCj4gPiA+ICAxIGZpbGUg Y2hhbmdlZCwgMjAgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKPiA+ID4gCj4gPiA+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2RkaS5jCj4gPiA+IGluZGV4IGYwYTcwOWI2NmUwMC4uNWYxYzU0NmU1 ZTYxIDEwMDY0NAo+ID4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+ ID4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+ID4gPiBAQCAtODAx LDYgKzgwMSw5IEBAIHN0YXRpYyBpbnQgaW50ZWxfZGRpX2hkbWlfbGV2ZWwoc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2LCBlbnVtIHBvcnQgcG9yCj4gPiA+ICAJICAgIGhkbWlfbGV2 ZWwgPj0gbl9oZG1pX2VudHJpZXMpCj4gPiA+ICAJCWhkbWlfbGV2ZWwgPSBoZG1pX2RlZmF1bHRf ZW50cnk7Cj4gPiA+ICAKPiA+ID4gKwlpZiAoV0FSTl9PTl9PTkNFKGhkbWlfbGV2ZWwgPj0gbl9o ZG1pX2VudHJpZXMpKQo+ID4gPiArCQloZG1pX2xldmVsID0gbl9oZG1pX2VudHJpZXMgLSAxOwo+ ID4gCj4gPiBpbnRlbF9kZGlfZ2V0X2J1Zl90cmFuc18qIGNhbiBzZXQgbl9lbnRyaWVzIHRvIDAg b24gZmFpbHVyZSwKPiA+IHdoaWNoIHdvdWxkIGNhdXNlIHRoaXMgdG8gcmV0dXJuIGEgbGV2ZWwg b2YgLTEgLSBtYXliZSB0aG9zZSBmdW5jdGlvbnMKPiA+IG5lZWQgdG8gcmV0dXJuIDEgb24gZmFp bHVyZSBpbnN0ZWFkLCBzaW1pbGFyIHRvIHRoZSBjbmxfZ2V0X2J1Zl90cmFuc18qCj4gPiBmdW5j dGlvbnM/Cj4gCj4gSG1tLiBJIGd1ZXNzIHdlIGNvdWxkIGp1c3QgZG8KPiAKPiBpZiAoV0FSTl9P TihoZG1pX2xldmVsID09IDApKQo+IAlyZXR1cm47Cj4gCj4gYmVmb3JlIHRoZSBvdGhlciBjaGVj ay4gVGhhdCB3b3VsZCBiZSBlcXVpdmFsZW50IHRvIHRoZQo+ICFkZGlfdHJhbnNsYXRpb25zIGNo ZWNrcyBkb25lIGluIHRoZSBvdGhlciBwbGFjZXMuCgpIbW0uIEFjdHVhbGx5IG5vdyB0aGF0IEkg cmVhZCB0aGluZ3MgYWdhaW4sIHRoZSAtMSBzaG91bGRuJ3QgYWN0dWFsbHkKY2F1c2UgdXMgYW55 IHByb2JsZW1zIHNpbmNlIGFsbCB1c2VzIG9mIGl0IHdvdWxkIGRvIGEgc2Vjb25kCiFkZGlfdHJh bnNsYXRpb25zIGNoZWNrIGJlZm9yZSBpbmRleGluZyBhbnl0aGluZyB3aXRoIHRoZSAtMS4KCi0x IGFuZCAwIGFyZSBib3RoIHdyb25nIGluZGV4ZXMgd2hlbiBkZWFsaW5nIHdpdGggYSB6ZXJvIHNp emVkIGFycmF5LApidXQgSSBzdXBwb3NlIGluIHRoZW9yeSAwIGlzIGEgYml0IGJldHRlciBzaW5j ZSBpdCB3b3VsZCB0cmlwIHVwIG9uCmZpcnRoZXIgbGV2ZWw+PW5fZW50cmllcyBjaGVja3MuIFNv IEkgZ3Vlc3MgSSBjb3VsZCB0cnkgdG8gYXZvaWQKdGhlIG5lZ2F0aXZlIHZhbHVlLgoKQW5vdGhl ciB3YXkgdG8gZG8gdGhhdCB3b3VsZCBiZSBqdXN0Ci0gcmV0dXJuIGhkbWlfbGV2ZWw7CisgcmV0 dXJuIG1heChoZG1pX2xldmVsLCAwKTsKCk9yIHlvdXIgb3RoZXIgaWRlYSBhYm91dCBrZWVwaW5n IHRoaW5ncyB1bnNpZ25lZCB3b3VsZCBhbHNvIHRha2UgY2FyZQpvZiBpdC4gRXhjZXB0IGhhdmlu ZyBhIHdpbGQgVUlOVF9NQVggcm9hbWluZyBhcm91bmQgc2VlbXMgcG90ZW50aWFsbHkKbW9yZSBk YW5nZXJvdXMgdG8gbWUuCgo+ID4gCj4gPiA+ICsKPiA+ID4gIAlyZXR1cm4gaGRtaV9sZXZlbDsK PiA+ID4gIH0KPiA+ID4gIAo+ID4gPiBAQCAtODY0LDYgKzg2NywxMSBAQCBzdGF0aWMgdm9pZCBp bnRlbF9wcmVwYXJlX2hkbWlfZGRpX2J1ZmZlcnMoc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29k ZXIsCj4gPiA+ICAKPiA+ID4gIAlkZGlfdHJhbnNsYXRpb25zX2hkbWkgPSBpbnRlbF9kZGlfZ2V0 X2J1Zl90cmFuc19oZG1pKGRldl9wcml2LCAmbl9oZG1pX2VudHJpZXMpOwo+ID4gPiAgCj4gPiA+ ICsJaWYgKFdBUk5fT05fT05DRSghZGRpX3RyYW5zbGF0aW9uc19oZG1pKSkKPiA+ID4gKwkJcmV0 dXJuOwo+ID4gPiArCWlmIChXQVJOX09OX09OQ0UoaGRtaV9sZXZlbCA+PSBuX2hkbWlfZW50cmll cykpCj4gPiA+ICsJCWhkbWlfbGV2ZWwgPSBuX2hkbWlfZW50cmllcyAtIDE7Cj4gPiA+ICsKPiA+ ID4gIAkvKiBJZiB3ZSdyZSBib29zdGluZyB0aGUgY3VycmVudCwgc2V0IGJpdCAzMSBvZiB0cmFu czEgKi8KPiA+ID4gIAlpZiAoSVNfR0VOOV9CQyhkZXZfcHJpdikgJiYKPiA+ID4gIAkgICAgZGV2 X3ByaXYtPnZidC5kZGlfcG9ydF9pbmZvW3BvcnRdLmhkbWlfYm9vc3RfbGV2ZWwpCj4gPiA+IEBA IC0xODQ3LDYgKzE4NTUsMTEgQEAgc3RhdGljIHZvaWQgc2tsX2RkaV9zZXRfaWJvb3N0KHN0cnVj dCBpbnRlbF9lbmNvZGVyICplbmNvZGVyLAo+ID4gPiAgCQllbHNlCj4gPiA+ICAJCQlkZGlfdHJh bnNsYXRpb25zID0gaW50ZWxfZGRpX2dldF9idWZfdHJhbnNfZHAoZGV2X3ByaXYsIHBvcnQsICZu X2VudHJpZXMpOwo+ID4gPiAgCj4gPiA+ICsJCWlmIChXQVJOX09OX09OQ0UoIWRkaV90cmFuc2xh dGlvbnMpKQo+ID4gPiArCQkJcmV0dXJuOwo+ID4gPiArCQlpZiAoV0FSTl9PTl9PTkNFKGxldmVs ID49IG5fZW50cmllcykpCj4gPiA+ICsJCQlsZXZlbCA9IG5fZW50cmllcyAtIDE7Cj4gPiAKPiA+ IAo+ID4gPiArCj4gPiA+ICAJCWlib29zdCA9IGRkaV90cmFuc2xhdGlvbnNbbGV2ZWxdLmlfYm9v c3Q7Cj4gPiA+ICAJfQo+ID4gPiAgCj4gPiA+IEBAIC0xODc3LDYgKzE4OTAsMTEgQEAgc3RhdGlj IHZvaWQgYnh0X2RkaV92c3dpbmdfc2VxdWVuY2Uoc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29k ZXIsCj4gPiA+ICAJZWxzZQo+ID4gPiAgCQlkZGlfdHJhbnNsYXRpb25zID0gYnh0X2dldF9idWZf dHJhbnNfZHAoZGV2X3ByaXYsICZuX2VudHJpZXMpOwo+ID4gPiAgCj4gPiA+ICsJaWYgKFdBUk5f T05fT05DRSghZGRpX3RyYW5zbGF0aW9ucykpCj4gPiA+ICsJCXJldHVybjsKPiA+ID4gKwlpZiAo V0FSTl9PTl9PTkNFKGxldmVsID49IG5fZW50cmllcykpCj4gPiA+ICsJCWxldmVsID0gbl9lbnRy aWVzIC0gMTsKPiA+ID4gKwo+ID4gPiAgCWJ4dF9kZGlfcGh5X3NldF9zaWduYWxfbGV2ZWwoZGV2 X3ByaXYsIHBvcnQsCj4gPiA+ICAJCQkJICAgICBkZGlfdHJhbnNsYXRpb25zW2xldmVsXS5tYXJn aW4sCj4gPiA+ICAJCQkJICAgICBkZGlfdHJhbnNsYXRpb25zW2xldmVsXS5zY2FsZSwKPiA+ID4g QEAgLTE5MzIsMTMgKzE5NTAsMTAgQEAgc3RhdGljIHZvaWQgY25sX2RkaV92c3dpbmdfcHJvZ3Jh bShzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlciwKPiA+ID4gIAllbHNlCj4gPiA+ICAJCWRk aV90cmFuc2xhdGlvbnMgPSBjbmxfZ2V0X2J1Zl90cmFuc19kcChkZXZfcHJpdiwgJm5fZW50cmll cyk7Cj4gPiA+ICAKPiA+ID4gLQlpZiAoV0FSTl9PTihkZGlfdHJhbnNsYXRpb25zID09IE5VTEwp KQo+ID4gPiArCWlmIChXQVJOX09OX09OQ0UoIWRkaV90cmFuc2xhdGlvbnMpKQo+ID4gPiAgCQly ZXR1cm47Cj4gPiA+IC0KPiA+ID4gLQlpZiAobGV2ZWwgPj0gbl9lbnRyaWVzKSB7Cj4gPiA+IC0J CURSTV9ERUJVR19LTVMoIkRESSB0cmFuc2xhdGlvbiBub3QgZm91bmQgZm9yIGxldmVsICVkLiBV c2luZyAlZCBpbnN0ZWFkLiIsIGxldmVsLCBuX2VudHJpZXMgLSAxKTsKPiA+ID4gKwlpZiAoV0FS Tl9PTl9PTkNFKGxldmVsID49IG5fZW50cmllcykpCj4gPiA+ICAJCWxldmVsID0gbl9lbnRyaWVz IC0gMTsKPiA+ID4gLQl9Cj4gPiA+ICAKPiA+ID4gIAkvKiBTZXQgUE9SVF9UWF9EVzUgU2NhbGlu ZyBNb2RlIFNlbCB0byAwMTBiLiAqLwo+ID4gPiAgCXZhbCA9IEk5MTVfUkVBRChDTkxfUE9SVF9U WF9EVzVfTE4wKHBvcnQpKTsKPiA+ID4gLS0gCj4gPiA+IDIuMTMuNgo+ID4gPiAKPiA+ID4gX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiA+ID4gSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdAo+ID4gPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4g PiA+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwt Z2Z4Cj4gCj4gLS0gCj4gVmlsbGUgU3lyasOkbMOkCj4gSW50ZWwgT1RDCj4gX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBs aXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKVmlsbGUgU3lyasOk bMOkCkludGVsIE9UQwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1n ZngK