From mboxrd@z Thu Jan  1 00:00:00 1970
From: Manasi Navare <manasi.d.navare@intel.com>
Subject: Re: [PATCH v2 06/10] drm/i915: Pass encoder type to
 cnl_ddi_vswing_sequence() explicitly
Date: Wed, 18 Oct 2017 14:11:46 -0700
Message-ID: <20171018211146.GB10621@intel.com>
References: <20171016145705.11780-1-ville.syrjala@linux.intel.com>
 <20171016145705.11780-7-ville.syrjala@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by gabe.freedesktop.org (Postfix) with ESMTPS id D96716E0D1
 for <intel-gfx@lists.freedesktop.org>; Wed, 18 Oct 2017 21:07:12 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20171016145705.11780-7-ville.syrjala@linux.intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gTW9uLCBPY3QgMTYsIDIwMTcgYXQgMDU6NTc6MDFQTSArMDMwMCwgVmlsbGUgU3lyamFsYSB3
cm90ZToKPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwu
Y29tPgo+IAo+IGVuY29kZXItPnR5cGUgaXMgdW5yZWxpYWJsZSBmb3IgRFAvSERNSSwgc28gcGFz
cyBpdCBpbiBleHBsaWNpdHkgaW50bwo+IGNubF9kZGlfdnN3aW5nX3NlcXVlbmNlKCkuIFRoaXMg
bWF0Y2hlcyB3aGF0IHdlIGRvIGZvciBCWFQuCj4KCkkgc3RpbGwgZG9udCBnZXQgd2h5IHdlIGNh
bnQgdXNlIGVuY29kZXItPnR5cGUgcmVsaWFibHk/ClNpbmNlIGlmIEkgdHJhY2UgYmFjayBvbiB0
aGUgY2FsbGVyIG9mIGludGVsX2RkaV9wcmVfZW5hYmxlX2hkbWkgb3IKaW50ZWxfZGRpX3ByZV9l
bmFibGVfZHAsIHRoZSBjYWxlciBpbnRlbF9kZGlfcHJlX2VuYWJsZSgpIGNhbGxzCmVpdGhlciBv
ZiB0aGVzZSBiYXNlZCBvbiBlbmNvZGVyLT50eXBlIGl0c2VsZi4KU28gd2h5IGRvIHdlIGV4cGxp
Y2l0bHkgbmVlZCB0byBwYXNzIGVuY29kZXItPnR5cGUgaW5zdGVhZApvZiBkZXJpdmluZyBpdCBm
cm9tIGVuY29kZXIgaW5zaWRlIHRoZSB2c3dpbmdfc2VxdWVuY18gZnVuY3Rpb25zPwoKTWF5IGJl
IEkgYW0gbWlzc2luZyBzb21ldGhpbmc/CgpNYW5hc2kKIAo+IHYyOiBQYXNzIGludGVsX2VuY29k
ZXIgZG93biB0byBjbmxfZGRpX3Zzd2luZ19wcm9ncmFtKCksIGFuZAo+ICAgICBjbGVhbiB1cCB0
aGUgYXJndW1lbnQgdHlwZXMgd2hpbGUgYXQgaXQKPiAKPiBTaWduZWQtb2ZmLWJ5OiBWaWxsZSBT
eXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJz
L2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYyB8IDUzICsrKysrKysrKysrKysrKysrKystLS0tLS0t
LS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDI1IGluc2VydGlvbnMoKyksIDI4IGRl
bGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k
ZGkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jCj4gaW5kZXggMmQ4ODYxNDhh
NjUzLi5jYWI3MjE3NzI5OWMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50
ZWxfZGRpLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+IEBAIC0x
OTIwLDIwICsxOTIwLDIxIEBAIHU4IGludGVsX2RkaV9kcF92b2x0YWdlX21heChzdHJ1Y3QgaW50
ZWxfZW5jb2RlciAqZW5jb2RlcikKPiAgCQlEUF9UUkFJTl9WT0xUQUdFX1NXSU5HX01BU0s7Cj4g
IH0KPiAgCj4gLXN0YXRpYyB2b2lkIGNubF9kZGlfdnN3aW5nX3Byb2dyYW0oc3RydWN0IGRybV9p
OTE1X3ByaXZhdGUgKmRldl9wcml2LAo+IC0JCQkJICAgIHUzMiBsZXZlbCwgZW51bSBwb3J0IHBv
cnQsIGludCB0eXBlKQo+ICtzdGF0aWMgdm9pZCBjbmxfZGRpX3Zzd2luZ19wcm9ncmFtKHN0cnVj
dCBpbnRlbF9lbmNvZGVyICplbmNvZGVyLAo+ICsJCQkJICAgaW50IGxldmVsLCBlbnVtIGludGVs
X291dHB1dF90eXBlIHR5cGUpCj4gIHsKPiAtCWNvbnN0IHN0cnVjdCBjbmxfZGRpX2J1Zl90cmFu
cyAqZGRpX3RyYW5zbGF0aW9ucyA9IE5VTEw7Cj4gLQl1MzIgbl9lbnRyaWVzLCB2YWw7Cj4gLQlp
bnQgbG47Cj4gKwlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGVu
Y29kZXItPmJhc2UuZGV2KTsKPiArCWVudW0gcG9ydCBwb3J0ID0gaW50ZWxfZGRpX2dldF9lbmNv
ZGVyX3BvcnQoZW5jb2Rlcik7Cj4gKwljb25zdCBzdHJ1Y3QgY25sX2RkaV9idWZfdHJhbnMgKmRk
aV90cmFuc2xhdGlvbnM7Cj4gKwlpbnQgbl9lbnRyaWVzLCBsbjsKPiArCXUzMiB2YWw7Cj4gIAo+
IC0JaWYgKHR5cGUgPT0gSU5URUxfT1VUUFVUX0hETUkpIHsKPiArCWlmICh0eXBlID09IElOVEVM
X09VVFBVVF9IRE1JKQo+ICAJCWRkaV90cmFuc2xhdGlvbnMgPSBjbmxfZ2V0X2J1Zl90cmFuc19o
ZG1pKGRldl9wcml2LCAmbl9lbnRyaWVzKTsKPiAtCX0gZWxzZSBpZiAodHlwZSA9PSBJTlRFTF9P
VVRQVVRfRFApIHsKPiAtCQlkZGlfdHJhbnNsYXRpb25zID0gY25sX2dldF9idWZfdHJhbnNfZHAo
ZGV2X3ByaXYsICZuX2VudHJpZXMpOwo+IC0JfSBlbHNlIGlmICh0eXBlID09IElOVEVMX09VVFBV
VF9FRFApIHsKPiArCWVsc2UgaWYgKHR5cGUgPT0gSU5URUxfT1VUUFVUX0VEUCkKPiAgCQlkZGlf
dHJhbnNsYXRpb25zID0gY25sX2dldF9idWZfdHJhbnNfZWRwKGRldl9wcml2LCAmbl9lbnRyaWVz
KTsKPiAtCX0KPiArCWVsc2UKPiArCQlkZGlfdHJhbnNsYXRpb25zID0gY25sX2dldF9idWZfdHJh
bnNfZHAoZGV2X3ByaXYsICZuX2VudHJpZXMpOwo+ICAKPiAgCWlmIChXQVJOX09OKGRkaV90cmFu
c2xhdGlvbnMgPT0gTlVMTCkpCj4gIAkJcmV0dXJuOwo+IEBAIC0xOTg2LDI2ICsxOTg3LDIyIEBA
IHN0YXRpYyB2b2lkIGNubF9kZGlfdnN3aW5nX3Byb2dyYW0oc3RydWN0IGRybV9pOTE1X3ByaXZh
dGUgKmRldl9wcml2LAo+ICAJSTkxNV9XUklURShDTkxfUE9SVF9UWF9EVzdfR1JQKHBvcnQpLCB2
YWwpOwo+ICB9Cj4gIAo+IC1zdGF0aWMgdm9pZCBjbmxfZGRpX3Zzd2luZ19zZXF1ZW5jZShzdHJ1
Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlciwgdTMyIGxldmVsKQo+ICtzdGF0aWMgdm9pZCBjbmxf
ZGRpX3Zzd2luZ19zZXF1ZW5jZShzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlciwKPiArCQkJ
CSAgICBpbnQgbGV2ZWwsIGVudW0gaW50ZWxfb3V0cHV0X3R5cGUgdHlwZSkKPiAgewo+ICAJc3Ry
dWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShlbmNvZGVyLT5iYXNlLmRl
dik7Cj4gLQlzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwID0gZW5jX3RvX2ludGVsX2RwKCZlbmNv
ZGVyLT5iYXNlKTsKPiAgCWVudW0gcG9ydCBwb3J0ID0gaW50ZWxfZGRpX2dldF9lbmNvZGVyX3Bv
cnQoZW5jb2Rlcik7Cj4gLQlpbnQgdHlwZSA9IGVuY29kZXItPnR5cGU7Cj4gLQlpbnQgd2lkdGgg
PSAwOwo+IC0JaW50IHJhdGUgPSAwOwo+ICsJaW50IHdpZHRoLCByYXRlLCBsbjsKPiAgCXUzMiB2
YWw7Cj4gLQlpbnQgbG4gPSAwOwo+ICAKPiAtCWlmICgoaW50ZWxfZHApICYmICh0eXBlID09IElO
VEVMX09VVFBVVF9FRFAgfHwgdHlwZSA9PSBJTlRFTF9PVVRQVVRfRFApKSB7Cj4gKwlpZiAodHlw
ZSA9PSBJTlRFTF9PVVRQVVRfSERNSSkgewo+ICsJCXdpZHRoID0gNDsKPiArCQlyYXRlID0gMDsg
LyogUmF0ZSBpcyBhbHdheXMgPCB0aGFuIDZHSHogZm9yIEhETUkgKi8KPiArCX0gZWxzZSB7Cj4g
KwkJc3RydWN0IGludGVsX2RwICppbnRlbF9kcCA9IGVuY190b19pbnRlbF9kcCgmZW5jb2Rlci0+
YmFzZSk7Cj4gKwo+ICAJCXdpZHRoID0gaW50ZWxfZHAtPmxhbmVfY291bnQ7Cj4gIAkJcmF0ZSA9
IGludGVsX2RwLT5saW5rX3JhdGU7Cj4gLQl9IGVsc2UgaWYgKHR5cGUgPT0gSU5URUxfT1VUUFVU
X0hETUkpIHsKPiAtCQl3aWR0aCA9IDQ7Cj4gLQkJLyogUmF0ZSBpcyBhbHdheXMgPCB0aGFuIDZH
SHogZm9yIEhETUkgKi8KPiAtCX0gZWxzZSB7Cj4gLQkJTUlTU0lOR19DQVNFKHR5cGUpOwo+IC0J
CXJldHVybjsKPiAgCX0KPiAgCj4gIAkvKgo+IEBAIC0yMDE0LDcgKzIwMTEsNyBAQCBzdGF0aWMg
dm9pZCBjbmxfZGRpX3Zzd2luZ19zZXF1ZW5jZShzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2Rl
ciwgdTMyIGxldmVsKQo+ICAJICogZWxzZSBjbGVhciB0byAwYi4KPiAgCSAqLwo+ICAJdmFsID0g
STkxNV9SRUFEKENOTF9QT1JUX1BDU19EVzFfTE4wKHBvcnQpKTsKPiAtCWlmICh0eXBlID09IElO
VEVMX09VVFBVVF9FRFAgfHwgdHlwZSA9PSBJTlRFTF9PVVRQVVRfRFApCj4gKwlpZiAodHlwZSAh
PSBJTlRFTF9PVVRQVVRfSERNSSkKPiAgCQl2YWwgfD0gQ09NTU9OX0tFRVBFUl9FTjsKPiAgCWVs
c2UKPiAgCQl2YWwgJj0gfkNPTU1PTl9LRUVQRVJfRU47Cj4gQEAgLTIwNDksNyArMjA0Niw3IEBA
IHN0YXRpYyB2b2lkIGNubF9kZGlfdnN3aW5nX3NlcXVlbmNlKHN0cnVjdCBpbnRlbF9lbmNvZGVy
ICplbmNvZGVyLCB1MzIgbGV2ZWwpCj4gIAlJOTE1X1dSSVRFKENOTF9QT1JUX1RYX0RXNV9HUlAo
cG9ydCksIHZhbCk7Cj4gIAo+ICAJLyogNS4gUHJvZ3JhbSBzd2luZyBhbmQgZGUtZW1waGFzaXMg
Ki8KPiAtCWNubF9kZGlfdnN3aW5nX3Byb2dyYW0oZGV2X3ByaXYsIGxldmVsLCBwb3J0LCB0eXBl
KTsKPiArCWNubF9kZGlfdnN3aW5nX3Byb2dyYW0oZW5jb2RlciwgbGV2ZWwsIHR5cGUpOwo+ICAK
PiAgCS8qIDYuIFNldCB0cmFpbmluZyBlbmFibGUgdG8gdHJpZ2dlciB1cGRhdGUgKi8KPiAgCXZh
bCA9IEk5MTVfUkVBRChDTkxfUE9SVF9UWF9EVzVfTE4wKHBvcnQpKTsKPiBAQCAtMjA4OSw3ICsy
MDg2LDcgQEAgdTMyIGJ4dF9zaWduYWxfbGV2ZWxzKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAp
Cj4gIAl1MzIgbGV2ZWwgPSBpbnRlbF9kZGlfZHBfbGV2ZWwoaW50ZWxfZHApOwo+ICAKPiAgCWlm
IChJU19DQU5OT05MQUtFKGRldl9wcml2KSkKPiAtCQljbmxfZGRpX3Zzd2luZ19zZXF1ZW5jZShl
bmNvZGVyLCBsZXZlbCk7Cj4gKwkJY25sX2RkaV92c3dpbmdfc2VxdWVuY2UoZW5jb2RlciwgbGV2
ZWwsIGVuY29kZXItPnR5cGUpOwo+ICAJZWxzZQo+ICAJCWJ4dF9kZGlfdnN3aW5nX3NlcXVlbmNl
KGVuY29kZXIsIGxldmVsLCBlbmNvZGVyLT50eXBlKTsKPiAgCj4gQEAgLTIxODgsNyArMjE4NSw3
IEBAIHN0YXRpYyB2b2lkIGludGVsX2RkaV9wcmVfZW5hYmxlX2RwKHN0cnVjdCBpbnRlbF9lbmNv
ZGVyICplbmNvZGVyLAo+ICAJaW50ZWxfZGlzcGxheV9wb3dlcl9nZXQoZGV2X3ByaXYsIGRpZ19w
b3J0LT5kZGlfaW9fcG93ZXJfZG9tYWluKTsKPiAgCj4gIAlpZiAoSVNfQ0FOTk9OTEFLRShkZXZf
cHJpdikpCj4gLQkJY25sX2RkaV92c3dpbmdfc2VxdWVuY2UoZW5jb2RlciwgbGV2ZWwpOwo+ICsJ
CWNubF9kZGlfdnN3aW5nX3NlcXVlbmNlKGVuY29kZXIsIGxldmVsLCBlbmNvZGVyLT50eXBlKTsK
PiAgCWVsc2UgaWYgKElTX0dFTjlfTFAoZGV2X3ByaXYpKQo+ICAJCWJ4dF9kZGlfdnN3aW5nX3Nl
cXVlbmNlKGVuY29kZXIsIGxldmVsLCBlbmNvZGVyLT50eXBlKTsKPiAgCWVsc2UKPiBAQCAtMjIx
OSw3ICsyMjE2LDcgQEAgc3RhdGljIHZvaWQgaW50ZWxfZGRpX3ByZV9lbmFibGVfaGRtaShzdHJ1
Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlciwKPiAgCWludGVsX2Rpc3BsYXlfcG93ZXJfZ2V0KGRl
dl9wcml2LCBkaWdfcG9ydC0+ZGRpX2lvX3Bvd2VyX2RvbWFpbik7Cj4gIAo+ICAJaWYgKElTX0NB
Tk5PTkxBS0UoZGV2X3ByaXYpKQo+IC0JCWNubF9kZGlfdnN3aW5nX3NlcXVlbmNlKGVuY29kZXIs
IGxldmVsKTsKPiArCQljbmxfZGRpX3Zzd2luZ19zZXF1ZW5jZShlbmNvZGVyLCBsZXZlbCwgSU5U
RUxfT1VUUFVUX0hETUkpOwo+ICAJZWxzZSBpZiAoSVNfR0VOOV9MUChkZXZfcHJpdikpCj4gIAkJ
Ynh0X2RkaV92c3dpbmdfc2VxdWVuY2UoZW5jb2RlciwgbGV2ZWwsIElOVEVMX09VVFBVVF9IRE1J
KTsKPiAgCWVsc2UKPiAtLSAKPiAyLjEzLjYKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1n
ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv
bWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMu
ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz
dGluZm8vaW50ZWwtZ2Z4Cg==