From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH v2 06/10] drm/i915: Pass encoder type to
 cnl_ddi_vswing_sequence() explicitly
Date: Thu, 19 Oct 2017 13:38:06 +0300
Message-ID: <20171019103806.GR10981@intel.com>
References: <20171016145705.11780-1-ville.syrjala@linux.intel.com>
 <20171016145705.11780-7-ville.syrjala@linux.intel.com>
 <20171018211146.GB10621@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by gabe.freedesktop.org (Postfix) with ESMTPS id E28DA6EA53
 for <intel-gfx@lists.freedesktop.org>; Thu, 19 Oct 2017 10:38:09 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20171018211146.GB10621@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Manasi Navare <manasi.d.navare@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gV2VkLCBPY3QgMTgsIDIwMTcgYXQgMDI6MTE6NDZQTSAtMDcwMCwgTWFuYXNpIE5hdmFyZSB3
cm90ZToKPiBPbiBNb24sIE9jdCAxNiwgMjAxNyBhdCAwNTo1NzowMVBNICswMzAwLCBWaWxsZSBT
eXJqYWxhIHdyb3RlOgo+ID4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxp
bnV4LmludGVsLmNvbT4KPiA+IAo+ID4gZW5jb2Rlci0+dHlwZSBpcyB1bnJlbGlhYmxlIGZvciBE
UC9IRE1JLCBzbyBwYXNzIGl0IGluIGV4cGxpY2l0eSBpbnRvCj4gPiBjbmxfZGRpX3Zzd2luZ19z
ZXF1ZW5jZSgpLiBUaGlzIG1hdGNoZXMgd2hhdCB3ZSBkbyBmb3IgQlhULgo+ID4KPiAKPiBJIHN0
aWxsIGRvbnQgZ2V0IHdoeSB3ZSBjYW50IHVzZSBlbmNvZGVyLT50eXBlIHJlbGlhYmx5Pwo+IFNp
bmNlIGlmIEkgdHJhY2UgYmFjayBvbiB0aGUgY2FsbGVyIG9mIGludGVsX2RkaV9wcmVfZW5hYmxl
X2hkbWkgb3IKPiBpbnRlbF9kZGlfcHJlX2VuYWJsZV9kcCwgdGhlIGNhbGVyIGludGVsX2RkaV9w
cmVfZW5hYmxlKCkgY2FsbHMKPiBlaXRoZXIgb2YgdGhlc2UgYmFzZWQgb24gZW5jb2Rlci0+dHlw
ZSBpdHNlbGYuCj4gU28gd2h5IGRvIHdlIGV4cGxpY2l0bHkgbmVlZCB0byBwYXNzIGVuY29kZXIt
PnR5cGUgaW5zdGVhZAo+IG9mIGRlcml2aW5nIGl0IGZyb20gZW5jb2RlciBpbnNpZGUgdGhlIHZz
d2luZ19zZXF1ZW5jXyBmdW5jdGlvbnM/Cj4gCj4gTWF5IGJlIEkgYW0gbWlzc2luZyBzb21ldGhp
bmc/CgpDdXJyZW50bHkgRERJIGVuY29kZXItPnR5cGUgY2hhbmdlcyBhdCB1bnByZWRpY2F0Ymxl
IHRpbWVzIHdoZW5ldmVyCndlIGRldGVjdCBhIERQIG9yIEhETUkgc2luaywgb3IgZm9yY2UgdGhl
IGRyaXZlciB0byB0aGluayBvbmUgb3IgdGhlCm90aGVyIGlzIGNvbm5lY3RlZC4gVGh1cyBpdCBj
YW4gZmxpcCBmbG9wIHByZXR0eSBtdWNoIHJhbmRvbWx5IGF0IGFueQp0aW1lIGxlYWRpbmcgdG8g
aGlsYXJpdHkgaWYgd2UgdHJ5IHRvIGRyaXZlIHRoZSBwb3J0IGluIG9uZSBtb2RlIGJ1dApzb21l
b25lIHBsdWdzIGluIGFub3RoZXIgdHlwZSBvZiBzaW5rLgoKSSdtIHRyeWluZyB0byBlbGltaW5h
dGUgdGhhdCBmbGlwLWZsb3BwaW5nIGJ5IG1ha2luZyBzdXJlIHRoZSAKZW5jb2Rlci0+dHlwZSBq
dXN0IHNheXMgIkRESSIsIGFuZCBpbnN0ZWFkIHdlIGZpZ3VyZSBvdXQgdGhlIHJlYWwgdHlwZQpm
cm9tIGNydGMgc3RhdGUgb3V0cHV0X3R5cGVzLiBTbyBvbmNlIEknbSBkb25lIChvbmUgbW9yZSBw
YXRjaCBzZXQKYWZ0ZXIgdGhpcyBvbmUgYXQgbGVhc3QpLCB3ZSB3aWxsIG5vdCB1c2UgZW5jb2Rl
ci0+dHlwZSBhbnltb3JlLCBleGNlcHQKaW4gYSB2ZXJ5IGxpbWl0ZWQgZmFzaGlvbiB3aGljaCBk
b2Vzbid0IGxlYWQgdG8gbWlzcHJvZ3JhbW1pbmcgb2YgdGhlCmhhcmR3YXJlLgoKPiAKPiBNYW5h
c2kKPiAgCj4gPiB2MjogUGFzcyBpbnRlbF9lbmNvZGVyIGRvd24gdG8gY25sX2RkaV92c3dpbmdf
cHJvZ3JhbSgpLCBhbmQKPiA+ICAgICBjbGVhbiB1cCB0aGUgYXJndW1lbnQgdHlwZXMgd2hpbGUg
YXQgaXQKPiA+IAo+ID4gU2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJq
YWxhQGxpbnV4LmludGVsLmNvbT4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2lu
dGVsX2RkaS5jIHwgNTMgKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+
ID4gIDEgZmlsZSBjaGFuZ2VkLCAyNSBpbnNlcnRpb25zKCspLCAyOCBkZWxldGlvbnMoLSkKPiA+
IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jIGIvZHJp
dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMKPiA+IGluZGV4IDJkODg2MTQ4YTY1My4uY2Fi
NzIxNzcyOTljIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRp
LmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jCj4gPiBAQCAtMTky
MCwyMCArMTkyMCwyMSBAQCB1OCBpbnRlbF9kZGlfZHBfdm9sdGFnZV9tYXgoc3RydWN0IGludGVs
X2VuY29kZXIgKmVuY29kZXIpCj4gPiAgCQlEUF9UUkFJTl9WT0xUQUdFX1NXSU5HX01BU0s7Cj4g
PiAgfQo+ID4gIAo+ID4gLXN0YXRpYyB2b2lkIGNubF9kZGlfdnN3aW5nX3Byb2dyYW0oc3RydWN0
IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ID4gLQkJCQkgICAgdTMyIGxldmVsLCBlbnVt
IHBvcnQgcG9ydCwgaW50IHR5cGUpCj4gPiArc3RhdGljIHZvaWQgY25sX2RkaV92c3dpbmdfcHJv
Z3JhbShzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlciwKPiA+ICsJCQkJICAgaW50IGxldmVs
LCBlbnVtIGludGVsX291dHB1dF90eXBlIHR5cGUpCj4gPiAgewo+ID4gLQljb25zdCBzdHJ1Y3Qg
Y25sX2RkaV9idWZfdHJhbnMgKmRkaV90cmFuc2xhdGlvbnMgPSBOVUxMOwo+ID4gLQl1MzIgbl9l
bnRyaWVzLCB2YWw7Cj4gPiAtCWludCBsbjsKPiA+ICsJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg
KmRldl9wcml2ID0gdG9faTkxNShlbmNvZGVyLT5iYXNlLmRldik7Cj4gPiArCWVudW0gcG9ydCBw
b3J0ID0gaW50ZWxfZGRpX2dldF9lbmNvZGVyX3BvcnQoZW5jb2Rlcik7Cj4gPiArCWNvbnN0IHN0
cnVjdCBjbmxfZGRpX2J1Zl90cmFucyAqZGRpX3RyYW5zbGF0aW9uczsKPiA+ICsJaW50IG5fZW50
cmllcywgbG47Cj4gPiArCXUzMiB2YWw7Cj4gPiAgCj4gPiAtCWlmICh0eXBlID09IElOVEVMX09V
VFBVVF9IRE1JKSB7Cj4gPiArCWlmICh0eXBlID09IElOVEVMX09VVFBVVF9IRE1JKQo+ID4gIAkJ
ZGRpX3RyYW5zbGF0aW9ucyA9IGNubF9nZXRfYnVmX3RyYW5zX2hkbWkoZGV2X3ByaXYsICZuX2Vu
dHJpZXMpOwo+ID4gLQl9IGVsc2UgaWYgKHR5cGUgPT0gSU5URUxfT1VUUFVUX0RQKSB7Cj4gPiAt
CQlkZGlfdHJhbnNsYXRpb25zID0gY25sX2dldF9idWZfdHJhbnNfZHAoZGV2X3ByaXYsICZuX2Vu
dHJpZXMpOwo+ID4gLQl9IGVsc2UgaWYgKHR5cGUgPT0gSU5URUxfT1VUUFVUX0VEUCkgewo+ID4g
KwllbHNlIGlmICh0eXBlID09IElOVEVMX09VVFBVVF9FRFApCj4gPiAgCQlkZGlfdHJhbnNsYXRp
b25zID0gY25sX2dldF9idWZfdHJhbnNfZWRwKGRldl9wcml2LCAmbl9lbnRyaWVzKTsKPiA+IC0J
fQo+ID4gKwllbHNlCj4gPiArCQlkZGlfdHJhbnNsYXRpb25zID0gY25sX2dldF9idWZfdHJhbnNf
ZHAoZGV2X3ByaXYsICZuX2VudHJpZXMpOwo+ID4gIAo+ID4gIAlpZiAoV0FSTl9PTihkZGlfdHJh
bnNsYXRpb25zID09IE5VTEwpKQo+ID4gIAkJcmV0dXJuOwo+ID4gQEAgLTE5ODYsMjYgKzE5ODcs
MjIgQEAgc3RhdGljIHZvaWQgY25sX2RkaV92c3dpbmdfcHJvZ3JhbShzdHJ1Y3QgZHJtX2k5MTVf
cHJpdmF0ZSAqZGV2X3ByaXYsCj4gPiAgCUk5MTVfV1JJVEUoQ05MX1BPUlRfVFhfRFc3X0dSUChw
b3J0KSwgdmFsKTsKPiA+ICB9Cj4gPiAgCj4gPiAtc3RhdGljIHZvaWQgY25sX2RkaV92c3dpbmdf
c2VxdWVuY2Uoc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIsIHUzMiBsZXZlbCkKPiA+ICtz
dGF0aWMgdm9pZCBjbmxfZGRpX3Zzd2luZ19zZXF1ZW5jZShzdHJ1Y3QgaW50ZWxfZW5jb2RlciAq
ZW5jb2RlciwKPiA+ICsJCQkJICAgIGludCBsZXZlbCwgZW51bSBpbnRlbF9vdXRwdXRfdHlwZSB0
eXBlKQo+ID4gIHsKPiA+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9f
aTkxNShlbmNvZGVyLT5iYXNlLmRldik7Cj4gPiAtCXN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAg
PSBlbmNfdG9faW50ZWxfZHAoJmVuY29kZXItPmJhc2UpOwo+ID4gIAllbnVtIHBvcnQgcG9ydCA9
IGludGVsX2RkaV9nZXRfZW5jb2Rlcl9wb3J0KGVuY29kZXIpOwo+ID4gLQlpbnQgdHlwZSA9IGVu
Y29kZXItPnR5cGU7Cj4gPiAtCWludCB3aWR0aCA9IDA7Cj4gPiAtCWludCByYXRlID0gMDsKPiA+
ICsJaW50IHdpZHRoLCByYXRlLCBsbjsKPiA+ICAJdTMyIHZhbDsKPiA+IC0JaW50IGxuID0gMDsK
PiA+ICAKPiA+IC0JaWYgKChpbnRlbF9kcCkgJiYgKHR5cGUgPT0gSU5URUxfT1VUUFVUX0VEUCB8
fCB0eXBlID09IElOVEVMX09VVFBVVF9EUCkpIHsKPiA+ICsJaWYgKHR5cGUgPT0gSU5URUxfT1VU
UFVUX0hETUkpIHsKPiA+ICsJCXdpZHRoID0gNDsKPiA+ICsJCXJhdGUgPSAwOyAvKiBSYXRlIGlz
IGFsd2F5cyA8IHRoYW4gNkdIeiBmb3IgSERNSSAqLwo+ID4gKwl9IGVsc2Ugewo+ID4gKwkJc3Ry
dWN0IGludGVsX2RwICppbnRlbF9kcCA9IGVuY190b19pbnRlbF9kcCgmZW5jb2Rlci0+YmFzZSk7
Cj4gPiArCj4gPiAgCQl3aWR0aCA9IGludGVsX2RwLT5sYW5lX2NvdW50Owo+ID4gIAkJcmF0ZSA9
IGludGVsX2RwLT5saW5rX3JhdGU7Cj4gPiAtCX0gZWxzZSBpZiAodHlwZSA9PSBJTlRFTF9PVVRQ
VVRfSERNSSkgewo+ID4gLQkJd2lkdGggPSA0Owo+ID4gLQkJLyogUmF0ZSBpcyBhbHdheXMgPCB0
aGFuIDZHSHogZm9yIEhETUkgKi8KPiA+IC0JfSBlbHNlIHsKPiA+IC0JCU1JU1NJTkdfQ0FTRSh0
eXBlKTsKPiA+IC0JCXJldHVybjsKPiA+ICAJfQo+ID4gIAo+ID4gIAkvKgo+ID4gQEAgLTIwMTQs
NyArMjAxMSw3IEBAIHN0YXRpYyB2b2lkIGNubF9kZGlfdnN3aW5nX3NlcXVlbmNlKHN0cnVjdCBp
bnRlbF9lbmNvZGVyICplbmNvZGVyLCB1MzIgbGV2ZWwpCj4gPiAgCSAqIGVsc2UgY2xlYXIgdG8g
MGIuCj4gPiAgCSAqLwo+ID4gIAl2YWwgPSBJOTE1X1JFQUQoQ05MX1BPUlRfUENTX0RXMV9MTjAo
cG9ydCkpOwo+ID4gLQlpZiAodHlwZSA9PSBJTlRFTF9PVVRQVVRfRURQIHx8IHR5cGUgPT0gSU5U
RUxfT1VUUFVUX0RQKQo+ID4gKwlpZiAodHlwZSAhPSBJTlRFTF9PVVRQVVRfSERNSSkKPiA+ICAJ
CXZhbCB8PSBDT01NT05fS0VFUEVSX0VOOwo+ID4gIAllbHNlCj4gPiAgCQl2YWwgJj0gfkNPTU1P
Tl9LRUVQRVJfRU47Cj4gPiBAQCAtMjA0OSw3ICsyMDQ2LDcgQEAgc3RhdGljIHZvaWQgY25sX2Rk
aV92c3dpbmdfc2VxdWVuY2Uoc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIsIHUzMiBsZXZl
bCkKPiA+ICAJSTkxNV9XUklURShDTkxfUE9SVF9UWF9EVzVfR1JQKHBvcnQpLCB2YWwpOwo+ID4g
IAo+ID4gIAkvKiA1LiBQcm9ncmFtIHN3aW5nIGFuZCBkZS1lbXBoYXNpcyAqLwo+ID4gLQljbmxf
ZGRpX3Zzd2luZ19wcm9ncmFtKGRldl9wcml2LCBsZXZlbCwgcG9ydCwgdHlwZSk7Cj4gPiArCWNu
bF9kZGlfdnN3aW5nX3Byb2dyYW0oZW5jb2RlciwgbGV2ZWwsIHR5cGUpOwo+ID4gIAo+ID4gIAkv
KiA2LiBTZXQgdHJhaW5pbmcgZW5hYmxlIHRvIHRyaWdnZXIgdXBkYXRlICovCj4gPiAgCXZhbCA9
IEk5MTVfUkVBRChDTkxfUE9SVF9UWF9EVzVfTE4wKHBvcnQpKTsKPiA+IEBAIC0yMDg5LDcgKzIw
ODYsNyBAQCB1MzIgYnh0X3NpZ25hbF9sZXZlbHMoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCkK
PiA+ICAJdTMyIGxldmVsID0gaW50ZWxfZGRpX2RwX2xldmVsKGludGVsX2RwKTsKPiA+ICAKPiA+
ICAJaWYgKElTX0NBTk5PTkxBS0UoZGV2X3ByaXYpKQo+ID4gLQkJY25sX2RkaV92c3dpbmdfc2Vx
dWVuY2UoZW5jb2RlciwgbGV2ZWwpOwo+ID4gKwkJY25sX2RkaV92c3dpbmdfc2VxdWVuY2UoZW5j
b2RlciwgbGV2ZWwsIGVuY29kZXItPnR5cGUpOwo+ID4gIAllbHNlCj4gPiAgCQlieHRfZGRpX3Zz
d2luZ19zZXF1ZW5jZShlbmNvZGVyLCBsZXZlbCwgZW5jb2Rlci0+dHlwZSk7Cj4gPiAgCj4gPiBA
QCAtMjE4OCw3ICsyMTg1LDcgQEAgc3RhdGljIHZvaWQgaW50ZWxfZGRpX3ByZV9lbmFibGVfZHAo
c3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIsCj4gPiAgCWludGVsX2Rpc3BsYXlfcG93ZXJf
Z2V0KGRldl9wcml2LCBkaWdfcG9ydC0+ZGRpX2lvX3Bvd2VyX2RvbWFpbik7Cj4gPiAgCj4gPiAg
CWlmIChJU19DQU5OT05MQUtFKGRldl9wcml2KSkKPiA+IC0JCWNubF9kZGlfdnN3aW5nX3NlcXVl
bmNlKGVuY29kZXIsIGxldmVsKTsKPiA+ICsJCWNubF9kZGlfdnN3aW5nX3NlcXVlbmNlKGVuY29k
ZXIsIGxldmVsLCBlbmNvZGVyLT50eXBlKTsKPiA+ICAJZWxzZSBpZiAoSVNfR0VOOV9MUChkZXZf
cHJpdikpCj4gPiAgCQlieHRfZGRpX3Zzd2luZ19zZXF1ZW5jZShlbmNvZGVyLCBsZXZlbCwgZW5j
b2Rlci0+dHlwZSk7Cj4gPiAgCWVsc2UKPiA+IEBAIC0yMjE5LDcgKzIyMTYsNyBAQCBzdGF0aWMg
dm9pZCBpbnRlbF9kZGlfcHJlX2VuYWJsZV9oZG1pKHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNv
ZGVyLAo+ID4gIAlpbnRlbF9kaXNwbGF5X3Bvd2VyX2dldChkZXZfcHJpdiwgZGlnX3BvcnQtPmRk
aV9pb19wb3dlcl9kb21haW4pOwo+ID4gIAo+ID4gIAlpZiAoSVNfQ0FOTk9OTEFLRShkZXZfcHJp
dikpCj4gPiAtCQljbmxfZGRpX3Zzd2luZ19zZXF1ZW5jZShlbmNvZGVyLCBsZXZlbCk7Cj4gPiAr
CQljbmxfZGRpX3Zzd2luZ19zZXF1ZW5jZShlbmNvZGVyLCBsZXZlbCwgSU5URUxfT1VUUFVUX0hE
TUkpOwo+ID4gIAllbHNlIGlmIChJU19HRU45X0xQKGRldl9wcml2KSkKPiA+ICAJCWJ4dF9kZGlf
dnN3aW5nX3NlcXVlbmNlKGVuY29kZXIsIGxldmVsLCBJTlRFTF9PVVRQVVRfSERNSSk7Cj4gPiAg
CWVsc2UKPiA+IC0tIAo+ID4gMi4xMy42Cj4gPiAKPiA+IF9fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fCj4gPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gPiBJ
bnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gPiBodHRwczovL2xpc3RzLmZyZWVkZXNr
dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAoKLS0gClZpbGxlIFN5cmrDpGzDpApJ
bnRlbCBPVEMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K
SW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0
dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==