From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 7/8] drm/i915: Use cdclk_state->voltage on CNL Date: Thu, 19 Oct 2017 13:48:04 +0300 Message-ID: <20171019104804.GS10981@intel.com> References: <20171018204825.2500-1-ville.syrjala@linux.intel.com> <20171018204825.2500-8-ville.syrjala@linux.intel.com> <20171018215059.woevjoyzig7rf4sb@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7FC446E09C for ; Thu, 19 Oct 2017 10:48:37 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20171018215059.woevjoyzig7rf4sb@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Rodrigo Vivi Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBPY3QgMTgsIDIwMTcgYXQgMDI6NTA6NTlQTSAtMDcwMCwgUm9kcmlnbyBWaXZpIHdy b3RlOgo+IE9uIFdlZCwgT2N0IDE4LCAyMDE3IGF0IDA4OjQ4OjI0UE0gKzAwMDAsIFZpbGxlIFN5 cmphbGEgd3JvdGU6Cj4gPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGlu dXguaW50ZWwuY29tPgo+ID4gCj4gPiBUcmFjayB0aGUgc3lzdGVtIGFnZW50IHZvbHRhZ2Ugd2Ug cmVxdWVzdCBmcm9tIHBjb2RlIGluIHRoZSBjZGNsayBzdGF0ZQo+ID4gb24gQ05MLiBBbm5veWlu Z2x5IHdlIGNhbid0IGFjdHVhbGx5IHJlYWQgb3V0IHRoZSBjdXJyZW50IHZhbHVlIHNpbmNlCj4g PiB0aGVyZSdzIG5vIHBjb2RlIGNvbW1hbmQgdG8gZG8gdGhhdCwgc28gd2UnbGwgaGF2ZSB0byBq dXN0IGFzc3VtZSB0aGF0Cj4gPiBpdCB3b3JrZWQuCj4gCj4gK3N0YXRpYyB1MzIgY25sX2N1cl92 b2x0YWdlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiArewo+ICsgICAgICAg dTMyIHZvbHRhZ2U7Cj4gKyAgICAgICBzYW5keWJyaWRnZV9wY29kZV9yZWFkKGRldl9wcml2LCBT S0xfUENPREVfQ0RDTEtfQ09OVFJPTCwgJnZvbHRhZ2UpOwoKSSBkb24ndCB0aGluayB0aGF0J2xs IHdvcmsuIF9wY29kZV9yZWFkKCkgYW5kIF9wY29kZV93cml0ZSgpIGFyZSBhY3R1YWxseQp0aGUg c2FtZSB0aGluZywgdGhlIG9ubHkgZGlmZmVyZW5jZSBpcyB3aGV0aGVyIHdlIHJldHVybiB0aGUg cmVzdWx0aW5nIHZhbHVlCm9yIG5vdC4gVGh1cyBpZiB3ZSBhY3R1YWxseSB0cmllZCB0byBkbyB0 aGlzIHdlJ2QgZW5kIHVwIHNldHRpbmcgdGhlCnZvbHRhZ2UgaW5zdGVhZCBvZiByZWFkaW5nIGl0 LiAKClRoZSBvbmx5IHdheSB0byBhY3R1YWxseSByZWFkIGFueXRoaW5nIGlzIGZvciBwY29kZSB0 byBzcGVjaWZ5IGEKc3BlY2lmaWMgcmVhZCBjb21tYW5kLiBJdCdzIGEgcmF0aGVyIHVuZm9ydHVu YXRlIGRlc2lnbiBvZiB0aGUKbWFpbGJveCBpbnRlcmZhY2UgOigKCldlIHNob3VsZCBwZXJoYXBz IHB1dCBzb21lIFdBUk5TIGludG8gdGhlIHBjb2RlIHJlYWQvd3JpdGUgZnVuY3Rpb25zIHNvCnRo YXQgcGVvcGxlIGRvbid0IGFjY2lkZW50YWxseSB1c2UgdGhlbSBpbiB0aGUgd3Jvbmcgd2F5LgoK PiArICAgICAgIHJldHVybiB2b2x0YWdlOwo+ICt9Cj4gKwo+ICBzdGF0aWMgdm9pZCBjbmxfZ2V0 X2NkY2xrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgICAgICAgICAgICAg ICAgICAgICAgICAgc3RydWN0IGludGVsX2NkY2xrX3N0YXRlICpjZGNsa19zdGF0ZSkKPiAgewo+ IEBAIC0xNDg2LDggKzE0OTMsNyBAQCBzdGF0aWMgdm9pZCBjbmxfZ2V0X2NkY2xrKHN0cnVjdCBk cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCj4gICAgICAgICBjZGNsa19zdGF0ZS0+Y2Rj bGsgPSBESVZfUk9VTkRfQ0xPU0VTVChjZGNsa19zdGF0ZS0+dmNvLCBkaXYpOwo+ICAKPiArICAg ICAgIGNkY2xrX3N0YXRlLT52b2x0YWdlID0gY25sX2N1cl92b2x0YWdlKGRldl9wcml2KTsKPiAg fQo+ICAKPiAgc3RhdGljIHZvaWQgY25sX2NkY2xrX3BsbF9kaXNhYmxlKHN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdikKPiBAQCAtMTU5NCw4ICsxNjAwLDcgQEAgc3RhdGljIHZvaWQg Y25sX3NldF9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAo+ICAg ICAgICAgaW50ZWxfdXBkYXRlX2NkY2xrKGRldl9wcml2KTsKPiAgCj4gKyAgICAgICBkZXZfcHJp di0+Y2RjbGsuaHcudm9sdGFnZSA9IGNubF9jdXJfdm9sdGFnZShkZXZfcHJpdik7Cj4gCj4gCj4g PiAKPiA+IENjOiBNaWthIEthaG9sYSA8bWlrYS5rYWhvbGFAaW50ZWwuY29tPgo+ID4gQ2M6IE1h bmFzaSBOYXZhcmUgPG1hbmFzaS5kLm5hdmFyZUBpbnRlbC5jb20+Cj4gPiBDYzogUm9kcmlnbyBW aXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29tPgo+ID4gU2lnbmVkLW9mZi1ieTogVmlsbGUgU3ly asOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiA+IC0tLQo+ID4gIGRyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2NkY2xrLmMgfCA0NCArKysrKysrKysrKysrKysrKysrKysr KystLS0tLS0tLS0tLS0tLQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAyOCBpbnNlcnRpb25zKCspLCAx NiBkZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2NkY2xrLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jZGNsay5jCj4gPiBp bmRleCAxYjRkY2Q5Njg5ZGEuLjc5NWExOGY2NGM0YyAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2NkY2xrLmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2NkY2xrLmMKPiA+IEBAIC0xNTA1LDYgKzE1MDUsMTkgQEAgc3RhdGljIGludCBjbmxf Y2FsY19jZGNsayhpbnQgbWluX2NkY2xrKQo+ID4gIAkJcmV0dXJuIDE2ODAwMDsKPiA+ICB9Cj4g PiAgCj4gPiArc3RhdGljIHU4IGNubF9jYWxjX3ZvbHRhZ2UoaW50IGNkY2xrKQo+ID4gK3sKPiA+ ICsJc3dpdGNoIChjZGNsaykgewo+ID4gKwlkZWZhdWx0Ogo+ID4gKwljYXNlIDE2ODAwMDoKPiA+ ICsJCXJldHVybiAwOwo+ID4gKwljYXNlIDMzNjAwMDoKPiA+ICsJCXJldHVybiAxOwo+ID4gKwlj YXNlIDUyODAwMDoKPiA+ICsJCXJldHVybiAyOwo+ID4gKwl9Cj4gPiArfQo+IAo+IHdoZXJlIGlz IHRoZSBwb3J0X2Nsb2NrIHRha2luZyBpbnRvIGFjY291bnQ/CgpMYXN0IHBhdGNoIG9mIHRoZSBz ZXJpZXMuCgo+IAo+ID4gKwo+ID4gIHN0YXRpYyB2b2lkIGNubF9jZGNsa19wbGxfdXBkYXRlKHN0 cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiA+ICAJCQkJIHN0cnVjdCBpbnRlbF9j ZGNsa19zdGF0ZSAqY2RjbGtfc3RhdGUpCj4gPiAgewo+ID4gQEAgLTE1MzgsNyArMTU1MSw3IEBA IHN0YXRpYyB2b2lkIGNubF9nZXRfY2RjbGsoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w cml2LAo+ID4gIAljZGNsa19zdGF0ZS0+Y2RjbGsgPSBjZGNsa19zdGF0ZS0+cmVmOwo+ID4gIAo+ ID4gIAlpZiAoY2RjbGtfc3RhdGUtPnZjbyA9PSAwKQo+ID4gLQkJcmV0dXJuOwo+ID4gKwkJZ290 byBvdXQ7Cj4gPiAgCj4gPiAgCWRpdmlkZXIgPSBJOTE1X1JFQUQoQ0RDTEtfQ1RMKSAmIEJYVF9D RENMS19DRDJYX0RJVl9TRUxfTUFTSzsKPiA+ICAKPiA+IEBAIC0xNTU1LDYgKzE1NjgsMTMgQEAg c3RhdGljIHZvaWQgY25sX2dldF9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3By aXYsCj4gPiAgCX0KPiA+ICAKPiA+ICAJY2RjbGtfc3RhdGUtPmNkY2xrID0gRElWX1JPVU5EX0NM T1NFU1QoY2RjbGtfc3RhdGUtPnZjbywgZGl2KTsKPiA+ICsKPiA+ICsgb3V0Ogo+ID4gKwkvKgo+ ID4gKwkgKiBDYW4ndCByZWFkIHRoaXMgb3V0IDooIExldCdzIGFzc3VtZSBpdCdzCj4gPiArCSAq IGF0IGxlYXN0IHdoYXQgdGhlIENEQ0xLIGZyZXF1ZW5jeSByZXF1aXJlcy4KPiA+ICsJICovCj4g PiArCWNkY2xrX3N0YXRlLT52b2x0YWdlID0gY25sX2NhbGNfdm9sdGFnZShjZGNsa19zdGF0ZS0+ Y2RjbGspOwo+ID4gIH0KPiA+ICAKPiA+ICBzdGF0aWMgdm9pZCBjbmxfY2RjbGtfcGxsX2Rpc2Fi bGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ID4gQEAgLTE1OTUsNyArMTYx NSw3IEBAIHN0YXRpYyB2b2lkIGNubF9zZXRfY2RjbGsoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg KmRldl9wcml2LAo+ID4gIHsKPiA+ICAJaW50IGNkY2xrID0gY2RjbGtfc3RhdGUtPmNkY2xrOwo+ ID4gIAlpbnQgdmNvID0gY2RjbGtfc3RhdGUtPnZjbzsKPiA+IC0JdTMyIHZhbCwgZGl2aWRlciwg cGN1X2FjazsKPiA+ICsJdTMyIHZhbCwgZGl2aWRlcjsKPiA+ICAJaW50IHJldDsKPiA+ICAKPiA+ ICAJbXV0ZXhfbG9jaygmZGV2X3ByaXYtPnBjdV9sb2NrKTsKPiA+IEBAIC0xNjI0LDE5ICsxNjQ0 LDYgQEAgc3RhdGljIHZvaWQgY25sX3NldF9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAq ZGV2X3ByaXYsCj4gPiAgCQlicmVhazsKPiA+ICAJfQo+ID4gIAo+ID4gLQlzd2l0Y2ggKGNkY2xr KSB7Cj4gPiAtCWNhc2UgNTI4MDAwOgo+ID4gLQkJcGN1X2FjayA9IDI7Cj4gPiAtCQlicmVhazsK PiA+IC0JY2FzZSAzMzYwMDA6Cj4gPiAtCQlwY3VfYWNrID0gMTsKPiA+IC0JCWJyZWFrOwo+ID4g LQljYXNlIDE2ODAwMDoKPiA+IC0JZGVmYXVsdDoKPiA+IC0JCXBjdV9hY2sgPSAwOwo+ID4gLQkJ YnJlYWs7Cj4gPiAtCX0KPiA+IC0KPiA+ICAJaWYgKGRldl9wcml2LT5jZGNsay5ody52Y28gIT0g MCAmJgo+ID4gIAkgICAgZGV2X3ByaXYtPmNkY2xrLmh3LnZjbyAhPSB2Y28pCj4gPiAgCQljbmxf Y2RjbGtfcGxsX2Rpc2FibGUoZGV2X3ByaXYpOwo+ID4gQEAgLTE2NTQsNyArMTY2MSw4IEBAIHN0 YXRpYyB2b2lkIGNubF9zZXRfY2RjbGsoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2 LAo+ID4gIAo+ID4gIAkvKiBpbmZvcm0gUENVIG9mIHRoZSBjaGFuZ2UgKi8KPiA+ICAJbXV0ZXhf bG9jaygmZGV2X3ByaXYtPnBjdV9sb2NrKTsKPiA+IC0Jc2FuZHlicmlkZ2VfcGNvZGVfd3JpdGUo ZGV2X3ByaXYsIFNLTF9QQ09ERV9DRENMS19DT05UUk9MLCBwY3VfYWNrKTsKPiA+ICsJc2FuZHli cmlkZ2VfcGNvZGVfd3JpdGUoZGV2X3ByaXYsIFNLTF9QQ09ERV9DRENMS19DT05UUk9MLAo+ID4g KwkJCQljZGNsa19zdGF0ZS0+dm9sdGFnZSk7Cj4gPiAgCW11dGV4X3VubG9jaygmZGV2X3ByaXYt PnBjdV9sb2NrKTsKPiA+ICAKPiA+ICAJaW50ZWxfdXBkYXRlX2NkY2xrKGRldl9wcml2KTsKPiA+ IEBAIC0xNzQ3LDYgKzE3NTUsNyBAQCB2b2lkIGNubF9pbml0X2NkY2xrKHN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdikKPiA+ICAKPiA+ICAJY2RjbGtfc3RhdGUuY2RjbGsgPSBjbmxf Y2FsY19jZGNsaygwKTsKPiA+ICAJY2RjbGtfc3RhdGUudmNvID0gY25sX2NkY2xrX3BsbF92Y28o ZGV2X3ByaXYsIGNkY2xrX3N0YXRlLmNkY2xrKTsKPiA+ICsJY2RjbGtfc3RhdGUudm9sdGFnZSA9 IGNubF9jYWxjX3ZvbHRhZ2UoY2RjbGtfc3RhdGUuY2RjbGspOwo+ID4gIAo+ID4gIAljbmxfc2V0 X2NkY2xrKGRldl9wcml2LCAmY2RjbGtfc3RhdGUpOwo+ID4gIH0KPiA+IEBAIC0xNzY0LDYgKzE3 NzMsNyBAQCB2b2lkIGNubF91bmluaXRfY2RjbGsoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRl dl9wcml2KQo+ID4gIAo+ID4gIAljZGNsa19zdGF0ZS5jZGNsayA9IGNkY2xrX3N0YXRlLnJlZjsK PiA+ICAJY2RjbGtfc3RhdGUudmNvID0gMDsKPiA+ICsJY2RjbGtfc3RhdGUudm9sdGFnZSA9IGNu bF9jYWxjX3ZvbHRhZ2UoY2RjbGtfc3RhdGUuY2RjbGspOwo+ID4gIAo+ID4gIAljbmxfc2V0X2Nk Y2xrKGRldl9wcml2LCAmY2RjbGtfc3RhdGUpOwo+ID4gIH0KPiA+IEBAIC0yMDgxLDYgKzIwOTEs NyBAQCBzdGF0aWMgaW50IGNubF9tb2Rlc2V0X2NhbGNfY2RjbGsoc3RydWN0IGRybV9hdG9taWNf c3RhdGUgKnN0YXRlKQo+ID4gIAo+ID4gIAlpbnRlbF9zdGF0ZS0+Y2RjbGsubG9naWNhbC52Y28g PSB2Y287Cj4gPiAgCWludGVsX3N0YXRlLT5jZGNsay5sb2dpY2FsLmNkY2xrID0gY2RjbGs7Cj4g PiArCWludGVsX3N0YXRlLT5jZGNsay5sb2dpY2FsLnZvbHRhZ2UgPSBjbmxfY2FsY192b2x0YWdl KGNkY2xrKTsKPiA+ICAKPiA+ICAJaWYgKCFpbnRlbF9zdGF0ZS0+YWN0aXZlX2NydGNzKSB7Cj4g PiAgCQljZGNsayA9IGNubF9jYWxjX2NkY2xrKDApOwo+ID4gQEAgLTIwODgsNiArMjA5OSw3IEBA IHN0YXRpYyBpbnQgY25sX21vZGVzZXRfY2FsY19jZGNsayhzdHJ1Y3QgZHJtX2F0b21pY19zdGF0 ZSAqc3RhdGUpCj4gPiAgCj4gPiAgCQlpbnRlbF9zdGF0ZS0+Y2RjbGsuYWN0dWFsLnZjbyA9IHZj bzsKPiA+ICAJCWludGVsX3N0YXRlLT5jZGNsay5hY3R1YWwuY2RjbGsgPSBjZGNsazsKPiA+ICsJ CWludGVsX3N0YXRlLT5jZGNsay5hY3R1YWwudm9sdGFnZSA9IGNubF9jYWxjX3ZvbHRhZ2UoY2Rj bGspOwo+ID4gIAl9IGVsc2Ugewo+ID4gIAkJaW50ZWxfc3RhdGUtPmNkY2xrLmFjdHVhbCA9Cj4g PiAgCQkJaW50ZWxfc3RhdGUtPmNkY2xrLmxvZ2ljYWw7Cj4gPiAtLSAKPiA+IDIuMTMuNgo+ID4g CgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9pbnRlbC1nZngK