From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 5/8] drm/i915: Use cdclk_state->voltage on SKL/KBL/CFL Date: Fri, 20 Oct 2017 14:18:12 +0300 Message-ID: <20171020111812.GD10981@intel.com> References: <20171018204825.2500-1-ville.syrjala@linux.intel.com> <20171018204825.2500-6-ville.syrjala@linux.intel.com> <20171019234708.bmwdladlcaa4gwax@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 003086E0FF for ; Fri, 20 Oct 2017 11:18:15 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20171019234708.bmwdladlcaa4gwax@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Rodrigo Vivi Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBPY3QgMTksIDIwMTcgYXQgMDQ6NDc6MDhQTSAtMDcwMCwgUm9kcmlnbyBWaXZpIHdy b3RlOgo+IE9uIFdlZCwgT2N0IDE4LCAyMDE3IGF0IDA4OjQ4OjIyUE0gKzAwMDAsIFZpbGxlIFN5 cmphbGEgd3JvdGU6Cj4gPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGlu dXguaW50ZWwuY29tPgo+ID4gCj4gPiBUcmFjayB0aGUgc3lzdGVtIGFnZW50IHZvbHRhZ2Ugd2Ug cmVxdWVzdCBmcm9tIHBjb2RlIGluIHRoZSBjZGNsayBzdGF0ZQo+ID4gb24gU0tML0tCTC9DRkwu IEFubm95aW5nbHkgd2UgY2FuJ3QgYWN0dWFsbHkgcmVhZCBvdXQgdGhlIGN1cnJlbnQgdmFsdWUg c2luY2UKPiA+IHRoZXJlJ3Mgbm8gcGNvZGUgY29tbWFuZCB0byBkbyB0aGF0LCBzbyB3ZSdsbCBo YXZlIHRvIGp1c3QgYXNzdW1lIHRoYXQKPiA+IGl0IHdvcmtlZC4KPiA+IAo+ID4gQ2M6IE1pa2Eg S2Fob2xhIDxtaWthLmthaG9sYUBpbnRlbC5jb20+Cj4gPiBDYzogTWFuYXNpIE5hdmFyZSA8bWFu YXNpLmQubmF2YXJlQGludGVsLmNvbT4KPiA+IENjOiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28udml2 aUBpbnRlbC5jb20+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5 cmphbGFAbGludXguaW50ZWwuY29tPgo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfY2RjbGsuYyB8IDQwICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0t Cj4gPiAgMSBmaWxlIGNoYW5nZWQsIDMzIGluc2VydGlvbnMoKyksIDcgZGVsZXRpb25zKC0pCj4g PiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jZGNsay5jIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY2RjbGsuYwo+ID4gaW5kZXggNzQ0MmU5NDQzZmZh Li42ZjdiNWFiZTZlM2YgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9jZGNsay5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jZGNsay5jCj4g PiBAQCAtNzg5LDYgKzc4OSwyNCBAQCBzdGF0aWMgaW50IHNrbF9jYWxjX2NkY2xrKGludCBtaW5f Y2RjbGssIGludCB2Y28pCj4gPiAgCX0KPiA+ICB9Cj4gPiAgCj4gPiArc3RhdGljIHU4IHNrbF9j YWxjX3ZvbHRhZ2UoaW50IGNkY2xrKQo+ID4gK3sKPiA+ICsJc3dpdGNoIChjZGNsaykgewo+ID4g KwlkZWZhdWx0Ogo+ID4gKwljYXNlIDMwODU3MToKPiA+ICsJY2FzZSAzMzc1MDA6Cj4gPiArCQly ZXR1cm4gMDsKPiA+ICsJY2FzZSA0NTAwMDA6Cj4gPiArCWNhc2UgNDMyMDAwOgo+ID4gKwkJcmV0 dXJuIDE7Cj4gPiArCWNhc2UgNTQwMDAwOgo+ID4gKwkJcmV0dXJuIDI7Cj4gPiArCWNhc2UgNjE3 MTQzOgo+ID4gKwljYXNlIDY3NTAwMDoKPiA+ICsJCXJldHVybiAzOwo+ID4gKwl9Cj4gPiArfQo+ ID4gKwo+ID4gIHN0YXRpYyB2b2lkIHNrbF9kcGxsMF91cGRhdGUoc3RydWN0IGRybV9pOTE1X3By aXZhdGUgKmRldl9wcml2LAo+ID4gIAkJCSAgICAgc3RydWN0IGludGVsX2NkY2xrX3N0YXRlICpj ZGNsa19zdGF0ZSkKPiA+ICB7Cj4gPiBAQCAtODM5LDcgKzg1Nyw3IEBAIHN0YXRpYyB2b2lkIHNr bF9nZXRfY2RjbGsoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ID4gIAljZGNs a19zdGF0ZS0+Y2RjbGsgPSBjZGNsa19zdGF0ZS0+cmVmOwo+ID4gIAo+ID4gIAlpZiAoY2RjbGtf c3RhdGUtPnZjbyA9PSAwKQo+ID4gLQkJcmV0dXJuOwo+ID4gKwkJZ290byBvdXQ7Cj4gCj4gd2h5 IGRvIHdlIG5lZWQgdGhpcyBjYXNlPwoKTWFpbmx5IGp1c3QgdG8gbWFrZSBzdXJlIHRoZSBlbnRp cmUgc3RhdGUgaXMgY29uc2lzdGVudC4KCj4gCj4gPiAgCj4gPiAgCWNkY3RsID0gSTkxNV9SRUFE KENEQ0xLX0NUTCk7Cj4gPiAgCj4gPiBAQCAtODgwLDYgKzg5OCwxMyBAQCBzdGF0aWMgdm9pZCBz a2xfZ2V0X2NkY2xrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiA+ICAJCQli cmVhazsKPiA+ICAJCX0KPiA+ICAJfQo+ID4gKwo+ID4gKyBvdXQ6Cj4gPiArCS8qCj4gPiArCSAq IENhbid0IHJlYWQgdGhpcyBvdXQgOiggTGV0J3MgYXNzdW1lIGl0J3MKPiA+ICsJICogYXQgbGVh c3Qgd2hhdCB0aGUgQ0RDTEsgZnJlcXVlbmN5IHJlcXVpcmVzLgo+ID4gKwkgKi8KPiA+ICsJY2Rj bGtfc3RhdGUtPnZvbHRhZ2UgPSBza2xfY2FsY192b2x0YWdlKGNkY2xrX3N0YXRlLT5jZGNsayk7 Cj4gPiAgfQo+ID4gIAo+ID4gIC8qIGNvbnZlcnQgZnJvbSBrSHogdG8gLjEgZml4cG9pbnQgTUh6 IHdpdGggLTFNSHogb2Zmc2V0ICovCj4gPiBAQCAtOTY0LDcgKzk4OSw3IEBAIHN0YXRpYyB2b2lk IHNrbF9zZXRfY2RjbGsoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ID4gIHsK PiA+ICAJaW50IGNkY2xrID0gY2RjbGtfc3RhdGUtPmNkY2xrOwo+ID4gIAlpbnQgdmNvID0gY2Rj bGtfc3RhdGUtPnZjbzsKPiA+IC0JdTMyIGZyZXFfc2VsZWN0LCBwY3VfYWNrOwo+ID4gKwl1MzIg ZnJlcV9zZWxlY3Q7Cj4gPiAgCWludCByZXQ7Cj4gPiAgCj4gPiAgCW11dGV4X2xvY2soJmRldl9w cml2LT5wY3VfbG9jayk7Cj4gPiBAQCAtOTg4LDIxICsxMDEzLDE3IEBAIHN0YXRpYyB2b2lkIHNr bF9zZXRfY2RjbGsoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ID4gIAljYXNl IDMwODU3MToKPiA+ICAJY2FzZSAzMzc1MDA6Cj4gPiAgCQlmcmVxX3NlbGVjdCA9IENEQ0xLX0ZS RVFfMzM3XzMwODsKPiA+IC0JCXBjdV9hY2sgPSAwOwo+ID4gIAkJYnJlYWs7Cj4gPiAgCWNhc2Ug NDUwMDAwOgo+ID4gIAljYXNlIDQzMjAwMDoKPiA+ICAJCWZyZXFfc2VsZWN0ID0gQ0RDTEtfRlJF UV80NTBfNDMyOwo+ID4gLQkJcGN1X2FjayA9IDE7Cj4gPiAgCQlicmVhazsKPiA+ICAJY2FzZSA1 NDAwMDA6Cj4gPiAgCQlmcmVxX3NlbGVjdCA9IENEQ0xLX0ZSRVFfNTQwOwo+ID4gLQkJcGN1X2Fj ayA9IDI7Cj4gPiAgCQlicmVhazsKPiA+ICAJY2FzZSA2MTcxNDM6Cj4gPiAgCWNhc2UgNjc1MDAw Ogo+ID4gIAkJZnJlcV9zZWxlY3QgPSBDRENMS19GUkVRXzY3NV82MTc7Cj4gPiAtCQlwY3VfYWNr ID0gMzsKPiA+ICAJCWJyZWFrOwo+ID4gIAl9Cj4gPiAgCj4gPiBAQCAtMTAxOCw3ICsxMDM5LDgg QEAgc3RhdGljIHZvaWQgc2tsX3NldF9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2 X3ByaXYsCj4gPiAgCj4gPiAgCS8qIGluZm9ybSBQQ1Ugb2YgdGhlIGNoYW5nZSAqLwo+ID4gIAlt dXRleF9sb2NrKCZkZXZfcHJpdi0+cGN1X2xvY2spOwo+ID4gLQlzYW5keWJyaWRnZV9wY29kZV93 cml0ZShkZXZfcHJpdiwgU0tMX1BDT0RFX0NEQ0xLX0NPTlRST0wsIHBjdV9hY2spOwo+ID4gKwlz YW5keWJyaWRnZV9wY29kZV93cml0ZShkZXZfcHJpdiwgU0tMX1BDT0RFX0NEQ0xLX0NPTlRST0ws Cj4gPiArCQkJCWNkY2xrX3N0YXRlLT52b2x0YWdlKTsKPiA+ICAJbXV0ZXhfdW5sb2NrKCZkZXZf cHJpdi0+cGN1X2xvY2spOwo+ID4gIAo+ID4gIAlpbnRlbF91cGRhdGVfY2RjbGsoZGV2X3ByaXYp Owo+ID4gQEAgLTEwOTcsNiArMTExOSw3IEBAIHZvaWQgc2tsX2luaXRfY2RjbGsoc3RydWN0IGRy bV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ID4gIAlpZiAoY2RjbGtfc3RhdGUudmNvID09IDAp Cj4gPiAgCQljZGNsa19zdGF0ZS52Y28gPSA4MTAwMDAwOwo+ID4gIAljZGNsa19zdGF0ZS5jZGNs ayA9IHNrbF9jYWxjX2NkY2xrKDAsIGNkY2xrX3N0YXRlLnZjbyk7Cj4gPiArCWNkY2xrX3N0YXRl LnZvbHRhZ2UgPSBza2xfY2FsY192b2x0YWdlKGNkY2xrX3N0YXRlLmNkY2xrKTsKPiA+ICAKPiA+ ICAJc2tsX3NldF9jZGNsayhkZXZfcHJpdiwgJmNkY2xrX3N0YXRlKTsKPiA+ICB9Cj4gPiBAQCAt MTExNCw2ICsxMTM3LDcgQEAgdm9pZCBza2xfdW5pbml0X2NkY2xrKHN0cnVjdCBkcm1faTkxNV9w cml2YXRlICpkZXZfcHJpdikKPiA+ICAKPiA+ICAJY2RjbGtfc3RhdGUuY2RjbGsgPSBjZGNsa19z dGF0ZS5yZWY7Cj4gPiAgCWNkY2xrX3N0YXRlLnZjbyA9IDA7Cj4gPiArCWNkY2xrX3N0YXRlLnZv bHRhZ2UgPSBza2xfY2FsY192b2x0YWdlKGNkY2xrX3N0YXRlLmNkY2xrKTsKPiA+ICAKPiA+ICAJ c2tsX3NldF9jZGNsayhkZXZfcHJpdiwgJmNkY2xrX3N0YXRlKTsKPiA+ICB9Cj4gPiBAQCAtMTk3 MCwxMiArMTk5NCwxNCBAQCBzdGF0aWMgaW50IHNrbF9tb2Rlc2V0X2NhbGNfY2RjbGsoc3RydWN0 IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlKQo+ID4gIAo+ID4gIAlpbnRlbF9zdGF0ZS0+Y2RjbGsu bG9naWNhbC52Y28gPSB2Y287Cj4gPiAgCWludGVsX3N0YXRlLT5jZGNsay5sb2dpY2FsLmNkY2xr ID0gY2RjbGs7Cj4gPiArCWludGVsX3N0YXRlLT5jZGNsay5sb2dpY2FsLnZvbHRhZ2UgPSBza2xf Y2FsY192b2x0YWdlKGNkY2xrKTsKPiA+ICAKPiA+ICAJaWYgKCFpbnRlbF9zdGF0ZS0+YWN0aXZl X2NydGNzKSB7Cj4gPiAgCQljZGNsayA9IHNrbF9jYWxjX2NkY2xrKDAsIHZjbyk7Cj4gPiAgCj4g PiAgCQlpbnRlbF9zdGF0ZS0+Y2RjbGsuYWN0dWFsLnZjbyA9IHZjbzsKPiA+ICAJCWludGVsX3N0 YXRlLT5jZGNsay5hY3R1YWwuY2RjbGsgPSBjZGNsazsKPiA+ICsJCWludGVsX3N0YXRlLT5jZGNs ay5hY3R1YWwudm9sdGFnZSA9IHNrbF9jYWxjX3ZvbHRhZ2UoY2RjbGspOwo+ID4gIAl9IGVsc2Ug ewo+ID4gIAkJaW50ZWxfc3RhdGUtPmNkY2xrLmFjdHVhbCA9Cj4gPiAgCQkJaW50ZWxfc3RhdGUt PmNkY2xrLmxvZ2ljYWw7Cj4gPiAtLSAKPiA+IDIuMTMuNgo+ID4gCgotLSAKVmlsbGUgU3lyasOk bMOkCkludGVsIE9UQwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1n ZngK