From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v2 3/8] drm/i915: Use cdclk_state->voltage on VLV/CHV Date: Fri, 20 Oct 2017 19:20:20 +0300 Message-ID: <20171020162020.GO10981@intel.com> References: <20171018204825.2500-4-ville.syrjala@linux.intel.com> <20171019174329.30912-1-ville.syrjala@linux.intel.com> <20171019234252.fqgjjkjzd5m34t4p@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6A1AE892EE for ; Fri, 20 Oct 2017 16:20:35 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20171019234252.fqgjjkjzd5m34t4p@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Rodrigo Vivi Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBPY3QgMTksIDIwMTcgYXQgMDQ6NDI6NTJQTSAtMDcwMCwgUm9kcmlnbyBWaXZpIHdy b3RlOgo+IE9uIFRodSwgT2N0IDE5LCAyMDE3IGF0IDA1OjQzOjI5UE0gKzAwMDAsIFZpbGxlIFN5 cmphbGEgd3JvdGU6Cj4gPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGlu dXguaW50ZWwuY29tPgo+ID4gCj4gPiBTdG9yZSB0aGUgcHVuaXQgRFNQRlJFUVVBUiB2YWx1ZSBp bnRvIGNkY2xrX3N0YXRlLT52b2x0YWdlIG9uCj4gPiBWTFYvQ0hWLiBTaW5jZSB3ZSBjYW4gYWN0 dWFsbHkgcmVhZCB0aGF0IG91dCBmcm9tIHRoZSBoYXJkd2FyZQo+ID4gdGhpcyBjYW4gZ2l2ZSB1 cyBhIGJpdCBtb3JlIGNyb3NzIGNoZWNraW5nIGJldHdlZW4gdGhlIGhhcmR3YXJlCj4gPiBhbmQg c29mdHdhcmUgc3RhdGUuCj4gPiAKPiA+IHYyOiBEb24ndCBicmVhayB3YWl0aW5nIGZvciBjZGNs ayBjaGFuZ2Ugb24gVkxWL0NIVgo+ID4gCj4gPiBDYzogTWlrYSBLYWhvbGEgPG1pa2Eua2Fob2xh QGludGVsLmNvbT4KPiA+IENjOiBNYW5hc2kgTmF2YXJlIDxtYW5hc2kuZC5uYXZhcmVAaW50ZWwu Y29tPgo+ID4gQ2M6IFJvZHJpZ28gVml2aSA8cm9kcmlnby52aXZpQGludGVsLmNvbT4KPiA+IFNp Z25lZC1vZmYtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5j b20+Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jZGNsay5jIHwgNjYg KysrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0KPiA+ICAxIGZpbGUgY2hhbmdl ZCwgNTAgaW5zZXJ0aW9ucygrKSwgMTYgZGVsZXRpb25zKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jZGNsay5jIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfY2RjbGsuYwo+ID4gaW5kZXggNTIyMjIyZjhiYjUwLi45Y2M0Mzc0Nzk3ZWIgMTAw NjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jZGNsay5jCj4gPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jZGNsay5jCj4gPiBAQCAtNDM3LDEzICs0Mzcs NDUgQEAgc3RhdGljIGludCB2bHZfY2FsY19jZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAq ZGV2X3ByaXYsIGludCBtaW5fY2RjbGspCj4gPiAgCQlyZXR1cm4gMjAwMDAwOwo+ID4gIH0KPiA+ ICAKPiA+ICtzdGF0aWMgdTggdmx2X2NhbGNfdm9sdGFnZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0 ZSAqZGV2X3ByaXYsIGludCBjZGNsaykKPiA+ICt7Cj4gPiArCWlmIChJU19WQUxMRVlWSUVXKGRl dl9wcml2KSkgewo+ID4gKwkJaWYgKGNkY2xrID49IDMyMDAwMCkgLyoganVtcCB0byBoaWdoZXN0 IHZvbHRhZ2UgZm9yIDQwME1IeiB0b28gKi8KPiA+ICsJCQlyZXR1cm4gMjsKPiA+ICsJCWVsc2Ug aWYgKGNkY2xrID49IDI2NjY2NykKPiA+ICsJCQlyZXR1cm4gMTsKPiA+ICsJCWVsc2UKPiA+ICsJ CQlyZXR1cm4gMDsKPiA+ICsJfSBlbHNlIHsKPiA+ICsJCS8qCj4gPiArCQkgKiBTcGVjcyBhcmUg ZnVsbCBvZiBtaXNpbmZvcm1hdGlvbiwgYnV0IHRlc3Rpbmcgb24gYWN0dWFsCj4gPiArCQkgKiBo YXJkd2FyZSBoYXMgc2hvd24gdGhhdCB3ZSBqdXN0IG5lZWQgdG8gd3JpdGUgdGhlIGRlc2lyZWQK PiA+ICsJCSAqIENDSyBkaXZpZGVyIGludG8gdGhlIFB1bml0IHJlZ2lzdGVyLgo+ID4gKwkJICov Cj4gPiArCQlyZXR1cm4gRElWX1JPVU5EX0NMT1NFU1QoZGV2X3ByaXYtPmhwbGxfZnJlcSA8PCAx LCBjZGNsaykgLSAxOwo+ID4gKwl9Cj4gPiArfQo+ID4gKwo+ID4gIHN0YXRpYyB2b2lkIHZsdl9n ZXRfY2RjbGsoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ID4gIAkJCSAgc3Ry dWN0IGludGVsX2NkY2xrX3N0YXRlICpjZGNsa19zdGF0ZSkKPiA+ICB7Cj4gPiArCXUzMiB2YWw7 Cj4gPiArCj4gPiAgCWNkY2xrX3N0YXRlLT52Y28gPSB2bHZfZ2V0X2hwbGxfdmNvKGRldl9wcml2 KTsKPiA+ICAJY2RjbGtfc3RhdGUtPmNkY2xrID0gdmx2X2dldF9jY2tfY2xvY2soZGV2X3ByaXYs ICJjZGNsayIsCj4gPiAgCQkJCQkgICAgICAgQ0NLX0RJU1BMQVlfQ0xPQ0tfQ09OVFJPTCwKPiA+ ICAJCQkJCSAgICAgICBjZGNsa19zdGF0ZS0+dmNvKTsKPiA+ICsKPiA+ICsJbXV0ZXhfbG9jaygm ZGV2X3ByaXYtPnBjdV9sb2NrKTsKPiA+ICsJdmFsID0gdmx2X3B1bml0X3JlYWQoZGV2X3ByaXYs IFBVTklUX1JFR19EU1BGUkVRKTsKPiA+ICsJbXV0ZXhfdW5sb2NrKCZkZXZfcHJpdi0+cGN1X2xv Y2spOwo+ID4gKwo+ID4gKwlpZiAoSVNfVkFMTEVZVklFVyhkZXZfcHJpdikpCj4gPiArCQljZGNs a19zdGF0ZS0+dm9sdGFnZSA9ICh2YWwgJiBEU1BGUkVRR1VBUl9NQVNLKSA+Pgo+ID4gKwkJCURT UEZSRVFHVUFSX1NISUZUOwo+ID4gKwllbHNlCj4gPiArCQljZGNsa19zdGF0ZS0+dm9sdGFnZSA9 ICh2YWwgJiBEU1BGUkVRR1VBUl9NQVNLX0NIVikgPj4KPiA+ICsJCQlEU1BGUkVRR1VBUl9TSElG VF9DSFY7Cj4gCj4gT2ggaW50ZXJyZXN0aW5nIHRoYXQgdmx2IGlzIHRoZSBvbmx5IG9uZSB3aGVy ZSB3ZSBjYW4gYWN0dWFsbHkgcmVhZCBpdC4gOigKPiAKPiBJIHdhcyBnb2luZyB0byBhc2sgcG9p bnRlcnMgdG8gc3BlYywgYnV0IGp1c3QgYnkge3ZsdixjaHZ9X3NldF9jZGNsayBpdCB3YXMKPiBw b3NzaWJsZSB0byB2ZXJpZnkgdGhpcyBpcyByaWdodC4KClllYWgsIHRoZSBpb3NmIHNpZGViYW5k IG1haWxib3ggaXMgbXVjaCBuaWNlciBiZWNhdXNlIHlvdSBoYXZlIGFjdHVhbApyZWFkIHZzLiB3 cml0ZSBvcGNvZGVzIGluIGFkZGl0aW9uIHRvIHRoZSBwb3J0K3JlZ2lzdGVyIG9mZnNldAppbmZv cm1hdGlvbiB3aGljaCBqdXN0IHNwZWNpZnkgd2hhdCB5b3Ugd2FudCB0byBhY2Nlc3MuCgo+IAo+ ID4gIH0KPiA+ICAKPiA+ICBzdGF0aWMgdm9pZCB2bHZfcHJvZ3JhbV9wZmlfY3JlZGl0cyhzdHJ1 Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gPiBAQCAtNDg2LDcgKzUxOCwxOSBAQCBz dGF0aWMgdm9pZCB2bHZfc2V0X2NkY2xrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp diwKPiA+ICAJCQkgIGNvbnN0IHN0cnVjdCBpbnRlbF9jZGNsa19zdGF0ZSAqY2RjbGtfc3RhdGUp Cj4gPiAgewo+ID4gIAlpbnQgY2RjbGsgPSBjZGNsa19zdGF0ZS0+Y2RjbGs7Cj4gPiAtCXUzMiB2 YWwsIGNtZDsKPiA+ICsJdTMyIHZhbCwgY21kID0gY2RjbGtfc3RhdGUtPnZvbHRhZ2U7Cj4gPiAr Cj4gPiArCXN3aXRjaCAoY2RjbGspIHsKPiA+ICsJY2FzZSA0MDAwMDA6Cj4gPiArCWNhc2UgMzMz MzMzOgo+ID4gKwljYXNlIDMyMDAwMDoKPiA+ICsJY2FzZSAyNjY2Njc6Cj4gPiArCWNhc2UgMjAw MDAwOgo+ID4gKwkJYnJlYWs7Cj4gPiArCWRlZmF1bHQ6Cj4gPiArCQlNSVNTSU5HX0NBU0UoY2Rj bGspOwo+ID4gKwkJcmV0dXJuOwo+ID4gKwl9Cj4gCj4gSSBiZWxpZXZlIHRoaXMgc2hvdWxkIGJl IGluIGEgc2VwYXJhdGVkIHBhdGNoLCBubz8hCj4gU2VlbXMgc29tZXRoaW5nIHdlIHdlcmUgYWxy ZWFkeSBtaXNzaW5nIGFueXdheXMuCgpJIHdhcyBnb2luZyBiYWNrIGFuZCBmb3J0aCBiZXR3ZWVu IHJlbW92aW5nIHRoaXMgZnJvbSB0aGUKY2h2X3NldF9jZGNsaygpLCBhbmQgaW4gdGhlIGVuZCBJ IGRlY2lkZWQgdG8ga2VlcCBpdC4gQW5kIGxvb2tzIGxpa2UgSQp0aGVuIGFjY2lkZW50YWxseSBh ZGRlZCBpdCBpbnRvIHZsdl9zZXRfY2RjbGsoKSBhcyB3ZWxsIHRoaW5raW5nIGJvdGgKaGFkIGl0 IG9yaWdpbmFsbHkuIEkgZ3Vlc3MgSSdtIHN0aWxsIGxlYW5pbmcgdG93YXJkcyBrZWVwaW5nIGl0 LCBzbwpJJ2xsIGdvIGFoZWFkIGFuZCBzcGxpdCB0aGlzIG91dCB0byBhIHNlcGFyYXRlIHBhdGNo LgoKPiAKPiBCdXQgYW55d2F5cywgaWYgeW91IGRlY2lkZSB0byBzcGxpdCBvciBub3QKPiAKPiBS ZXZpZXdlZC1ieTogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29tPgo+IAo+ID4g IAo+ID4gIAkvKiBUaGVyZSBhcmUgY2FzZXMgd2hlcmUgd2UgY2FuIGVuZCB1cCBoZXJlIHdpdGgg cG93ZXIgZG9tYWlucwo+ID4gIAkgKiBvZmYgYW5kIGEgQ0RDTEsgZnJlcXVlbmN5IG90aGVyIHRo YW4gdGhlIG1pbmltdW0sIGxpa2Ugd2hlbgo+ID4gQEAgLTQ5NiwxMyArNTQwLDYgQEAgc3RhdGlj IHZvaWQgdmx2X3NldF9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4g PiAgCSAqLwo+ID4gIAlpbnRlbF9kaXNwbGF5X3Bvd2VyX2dldChkZXZfcHJpdiwgUE9XRVJfRE9N QUlOX1BJUEVfQSk7Cj4gPiAgCj4gPiAtCWlmIChjZGNsayA+PSAzMjAwMDApIC8qIGp1bXAgdG8g aGlnaGVzdCB2b2x0YWdlIGZvciA0MDBNSHogdG9vICovCj4gPiAtCQljbWQgPSAyOwo+ID4gLQll bHNlIGlmIChjZGNsayA9PSAyNjY2NjcpCj4gPiAtCQljbWQgPSAxOwo+ID4gLQllbHNlCj4gPiAt CQljbWQgPSAwOwo+ID4gLQo+ID4gIAltdXRleF9sb2NrKCZkZXZfcHJpdi0+cGN1X2xvY2spOwo+ ID4gIAl2YWwgPSB2bHZfcHVuaXRfcmVhZChkZXZfcHJpdiwgUFVOSVRfUkVHX0RTUEZSRVEpOwo+ ID4gIAl2YWwgJj0gfkRTUEZSRVFHVUFSX01BU0s7Cj4gPiBAQCAtNTYyLDcgKzU5OSw3IEBAIHN0 YXRpYyB2b2lkIGNodl9zZXRfY2RjbGsoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2 LAo+ID4gIAkJCSAgY29uc3Qgc3RydWN0IGludGVsX2NkY2xrX3N0YXRlICpjZGNsa19zdGF0ZSkK PiA+ICB7Cj4gPiAgCWludCBjZGNsayA9IGNkY2xrX3N0YXRlLT5jZGNsazsKPiA+IC0JdTMyIHZh bCwgY21kOwo+ID4gKwl1MzIgdmFsLCBjbWQgPSBjZGNsa19zdGF0ZS0+dm9sdGFnZTsKPiA+ICAK PiA+ICAJc3dpdGNoIChjZGNsaykgewo+ID4gIAljYXNlIDMzMzMzMzoKPiA+IEBAIC01ODMsMTMg KzYyMCw2IEBAIHN0YXRpYyB2b2lkIGNodl9zZXRfY2RjbGsoc3RydWN0IGRybV9pOTE1X3ByaXZh dGUgKmRldl9wcml2LAo+ID4gIAkgKi8KPiA+ICAJaW50ZWxfZGlzcGxheV9wb3dlcl9nZXQoZGV2 X3ByaXYsIFBPV0VSX0RPTUFJTl9QSVBFX0EpOwo+ID4gIAo+ID4gLQkvKgo+ID4gLQkgKiBTcGVj cyBhcmUgZnVsbCBvZiBtaXNpbmZvcm1hdGlvbiwgYnV0IHRlc3Rpbmcgb24gYWN0dWFsCj4gPiAt CSAqIGhhcmR3YXJlIGhhcyBzaG93biB0aGF0IHdlIGp1c3QgbmVlZCB0byB3cml0ZSB0aGUgZGVz aXJlZAo+ID4gLQkgKiBDQ0sgZGl2aWRlciBpbnRvIHRoZSBQdW5pdCByZWdpc3Rlci4KPiA+IC0J ICovCj4gPiAtCWNtZCA9IERJVl9ST1VORF9DTE9TRVNUKGRldl9wcml2LT5ocGxsX2ZyZXEgPDwg MSwgY2RjbGspIC0gMTsKPiA+IC0KPiA+ICAJbXV0ZXhfbG9jaygmZGV2X3ByaXYtPnBjdV9sb2Nr KTsKPiA+ICAJdmFsID0gdmx2X3B1bml0X3JlYWQoZGV2X3ByaXYsIFBVTklUX1JFR19EU1BGUkVR KTsKPiA+ICAJdmFsICY9IH5EU1BGUkVRR1VBUl9NQVNLX0NIVjsKPiA+IEBAIC0xODU5LDExICsx ODg5LDE1IEBAIHN0YXRpYyBpbnQgdmx2X21vZGVzZXRfY2FsY19jZGNsayhzdHJ1Y3QgZHJtX2F0 b21pY19zdGF0ZSAqc3RhdGUpCj4gPiAgCWNkY2xrID0gdmx2X2NhbGNfY2RjbGsoZGV2X3ByaXYs IG1pbl9jZGNsayk7Cj4gPiAgCj4gPiAgCWludGVsX3N0YXRlLT5jZGNsay5sb2dpY2FsLmNkY2xr ID0gY2RjbGs7Cj4gPiArCWludGVsX3N0YXRlLT5jZGNsay5sb2dpY2FsLnZvbHRhZ2UgPQo+ID4g KwkJdmx2X2NhbGNfdm9sdGFnZShkZXZfcHJpdiwgY2RjbGspOwo+ID4gIAo+ID4gIAlpZiAoIWlu dGVsX3N0YXRlLT5hY3RpdmVfY3J0Y3MpIHsKPiA+ICAJCWNkY2xrID0gdmx2X2NhbGNfY2RjbGso ZGV2X3ByaXYsIDApOwo+ID4gIAo+ID4gIAkJaW50ZWxfc3RhdGUtPmNkY2xrLmFjdHVhbC5jZGNs ayA9IGNkY2xrOwo+ID4gKwkJaW50ZWxfc3RhdGUtPmNkY2xrLmFjdHVhbC52b2x0YWdlID0KPiA+ ICsJCQl2bHZfY2FsY192b2x0YWdlKGRldl9wcml2LCBjZGNsayk7Cj4gPiAgCX0gZWxzZSB7Cj4g PiAgCQlpbnRlbF9zdGF0ZS0+Y2RjbGsuYWN0dWFsID0KPiA+ICAJCQlpbnRlbF9zdGF0ZS0+Y2Rj bGsubG9naWNhbDsKPiA+IC0tIAo+ID4gMi4xMy42Cj4gPiAKCi0tIApWaWxsZSBTeXJqw6Rsw6QK SW50ZWwgT1RDCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=