From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915/cnl: Force DDI_A_4_LANES when needed. Date: Mon, 23 Oct 2017 20:26:58 +0300 Message-ID: <20171023172657.GA10981@intel.com> References: <20171023131135.GY10981@intel.com> <20171023171200.19092-1-rodrigo.vivi@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 21B636E3AA for ; Mon, 23 Oct 2017 17:27:02 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20171023171200.19092-1-rodrigo.vivi@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Rodrigo Vivi Cc: Jani Nikula , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBPY3QgMjMsIDIwMTcgYXQgMTA6MTI6MDBBTSAtMDcwMCwgUm9kcmlnbyBWaXZpIHdy b3RlOgo+IEFzIHdlIGZhY2VkIGluIEJYVCwgb24gQ05MIERESV9BXzRfTEFORVMgaXMgbm90Cj4g c2V0IGFzIGV4cGVjdGVkIHdoZW4gc3lzdGVtIGlzIGJvb3Qgd2l0aCBtdWx0aXBsZQo+IG1vbml0 b3JzIGNvbm5lY3RlZC4gVGhpcyByZXN1bHQgaW4gd3JvbmcgbGFuZQo+IHNldHVwIGltcGFjdGlu ZyB0aGUgbWF4IGRhdGEgcmF0ZSBhdmFpbGFibGUgYW5kCj4gY29uc2VxdWVudGx5IGJsb2NraW5n IG1vZGVzZXQgb24gZURQLCByZXN1bHRpbmcKPiBpbiBhIGJsYW5rIHNjcmVlbi4KPiAKPiBNb3N0 IG9mIENOTCBTS1VzIGRvbid0IHN1cHBvcnQgRERJLUUuCj4gVGhlIG9ubHkgU0tVIHRoYXQgc3Vw cG9ydHMgRERJLUUgaXMgdGhlIHNhbWUKPiB0aGF0IHN1cHBvcnRzIHRoZSBmdWxsIEEvRSBzcGxp dCBjYWxsZWQgRERJLUYuCj4gCj4gQWxzbyB3aGVuIERESS1GIGlzIHVzZWQgRERJLUUgY2Fubm90 IGJlIHVzZWQgYmVjYXVzZQo+IHRoZXkgc2hhcmUgSW50ZXJydXB0cy4gU28gRERJLUUgaXMgYWxt b3N0IHVzZWxlc3MuCj4gQW55d2F5cyBsZXQncyBjb25zaWRlciB0aGlzIGlzIHBvc3NpYmxlIGFu ZCByZWx5IG9uCj4gVkJUIGZvciB0aGF0Lgo+IAo+IFRoaXMgcGF0Y2ggd2FzIGluaXRpYWx5IHN0 YXJ0IGJ5IENsaW50LCBidXQgcmVxdWlyZWQKPiBtYW55IGNoYW5nZXMgaW5jbHVkaW5nIGZ1bGwg Y29tbWl0IG1lc3NhZ2UuIFNvCj4gQ3JlZGl0cyBlbnRpcmVseSB0byBDbGludCBmb3IgZmluZGlu ZyB0aGlzLgo+IAo+IHYyOiBFeHRyYWN0IGFsbCBtZXNzeSBjb25kaXRpb25zIGludG8gYSBoZWxw ZXIgZnVuY3Rpb24KPiAgICAgYXMgc3VnZ2VzdGVkIGJ5IFZpbGxlLgo+ICAgICBBbG9uZyB3aXRo IHNpbXBsaWZpY2F0aW9uIEkgcmVtb3ZlZCB0aGUgZGVidWcKPiAgICAgbWVzc2FnZSBvbiB0aGUg d29ya2luZyBjYXNlIHNpbmNlIG5vdyBhbGwgY29uZGl0aW9ucwo+ICAgICBhcmUgZ3JvdXBlZC4K PiAKPiBTdWdnZXN0ZWQtYnk6IENsaW50IFRheWxvciA8Y2xpbnRvbi5hLnRheWxvckBpbnRlbC5j b20+Cj4gQ2M6IENsaW50IFRheWxvciA8Y2xpbnRvbi5hLnRheWxvckBpbnRlbC5jb20+Cj4gQ2M6 IE1pa2EgS2Fob2xhIDxtaWthLmthaG9sYUBpbnRlbC5jb20+Cj4gQ2M6IEphbmkgTmlrdWxhIDxq YW5pLm5pa3VsYUBpbnRlbC5jb20+Cj4gQ2M6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFs YUBsaW51eC5pbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogUm9kcmlnbyBWaXZpIDxyb2RyaWdv LnZpdmlAaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGku YyB8IDM2ICsrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hh bmdlZCwgMjUgaW5zZXJ0aW9ucygrKSwgMTEgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZGRpLmMKPiBpbmRleCBhZGY1MWIzMjg4NDQuLjViMDNjMjRiYWU5NyAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2RkaS5jCj4gQEAgLTI2OTQsNiArMjY5NCwyNCBAQCBpbnRlbF9kZGlf aW5pdF9oZG1pX2Nvbm5lY3RvcihzdHJ1Y3QgaW50ZWxfZGlnaXRhbF9wb3J0ICppbnRlbF9kaWdf cG9ydCkKPiAgCXJldHVybiBjb25uZWN0b3I7Cj4gIH0KPiAgCj4gK3N0YXRpYyBib29sIGludGVs X2RkaV9hX2ZvcmNlXzRfbGFuZXMoc3RydWN0IGludGVsX2RpZ2l0YWxfcG9ydCAqZHBvcnQpCj4g K3sKPiArCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZHBvcnQt PmJhc2UuYmFzZS5kZXYpOwo+ICsKPiArCS8qIEJyb3h0b246IEJzcGVjIHNheXMgdGhhdCBERElf QV80X0xBTkVTIGlzIHRoZSBvbmx5IHN1cHBvcnRlZAo+ICsJICogICAgICAgICAgY29uZmlndXJh dGlvbgo+ICsJICogQ2Fubm9ubGFrZTogTW9zdCBvZiBTS1VzIGRvbid0IHN1cHBvcnQgRERJX0Us IGFuZCB0aGUgb25seQo+ICsJICogICAgICAgICAgICAgb25lIHdobyBkb2VzIGFsc28gaGF2ZSBh IGZ1bGwgQS9FIHNwbGl0IGNhbGxlZAo+ICsJICogICAgICAgICAgICAgRERJX0Ygd2hhdCBtYWtl cyBERElfRSB1c2VsZXNzLiBIb3dldmVyIGZvciB0aGlzCj4gKwkgKiAgICAgICAgICAgICBjYXNl IGxldCdzIHRydXN0IFZCVCBpbmZvLgo+ICsJICovCj4gKwlyZXR1cm4gZHBvcnQtPnBvcnQgPT0g UE9SVF9BICYmCj4gKwkJIShkcG9ydC0+c2F2ZWRfcG9ydF9iaXRzICYgRERJX0FfNF9MQU5FUykg JiYKPiArCQkoSVNfR0VOOV9MUChkZXZfcHJpdikgfHwKPiArCQkgKChJU19DQU5OT05MQUtFKGRl dl9wcml2KSkgJiYKICAgICAgICAgICAgICAgICAgXiAgICAgICAgICAgICAgICAgICAgICAgXgoK VGhvc2UgZG9uJ3QgbG9vayBuZWNlc3NhcnkuCgpJdCBzdGlsbCB0b29rIG1lIGEgd2hpbGUgdG8g cGFyc2UgdGhhdCB0aGluZy4gTWF5YmUgaXQgc2hvdWxkIGJlIHNwbGl0CmV2ZW4gZnVydGhlcj8g RWcuIHNvbWV0aGluZyBsaWtlOgoKewoJaWYgKHBvcnQgIT0gUE9SVF9BKQoJCXJldHVybiBmYWxz ZTsKCWlmIChzYXZlZF9wb3J0X2JpdHMgJiA0X0xBTkVTKQoJCXJldHVybiBmYWxzZTsKCgkvKiBi bGFoICovCglpZiAoQlhUKQoJCXJldHVybiB0cnVlOwoKCS8qIG1laCAqLwoJaWYgKENOTCAmJiAh cG9ydF9lX3ByZXNlbnQpCgkJcmV0dXJuIHRydWU7CgoJcmV0dXJuIGZhbHNlOwp9CgpCdXQgeW91 ciBjb2RlIGxvb2tzIGNvcnJlY3QgYXMgd2VsbCwgYW5kIEkgY2FuIGxpdmUgd2l0aCBpdAppZiB5 b3Ugd2FudCB0byBrZWVwIGl0IGFzIGlzLiBTbywgd2l0aCB0aGUgZXh0cmEgcGFyZW5zIHJlbW92 ZWQKUmV2aWV3ZWQtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRl bC5jb20+Cgo+ICsJCSAgIWludGVsX2Jpb3NfaXNfcG9ydF9wcmVzZW50KGRldl9wcml2LCBQT1JU X0UpKSk7Cj4gK30KPiArCj4gIHZvaWQgaW50ZWxfZGRpX2luaXQoc3RydWN0IGRybV9pOTE1X3By aXZhdGUgKmRldl9wcml2LCBlbnVtIHBvcnQgcG9ydCkKPiAgewo+ICAJc3RydWN0IGludGVsX2Rp Z2l0YWxfcG9ydCAqaW50ZWxfZGlnX3BvcnQ7Cj4gQEAgLTI4MDMsMTggKzI4MjEsMTQgQEAgdm9p ZCBpbnRlbF9kZGlfaW5pdChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIGVudW0g cG9ydCBwb3J0KQo+ICAJfQo+ICAKPiAgCS8qCj4gLQkgKiBCc3BlYyBzYXlzIHRoYXQgRERJX0Ff NF9MQU5FUyBpcyB0aGUgb25seSBzdXBwb3J0ZWQgY29uZmlndXJhdGlvbgo+IC0JICogZm9yIEJy b3h0b24uICBZZXQgc29tZSBCSU9TIGZhaWwgdG8gc2V0IHRoaXMgYml0IG9uIHBvcnQgQSBpZiBl RFAKPiAtCSAqIHdhc24ndCBsaXQgdXAgYXQgYm9vdC4gIEZvcmNlIHRoaXMgYml0IG9uIGluIG91 ciBpbnRlcm5hbAo+IC0JICogY29uZmlndXJhdGlvbiBzbyB0aGF0IHdlIHVzZSB0aGUgcHJvcGVy IGxhbmUgY291bnQgZm9yIG91cgo+IC0JICogY2FsY3VsYXRpb25zLgo+ICsJICogU29tZSBCSU9T IG1pZ2h0IGZhaWwgdG8gc2V0IHRoaXMgYml0IG9uIHBvcnQgQSBpZiBlRFAKPiArCSAqIHdhc24n dCBsaXQgdXAgYXQgYm9vdC4gIEZvcmNlIHRoaXMgYml0IHNldCB3aGVuIG5lZWRlZAo+ICsJICog c28gd2UgdXNlIHRoZSBwcm9wZXIgbGFuZSBjb3VudCBmb3Igb3VyIGNhbGN1bGF0aW9ucy4KPiAg CSAqLwo+IC0JaWYgKElTX0dFTjlfTFAoZGV2X3ByaXYpICYmIHBvcnQgPT0gUE9SVF9BKSB7Cj4g LQkJaWYgKCEoaW50ZWxfZGlnX3BvcnQtPnNhdmVkX3BvcnRfYml0cyAmIERESV9BXzRfTEFORVMp KSB7Cj4gLQkJCURSTV9ERUJVR19LTVMoIkJYVCBCSU9TIGZvcmdvdCB0byBzZXQgRERJX0FfNF9M QU5FUyBmb3IgcG9ydCBBOyBmaXhpbmdcbiIpOwo+IC0JCQlpbnRlbF9kaWdfcG9ydC0+c2F2ZWRf cG9ydF9iaXRzIHw9IERESV9BXzRfTEFORVM7Cj4gLQkJCW1heF9sYW5lcyA9IDQ7Cj4gLQkJfQo+ ICsJaWYgKGludGVsX2RkaV9hX2ZvcmNlXzRfbGFuZXMoaW50ZWxfZGlnX3BvcnQpKSB7Cj4gKwkJ RFJNX0RFQlVHX0tNUygiRm9yY2luZyBERElfQV80X0xBTkVTIGZvciBwb3J0IEFcbiIpOwo+ICsJ CWludGVsX2RpZ19wb3J0LT5zYXZlZF9wb3J0X2JpdHMgfD0gRERJX0FfNF9MQU5FUzsKPiArCQlt YXhfbGFuZXMgPSA0Owo+ICAJfQo+ICAKPiAgCWludGVsX2RpZ19wb3J0LT5tYXhfbGFuZXMgPSBt YXhfbGFuZXM7Cj4gLS0gCj4gMi4xMy41CgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZngg bWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK