From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915/cnl: Force DDI_A_4_LANES when needed. Date: Tue, 24 Oct 2017 12:21:38 +0300 Message-ID: <20171024092138.GC10981@intel.com> References: <20171023172657.GA10981@intel.com> <20171023173920.22890-1-rodrigo.vivi@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 526E36E10E for ; Tue, 24 Oct 2017 09:21:51 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20171023173920.22890-1-rodrigo.vivi@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Rodrigo Vivi Cc: Jani Nikula , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBPY3QgMjMsIDIwMTcgYXQgMTA6Mzk6MjBBTSAtMDcwMCwgUm9kcmlnbyBWaXZpIHdy b3RlOgo+IEFzIHdlIGZhY2VkIGluIEJYVCwgb24gQ05MIERESV9BXzRfTEFORVMgaXMgbm90Cj4g c2V0IGFzIGV4cGVjdGVkIHdoZW4gc3lzdGVtIGlzIGJvb3Qgd2l0aCBtdWx0aXBsZQo+IG1vbml0 b3JzIGNvbm5lY3RlZC4gVGhpcyByZXN1bHQgaW4gd3JvbmcgbGFuZQo+IHNldHVwIGltcGFjdGlu ZyB0aGUgbWF4IGRhdGEgcmF0ZSBhdmFpbGFibGUgYW5kCj4gY29uc2VxdWVudGx5IGJsb2NraW5n IG1vZGVzZXQgb24gZURQLCByZXN1bHRpbmcKPiBpbiBhIGJsYW5rIHNjcmVlbi4KPiAKPiBNb3N0 IG9mIENOTCBTS1VzIGRvbid0IHN1cHBvcnQgRERJLUUuCj4gVGhlIG9ubHkgU0tVIHRoYXQgc3Vw cG9ydHMgRERJLUUgaXMgdGhlIHNhbWUKPiB0aGF0IHN1cHBvcnRzIHRoZSBmdWxsIEEvRSBzcGxp dCBjYWxsZWQgRERJLUYuCj4gCj4gQWxzbyB3aGVuIERESS1GIGlzIHVzZWQgRERJLUUgY2Fubm90 IGJlIHVzZWQgYmVjYXVzZQo+IHRoZXkgc2hhcmUgSW50ZXJydXB0cy4gU28gRERJLUUgaXMgYWxt b3N0IHVzZWxlc3MuCj4gQW55d2F5cyBsZXQncyBjb25zaWRlciB0aGlzIGlzIHBvc3NpYmxlIGFu ZCByZWx5IG9uCj4gVkJUIGZvciB0aGF0Lgo+IAo+IFRoaXMgcGF0Y2ggd2FzIGluaXRpYWx5IHN0 YXJ0IGJ5IENsaW50LCBidXQgcmVxdWlyZWQKPiBtYW55IGNoYW5nZXMgaW5jbHVkaW5nIGZ1bGwg Y29tbWl0IG1lc3NhZ2UuIFNvCj4gQ3JlZGl0cyBlbnRpcmVseSB0byBDbGludCBmb3IgZmluZGlu ZyB0aGlzLgo+IAo+IHYyOiBFeHRyYWN0IGFsbCBtZXNzeSBjb25kaXRpb25zIGludG8gYSBoZWxw ZXIgZnVuY3Rpb24KPiAgICAgYXMgc3VnZ2VzdGVkIGJ5IFZpbGxlLgo+ICAgICBBbG9uZyB3aXRo IHNpbXBsaWZpY2F0aW9uIEkgcmVtb3ZlZCB0aGUgZGVidWcKPiAgICAgbWVzc2FnZSBvbiB0aGUg d29ya2luZyBjYXNlIHNpbmNlIG5vdyBhbGwgY29uZGl0aW9ucwo+ICAgICBhcmUgZ3JvdXBlZC4K PiB2MzogU3BsaXQgdGhlIGNvbmRpdGlvbnMgZXZlbiBtb3JlIGFzIHN1Z2dlc3RlZCBieSBWaWxs ZS4KPiAgICAgR2V0J3MgY2xlYW5lciBhbmQgZWFzaWVyIHRvIGFkZCBuZXcgY2FzZXMgaW4gdGhl Cj4gICAgIGZ1dHVyZS4KPiAKPiBTdWdnZXN0ZWQtYnk6IENsaW50IFRheWxvciA8Y2xpbnRvbi5h LnRheWxvckBpbnRlbC5jb20+Cj4gQ2M6IENsaW50IFRheWxvciA8Y2xpbnRvbi5hLnRheWxvckBp bnRlbC5jb20+Cj4gQ2M6IE1pa2EgS2Fob2xhIDxtaWthLmthaG9sYUBpbnRlbC5jb20+Cj4gQ2M6 IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+Cj4gQ2M6IFZpbGxlIFN5cmrDpGzD pCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogUm9kcmln byBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29tPgoKUmV2aWV3ZWQtYnk6IFZpbGxlIFN5cmrD pGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cgo+IC0tLQo+ICBkcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kZGkuYyB8IDQ2ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysr Ky0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDM1IGluc2VydGlvbnMoKyksIDExIGRlbGV0 aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGku YyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jCj4gaW5kZXggYWRmNTFiMzI4ODQ0 Li4zOGE3MDg4YmQzOWMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZGRpLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+IEBAIC0yNjk0 LDYgKzI2OTQsMzQgQEAgaW50ZWxfZGRpX2luaXRfaGRtaV9jb25uZWN0b3Ioc3RydWN0IGludGVs X2RpZ2l0YWxfcG9ydCAqaW50ZWxfZGlnX3BvcnQpCj4gIAlyZXR1cm4gY29ubmVjdG9yOwo+ICB9 Cj4gIAo+ICtzdGF0aWMgYm9vbCBpbnRlbF9kZGlfYV9mb3JjZV80X2xhbmVzKHN0cnVjdCBpbnRl bF9kaWdpdGFsX3BvcnQgKmRwb3J0KQo+ICt7Cj4gKwlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAq ZGV2X3ByaXYgPSB0b19pOTE1KGRwb3J0LT5iYXNlLmJhc2UuZGV2KTsKPiArCj4gKwlpZiAoZHBv cnQtPnBvcnQgIT0gUE9SVF9BKQo+ICsJCXJldHVybiBmYWxzZTsKPiArCj4gKwlpZiAoZHBvcnQt PnNhdmVkX3BvcnRfYml0cyAmIERESV9BXzRfTEFORVMpCj4gKwkJcmV0dXJuIGZhbHNlOwo+ICsK PiArCS8qIEJyb3h0b24vR2VtaW5pbGFrZTogQnNwZWMgc2F5cyB0aGF0IERESV9BXzRfTEFORVMg aXMgdGhlIG9ubHkKPiArCSAqICAgICAgICAgICAgICAgICAgICAgc3VwcG9ydGVkIGNvbmZpZ3Vy YXRpb24KPiArCSAqLwo+ICsJaWYgKElTX0dFTjlfTFAoZGV2X3ByaXYpKQo+ICsJCXJldHVybiB0 cnVlOwo+ICsKPiArCS8qIENhbm5vbmxha2U6IE1vc3Qgb2YgU0tVcyBkb24ndCBzdXBwb3J0IERE SV9FLCBhbmQgdGhlIG9ubHkKPiArCSAqICAgICAgICAgICAgIG9uZSB3aG8gZG9lcyBhbHNvIGhh dmUgYSBmdWxsIEEvRSBzcGxpdCBjYWxsZWQKPiArCSAqICAgICAgICAgICAgIERESV9GIHdoYXQg bWFrZXMgRERJX0UgdXNlbGVzcy4gSG93ZXZlciBmb3IgdGhpcwo+ICsJICogICAgICAgICAgICAg Y2FzZSBsZXQncyB0cnVzdCBWQlQgaW5mby4KPiArCSAqLwo+ICsJaWYgKElTX0NBTk5PTkxBS0Uo ZGV2X3ByaXYpICYmCj4gKwkgICAgIWludGVsX2Jpb3NfaXNfcG9ydF9wcmVzZW50KGRldl9wcml2 LCBQT1JUX0UpKQo+ICsJCXJldHVybiB0cnVlOwo+ICsKPiArCXJldHVybiBmYWxzZTsKPiArfQo+ ICsKPiAgdm9pZCBpbnRlbF9kZGlfaW5pdChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3By aXYsIGVudW0gcG9ydCBwb3J0KQo+ICB7Cj4gIAlzdHJ1Y3QgaW50ZWxfZGlnaXRhbF9wb3J0ICpp bnRlbF9kaWdfcG9ydDsKPiBAQCAtMjgwMywxOCArMjgzMSwxNCBAQCB2b2lkIGludGVsX2RkaV9p bml0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwgZW51bSBwb3J0IHBvcnQpCj4g IAl9Cj4gIAo+ICAJLyoKPiAtCSAqIEJzcGVjIHNheXMgdGhhdCBERElfQV80X0xBTkVTIGlzIHRo ZSBvbmx5IHN1cHBvcnRlZCBjb25maWd1cmF0aW9uCj4gLQkgKiBmb3IgQnJveHRvbi4gIFlldCBz b21lIEJJT1MgZmFpbCB0byBzZXQgdGhpcyBiaXQgb24gcG9ydCBBIGlmIGVEUAo+IC0JICogd2Fz bid0IGxpdCB1cCBhdCBib290LiAgRm9yY2UgdGhpcyBiaXQgb24gaW4gb3VyIGludGVybmFsCj4g LQkgKiBjb25maWd1cmF0aW9uIHNvIHRoYXQgd2UgdXNlIHRoZSBwcm9wZXIgbGFuZSBjb3VudCBm b3Igb3VyCj4gLQkgKiBjYWxjdWxhdGlvbnMuCj4gKwkgKiBTb21lIEJJT1MgbWlnaHQgZmFpbCB0 byBzZXQgdGhpcyBiaXQgb24gcG9ydCBBIGlmIGVEUAo+ICsJICogd2Fzbid0IGxpdCB1cCBhdCBi b290LiAgRm9yY2UgdGhpcyBiaXQgc2V0IHdoZW4gbmVlZGVkCj4gKwkgKiBzbyB3ZSB1c2UgdGhl IHByb3BlciBsYW5lIGNvdW50IGZvciBvdXIgY2FsY3VsYXRpb25zLgo+ICAJICovCj4gLQlpZiAo SVNfR0VOOV9MUChkZXZfcHJpdikgJiYgcG9ydCA9PSBQT1JUX0EpIHsKPiAtCQlpZiAoIShpbnRl bF9kaWdfcG9ydC0+c2F2ZWRfcG9ydF9iaXRzICYgRERJX0FfNF9MQU5FUykpIHsKPiAtCQkJRFJN X0RFQlVHX0tNUygiQlhUIEJJT1MgZm9yZ290IHRvIHNldCBERElfQV80X0xBTkVTIGZvciBwb3J0 IEE7IGZpeGluZ1xuIik7Cj4gLQkJCWludGVsX2RpZ19wb3J0LT5zYXZlZF9wb3J0X2JpdHMgfD0g RERJX0FfNF9MQU5FUzsKPiAtCQkJbWF4X2xhbmVzID0gNDsKPiAtCQl9Cj4gKwlpZiAoaW50ZWxf ZGRpX2FfZm9yY2VfNF9sYW5lcyhpbnRlbF9kaWdfcG9ydCkpIHsKPiArCQlEUk1fREVCVUdfS01T KCJGb3JjaW5nIERESV9BXzRfTEFORVMgZm9yIHBvcnQgQVxuIik7Cj4gKwkJaW50ZWxfZGlnX3Bv cnQtPnNhdmVkX3BvcnRfYml0cyB8PSBERElfQV80X0xBTkVTOwo+ICsJCW1heF9sYW5lcyA9IDQ7 Cj4gIAl9Cj4gIAo+ICAJaW50ZWxfZGlnX3BvcnQtPm1heF9sYW5lcyA9IG1heF9sYW5lczsKPiAt LSAKPiAyLjEzLjUKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwgT1RDCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QK SW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=