From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [PATCH 10/10] drm/i915: Perform a central cdclk state sanity check Date: Tue, 24 Oct 2017 14:51:32 -0700 Message-ID: <20171024215132.u5skrhixe4dfnfnt@intel.com> References: <20171024095216.1638-1-ville.syrjala@linux.intel.com> <20171024095216.1638-11-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id A0BFF6E5D3 for ; Tue, 24 Oct 2017 21:51:33 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20171024095216.1638-11-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville Syrjala Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBPY3QgMjQsIDIwMTcgYXQgMDk6NTI6MTZBTSArMDAwMCwgVmlsbGUgU3lyamFsYSB3 cm90ZToKPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwu Y29tPgo+IAo+IFdBUk4gaWYgdGhlIGNkY2xrIHN0YXRlIGRvZXNuJ3QgbWF0Y2ggd2hhdCB3ZSBl eHBlY3QgYWZ0ZXIgcHJvZ3JhbW1pbmcuCj4gQW5kIGxldCdzIHJlbW92ZSB0aGUgV0FSTiBmcm9t IGJkd19zZXRfY2RjbGsoKSB0aGF0J3MgdHJ5aW5nIHRvIGFjaGlldmUKPiB0aGUgc2FtZSB0aGlu ZyBpbiBhIG1vcmUgbGltaXRlIGZhc2hpb24uCj4gCj4gQWxzbyB0YWtlIHRoZSBvcHBvcnR1bml0 eSB0byByZWZhY3RvciB0aGUgY29kZSB0byB1c2UgYSBjb21tb24gZnVuY3Rpb24KPiBmb3IgZHVt cGluZyBvdXQgYSBjZGNsayBzdGF0ZS4KPiAKPiBDYzogTWlrYSBLYWhvbGEgPG1pa2Eua2Fob2xh QGludGVsLmNvbT4KPiBDYzogTWFuYXNpIE5hdmFyZSA8bWFuYXNpLmQubmF2YXJlQGludGVsLmNv bT4KPiBDYzogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29tPgo+IFNpZ25lZC1v ZmYtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cgpi ZXR0ZXIgY29kZSwgYmV0dGVyIGxvZ3MgYW5kIHJpZ2h0IGNoZWNrcy4KClJldmlld2VkLWJ5OiBS b2RyaWdvIFZpdmkgPHJvZHJpZ28udml2aUBpbnRlbC5jb20+Cgo+IC0tLQo+ICBkcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9jZGNsay5jICAgfCAzMCArKysrKysrKysrKysrKysrKysrLS0tLS0t LS0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIHwgIDMgKysrCj4g IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oICAgICB8ICAyICsrCj4gIDMgZmlsZXMg Y2hhbmdlZCwgMjQgaW5zZXJ0aW9ucygrKSwgMTEgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2NkY2xrLmMgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9jZGNsay5jCj4gaW5kZXggZmVkZmUzYzcyMGI2Li41MWNkMjNkZDg2NzYgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY2RjbGsuYwo+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2NkY2xrLmMKPiBAQCAtNzY4LDEwICs3NjgsNiBAQCBz dGF0aWMgdm9pZCBiZHdfc2V0X2NkY2xrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp diwKPiAgCUk5MTVfV1JJVEUoQ0RDTEtfRlJFUSwgRElWX1JPVU5EX0NMT1NFU1QoY2RjbGssIDEw MDApIC0gMSk7Cj4gIAo+ICAJaW50ZWxfdXBkYXRlX2NkY2xrKGRldl9wcml2KTsKPiAtCj4gLQlX QVJOKGNkY2xrICE9IGRldl9wcml2LT5jZGNsay5ody5jZGNsaywKPiAtCSAgICAgImNkY2xrIHJl cXVlc3RlZCAlZCBrSHogYnV0IGdvdCAlZCBrSHpcbiIsCj4gLQkgICAgIGNkY2xrLCBkZXZfcHJp di0+Y2RjbGsuaHcuY2RjbGspOwo+ICB9Cj4gIAo+ICBzdGF0aWMgaW50IHNrbF9jYWxjX2NkY2xr KGludCBtaW5fY2RjbGssIGludCB2Y28pCj4gQEAgLTEwNjgsNiArMTA2NCw4IEBAIHN0YXRpYyB2 b2lkIHNrbF9zYW5pdGl6ZV9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYp Cj4gIAkJZ290byBzYW5pdGl6ZTsKPiAgCj4gIAlpbnRlbF91cGRhdGVfY2RjbGsoZGV2X3ByaXYp Owo+ICsJaW50ZWxfZHVtcF9jZGNsa19zdGF0ZSgmZGV2X3ByaXYtPmNkY2xrLmh3LCAiQ3VycmVu dCBDRENMSyIpOwo+ICsKPiAgCS8qIElzIFBMTCBlbmFibGVkIGFuZCBsb2NrZWQgPyAqLwo+ICAJ aWYgKGRldl9wcml2LT5jZGNsay5ody52Y28gPT0gMCB8fAo+ICAJICAgIGRldl9wcml2LT5jZGNs ay5ody5jZGNsayA9PSBkZXZfcHJpdi0+Y2RjbGsuaHcucmVmKQo+IEBAIC0xNDA3LDYgKzE0MDUs NyBAQCBzdGF0aWMgdm9pZCBieHRfc2FuaXRpemVfY2RjbGsoc3RydWN0IGRybV9pOTE1X3ByaXZh dGUgKmRldl9wcml2KQo+ICAJdTMyIGNkY3RsLCBleHBlY3RlZDsKPiAgCj4gIAlpbnRlbF91cGRh dGVfY2RjbGsoZGV2X3ByaXYpOwo+ICsJaW50ZWxfZHVtcF9jZGNsa19zdGF0ZSgmZGV2X3ByaXYt PmNkY2xrLmh3LCAiQ3VycmVudCBDRENMSyIpOwo+ICAKPiAgCWlmIChkZXZfcHJpdi0+Y2RjbGsu aHcudmNvID09IDAgfHwKPiAgCSAgICBkZXZfcHJpdi0+Y2RjbGsuaHcuY2RjbGsgPT0gZGV2X3By aXYtPmNkY2xrLmh3LnJlZikKPiBAQCAtMTcxMyw2ICsxNzEyLDcgQEAgc3RhdGljIHZvaWQgY25s X3Nhbml0aXplX2NkY2xrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgCXUz MiBjZGN0bCwgZXhwZWN0ZWQ7Cj4gIAo+ICAJaW50ZWxfdXBkYXRlX2NkY2xrKGRldl9wcml2KTsK PiArCWludGVsX2R1bXBfY2RjbGtfc3RhdGUoJmRldl9wcml2LT5jZGNsay5odywgIkN1cnJlbnQg Q0RDTEsiKTsKPiAgCj4gIAlpZiAoZGV2X3ByaXYtPmNkY2xrLmh3LnZjbyA9PSAwIHx8Cj4gIAkg ICAgZGV2X3ByaXYtPmNkY2xrLmh3LmNkY2xrID09IGRldl9wcml2LT5jZGNsay5ody5yZWYpCj4g QEAgLTE4MjYsNiArMTgyNiwxNCBAQCBib29sIGludGVsX2NkY2xrX2NoYW5nZWQoY29uc3Qgc3Ry dWN0IGludGVsX2NkY2xrX3N0YXRlICphLAo+ICAJCWEtPnZvbHRhZ2VfbGV2ZWwgIT0gYi0+dm9s dGFnZV9sZXZlbDsKPiAgfQo+ICAKPiArdm9pZCBpbnRlbF9kdW1wX2NkY2xrX3N0YXRlKGNvbnN0 IHN0cnVjdCBpbnRlbF9jZGNsa19zdGF0ZSAqY2RjbGtfc3RhdGUsCj4gKwkJCSAgICBjb25zdCBj aGFyICpjb250ZXh0KQo+ICt7Cj4gKwlEUk1fREVCVUdfRFJJVkVSKCIlcyAlZCBrSHosIFZDTyAl ZCBrSHosIHJlZiAlZCBrSHosIHZvbHRhZ2UgbGV2ZWwgJWRcbiIsCj4gKwkJCSBjb250ZXh0LCBj ZGNsa19zdGF0ZS0+Y2RjbGssIGNkY2xrX3N0YXRlLT52Y28sCj4gKwkJCSBjZGNsa19zdGF0ZS0+ cmVmLCBjZGNsa19zdGF0ZS0+dm9sdGFnZV9sZXZlbCk7Cj4gK30KPiArCj4gIC8qKgo+ICAgKiBp bnRlbF9zZXRfY2RjbGsgLSBQdXNoIHRoZSBDRENMSyBzdGF0ZSB0byB0aGUgaGFyZHdhcmUKPiAg ICogQGRldl9wcml2OiBpOTE1IGRldmljZQo+IEBAIC0xODQzLDExICsxODUxLDE1IEBAIHZvaWQg aW50ZWxfc2V0X2NkY2xrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCWlm IChXQVJOX09OX09OQ0UoIWRldl9wcml2LT5kaXNwbGF5LnNldF9jZGNsaykpCj4gIAkJcmV0dXJu Owo+ICAKPiAtCURSTV9ERUJVR19EUklWRVIoIkNoYW5naW5nIENEQ0xLIHRvICVkIGtIeiwgVkNP ICVkIGtIeiwgcmVmICVkIGtIeiwgdm9sdGFnZV9sZXZlbCAlZFxuIiwKPiAtCQkJIGNkY2xrX3N0 YXRlLT5jZGNsaywgY2RjbGtfc3RhdGUtPnZjbywKPiAtCQkJIGNkY2xrX3N0YXRlLT5yZWYsIGNk Y2xrX3N0YXRlLT52b2x0YWdlX2xldmVsKTsKPiArCWludGVsX2R1bXBfY2RjbGtfc3RhdGUoY2Rj bGtfc3RhdGUsICJDaGFuZ2luZyBDRENMSyB0byIpOwo+ICAKPiAgCWRldl9wcml2LT5kaXNwbGF5 LnNldF9jZGNsayhkZXZfcHJpdiwgY2RjbGtfc3RhdGUpOwo+ICsKPiArCWlmIChXQVJOKGludGVs X2NkY2xrX2NoYW5nZWQoJmRldl9wcml2LT5jZGNsay5odywgY2RjbGtfc3RhdGUpLAo+ICsJCSAi Y2RjbGsgc3RhdGUgZG9lc24ndCBtYXRjaCFcbiIpKSB7Cj4gKwkJaW50ZWxfZHVtcF9jZGNsa19z dGF0ZSgmZGV2X3ByaXYtPmNkY2xrLmh3LCAiW2h3IHN0YXRlXSIpOwo+ICsJCWludGVsX2R1bXBf Y2RjbGtfc3RhdGUoY2RjbGtfc3RhdGUsICJbc3cgc3RhdGVdIik7Cj4gKwl9Cj4gIH0KPiAgCj4g IHN0YXRpYyBpbnQgaW50ZWxfcGl4ZWxfcmF0ZV90b19jZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJp dmF0ZSAqZGV2X3ByaXYsCj4gQEAgLTIyODAsMTAgKzIyOTIsNiBAQCB2b2lkIGludGVsX3VwZGF0 ZV9jZGNsayhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gIHsKPiAgCWRldl9w cml2LT5kaXNwbGF5LmdldF9jZGNsayhkZXZfcHJpdiwgJmRldl9wcml2LT5jZGNsay5odyk7Cj4g IAo+IC0JRFJNX0RFQlVHX0RSSVZFUigiQ3VycmVudCBDRCBjbG9jayByYXRlOiAlZCBrSHosIFZD TzogJWQga0h6LCByZWY6ICVkIGtIelxuIiwKPiAtCQkJIGRldl9wcml2LT5jZGNsay5ody5jZGNs aywgZGV2X3ByaXYtPmNkY2xrLmh3LnZjbywKPiAtCQkJIGRldl9wcml2LT5jZGNsay5ody5yZWYp Owo+IC0KPiAgCS8qCj4gIAkgKiA5OjAgQ01CVVMgW3NpY10gQ0RDTEsgZnJlcXVlbmN5IChjZGZy ZXEpOgo+ICAJICogUHJvZ3JhbW1uZyBbc2ljXSBub3RlOiBiaXRbOToyXSBzaG91bGQgYmUgcHJv Z3JhbW1lZCB0byB0aGUgbnVtYmVyCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ IGluZGV4IGI1ZmE2NDNlMTgxMi4uN2Q3OTUyYjc4YTNiIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2Rpc3BsYXkuYwo+IEBAIC04ODU3LDcgKzg4NTcsOSBAQCBzdGF0aWMgdm9pZCBoc3df cmVzdG9yZV9sY3BsbChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gIAl9Cj4g IAo+ICAJaW50ZWxfdW5jb3JlX2ZvcmNld2FrZV9wdXQoZGV2X3ByaXYsIEZPUkNFV0FLRV9BTEwp Owo+ICsKPiAgCWludGVsX3VwZGF0ZV9jZGNsayhkZXZfcHJpdik7Cj4gKwlpbnRlbF9kdW1wX2Nk Y2xrX3N0YXRlKCZkZXZfcHJpdi0+Y2RjbGsuaHcsICJDdXJyZW50IENEQ0xLIik7Cj4gIH0KPiAg Cj4gIC8qCj4gQEAgLTE0MzU4LDYgKzE0MzYwLDcgQEAgdm9pZCBpbnRlbF9tb2Rlc2V0X2luaXRf aHcoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk ZXZfcHJpdiA9IHRvX2k5MTUoZGV2KTsKPiAgCj4gIAlpbnRlbF91cGRhdGVfY2RjbGsoZGV2X3By aXYpOwo+ICsJaW50ZWxfZHVtcF9jZGNsa19zdGF0ZSgmZGV2X3ByaXYtPmNkY2xrLmh3LCAiQ3Vy cmVudCBDRENMSyIpOwo+ICAJZGV2X3ByaXYtPmNkY2xrLmxvZ2ljYWwgPSBkZXZfcHJpdi0+Y2Rj bGsuYWN0dWFsID0gZGV2X3ByaXYtPmNkY2xrLmh3Owo+ICAKPiAgCWludGVsX2luaXRfY2xvY2tf Z2F0aW5nKGRldl9wcml2KTsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+IGluZGV4IDNkZThk OThiYWVkNy4uM2I0ZWFmZDM5ZjU1IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2Rydi5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiBA QCAtMTMzNiw2ICsxMzM2LDggQEAgYm9vbCBpbnRlbF9jZGNsa19jaGFuZ2VkKGNvbnN0IHN0cnVj dCBpbnRlbF9jZGNsa19zdGF0ZSAqYSwKPiAgCQkJIGNvbnN0IHN0cnVjdCBpbnRlbF9jZGNsa19z dGF0ZSAqYik7Cj4gIHZvaWQgaW50ZWxfc2V0X2NkY2xrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICpkZXZfcHJpdiwKPiAgCQkgICAgIGNvbnN0IHN0cnVjdCBpbnRlbF9jZGNsa19zdGF0ZSAqY2Rj bGtfc3RhdGUpOwo+ICt2b2lkIGludGVsX2R1bXBfY2RjbGtfc3RhdGUoY29uc3Qgc3RydWN0IGlu dGVsX2NkY2xrX3N0YXRlICpjZGNsa19zdGF0ZSwKPiArCQkJICAgIGNvbnN0IGNoYXIgKmNvbnRl eHQpOwo+ICAKPiAgLyogaW50ZWxfZGlzcGxheS5jICovCj4gIHZvaWQgaTgzMF9lbmFibGVfcGlw ZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsIGVudW0gcGlwZSBwaXBlKTsKPiAt LSAKPiAyLjEzLjYKPiAKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwt Z2Z4Cg==