From: Manasi Navare <manasi.d.navare@intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915/edp: clean up code and comments around eDP DPCD read
Date: Thu, 26 Oct 2017 12:34:53 -0700 [thread overview]
Message-ID: <20171026193453.GC19276@intel.com> (raw)
In-Reply-To: <20171026142932.17737-2-jani.nikula@intel.com>
On Thu, Oct 26, 2017 at 05:29:32PM +0300, Jani Nikula wrote:
> Some minor drive-by cleanups.
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>
> ---
> drivers/gpu/drm/i915/intel_dp.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index 158438bb0389..73b1ed8cff6b 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -3747,11 +3747,11 @@ intel_edp_init_dpcd(struct intel_dp *intel_dp)
> if (drm_dp_dpcd_read(&intel_dp->aux, DP_EDP_DPCD_REV,
> intel_dp->edp_dpcd, sizeof(intel_dp->edp_dpcd)) ==
> sizeof(intel_dp->edp_dpcd))
> - DRM_DEBUG_KMS("EDP DPCD : %*ph\n", (int) sizeof(intel_dp->edp_dpcd),
> + DRM_DEBUG_KMS("eDP DPCD: %*ph\n", (int) sizeof(intel_dp->edp_dpcd),
> intel_dp->edp_dpcd);
>
> - /* Intermediate frequency support */
> - if (intel_dp->edp_dpcd[0] >= 0x03) { /* eDp v1.4 or higher */
> + /* Read the eDP 1.4+ supported link rates. */
> + if (intel_dp->edp_dpcd[0] >= DP_EDP_14) {
> __le16 sink_rates[DP_MAX_SUPPORTED_RATES];
> int i;
>
> @@ -3775,6 +3775,10 @@ intel_edp_init_dpcd(struct intel_dp *intel_dp)
> intel_dp->num_sink_rates = i;
> }
>
> + /*
> + * Use DP_LINK_RATE_SET if DP_SUPPORTED_LINK_RATES are available,
> + * default to DP_MAX_LINK_RATE and DP_LINK_BW_SET otherwise.
> + */
> if (intel_dp->num_sink_rates)
> intel_dp->use_rate_select = true;
> else
> --
> 2.11.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-10-26 19:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 14:29 [PATCH 1/2] drm/i915/edp: read edp display control registers unconditionally Jani Nikula
2017-10-26 14:29 ` [PATCH 2/2] drm/i915/edp: clean up code and comments around eDP DPCD read Jani Nikula
2017-10-26 19:34 ` Manasi Navare [this message]
2017-10-26 14:55 ` [PATCH 1/2] drm/i915/edp: read edp display control registers unconditionally Ville Syrjälä
2017-10-26 15:02 ` ✓ Fi.CI.BAT: success for series starting with [1/2] " Patchwork
2017-10-26 19:40 ` [PATCH 1/2] " Manasi Navare
2017-10-30 9:55 ` Jani Nikula
2017-10-27 11:02 ` ✓ Fi.CI.BAT: success for series starting with [1/2] " Patchwork
2017-10-27 11:14 ` ✗ Fi.CI.BAT: failure " Patchwork
2017-10-30 15:31 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171026193453.GC19276@intel.com \
--to=manasi.d.navare@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox