From mboxrd@z Thu Jan 1 00:00:00 1970 From: Manasi Navare Subject: Re: [PATCH 2/2] drm/i915/edp: clean up code and comments around eDP DPCD read Date: Thu, 26 Oct 2017 12:34:53 -0700 Message-ID: <20171026193453.GC19276@intel.com> References: <20171026142932.17737-1-jani.nikula@intel.com> <20171026142932.17737-2-jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 06AB36E83B for ; Thu, 26 Oct 2017 19:30:04 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20171026142932.17737-2-jani.nikula@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBPY3QgMjYsIDIwMTcgYXQgMDU6Mjk6MzJQTSArMDMwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gU29tZSBtaW5vciBkcml2ZS1ieSBjbGVhbnVwcy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBK YW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgogUmV2aWV3ZWQtYnk6IE1hbmFzaSBO YXZhcmUgPG1hbmFzaS5kLm5hdmFyZUBpbnRlbC5jb20+Cgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9kcC5jIHwgMTAgKysrKysrKy0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNyBp bnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kcC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+ IGluZGV4IDE1ODQzOGJiMDM4OS4uNzNiMWVkOGNmZjZiIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9kcC5jCj4gQEAgLTM3NDcsMTEgKzM3NDcsMTEgQEAgaW50ZWxfZWRwX2luaXRfZHBjZChzdHJ1 Y3QgaW50ZWxfZHAgKmludGVsX2RwKQo+ICAJaWYgKGRybV9kcF9kcGNkX3JlYWQoJmludGVsX2Rw LT5hdXgsIERQX0VEUF9EUENEX1JFViwKPiAgCQkJICAgICBpbnRlbF9kcC0+ZWRwX2RwY2QsIHNp emVvZihpbnRlbF9kcC0+ZWRwX2RwY2QpKSA9PQo+ICAJCQkgICAgIHNpemVvZihpbnRlbF9kcC0+ ZWRwX2RwY2QpKQo+IC0JCURSTV9ERUJVR19LTVMoIkVEUCBEUENEIDogJSpwaFxuIiwgKGludCkg c2l6ZW9mKGludGVsX2RwLT5lZHBfZHBjZCksCj4gKwkJRFJNX0RFQlVHX0tNUygiZURQIERQQ0Q6 ICUqcGhcbiIsIChpbnQpIHNpemVvZihpbnRlbF9kcC0+ZWRwX2RwY2QpLAo+ICAJCQkgICAgICBp bnRlbF9kcC0+ZWRwX2RwY2QpOwo+ICAKPiAtCS8qIEludGVybWVkaWF0ZSBmcmVxdWVuY3kgc3Vw cG9ydCAqLwo+IC0JaWYgKGludGVsX2RwLT5lZHBfZHBjZFswXSA+PSAweDAzKSB7IC8qIGVEcCB2 MS40IG9yIGhpZ2hlciAqLwo+ICsJLyogUmVhZCB0aGUgZURQIDEuNCsgc3VwcG9ydGVkIGxpbmsg cmF0ZXMuICovCj4gKwlpZiAoaW50ZWxfZHAtPmVkcF9kcGNkWzBdID49IERQX0VEUF8xNCkgewo+ ICAJCV9fbGUxNiBzaW5rX3JhdGVzW0RQX01BWF9TVVBQT1JURURfUkFURVNdOwo+ICAJCWludCBp Owo+ICAKPiBAQCAtMzc3NSw2ICszNzc1LDEwIEBAIGludGVsX2VkcF9pbml0X2RwY2Qoc3RydWN0 IGludGVsX2RwICppbnRlbF9kcCkKPiAgCQlpbnRlbF9kcC0+bnVtX3NpbmtfcmF0ZXMgPSBpOwo+ ICAJfQo+ICAKPiArCS8qCj4gKwkgKiBVc2UgRFBfTElOS19SQVRFX1NFVCBpZiBEUF9TVVBQT1JU RURfTElOS19SQVRFUyBhcmUgYXZhaWxhYmxlLAo+ICsJICogZGVmYXVsdCB0byBEUF9NQVhfTElO S19SQVRFIGFuZCBEUF9MSU5LX0JXX1NFVCBvdGhlcndpc2UuCj4gKwkgKi8KPiAgCWlmIChpbnRl bF9kcC0+bnVtX3NpbmtfcmF0ZXMpCj4gIAkJaW50ZWxfZHAtPnVzZV9yYXRlX3NlbGVjdCA9IHRy dWU7Cj4gIAllbHNlCj4gLS0gCj4gMi4xMS4wCj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwt Z2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2ludGVsLWdmeAo=