Re: [PATCH 08/10] drm/i915: Pass a crtc state to ddi post_disable from MST code

Maarten Lankhorst
2017-10-27T11:39:02Z

Op 19-10-17 om 15:37 schreef Ville Syrjala:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Pass an old crtc state to intel_ddi_post_disable() from the MST code.
>
> Note that this crtc state won't necessaitly match the one that was
> passed to intel_ddi_pre_enable() if the first stream to be enabled isn't
> the last stream to be disabled. But this is fine since the states should
> be identical in every important way. This does mean people frobbing
> the DDI pre_enable/post_disable hooks have to pay attention in what
> parts of the state they consult.
>
> The alternative would be to inline the relevant code into the MST code.
> That is actually what we used to do for pre_enable before
> commit e081c8463ac9 ("drm/i915: Remove duplicate DDI enabling logic
> from MST path"). For post_disable we've always called the DDI hook.

I woudl rather have it NULL throughout the entire disable sequence, it's going to be
dangerous anyway, and something dangerous shouldn't be easy. The fact that you have
to think

Also there's an unrelated hunk in intel_ddi_pre_enable?