Re: [PATCH 10/10] drm/i915: Use intel_crtc_has_dp_encoder() for LPE audio

Ville Syrjälä
2017-10-27T11:53:08Z

On Fri, Oct 27, 2017 at 01:43:54PM +0200, Maarten Lankhorst wrote:
> Op 19-10-17 om 15:37 schreef Ville Syrjala:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Reduce our general reliance on encoder->type and instead use
> > output_types from the crtc state when enabling LPE audio.
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_audio.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
> > index 0ddba16fde1b..1e59efbfe8a3 100644
> > --- a/drivers/gpu/drm/i915/intel_audio.c
> > +++ b/drivers/gpu/drm/i915/intel_audio.c
> > @@ -629,7 +629,7 @@ void intel_audio_codec_enable(struct intel_encoder *intel_encoder,
> >
> > intel_lpe_audio_notify(dev_priv, pipe, port, connector->eld,
> > crtc_state->port_clock,
> > - intel_encoder->type == INTEL_OUTPUT_DP);
> > + intel_crtc_has_dp_encoder(crtc_state));
> > }
> >
> > /**
>
> Should this patch be moved to before 05/10?

Actually I'd just drop this for now. Jani pointed out that there are a
few other cases in the audio code as well. And after I had a look at it
I came up with a more thorough patch that plumbs the crtc/connector
states all the way down in the audio code. I'll post that as part of yet
another cleanup series.

--
Ville Syrjälä
Intel OTC