Re: [PATCH 10/10] drm/i915: Use intel_crtc_has_dp_encoder() for LPE audio

Maarten Lankhorst
2017-10-27T11:43:59Z

Op 19-10-17 om 15:37 schreef Ville Syrjala:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Reduce our general reliance on encoder->type and instead use
> output_types from the crtc state when enabling LPE audio.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_audio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
> index 0ddba16fde1b..1e59efbfe8a3 100644
> --- a/drivers/gpu/drm/i915/intel_audio.c
> +++ b/drivers/gpu/drm/i915/intel_audio.c
> @@ -629,7 +629,7 @@ void intel_audio_codec_enable(struct intel_encoder *intel_encoder,
>
> intel_lpe_audio_notify(dev_priv, pipe, port, connector->eld,
> crtc_state->port_clock,
> - intel_encoder->type == INTEL_OUTPUT_DP);
> + intel_crtc_has_dp_encoder(crtc_state));
> }
>
> /**

Should this patch be moved to before 05/10?

Looks sane otherwise.

~Maarten