public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH 1/3] drm/i915: Reject unknown syncobj flags
@ 2017-10-27 13:40 Tvrtko Ursulin
  2017-10-27 13:40 ` [PATCH 2/3] drm/i915: Fortify ptr_pack_bits against mistakes Tvrtko Ursulin
                   ` (5 more replies)
  0 siblings, 6 replies; 9+ messages in thread
From: Tvrtko Ursulin @ 2017-10-27 13:40 UTC (permalink / raw)
  To: Intel-gfx; +Cc: David Airlie, intel-gfx, dri-devel, Rodrigo Vivi

From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

We have to reject unknown flags for uAPI considerations, and also
because the curent implementation limits their i915 storage space
to two bits.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Fixes: cf6e7bac6357 ("drm/i915: Add support for drm syncobjs")
Cc: Jason Ekstrand <jason@jlekstrand.net>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: David Airlie <airlied@linux.ie>
Cc: intel-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
---
 drivers/gpu/drm/i915/i915_gem_execbuffer.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/gpu/drm/i915/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
index 3d7190764f10..3bc723ed6e2f 100644
--- a/drivers/gpu/drm/i915/i915_gem_execbuffer.c
+++ b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
@@ -2100,6 +2100,11 @@ get_fence_array(struct drm_i915_gem_execbuffer2 *args,
 			goto err;
 		}
 
+		if (fence.flags & ~((typeof(fence.flags))2)) {
+			err = -EINVAL;
+			goto err;
+		}
+
 		syncobj = drm_syncobj_find(file, fence.handle);
 		if (!syncobj) {
 			DRM_DEBUG("Invalid syncobj handle provided\n");
-- 
2.9.5

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2017-10-30  9:14 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-27 13:40 [PATCH 1/3] drm/i915: Reject unknown syncobj flags Tvrtko Ursulin
2017-10-27 13:40 ` [PATCH 2/3] drm/i915: Fortify ptr_pack_bits against mistakes Tvrtko Ursulin
2017-10-27 13:40 ` [PATCH 3/3] drm/i915: Warn in debug builds of incorrect usages of ptr_pack_bits Tvrtko Ursulin
2017-10-27 13:44   ` Chris Wilson
2017-10-27 13:48 ` [PATCH 1/3] drm/i915: Reject unknown syncobj flags Chris Wilson
2017-10-27 14:12   ` [PATCH v2 " Tvrtko Ursulin
2017-10-27 14:01 ` ✗ Fi.CI.BAT: failure for series starting with [1/3] " Patchwork
2017-10-27 14:57 ` ✗ Fi.CI.BAT: failure for series starting with [v2,1/3] drm/i915: Reject unknown syncobj flags (rev2) Patchwork
2017-10-30  9:14 ` ✓ Fi.CI.BAT: success " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox