From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 1/2] drm/i915/fbc: intel_fbc.crtc and
 intel_fbc.enabled are synonymous
Date: Fri, 27 Oct 2017 22:56:44 +0300
Message-ID: <20171027195644.GM10981@intel.com>
References: <20171027194240.11494-1-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 7FA836E244
 for <intel-gfx@lists.freedesktop.org>; Fri, 27 Oct 2017 19:56:48 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20171027194240.11494-1-chris@chris-wilson.co.uk>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, intel-gfx@lists.freedesktop.org, Rodrigo Vivi <rodrigo.vivi@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

T24gRnJpLCBPY3QgMjcsIDIwMTcgYXQgMDg6NDI6MzlQTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy
b3RlOgo+IFNsaWdodGx5IHJlZHVjZSB0aGUgY2hhbmNlIGZvciBjb25mdXNpb24gYnkgb25seSBo
YXZpbmcgb25lIHZhcmlhYmxlCj4gaW5zdGVhZCBvZiB0d28gdG8gdGVsbCB1cyB3aGVuIGludGVs
X2ZiYyBpcyBlbmFibGVkIG9uIGEgY3J0Yy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxz
b24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzogUm9kcmlnbyBWaXZpIDxyb2RyaWdv
LnZpdmlAaW50ZWwuY29tPgo+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xs
LmNoPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oICB8ICAxIC0KPiAg
ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZmJjLmMgfCAzMyArKysrKysrKysrKysrLS0tLS0t
LS0tLS0tLS0tLS0tLS0KPiAgMiBmaWxlcyBjaGFuZ2VkLCAxMyBpbnNlcnRpb25zKCspLCAyMSBk
ZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9k
cnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiBpbmRleCA2MWMxNTVjYmY5
ZDcuLmMwZjhhMTNlYzk1NyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1
X2Rydi5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+IEBAIC0xMDgz
LDcgKzEwODMsNiBAQCBzdHJ1Y3QgaW50ZWxfZmJjIHsKPiAgCj4gIAlib29sIGZhbHNlX2NvbG9y
Owo+ICAKPiAtCWJvb2wgZW5hYmxlZDsKPiAgCWJvb2wgYWN0aXZlOwo+ICAKPiAgCWJvb2wgdW5k
ZXJydW5fZGV0ZWN0ZWQ7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs
X2ZiYy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZmJjLmMKPiBpbmRleCAxYTBmNWUw
YzhkMTAuLmY0YzNhM2I5YThlNiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p
bnRlbF9mYmMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2ZiYy5jCj4gQEAg
LTQ3Miw3ICs0NzIsNyBAQCBzdGF0aWMgdm9pZCBpbnRlbF9mYmNfc2NoZWR1bGVfYWN0aXZhdGlv
bihzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YykKPiAgCXN0cnVjdCBpbnRlbF9mYmNfd29yayAqd29y
ayA9ICZmYmMtPndvcms7Cj4gIAo+ICAJV0FSTl9PTighbXV0ZXhfaXNfbG9ja2VkKCZmYmMtPmxv
Y2spKTsKPiAtCWlmIChXQVJOX09OKCFmYmMtPmVuYWJsZWQpKQo+ICsJaWYgKFdBUk5fT04oZmJj
LT5jcnRjICE9IGNydGMpKQo+ICAJCXJldHVybjsKCkkgd2FzIGEgYml0IHdvcnJpZWQgdGhhdCB0
aGlzIG1pZ2h0IHRyaXAgbmVlZGxlc3NseSwgYnV0IGxvb2tzIGxpa2UKX19pbnRlbF9mYmNfcG9z
dF91cGRhdGUoKSBzaG91bGQga2VlcCB0aGF0IGZyb20gaGFwcGVuaW5nLgoKPiAgCj4gIAlpZiAo
ZHJtX2NydGNfdmJsYW5rX2dldCgmY3J0Yy0+YmFzZSkpIHsKPiBAQCAtOTI3LDcgKzkyNyw3IEBA
IHZvaWQgaW50ZWxfZmJjX3ByZV91cGRhdGUoc3RydWN0IGludGVsX2NydGMgKmNydGMsCj4gIAkJ
Z290byBkZWFjdGl2YXRlOwo+ICAJfQo+ICAKPiAtCWlmICghZmJjLT5lbmFibGVkIHx8IGZiYy0+
Y3J0YyAhPSBjcnRjKQo+ICsJaWYgKGZiYy0+Y3J0YyAhPSBjcnRjKQo+ICAJCWdvdG8gdW5sb2Nr
Owo+ICAKPiAgCWludGVsX2ZiY191cGRhdGVfc3RhdGVfY2FjaGUoY3J0YywgY3J0Y19zdGF0ZSwg
cGxhbmVfc3RhdGUpOwo+IEBAIC05NDYsNyArOTQ2LDcgQEAgc3RhdGljIHZvaWQgX19pbnRlbF9m
YmNfcG9zdF91cGRhdGUoc3RydWN0IGludGVsX2NydGMgKmNydGMpCj4gIAo+ICAJV0FSTl9PTigh
bXV0ZXhfaXNfbG9ja2VkKCZmYmMtPmxvY2spKTsKPiAgCj4gLQlpZiAoIWZiYy0+ZW5hYmxlZCB8
fCBmYmMtPmNydGMgIT0gY3J0YykKPiArCWlmIChmYmMtPmNydGMgIT0gY3J0YykKPiAgCQlyZXR1
cm47Cj4gIAo+ICAJaWYgKCFpbnRlbF9mYmNfY2FuX2FjdGl2YXRlKGNydGMpKSB7Cj4gQEAgLTk4
Niw3ICs5ODYsNyBAQCB2b2lkIGludGVsX2ZiY19wb3N0X3VwZGF0ZShzdHJ1Y3QgaW50ZWxfY3J0
YyAqY3J0YykKPiAgCj4gIHN0YXRpYyB1bnNpZ25lZCBpbnQgaW50ZWxfZmJjX2dldF9mcm9udGJ1
ZmZlcl9iaXQoc3RydWN0IGludGVsX2ZiYyAqZmJjKQo+ICB7Cj4gLQlpZiAoZmJjLT5lbmFibGVk
KQo+ICsJaWYgKGZiYy0+Y3J0YykKPiAgCQlyZXR1cm4gdG9faW50ZWxfcGxhbmUoZmJjLT5jcnRj
LT5iYXNlLnByaW1hcnkpLT5mcm9udGJ1ZmZlcl9iaXQ7Cj4gIAllbHNlCj4gIAkJcmV0dXJuIGZi
Yy0+cG9zc2libGVfZnJhbWVidWZmZXJfYml0czsKPiBAQCAtMTAwOCw3ICsxMDA4LDcgQEAgdm9p
ZCBpbnRlbF9mYmNfaW52YWxpZGF0ZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYs
Cj4gIAo+ICAJZmJjLT5idXN5X2JpdHMgfD0gaW50ZWxfZmJjX2dldF9mcm9udGJ1ZmZlcl9iaXQo
ZmJjKSAmIGZyb250YnVmZmVyX2JpdHM7Cj4gIAo+IC0JaWYgKGZiYy0+ZW5hYmxlZCAmJiBmYmMt
PmJ1c3lfYml0cykKPiArCWlmIChmYmMtPmNydGMgJiYgZmJjLT5idXN5X2JpdHMpCj4gIAkJaW50
ZWxfZmJjX2RlYWN0aXZhdGUoZGV2X3ByaXYpOwo+ICAKPiAgCW11dGV4X3VubG9jaygmZmJjLT5s
b2NrKTsKPiBAQCAtMTAyOSw3ICsxMDI5LDcgQEAgdm9pZCBpbnRlbF9mYmNfZmx1c2goc3RydWN0
IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAJaWYgKG9yaWdpbiA9PSBPUklHSU5fR1RU
IHx8IG9yaWdpbiA9PSBPUklHSU5fRkxJUCkKPiAgCQlnb3RvIG91dDsKPiAgCj4gLQlpZiAoIWZi
Yy0+YnVzeV9iaXRzICYmIGZiYy0+ZW5hYmxlZCAmJgo+ICsJaWYgKCFmYmMtPmJ1c3lfYml0cyAm
JiBmYmMtPmNydGMgJiYKPiAgCSAgICAoZnJvbnRidWZmZXJfYml0cyAmIGludGVsX2ZiY19nZXRf
ZnJvbnRidWZmZXJfYml0KGZiYykpKSB7Cj4gIAkJaWYgKGZiYy0+YWN0aXZlKQo+ICAJCQlpbnRl
bF9mYmNfcmVjb21wcmVzcyhkZXZfcHJpdik7Cj4gQEAgLTExMjksMjAgKzExMjksMTcgQEAgdm9p
ZCBpbnRlbF9mYmNfZW5hYmxlKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjLAo+ICAKPiAgCW11dGV4
X2xvY2soJmZiYy0+bG9jayk7Cj4gIAo+IC0JaWYgKGZiYy0+ZW5hYmxlZCkgewo+IC0JCVdBUk5f
T04oZmJjLT5jcnRjID09IE5VTEwpOwo+IC0JCWlmIChmYmMtPmNydGMgPT0gY3J0Yykgewo+IC0J
CQlXQVJOX09OKCFjcnRjX3N0YXRlLT5lbmFibGVfZmJjKTsKPiAtCQkJV0FSTl9PTihmYmMtPmFj
dGl2ZSk7Cj4gLQkJfQo+IC0JCWdvdG8gb3V0Owo+ICsJaWYgKGZiYy0+Y3J0YyA9PSBjcnRjKSB7
Cj4gKwkJV0FSTl9PTighY3J0Y19zdGF0ZS0+ZW5hYmxlX2ZiYyk7Cj4gKwkJV0FSTl9PTihmYmMt
PmFjdGl2ZSk7Cj4gIAl9Cj4gKwlpZiAoZmJjLT5jcnRjKQo+ICsJCWdvdG8gb3V0Owo+ICAKPiAg
CWlmICghY3J0Y19zdGF0ZS0+ZW5hYmxlX2ZiYykKPiAgCQlnb3RvIG91dDsKPiAgCj4gIAlXQVJO
X09OKGZiYy0+YWN0aXZlKTsKPiAtCVdBUk5fT04oZmJjLT5jcnRjICE9IE5VTEwpOwo+ICAKPiAg
CWludGVsX2ZiY191cGRhdGVfc3RhdGVfY2FjaGUoY3J0YywgY3J0Y19zdGF0ZSwgcGxhbmVfc3Rh
dGUpOwo+ICAJaWYgKGludGVsX2ZiY19hbGxvY19jZmIoY3J0YykpIHsKPiBAQCAtMTE1Myw3ICsx
MTUwLDYgQEAgdm9pZCBpbnRlbF9mYmNfZW5hYmxlKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjLAo+
ICAJRFJNX0RFQlVHX0tNUygiRW5hYmxpbmcgRkJDIG9uIHBpcGUgJWNcbiIsIHBpcGVfbmFtZShj
cnRjLT5waXBlKSk7Cj4gIAlmYmMtPm5vX2ZiY19yZWFzb24gPSAiRkJDIGVuYWJsZWQgYnV0IG5v
dCBhY3RpdmUgeWV0XG4iOwo+ICAKPiAtCWZiYy0+ZW5hYmxlZCA9IHRydWU7Cj4gIAlmYmMtPmNy
dGMgPSBjcnRjOwo+ICBvdXQ6Cj4gIAltdXRleF91bmxvY2soJmZiYy0+bG9jayk7Cj4gQEAgLTEx
NzIsNyArMTE2OCw2IEBAIHN0YXRpYyB2b2lkIF9faW50ZWxfZmJjX2Rpc2FibGUoc3RydWN0IGRy
bV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAJc3RydWN0IGludGVsX2NydGMgKmNydGMgPSBm
YmMtPmNydGM7Cj4gIAo+ICAJV0FSTl9PTighbXV0ZXhfaXNfbG9ja2VkKCZmYmMtPmxvY2spKTsK
PiAtCVdBUk5fT04oIWZiYy0+ZW5hYmxlZCk7CgpXQVJOKCFjcnRjKSBtYXliZT8gVGhvdWdoIHRo
ZSBjYWxsZXJzIGFyZSBwcmV0dHkgY2xlYXIsIHNvIG5vdCBzdXJlIGl0J3MKZXZlbiB3b3J0aCBp
dC4KClJldmlld2VkLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50
ZWwuY29tPgoKPiAgCVdBUk5fT04oZmJjLT5hY3RpdmUpOwo+ICAJV0FSTl9PTihjcnRjLT5hY3Rp
dmUpOwo+ICAKPiBAQCAtMTE4MCw3ICsxMTc1LDYgQEAgc3RhdGljIHZvaWQgX19pbnRlbF9mYmNf
ZGlzYWJsZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gIAo+ICAJX19pbnRl
bF9mYmNfY2xlYW51cF9jZmIoZGV2X3ByaXYpOwo+ICAKPiAtCWZiYy0+ZW5hYmxlZCA9IGZhbHNl
Owo+ICAJZmJjLT5jcnRjID0gTlVMTDsKPiAgfQo+ICAKPiBAQCAtMTIyMCw3ICsxMjE0LDcgQEAg
dm9pZCBpbnRlbF9mYmNfZ2xvYmFsX2Rpc2FibGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRl
dl9wcml2KQo+ICAJCXJldHVybjsKPiAgCj4gIAltdXRleF9sb2NrKCZmYmMtPmxvY2spOwo+IC0J
aWYgKGZiYy0+ZW5hYmxlZCkKPiArCWlmIChmYmMtPmNydGMpCj4gIAkJX19pbnRlbF9mYmNfZGlz
YWJsZShkZXZfcHJpdik7Cj4gIAltdXRleF91bmxvY2soJmZiYy0+bG9jayk7Cj4gIAo+IEBAIC0x
MjM2LDcgKzEyMzAsNyBAQCBzdGF0aWMgdm9pZCBpbnRlbF9mYmNfdW5kZXJydW5fd29ya19mbihz
dHJ1Y3Qgd29ya19zdHJ1Y3QgKndvcmspCj4gIAltdXRleF9sb2NrKCZmYmMtPmxvY2spOwo+ICAK
PiAgCS8qIE1heWJlIHdlIHdlcmUgc2NoZWR1bGVkIHR3aWNlLiAqLwo+IC0JaWYgKGZiYy0+dW5k
ZXJydW5fZGV0ZWN0ZWQgfHwgIWZiYy0+ZW5hYmxlZCkKPiArCWlmIChmYmMtPnVuZGVycnVuX2Rl
dGVjdGVkIHx8ICFmYmMtPmNydGMpCj4gIAkJZ290byBvdXQ7Cj4gIAo+ICAJRFJNX0RFQlVHX0tN
UygiRGlzYWJsaW5nIEZCQyBkdWUgdG8gRklGTyB1bmRlcnJ1bi5cbiIpOwo+IEBAIC0xMzUxLDcg
KzEzNDUsNiBAQCB2b2lkIGludGVsX2ZiY19pbml0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk
ZXZfcHJpdikKPiAgCUlOSVRfV09SSygmZmJjLT53b3JrLndvcmssIGludGVsX2ZiY193b3JrX2Zu
KTsKPiAgCUlOSVRfV09SSygmZmJjLT51bmRlcnJ1bl93b3JrLCBpbnRlbF9mYmNfdW5kZXJydW5f
d29ya19mbik7Cj4gIAltdXRleF9pbml0KCZmYmMtPmxvY2spOwo+IC0JZmJjLT5lbmFibGVkID0g
ZmFsc2U7Cj4gIAlmYmMtPmFjdGl2ZSA9IGZhbHNlOwo+ICAJZmJjLT53b3JrLnNjaGVkdWxlZCA9
IGZhbHNlOwo+ICAKPiAtLSAKPiAyLjE1LjAucmMyCj4gCj4gX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50
ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au
b3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVs
IE9UQwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRl
bC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6
Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK