* [PATCH] drm/i915: Replace "cc-option -Wno-foo" with "cc-disable-warning foo"
@ 2017-10-30 17:29 Chris Wilson
2017-10-30 17:41 ` Ville Syrjälä
` (5 more replies)
0 siblings, 6 replies; 8+ messages in thread
From: Chris Wilson @ 2017-10-30 17:29 UTC (permalink / raw)
To: intel-gfx; +Cc: Jani Nikula
To quote kbuild/makefiles.txt:
cc-disable-warning checks if gcc supports a given warning and returns
the commandline switch to disable it. This special function is needed,
because gcc 4.4 and later accept any unknown -Wno-* option and only
warn about it if there is another warning in the source file.
This is exactly what we were trying to achieve with cc-option -Wno-foo and
failed miserably.
Reported-by: kbuild-all@01.org
Fixes: 39bf4de89ff7 ("drm/i915: Add -Wall -Wextra to our build, set warnings to full")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/Makefile | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
index 7750be8e27a6..1bbc5440db40 100644
--- a/drivers/gpu/drm/i915/Makefile
+++ b/drivers/gpu/drm/i915/Makefile
@@ -12,15 +12,15 @@
# will most likely get a sudden build breakage... Hopefully we will fix
# new warnings before CI updates!
subdir-ccflags-y := -Wall -Wextra
-subdir-ccflags-y += $(call cc-option,-Wno-unused-parameter,)
-subdir-ccflags-y += $(call cc-option,-Wno-type-limits,)
-subdir-ccflags-y += $(call cc-option,-Wno-missing-field-initializers,)
-subdir-ccflags-y += $(call cc-option,-Wno-implicit-fallthrough,)
+subdir-ccflags-y += $(call cc-disable-warning, unused-parameter)
+subdir-ccflags-y += $(call cc-disable-warning, type-limits)
+subdir-ccflags-y += $(call cc-disable-warning, missing-field-initializers)
+subdir-ccflags-y += $(call cc-disable-warning, implicit-fallthrough)
subdir-ccflags-$(CONFIG_DRM_I915_WERROR) += -Werror
# Fine grained warnings disable
-CFLAGS_i915_pci.o = $(call cc-option,-Wno-override-init,)
-CFLAGS_intel_fbdev.o = $(call cc-option,-Wno-override-init,)
+CFLAGS_i915_pci.o = $(call cc-disable-warning, override-init)
+CFLAGS_intel_fbdev.o = $(call cc-disable-warning, override-init)
subdir-ccflags-y += \
$(call as-instr,movntdqa (%eax)$(comma)%xmm0,-DCONFIG_AS_MOVNTDQA)
--
2.15.0.rc2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] drm/i915: Replace "cc-option -Wno-foo" with "cc-disable-warning foo"
2017-10-30 17:29 [PATCH] drm/i915: Replace "cc-option -Wno-foo" with "cc-disable-warning foo" Chris Wilson
@ 2017-10-30 17:41 ` Ville Syrjälä
2017-10-30 21:25 ` Chris Wilson
2017-10-30 17:51 ` ✓ Fi.CI.BAT: success for " Patchwork
` (4 subsequent siblings)
5 siblings, 1 reply; 8+ messages in thread
From: Ville Syrjälä @ 2017-10-30 17:41 UTC (permalink / raw)
To: Chris Wilson; +Cc: Jani Nikula, intel-gfx
On Mon, Oct 30, 2017 at 05:29:27PM +0000, Chris Wilson wrote:
> To quote kbuild/makefiles.txt:
>
> cc-disable-warning checks if gcc supports a given warning and returns
> the commandline switch to disable it. This special function is needed,
> because gcc 4.4 and later accept any unknown -Wno-* option and only
> warn about it if there is another warning in the source file.
>
> This is exactly what we were trying to achieve with cc-option -Wno-foo and
> failed miserably.
>
> Reported-by: kbuild-all@01.org
> Fixes: 39bf4de89ff7 ("drm/i915: Add -Wall -Wextra to our build, set warnings to full")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/Makefile | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
> index 7750be8e27a6..1bbc5440db40 100644
> --- a/drivers/gpu/drm/i915/Makefile
> +++ b/drivers/gpu/drm/i915/Makefile
> @@ -12,15 +12,15 @@
> # will most likely get a sudden build breakage... Hopefully we will fix
> # new warnings before CI updates!
> subdir-ccflags-y := -Wall -Wextra
> -subdir-ccflags-y += $(call cc-option,-Wno-unused-parameter,)
> -subdir-ccflags-y += $(call cc-option,-Wno-type-limits,)
> -subdir-ccflags-y += $(call cc-option,-Wno-missing-field-initializers,)
> -subdir-ccflags-y += $(call cc-option,-Wno-implicit-fallthrough,)
> +subdir-ccflags-y += $(call cc-disable-warning, unused-parameter)
> +subdir-ccflags-y += $(call cc-disable-warning, type-limits)
> +subdir-ccflags-y += $(call cc-disable-warning, missing-field-initializers)
> +subdir-ccflags-y += $(call cc-disable-warning, implicit-fallthrough)
> subdir-ccflags-$(CONFIG_DRM_I915_WERROR) += -Werror
>
> # Fine grained warnings disable
> -CFLAGS_i915_pci.o = $(call cc-option,-Wno-override-init,)
> -CFLAGS_intel_fbdev.o = $(call cc-option,-Wno-override-init,)
> +CFLAGS_i915_pci.o = $(call cc-disable-warning, override-init)
> +CFLAGS_intel_fbdev.o = $(call cc-disable-warning, override-init)
Looks correct to me.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> subdir-ccflags-y += \
> $(call as-instr,movntdqa (%eax)$(comma)%xmm0,-DCONFIG_AS_MOVNTDQA)
> --
> 2.15.0.rc2
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] drm/i915: Replace "cc-option -Wno-foo" with "cc-disable-warning foo"
2017-10-30 17:41 ` Ville Syrjälä
@ 2017-10-30 21:25 ` Chris Wilson
0 siblings, 0 replies; 8+ messages in thread
From: Chris Wilson @ 2017-10-30 21:25 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: Jani Nikula, intel-gfx
Quoting Ville Syrjälä (2017-10-30 17:41:51)
> On Mon, Oct 30, 2017 at 05:29:27PM +0000, Chris Wilson wrote:
> > To quote kbuild/makefiles.txt:
> >
> > cc-disable-warning checks if gcc supports a given warning and returns
> > the commandline switch to disable it. This special function is needed,
> > because gcc 4.4 and later accept any unknown -Wno-* option and only
> > warn about it if there is another warning in the source file.
> >
> > This is exactly what we were trying to achieve with cc-option -Wno-foo and
> > failed miserably.
> >
> > Reported-by: kbuild-all@01.org
> > Fixes: 39bf4de89ff7 ("drm/i915: Add -Wall -Wextra to our build, set warnings to full")
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> > Cc: Jani Nikula <jani.nikula@intel.com>
> > ---
> > drivers/gpu/drm/i915/Makefile | 12 ++++++------
> > 1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
> > index 7750be8e27a6..1bbc5440db40 100644
> > --- a/drivers/gpu/drm/i915/Makefile
> > +++ b/drivers/gpu/drm/i915/Makefile
> > @@ -12,15 +12,15 @@
> > # will most likely get a sudden build breakage... Hopefully we will fix
> > # new warnings before CI updates!
> > subdir-ccflags-y := -Wall -Wextra
> > -subdir-ccflags-y += $(call cc-option,-Wno-unused-parameter,)
> > -subdir-ccflags-y += $(call cc-option,-Wno-type-limits,)
> > -subdir-ccflags-y += $(call cc-option,-Wno-missing-field-initializers,)
> > -subdir-ccflags-y += $(call cc-option,-Wno-implicit-fallthrough,)
> > +subdir-ccflags-y += $(call cc-disable-warning, unused-parameter)
> > +subdir-ccflags-y += $(call cc-disable-warning, type-limits)
> > +subdir-ccflags-y += $(call cc-disable-warning, missing-field-initializers)
> > +subdir-ccflags-y += $(call cc-disable-warning, implicit-fallthrough)
> > subdir-ccflags-$(CONFIG_DRM_I915_WERROR) += -Werror
> >
> > # Fine grained warnings disable
> > -CFLAGS_i915_pci.o = $(call cc-option,-Wno-override-init,)
> > -CFLAGS_intel_fbdev.o = $(call cc-option,-Wno-override-init,)
> > +CFLAGS_i915_pci.o = $(call cc-disable-warning, override-init)
> > +CFLAGS_intel_fbdev.o = $(call cc-disable-warning, override-init)
>
> Looks correct to me.
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
And it still survives CI with -Wall -Wextra -Werror, so not entirely
broken.
Should we open a sweepstake on what kbuild reports next?
Thanks and pushed,
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Replace "cc-option -Wno-foo" with "cc-disable-warning foo"
2017-10-30 17:29 [PATCH] drm/i915: Replace "cc-option -Wno-foo" with "cc-disable-warning foo" Chris Wilson
2017-10-30 17:41 ` Ville Syrjälä
@ 2017-10-30 17:51 ` Patchwork
2017-10-30 18:57 ` ✓ Fi.CI.IGT: " Patchwork
` (3 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2017-10-30 17:51 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Replace "cc-option -Wno-foo" with "cc-disable-warning foo"
URL : https://patchwork.freedesktop.org/series/32852/
State : success
== Summary ==
Series 32852v1 drm/i915: Replace "cc-option -Wno-foo" with "cc-disable-warning foo"
https://patchwork.freedesktop.org/api/1.0/series/32852/revisions/1/mbox/
Test chamelium:
Subgroup dp-crc-fast:
pass -> FAIL (fi-kbl-7500u) fdo#102514
Test debugfs_test:
Subgroup read_all_entries:
dmesg-warn -> PASS (fi-cfl-s)
Test drv_getparams_basic:
Subgroup basic-eu-total:
dmesg-warn -> PASS (fi-cfl-s)
Subgroup basic-subslice-total:
dmesg-warn -> PASS (fi-cfl-s)
Test drv_hangman:
Subgroup error-state-basic:
dmesg-warn -> PASS (fi-cfl-s)
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-b:
pass -> DMESG-WARN (fi-byt-n2820) fdo#101705
fdo#102514 https://bugs.freedesktop.org/show_bug.cgi?id=102514
fdo#101705 https://bugs.freedesktop.org/show_bug.cgi?id=101705
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:439s
fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:452s
fi-blb-e6850 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:373s
fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:518s
fi-bwr-2160 total:289 pass:183 dwarn:0 dfail:0 fail:0 skip:106 time:265s
fi-bxt-dsi total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:30 time:490s
fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:492s
fi-byt-j1900 total:289 pass:253 dwarn:1 dfail:0 fail:0 skip:35 time:491s
fi-byt-n2820 total:289 pass:249 dwarn:1 dfail:0 fail:0 skip:39 time:477s
fi-cfl-s total:289 pass:253 dwarn:4 dfail:0 fail:0 skip:32 time:561s
fi-elk-e7500 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:422s
fi-gdg-551 total:289 pass:178 dwarn:1 dfail:0 fail:1 skip:109 time:247s
fi-glk-1 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:576s
fi-glk-dsi total:289 pass:258 dwarn:0 dfail:0 fail:1 skip:30 time:483s
fi-hsw-4770 total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:426s
fi-hsw-4770r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:428s
fi-ilk-650 total:289 pass:228 dwarn:0 dfail:0 fail:0 skip:61 time:423s
fi-ivb-3520m total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:495s
fi-ivb-3770 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:456s
fi-kbl-7500u total:289 pass:263 dwarn:1 dfail:0 fail:1 skip:24 time:481s
fi-kbl-7560u total:289 pass:270 dwarn:0 dfail:0 fail:0 skip:19 time:574s
fi-kbl-7567u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:474s
fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:579s
fi-pnv-d510 total:289 pass:222 dwarn:1 dfail:0 fail:0 skip:66 time:549s
fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:449s
fi-skl-6600u total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:596s
fi-skl-6700hq total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:642s
fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:519s
fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:503s
fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:454s
fi-snb-2520m total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:565s
fi-snb-2600 total:289 pass:249 dwarn:0 dfail:0 fail:0 skip:40 time:422s
2dd14a4ad87f449830d9fbb7b4a33f5d369dcde2 drm-tip: 2017y-10m-30d-13h-40m-22s UTC integration manifest
f45faa19061e drm/i915: Replace "cc-option -Wno-foo" with "cc-disable-warning foo"
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_6265/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread* ✓ Fi.CI.IGT: success for drm/i915: Replace "cc-option -Wno-foo" with "cc-disable-warning foo"
2017-10-30 17:29 [PATCH] drm/i915: Replace "cc-option -Wno-foo" with "cc-disable-warning foo" Chris Wilson
2017-10-30 17:41 ` Ville Syrjälä
2017-10-30 17:51 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2017-10-30 18:57 ` Patchwork
2017-10-30 22:43 ` ✓ Fi.CI.BAT: " Patchwork
` (2 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2017-10-30 18:57 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Replace "cc-option -Wno-foo" with "cc-disable-warning foo"
URL : https://patchwork.freedesktop.org/series/32852/
State : success
== Summary ==
Test kms_flip:
Subgroup dpms-vs-vblank-race:
pass -> FAIL (shard-hsw) fdo#103060
Subgroup wf_vblank-vs-dpms:
dmesg-warn -> PASS (shard-hsw) fdo#102614
Test gem_tiled_swapping:
Subgroup non-threaded:
incomplete -> PASS (shard-hsw)
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
shard-hsw total:2539 pass:1433 dwarn:0 dfail:0 fail:9 skip:1097 time:9239s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_6265/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread* ✓ Fi.CI.BAT: success for drm/i915: Replace "cc-option -Wno-foo" with "cc-disable-warning foo"
2017-10-30 17:29 [PATCH] drm/i915: Replace "cc-option -Wno-foo" with "cc-disable-warning foo" Chris Wilson
` (2 preceding siblings ...)
2017-10-30 18:57 ` ✓ Fi.CI.IGT: " Patchwork
@ 2017-10-30 22:43 ` Patchwork
2017-10-30 23:45 ` ✓ Fi.CI.IGT: " Patchwork
2017-10-31 13:22 ` [PATCH] " Joonas Lahtinen
5 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2017-10-30 22:43 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Replace "cc-option -Wno-foo" with "cc-disable-warning foo"
URL : https://patchwork.freedesktop.org/series/32852/
State : success
== Summary ==
Series 32852v1 drm/i915: Replace "cc-option -Wno-foo" with "cc-disable-warning foo"
https://patchwork.freedesktop.org/api/1.0/series/32852/revisions/1/mbox/
Test gem_exec_suspend:
Subgroup basic-s3:
pass -> DMESG-WARN (fi-cfl-s) fdo#103186
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-c:
incomplete -> PASS (fi-bxt-dsi)
Test pm_rpm:
Subgroup basic-pci-d3-state:
incomplete -> FAIL (fi-bxt-j4205)
fdo#103186 https://bugs.freedesktop.org/show_bug.cgi?id=103186
fi-bdw-5557u total:289 pass:266 dwarn:0 dfail:0 fail:2 skip:21 time:459s
fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:453s
fi-blb-e6850 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:376s
fi-bsw-n3050 total:289 pass:241 dwarn:0 dfail:0 fail:2 skip:46 time:550s
fi-bwr-2160 total:289 pass:183 dwarn:0 dfail:0 fail:0 skip:106 time:268s
fi-bxt-dsi total:289 pass:257 dwarn:0 dfail:0 fail:2 skip:30 time:518s
fi-bxt-j4205 total:289 pass:258 dwarn:0 dfail:0 fail:2 skip:29 time:514s
fi-byt-j1900 total:289 pass:251 dwarn:1 dfail:0 fail:2 skip:35 time:518s
fi-byt-n2820 total:289 pass:247 dwarn:1 dfail:0 fail:2 skip:39 time:499s
fi-cfl-s total:289 pass:251 dwarn:4 dfail:0 fail:2 skip:32 time:563s
fi-elk-e7500 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:424s
fi-gdg-551 total:289 pass:178 dwarn:1 dfail:0 fail:1 skip:109 time:268s
fi-glk-1 total:289 pass:259 dwarn:0 dfail:0 fail:2 skip:28 time:601s
fi-hsw-4770 total:289 pass:260 dwarn:0 dfail:0 fail:2 skip:27 time:446s
fi-hsw-4770r total:289 pass:260 dwarn:0 dfail:0 fail:2 skip:27 time:451s
fi-ilk-650 total:289 pass:228 dwarn:0 dfail:0 fail:0 skip:61 time:424s
fi-ivb-3520m total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:493s
fi-ivb-3770 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:458s
fi-kbl-7500u total:289 pass:262 dwarn:1 dfail:0 fail:2 skip:24 time:517s
fi-kbl-7560u total:289 pass:268 dwarn:0 dfail:0 fail:2 skip:19 time:579s
fi-kbl-7567u total:289 pass:267 dwarn:0 dfail:0 fail:2 skip:20 time:487s
fi-kbl-r total:289 pass:260 dwarn:0 dfail:0 fail:2 skip:27 time:596s
fi-pnv-d510 total:289 pass:222 dwarn:1 dfail:0 fail:0 skip:66 time:541s
fi-skl-6260u total:289 pass:267 dwarn:0 dfail:0 fail:2 skip:20 time:473s
fi-skl-6600u total:289 pass:260 dwarn:0 dfail:0 fail:2 skip:27 time:601s
fi-skl-6700hq total:289 pass:261 dwarn:0 dfail:0 fail:2 skip:26 time:664s
fi-skl-6700k total:289 pass:263 dwarn:0 dfail:0 fail:2 skip:24 time:538s
fi-skl-6770hq total:289 pass:267 dwarn:0 dfail:0 fail:2 skip:20 time:521s
fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:459s
fi-snb-2520m total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:565s
fi-snb-2600 total:289 pass:249 dwarn:0 dfail:0 fail:0 skip:40 time:423s
302b1723bec5e7f43e423c975b9b87705fb9fdd6 drm-tip: 2017y-10m-30d-18h-28m-39s UTC integration manifest
05005a54f357 drm/i915: Replace "cc-option -Wno-foo" with "cc-disable-warning foo"
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_6270/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread* ✓ Fi.CI.IGT: success for drm/i915: Replace "cc-option -Wno-foo" with "cc-disable-warning foo"
2017-10-30 17:29 [PATCH] drm/i915: Replace "cc-option -Wno-foo" with "cc-disable-warning foo" Chris Wilson
` (3 preceding siblings ...)
2017-10-30 22:43 ` ✓ Fi.CI.BAT: " Patchwork
@ 2017-10-30 23:45 ` Patchwork
2017-10-31 13:22 ` [PATCH] " Joonas Lahtinen
5 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2017-10-30 23:45 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Replace "cc-option -Wno-foo" with "cc-disable-warning foo"
URL : https://patchwork.freedesktop.org/series/32852/
State : success
== Summary ==
Test kms_setmode:
Subgroup basic:
fail -> PASS (shard-hsw) fdo#99912
Test kms_flip:
Subgroup flip-vs-rmfb:
pass -> DMESG-WARN (shard-hsw) fdo#102614
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
shard-hsw total:2539 pass:1392 dwarn:2 dfail:0 fail:51 skip:1094 time:9268s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_6270/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] drm/i915: Replace "cc-option -Wno-foo" with "cc-disable-warning foo"
2017-10-30 17:29 [PATCH] drm/i915: Replace "cc-option -Wno-foo" with "cc-disable-warning foo" Chris Wilson
` (4 preceding siblings ...)
2017-10-30 23:45 ` ✓ Fi.CI.IGT: " Patchwork
@ 2017-10-31 13:22 ` Joonas Lahtinen
5 siblings, 0 replies; 8+ messages in thread
From: Joonas Lahtinen @ 2017-10-31 13:22 UTC (permalink / raw)
To: Chris Wilson, intel-gfx; +Cc: Jani Nikula
On Mon, 2017-10-30 at 17:29 +0000, Chris Wilson wrote:
> To quote kbuild/makefiles.txt:
>
> cc-disable-warning checks if gcc supports a given warning and returns
> the commandline switch to disable it. This special function is needed,
> because gcc 4.4 and later accept any unknown -Wno-* option and only
> warn about it if there is another warning in the source file.
>
> This is exactly what we were trying to achieve with cc-option -Wno-foo and
> failed miserably.
>
> Reported-by: kbuild-all@01.org
> Fixes: 39bf4de89ff7 ("drm/i915: Add -Wall -Wextra to our build, set warnings to full")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
Poor person who greps for "-Wno-", should we add comment
"# -Wno-whatever" at the end of each line?
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2017-10-31 13:22 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-30 17:29 [PATCH] drm/i915: Replace "cc-option -Wno-foo" with "cc-disable-warning foo" Chris Wilson
2017-10-30 17:41 ` Ville Syrjälä
2017-10-30 21:25 ` Chris Wilson
2017-10-30 17:51 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-10-30 18:57 ` ✓ Fi.CI.IGT: " Patchwork
2017-10-30 22:43 ` ✓ Fi.CI.BAT: " Patchwork
2017-10-30 23:45 ` ✓ Fi.CI.IGT: " Patchwork
2017-10-31 13:22 ` [PATCH] " Joonas Lahtinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox