From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: "Noralf Trønnes" <noralf@tronnes.org>
Cc: jy0922.shim@samsung.com, daniel.vetter@ffwll.ch,
tomi.valkeinen@ti.com, sw0312.kim@samsung.com,
dri-devel@lists.freedesktop.org, inki.dae@samsung.com,
hdegoede@redhat.com, kyungmin.park@samsung.com,
bskeggs@redhat.com, rodrigo.vivi@intel.com,
alexander.deucher@amd.com, intel-gfx@lists.freedesktop.org,
christian.koenig@amd.com, mark.yao@rock-chips.com
Subject: Re: [PATCH v2 05/15] drm/armada: Use drm_fb_helper_lastclose() and _poll_changed()
Date: Tue, 31 Oct 2017 17:11:47 +0000 [thread overview]
Message-ID: <20171031171147.GH9463@n2100.armlinux.org.uk> (raw)
In-Reply-To: <20171030153951.56269-6-noralf@tronnes.org>
On Mon, Oct 30, 2017 at 04:39:41PM +0100, Noralf Trønnes wrote:
> -static void armada_output_poll_changed(struct drm_device *dev)
> -{
> - struct armada_private *priv = dev->dev_private;
> - struct drm_fb_helper *fbh = priv->fbdev;
> -
> - if (fbh)
> - drm_fb_helper_hotplug_event(fbh);
> -}
> -
> const struct drm_mode_config_funcs armada_drm_mode_config_funcs = {
> .fb_create = armada_fb_create,
> - .output_poll_changed = armada_output_poll_changed,
> + .output_poll_changed = drm_fb_helper_output_poll_changed,
I think this is fine, because although it gets rid of the NULL checks
for the drm_fb_helper structure, the driver will fail to initialise
unless priv->fbdev and the fb helper successfully initialises.
It would be nice to mention that in the commit message as to why
removing those NULL checks is safe.
In any case,
Acked-by: Russell King <rmk+kernel@armlinux.org.uk>
Thanks.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-10-31 17:12 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-30 15:39 [PATCH v2 00/15] drm/fb-helper: Add .last_close and .output_poll_changed helpers Noralf Trønnes
2017-10-30 15:39 ` [PATCH v2 01/15] drm/fb-helper: Handle function NULL argument Noralf Trønnes
2017-10-30 15:39 ` [PATCH v2 02/15] drm: Add drm_device->fb_helper pointer Noralf Trønnes
2017-10-30 15:39 ` [PATCH v2 03/15] drm/fb-helper: Add .last_close and .output_poll_changed helpers Noralf Trønnes
2017-10-30 15:39 ` [PATCH v2 04/15] drm/amdgpu: Use drm_fb_helper_lastclose() and _poll_changed() Noralf Trønnes
2017-10-30 15:39 ` [PATCH v2 05/15] drm/armada: " Noralf Trønnes
2017-10-31 17:11 ` Russell King - ARM Linux [this message]
2017-10-30 15:39 ` [PATCH v2 06/15] drm/exynos: " Noralf Trønnes
2017-10-31 10:28 ` Daniel Vetter
2017-11-09 8:37 ` Inki Dae
2017-10-30 15:39 ` [PATCH v2 07/15] drm/gma500: " Noralf Trønnes
2017-10-31 10:28 ` Daniel Vetter
2017-10-30 15:39 ` [PATCH v2 08/15] drm/i915: Use drm_fb_helper_output_poll_changed() Noralf Trønnes
2017-10-31 10:27 ` Daniel Vetter
2017-10-31 14:26 ` Noralf Trønnes
2017-10-31 16:34 ` Daniel Vetter
2017-10-30 15:39 ` [PATCH v2 09/15] drm/msm: Use drm_fb_helper_lastclose() and _poll_changed() Noralf Trønnes
2017-10-30 15:39 ` [PATCH v2 10/15] drm/nouveau: Use drm_fb_helper_output_poll_changed() Noralf Trønnes
2017-10-30 15:39 ` [PATCH v2 11/15] drm/omap: Use drm_fb_helper_lastclose() and _poll_changed() Noralf Trønnes
2017-10-30 15:39 ` [PATCH v2 12/15] drm/radeon: " Noralf Trønnes
2017-10-30 15:39 ` [PATCH v2 13/15] drm/rockchip: " Noralf Trønnes
2017-10-30 15:39 ` [PATCH v2 14/15] drm/tegra: " Noralf Trønnes
2017-10-30 15:39 ` [PATCH v2 15/15] staging: vboxvideo: Use drm_fb_helper_lastclose() Noralf Trønnes
2017-10-31 10:32 ` Daniel Vetter
2017-10-31 14:40 ` Noralf Trønnes
2017-10-31 16:35 ` Daniel Vetter
2017-10-30 16:36 ` ✗ Fi.CI.BAT: failure for drm/fb-helper: Add .last_close and .output_poll_changed helpers (rev2) Patchwork
2017-10-31 18:26 ` [PATCH v2 00/15] drm/fb-helper: Add .last_close and .output_poll_changed helpers Noralf Trønnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171031171147.GH9463@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=alexander.deucher@amd.com \
--cc=bskeggs@redhat.com \
--cc=christian.koenig@amd.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hdegoede@redhat.com \
--cc=inki.dae@samsung.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jy0922.shim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=mark.yao@rock-chips.com \
--cc=noralf@tronnes.org \
--cc=rodrigo.vivi@intel.com \
--cc=sw0312.kim@samsung.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox