From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: Don't try to use negative pll_id. Date: Wed, 1 Nov 2017 21:26:15 +0200 Message-ID: <20171101192615.GI10981@intel.com> References: <20171101184458.31698-1-rodrigo.vivi@intel.com> <20171101185655.GH10981@intel.com> <20171101191342.o2lquxgy24rlskob@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8C4216E81E for ; Wed, 1 Nov 2017 19:26:18 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20171101191342.o2lquxgy24rlskob@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Rodrigo Vivi Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBOb3YgMDEsIDIwMTcgYXQgMTI6MTM6NDJQTSAtMDcwMCwgUm9kcmlnbyBWaXZpIHdy b3RlOgo+IE9uIFdlZCwgTm92IDAxLCAyMDE3IGF0IDA2OjU2OjU1UE0gKzAwMDAsIFZpbGxlIFN5 cmrDpGzDpCB3cm90ZToKPiA+IE9uIFdlZCwgTm92IDAxLCAyMDE3IGF0IDExOjQ0OjU4QU0gLTA3 MDAsIFJvZHJpZ28gVml2aSB3cm90ZToKPiA+ID4gSXQgaXMgdW5saWtlbHkgd2UgYXJlIGdldHRp bmcgdGhlIC0xIGhlcmUuCj4gPiA+IEJ1dCBpZiB3ZSBwcm9wYWdhdGUgdGhhdCBwbGxfaWQgLTEg dG8gdGhlIHJlc3Qgb2YgdGhlIGNvZGUKPiA+ID4gd2UgbWlnaHQgaGF2ZSBmdW5ueSBjYWxjdWxh dGlvbnMgb24gbGlua19jbG9jayBhbmQgd2hvCj4gPiA+IGtub3dzIHdoYXQgcmVnaXN0ZXJzIHdl IGVuZCB1cCBhY2Nlc3NpbmcuCj4gPiA+IAo+ID4gPiBCZXR0ZXIgdG8gcHJvdGVjdCB0aGUgY29k ZS4KPiA+ID4gCj4gPiA+IEFsc28gYmV0dGVyIHdpdGggZXJybm8gbnVtYmVyIGluc3RlYWQgb2Yg Z2VuZXJpYyAtMS4KPiA+ID4gCj4gPiA+IENjOiBNYW5hc2kgTmF2YXJlIDxtYW5hc2kuZC5uYXZh cmVAaW50ZWwuY29tPgo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28u dml2aUBpbnRlbC5jb20+Cj4gPiA+IC0tLQo+ID4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZGRpLmMgICAgICB8IDEwICsrKysrKysrKysKPiA+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2RwbGxfbWdyLmMgfCAgMiArLQo+ID4gPiAgMiBmaWxlcyBjaGFuZ2VkLCAxMSBpbnNl cnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4gPiA+IAo+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k ZGkuYwo+ID4gPiBpbmRleCBhY2U2NzRjZDc5YjkuLjJjNmFiZGJmMzNlYSAxMDA2NDQKPiA+ID4g LS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMKPiA+ID4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMKPiA+ID4gQEAgLTEyODMsNiArMTI4MywxMSBAQCBz dGF0aWMgdm9pZCBjbmxfZGRpX2Nsb2NrX2dldChzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2Rl ciwKPiA+ID4gIAo+ID4gPiAgCXBsbF9pZCA9IGludGVsX2dldF9zaGFyZWRfZHBsbF9pZChkZXZf cHJpdiwgcGlwZV9jb25maWctPnNoYXJlZF9kcGxsKTsKPiA+ID4gIAo+ID4gPiArCWlmIChwbGxf aWQgPCAwKSB7Cj4gPiA+ICsJCURSTV9FUlJPUigiUExMIG5vdCBmb3VuZFxuIik7Cj4gPiA+ICsJ CXJldHVybjsKPiA+ID4gKwl9Cj4gPiA+ICsKPiA+ID4gIAljZmdjcjAgPSBJOTE1X1JFQUQoQ05M X0RQTExfQ0ZHQ1IwKHBsbF9pZCkpOwo+ID4gCj4gPiBEb24ndCB3ZSBoYXZlIHRoZSBkcGxsIHN0 YXRlIGFscmVhZHkgcmVhZCBvdXQ/Cj4gPiAKPiA+IGNydGNfc3RhdGUtPmRsbF9od19zdGF0ZS5j ZmdjcjAgZXRjLj8KPiAKPiBvaCEgd2UgZG8hCj4gQWxzbyBkdXJpbmcgY2FsY193cnBsbF9saW5r IHdlIHNob3VsZCBiZSB1c2luZyB0aGlzLAo+IHNob3VsZG4ndCB3ZT8hCj4gCj4gUHJvYmFibHkg bXkgYmFkIHdoZW4gZG9pbmcgdGhpcyBjb2RlIGxvb2tpbmcgdG8gc2tsIGNvZGUuLi4KPiAKPiBT YW1lIHRoaW5nIG9uIHNrbCBjYXNlLCByaWdodD8hCgpPbiBhbGwgcGxhdGZvcm1zIEknZCBzYXku IFRoaXMgaXMgYWxsIHByb2JhYmx5IGp1c3QgbGVmdG92ZXJzIGZyb20gYmVmb3JlCndlIGhhZCB0 aGUgZHBsbCBtYW5hZ2VyLgoKSSBzdXNwZWN0IHdlIHNob3VsZCBqdXN0IG1vdmUgYWxsIHRoZXNl IGZvb19jYWxjX3dycGxsX2xpbmsoKSBldGMuCmZ1bmN0aW9ucyBpbnRvIHRoZSBkcGxsIG1hbmFn ZXIuIE5vdCBzdXJlIGlmIHdlIGNvdWxkIGp1c3QgZGlyZWN0bHkKZmlsbCBvdXQgdGhlIHBvcnRf Y2xvY2sgaW4gdGhlIGRwbGwgbWFuYWdlciBhY3R1YWxseS4gSG1tLiBJIGd1ZXNzIG5vdAppbiB0 aGUgLmdldF9od19zdGF0ZSgpIGF0IGxlYXN0IHNpbmNlIHdlIGRvbid0IHBhc3MgdGhlIGZ1bGwg Y3J0YyBzdGF0ZQp0aGVyZS4gQnV0IHdlIGNvdWxkIHBlcmhhcHMgaGF2ZSBzb21lIGtpbmQgb2Yg LmNsb2NrX2dldCgpIGZ1bmN0aW9uCnRoYXQnZCBiZSBzaW1pbGFyIHRvIHRoZSBpOXh4L3Zsdi9j aHZfY2xvY2tfZ2V0KCksIGV4Y2VwdCB3ZSdkIGp1c3QgY2FsbAppdCBmcm9tIHRoZSBEREkgY29k ZSB3aGVyZSB3ZSBjdXJyZW50bHkgY2FsbCB0aGVzZSBoYW5kIHJvbGxlZApmdW5jdGlvbnMuCgo+ ID4gCj4gPiA+ICAKPiA+ID4gIAlpZiAoY2ZnY3IwICYgRFBMTF9DRkdDUjBfSERNSV9NT0RFKSB7 Cj4gPiA+IEBAIC0xMzM3LDYgKzEzNDIsMTEgQEAgc3RhdGljIHZvaWQgc2tsX2RkaV9jbG9ja19n ZXQoc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIsCj4gPiA+ICAKPiA+ID4gIAlwbGxfaWQg PSBpbnRlbF9nZXRfc2hhcmVkX2RwbGxfaWQoZGV2X3ByaXYsIHBpcGVfY29uZmlnLT5zaGFyZWRf ZHBsbCk7Cj4gPiA+ICAKPiA+ID4gKwlpZiAocGxsX2lkIDwgMCkgewo+ID4gPiArCQlEUk1fRVJS T1IoIlBMTCBub3QgZm91bmRcbiIpOwo+ID4gPiArCQlyZXR1cm47Cj4gPiA+ICsJfQo+ID4gPiAr Cj4gPiA+ICAJZHBsbF9jdGwxID0gSTkxNV9SRUFEKERQTExfQ1RSTDEpOwo+ID4gPiAgCj4gPiA+ ICAJaWYgKGRwbGxfY3RsMSAmIERQTExfQ1RSTDFfSERNSV9NT0RFKHBsbF9pZCkpIHsKPiA+ID4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwbGxfbWdyLmMgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21nci5jCj4gPiA+IGluZGV4IGE4M2JmMWMzOGUw NS4uYzRhN2YzOWUxNzNhIDEwMDY0NAo+ID4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kcGxsX21nci5jCj4gPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rw bGxfbWdyLmMKPiA+ID4gQEAgLTEwMiw3ICsxMDIsNyBAQCBpbnRlbF9nZXRfc2hhcmVkX2RwbGxf aWQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ID4gPiAgewo+ID4gPiAgCWlm IChXQVJOX09OKHBsbCA8IGRldl9wcml2LT5zaGFyZWRfZHBsbHN8fAo+ID4gPiAgCQkgICAgcGxs ID4gJmRldl9wcml2LT5zaGFyZWRfZHBsbHNbZGV2X3ByaXYtPm51bV9zaGFyZWRfZHBsbF0pKQo+ ID4gPiAtCQlyZXR1cm4gLTE7Cj4gPiA+ICsJCXJldHVybiAtRU5PRU5UOwo+ID4gPiAgCj4gPiA+ ICAJcmV0dXJuIChlbnVtIGludGVsX2RwbGxfaWQpIChwbGwgLSBkZXZfcHJpdi0+c2hhcmVkX2Rw bGxzKTsKPiA+ID4gIH0KPiA+ID4gLS0gCj4gPiA+IDIuMTMuNgo+ID4gPiAKPiA+ID4gX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiA+ID4gSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdAo+ID4gPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gPiA+ IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4 Cj4gPiAKPiA+IC0tIAo+ID4gVmlsbGUgU3lyasOkbMOkCj4gPiBJbnRlbCBPVEMKCi0tIApWaWxs ZSBTeXJqw6Rsw6QKSW50ZWwgT1RDCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2ludGVsLWdmeAo=