From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [PATCH] drm/i915: Don't try to use negative pll_id. Date: Wed, 1 Nov 2017 12:36:57 -0700 Message-ID: <20171101193657.dqq2rp2pqpych4g2@intel.com> References: <20171101184458.31698-1-rodrigo.vivi@intel.com> <20171101190851.GB28377@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 32B906E82E for ; Wed, 1 Nov 2017 19:36:59 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20171101190851.GB28377@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Manasi Navare Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBOb3YgMDEsIDIwMTcgYXQgMDc6MDg6NTJQTSArMDAwMCwgTWFuYXNpIE5hdmFyZSB3 cm90ZToKPiBPbiBXZWQsIE5vdiAwMSwgMjAxNyBhdCAxMTo0NDo1OEFNIC0wNzAwLCBSb2RyaWdv IFZpdmkgd3JvdGU6Cj4gPiBJdCBpcyB1bmxpa2VseSB3ZSBhcmUgZ2V0dGluZyB0aGUgLTEgaGVy ZS4KPiA+IEJ1dCBpZiB3ZSBwcm9wYWdhdGUgdGhhdCBwbGxfaWQgLTEgdG8gdGhlIHJlc3Qgb2Yg dGhlIGNvZGUKPiA+IHdlIG1pZ2h0IGhhdmUgZnVubnkgY2FsY3VsYXRpb25zIG9uIGxpbmtfY2xv Y2sgYW5kIHdobwo+ID4ga25vd3Mgd2hhdCByZWdpc3RlcnMgd2UgZW5kIHVwIGFjY2Vzc2luZy4K PiA+IAo+ID4gQmV0dGVyIHRvIHByb3RlY3QgdGhlIGNvZGUuCj4gPiAKPiA+IEFsc28gYmV0dGVy IHdpdGggZXJybm8gbnVtYmVyIGluc3RlYWQgb2YgZ2VuZXJpYyAtMS4KPiA+IAo+ID4gQ2M6IE1h bmFzaSBOYXZhcmUgPG1hbmFzaS5kLm5hdmFyZUBpbnRlbC5jb20+Cj4gPiBTaWduZWQtb2ZmLWJ5 OiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28udml2aUBpbnRlbC5jb20+Cj4gPiAtLS0KPiA+ICBkcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYyAgICAgIHwgMTAgKysrKysrKysrKwo+ID4gIGRy aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwbGxfbWdyLmMgfCAgMiArLQo+ID4gIDIgZmlsZXMg Y2hhbmdlZCwgMTEgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+ID4gCj4gPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kZGkuYwo+ID4gaW5kZXggYWNlNjc0Y2Q3OWI5Li4yYzZhYmRiZjMzZWEgMTAw NjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+ID4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMKPiA+IEBAIC0xMjgzLDYgKzEyODMsMTEg QEAgc3RhdGljIHZvaWQgY25sX2RkaV9jbG9ja19nZXQoc3RydWN0IGludGVsX2VuY29kZXIgKmVu Y29kZXIsCj4gPiAgCj4gPiAgCXBsbF9pZCA9IGludGVsX2dldF9zaGFyZWRfZHBsbF9pZChkZXZf cHJpdiwgcGlwZV9jb25maWctPnNoYXJlZF9kcGxsKTsKPiA+ICAKPiA+ICsJaWYgKHBsbF9pZCA8 IDApIHsKPiA+ICsJCURSTV9FUlJPUigiUExMIG5vdCBmb3VuZFxuIik7Cj4gPiArCQlyZXR1cm47 Cj4gPiArCX0KPiA+ICsKPiAKPiBUaGUgZnVuY3Rpb24gaW50ZWxfZ2V0X3NoYXJlZF9kcGxsX2lk KCkgYWxyZWFkeSBoYXMgdGhpcyBXQVJOX09OOgo+IGlmIChXQVJOX09OKHBsbCA8IGRldl9wcml2 LT5zaGFyZWRfZHBsbHMpKQo+IGFuZCBpdCByZXR1cm4gcGxsX2lkID0gKHBsbCAtIGRldl9wcml2 LT5zaGFyZWRfZHBsbHMpOwo+IFNvIHNob3VsZG50IHRoaXMgYWxyZWFkeSB0aHJvdyBhIHdhcm5p bmcgaW4gY2FzZSBwbGwgPCBkZXZfcHJpdi0+c2hhcmVkX2RwbGxzIGV2ZW50dWFsbHkKPiByZXN1 bHRpbmcgaW50byBhIG5lZ2F0aXZlIHBsbF9pZD8KCnllYXAsIHdlIHRocm91Z2ggYSB3YXJuaW5n IGFuZCByZXR1cm4gLTEuCgpUaGVuIHdlIHVzZSB0aGUgLTEgdG8gZG8gc29tZSByZWcgYWNjZXNz IGFuZCBiaXRzLi4uCgo+IAo+IE1hbmFzaQo+IAo+ID4gIAljZmdjcjAgPSBJOTE1X1JFQUQoQ05M X0RQTExfQ0ZHQ1IwKHBsbF9pZCkpOwo+ID4gIAo+ID4gIAlpZiAoY2ZnY3IwICYgRFBMTF9DRkdD UjBfSERNSV9NT0RFKSB7Cj4gPiBAQCAtMTMzNyw2ICsxMzQyLDExIEBAIHN0YXRpYyB2b2lkIHNr bF9kZGlfY2xvY2tfZ2V0KHN0cnVjdCBpbnRlbF9lbmNvZGVyICplbmNvZGVyLAo+ID4gIAo+ID4g IAlwbGxfaWQgPSBpbnRlbF9nZXRfc2hhcmVkX2RwbGxfaWQoZGV2X3ByaXYsIHBpcGVfY29uZmln LT5zaGFyZWRfZHBsbCk7Cj4gPiAgCj4gPiArCWlmIChwbGxfaWQgPCAwKSB7Cj4gPiArCQlEUk1f RVJST1IoIlBMTCBub3QgZm91bmRcbiIpOwo+ID4gKwkJcmV0dXJuOwo+ID4gKwl9Cj4gPiArCj4g PiAgCWRwbGxfY3RsMSA9IEk5MTVfUkVBRChEUExMX0NUUkwxKTsKPiA+ICAKPiA+ICAJaWYgKGRw bGxfY3RsMSAmIERQTExfQ1RSTDFfSERNSV9NT0RFKHBsbF9pZCkpIHsKPiA+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21nci5jIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZHBsbF9tZ3IuYwo+ID4gaW5kZXggYTgzYmYxYzM4ZTA1Li5jNGE3ZjM5ZTE3 M2EgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21nci5j Cj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcGxsX21nci5jCj4gPiBAQCAt MTAyLDcgKzEwMiw3IEBAIGludGVsX2dldF9zaGFyZWRfZHBsbF9pZChzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSAqZGV2X3ByaXYsCj4gPiAgewo+ID4gIAlpZiAoV0FSTl9PTihwbGwgPCBkZXZfcHJp di0+c2hhcmVkX2RwbGxzfHwKPiA+ICAJCSAgICBwbGwgPiAmZGV2X3ByaXYtPnNoYXJlZF9kcGxs c1tkZXZfcHJpdi0+bnVtX3NoYXJlZF9kcGxsXSkpCj4gPiAtCQlyZXR1cm4gLTE7Cj4gPiArCQly ZXR1cm4gLUVOT0VOVDsKPiA+ICAKPiA+ICAJcmV0dXJuIChlbnVtIGludGVsX2RwbGxfaWQpIChw bGwgLSBkZXZfcHJpdi0+c2hhcmVkX2RwbGxzKTsKPiA+ICB9Cj4gPiAtLSAKPiA+IDIuMTMuNgo+ ID4gCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVs LWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=