From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 1/2] drm/i915: Move 90/270 rotation validity check into its own function Date: Fri, 3 Nov 2017 17:50:17 +0200 Message-ID: <20171103155017.GX10981@intel.com> References: <1509719878-300-1-git-send-email-juhapekka.heikkila@gmail.com> <1509719878-300-2-git-send-email-juhapekka.heikkila@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7385F6EAAA for ; Fri, 3 Nov 2017 15:50:20 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1509719878-300-2-git-send-email-juhapekka.heikkila@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Juha-Pekka Heikkila Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBOb3YgMDMsIDIwMTcgYXQgMDQ6Mzc6NTdQTSArMDIwMCwgSnVoYS1QZWtrYSBIZWlr a2lsYSB3cm90ZToKPiBUaGlzIG1ha2VzIGludGVsX3BsYW5lX2F0b21pY19jaGVja193aXRoX3N0 YXRlKCkgZ2VuZXJhbGx5IHNob3J0ZXIuCj4gCj4gU2lnbmVkLW9mZi1ieTogSnVoYS1QZWtrYSBI ZWlra2lsYSA8anVoYXBla2thLmhlaWtraWxhQGdtYWlsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfYXRvbWljX3BsYW5lLmMgfCA1MyArKysrKysrKysrKysrKysrKy0t LS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAzMCBpbnNlcnRpb25zKCspLCAyMyBkZWxl dGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYXRv bWljX3BsYW5lLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9hdG9taWNfcGxhbmUuYwo+ IGluZGV4IDhlNmRjMTUuLjZjNGM4MmUyZCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9hdG9taWNfcGxhbmUuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2F0b21pY19wbGFuZS5jCj4gQEAgLTEwNyw2ICsxMDcsMzUgQEAgaW50ZWxfcGxhbmVfZGVz dHJveV9zdGF0ZShzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSwKPiAgCWRybV9hdG9taWNfaGVscGVy X3BsYW5lX2Rlc3Ryb3lfc3RhdGUocGxhbmUsIHN0YXRlKTsKPiAgfQo+ICAKPiArc3RhdGljIGJv b2wgaW50ZWxfdmFsaWRfcm90YXRpb24oY29uc3Qgc3RydWN0IGRybV9wbGFuZV9zdGF0ZSAqc3Rh dGUpCj4gK3sKPiArCXN0cnVjdCBkcm1fZm9ybWF0X25hbWVfYnVmIGZvcm1hdF9uYW1lOwo+ICsK PiArCWlmIChzdGF0ZS0+ZmItPm1vZGlmaWVyICE9IEk5MTVfRk9STUFUX01PRF9ZX1RJTEVEICYm Cj4gKwkgICAgc3RhdGUtPmZiLT5tb2RpZmllciAhPSBJOTE1X0ZPUk1BVF9NT0RfWWZfVElMRUQp IHsKPiArCQlEUk1fREVCVUdfS01TKCJZL1lmIHRpbGluZyByZXF1aXJlZCBmb3IgOTAvMjcwIVxu Iik7Cj4gKwkJcmV0dXJuIGZhbHNlOwo+ICsJfQo+ICsKPiArCS8qCj4gKwkgKiA5MC8yNzAgaXMg bm90IGFsbG93ZWQgd2l0aCBSR0I2NCAxNjoxNjoxNjoxNiwKPiArCSAqIFJHQiAxNi1iaXQgNTo2 OjUsIGFuZCBJbmRleGVkIDgtYml0Lgo+ICsJICogVEJEOiBBZGQgUkdCNjQgY2FzZSBvbmNlIGl0 cyBhZGRlZCBpbiBzdXBwb3J0ZWQgZm9ybWF0IGxpc3QuCj4gKwkgKi8KPiArCXN3aXRjaCAoc3Rh dGUtPmZiLT5mb3JtYXQtPmZvcm1hdCkgewo+ICsJY2FzZSBEUk1fRk9STUFUX0M4Ogo+ICsJY2Fz ZSBEUk1fRk9STUFUX1JHQjU2NToKPiArCQlEUk1fREVCVUdfS01TKCJVbnN1cHBvcnRlZCBwaXhl bCBmb3JtYXQgJXMgZm9yIDkwLzI3MCFcbiIsCj4gKwkJCSAgICAgIGRybV9nZXRfZm9ybWF0X25h bWUoc3RhdGUtPmZiLT5mb3JtYXQtPmZvcm1hdCwKPiArCQkJCQkJICAmZm9ybWF0X25hbWUpKTsK PiArCQlyZXR1cm4gZmFsc2U7Cj4gKwo+ICsJZGVmYXVsdDoKPiArCQlicmVhazsKPiArCX0KClVz dWFsbHkgdGhlcmUncyBhbiBlbXB0eSBsaW5lIGFmdGVyIHRoZSBmaW5hbCByZXR1cm4uCgo+ICsJ cmV0dXJuIHRydWU7Cj4gK30KPiArCj4gIGludCBpbnRlbF9wbGFuZV9hdG9taWNfY2hlY2tfd2l0 aF9zdGF0ZShjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqb2xkX2NydGNfc3RhdGUsCj4g IAkJCQkJc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUsCj4gIAkJCQkJY29uc3Qg c3RydWN0IGludGVsX3BsYW5lX3N0YXRlICpvbGRfcGxhbmVfc3RhdGUsCj4gQEAgLTEzOCwzMCAr MTY3LDggQEAgaW50IGludGVsX3BsYW5lX2F0b21pY19jaGVja193aXRoX3N0YXRlKGNvbnN0IHN0 cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpvbGRfY3J0Y18KPiAgCQljcnRjX3N0YXRlLT5iYXNlLmVu YWJsZSA/IGNydGNfc3RhdGUtPnBpcGVfc3JjX2ggOiAwOwo+ICAKPiAgCWlmIChzdGF0ZS0+ZmIg JiYgZHJtX3JvdGF0aW9uXzkwX29yXzI3MChzdGF0ZS0+cm90YXRpb24pKSB7CgpJJ2QgcHVsbCB0 aGVzZSBjaGVja3MgaW50byB0aGUgbmV3IGZ1bmN0aW9uIGFzIHdlbGwgKGFzIGFuIGVhcmx5CnJl dHVybiBzbyB0aGF0IHdlIGRvbid0IGhhdmUgdG8gbmVlZGxlc3NseSBpbmRlbnQgdGhlIHdob2xl CmZ1bmN0aW9uIGJvZHkpLiBPdGhlcndpc2UgdGhlIGZ1bmN0aW9uIG5hbWUgZG9lc24ndCByZWFs bHkgbWF0Y2gKdGhlIGltcGxlbWVudGF0aW9uLgoKPiAtCQlzdHJ1Y3QgZHJtX2Zvcm1hdF9uYW1l X2J1ZiBmb3JtYXRfbmFtZTsKPiAtCj4gLQkJaWYgKHN0YXRlLT5mYi0+bW9kaWZpZXIgIT0gSTkx NV9GT1JNQVRfTU9EX1lfVElMRUQgJiYKPiAtCQkgICAgc3RhdGUtPmZiLT5tb2RpZmllciAhPSBJ OTE1X0ZPUk1BVF9NT0RfWWZfVElMRUQpIHsKPiAtCQkJRFJNX0RFQlVHX0tNUygiWS9ZZiB0aWxp bmcgcmVxdWlyZWQgZm9yIDkwLzI3MCFcbiIpOwo+ICsJCWlmICghaW50ZWxfdmFsaWRfcm90YXRp b24oc3RhdGUpKQo+ICAJCQlyZXR1cm4gLUVJTlZBTDsKPiAtCQl9Cj4gLQo+IC0JCS8qCj4gLQkJ ICogOTAvMjcwIGlzIG5vdCBhbGxvd2VkIHdpdGggUkdCNjQgMTY6MTY6MTY6MTYsCj4gLQkJICog UkdCIDE2LWJpdCA1OjY6NSwgYW5kIEluZGV4ZWQgOC1iaXQuCj4gLQkJICogVEJEOiBBZGQgUkdC NjQgY2FzZSBvbmNlIGl0cyBhZGRlZCBpbiBzdXBwb3J0ZWQgZm9ybWF0IGxpc3QuCj4gLQkJICov Cj4gLQkJc3dpdGNoIChzdGF0ZS0+ZmItPmZvcm1hdC0+Zm9ybWF0KSB7Cj4gLQkJY2FzZSBEUk1f Rk9STUFUX0M4Ogo+IC0JCWNhc2UgRFJNX0ZPUk1BVF9SR0I1NjU6Cj4gLQkJCURSTV9ERUJVR19L TVMoIlVuc3VwcG9ydGVkIHBpeGVsIGZvcm1hdCAlcyBmb3IgOTAvMjcwIVxuIiwKPiAtCQkJICAg ICAgICAgICAgICBkcm1fZ2V0X2Zvcm1hdF9uYW1lKHN0YXRlLT5mYi0+Zm9ybWF0LT5mb3JtYXQs Cj4gLQkJCSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAmZm9ybWF0X25hbWUpKTsK PiAtCQkJcmV0dXJuIC1FSU5WQUw7Cj4gLQo+IC0JCWRlZmF1bHQ6Cj4gLQkJCWJyZWFrOwo+IC0J CX0KPiAgCX0KPiAgCj4gIAkvKiBDSFYgaWdub3JlcyB0aGUgbWlycm9yIGJpdCB3aGVuIHRoZSBy b3RhdGUgYml0IGlzIHNldCA6KCAqLwo+IC0tIAo+IDIuNy40Cj4gCj4gX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0 Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKVmlsbGUgU3lyasOkbMOk CkludGVsIE9UQwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK