From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 1/2] drm/i915: Move 90/270 rotation validity check into its own function Date: Fri, 3 Nov 2017 17:52:05 +0200 Message-ID: <20171103155205.GY10981@intel.com> References: <1509719878-300-1-git-send-email-juhapekka.heikkila@gmail.com> <1509719878-300-2-git-send-email-juhapekka.heikkila@gmail.com> <20171103155017.GX10981@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 87CA76EAB2 for ; Fri, 3 Nov 2017 15:52:08 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20171103155017.GX10981@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Juha-Pekka Heikkila Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBOb3YgMDMsIDIwMTcgYXQgMDU6NTA6MTdQTSArMDIwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IE9uIEZyaSwgTm92IDAzLCAyMDE3IGF0IDA0OjM3OjU3UE0gKzAyMDAsIEp1aGEt UGVra2EgSGVpa2tpbGEgd3JvdGU6Cj4gPiBUaGlzIG1ha2VzIGludGVsX3BsYW5lX2F0b21pY19j aGVja193aXRoX3N0YXRlKCkgZ2VuZXJhbGx5IHNob3J0ZXIuCj4gPiAKPiA+IFNpZ25lZC1vZmYt Ynk6IEp1aGEtUGVra2EgSGVpa2tpbGEgPGp1aGFwZWtrYS5oZWlra2lsYUBnbWFpbC5jb20+Cj4g PiAtLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9hdG9taWNfcGxhbmUuYyB8IDUz ICsrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgMzAg aW5zZXJ0aW9ucygrKSwgMjMgZGVsZXRpb25zKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9hdG9taWNfcGxhbmUuYyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2F0b21pY19wbGFuZS5jCj4gPiBpbmRleCA4ZTZkYzE1Li42YzRjODJlMmQgMTAw NjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9hdG9taWNfcGxhbmUuYwo+ ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYXRvbWljX3BsYW5lLmMKPiA+IEBA IC0xMDcsNiArMTA3LDM1IEBAIGludGVsX3BsYW5lX2Rlc3Ryb3lfc3RhdGUoc3RydWN0IGRybV9w bGFuZSAqcGxhbmUsCj4gPiAgCWRybV9hdG9taWNfaGVscGVyX3BsYW5lX2Rlc3Ryb3lfc3RhdGUo cGxhbmUsIHN0YXRlKTsKPiA+ICB9Cj4gPiAgCj4gPiArc3RhdGljIGJvb2wgaW50ZWxfdmFsaWRf cm90YXRpb24oY29uc3Qgc3RydWN0IGRybV9wbGFuZV9zdGF0ZSAqc3RhdGUpCgpPaCBhbmQgcGxl YXNlIG5hbWUgdGhpcyBwYXJhbWV0ZXIgJ3BsYW5lX3N0YXRlJy4gV2UncmUgdHJ5aW5nIHRvIHNs b3dseQpjbGVhbiB1cCB0aGUgbWVzcyB3aXRoIGluY29uc2lzdGVudCBuYW1pbmcgb2YgdGhpbmdz LgoKPiA+ICt7Cj4gPiArCXN0cnVjdCBkcm1fZm9ybWF0X25hbWVfYnVmIGZvcm1hdF9uYW1lOwo+ ID4gKwo+ID4gKwlpZiAoc3RhdGUtPmZiLT5tb2RpZmllciAhPSBJOTE1X0ZPUk1BVF9NT0RfWV9U SUxFRCAmJgo+ID4gKwkgICAgc3RhdGUtPmZiLT5tb2RpZmllciAhPSBJOTE1X0ZPUk1BVF9NT0Rf WWZfVElMRUQpIHsKPiA+ICsJCURSTV9ERUJVR19LTVMoIlkvWWYgdGlsaW5nIHJlcXVpcmVkIGZv ciA5MC8yNzAhXG4iKTsKPiA+ICsJCXJldHVybiBmYWxzZTsKPiA+ICsJfQo+ID4gKwo+ID4gKwkv Kgo+ID4gKwkgKiA5MC8yNzAgaXMgbm90IGFsbG93ZWQgd2l0aCBSR0I2NCAxNjoxNjoxNjoxNiwK PiA+ICsJICogUkdCIDE2LWJpdCA1OjY6NSwgYW5kIEluZGV4ZWQgOC1iaXQuCj4gPiArCSAqIFRC RDogQWRkIFJHQjY0IGNhc2Ugb25jZSBpdHMgYWRkZWQgaW4gc3VwcG9ydGVkIGZvcm1hdCBsaXN0 Lgo+ID4gKwkgKi8KPiA+ICsJc3dpdGNoIChzdGF0ZS0+ZmItPmZvcm1hdC0+Zm9ybWF0KSB7Cj4g PiArCWNhc2UgRFJNX0ZPUk1BVF9DODoKPiA+ICsJY2FzZSBEUk1fRk9STUFUX1JHQjU2NToKPiA+ ICsJCURSTV9ERUJVR19LTVMoIlVuc3VwcG9ydGVkIHBpeGVsIGZvcm1hdCAlcyBmb3IgOTAvMjcw IVxuIiwKPiA+ICsJCQkgICAgICBkcm1fZ2V0X2Zvcm1hdF9uYW1lKHN0YXRlLT5mYi0+Zm9ybWF0 LT5mb3JtYXQsCj4gPiArCQkJCQkJICAmZm9ybWF0X25hbWUpKTsKPiA+ICsJCXJldHVybiBmYWxz ZTsKPiA+ICsKPiA+ICsJZGVmYXVsdDoKPiA+ICsJCWJyZWFrOwo+ID4gKwl9Cj4gCj4gVXN1YWxs eSB0aGVyZSdzIGFuIGVtcHR5IGxpbmUgYWZ0ZXIgdGhlIGZpbmFsIHJldHVybi4KPiAKPiA+ICsJ cmV0dXJuIHRydWU7Cj4gPiArfQo+ID4gKwo+ID4gIGludCBpbnRlbF9wbGFuZV9hdG9taWNfY2hl Y2tfd2l0aF9zdGF0ZShjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqb2xkX2NydGNfc3Rh dGUsCj4gPiAgCQkJCQlzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSwKPiA+ICAJ CQkJCWNvbnN0IHN0cnVjdCBpbnRlbF9wbGFuZV9zdGF0ZSAqb2xkX3BsYW5lX3N0YXRlLAo+ID4g QEAgLTEzOCwzMCArMTY3LDggQEAgaW50IGludGVsX3BsYW5lX2F0b21pY19jaGVja193aXRoX3N0 YXRlKGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpvbGRfY3J0Y18KPiA+ICAJCWNydGNf c3RhdGUtPmJhc2UuZW5hYmxlID8gY3J0Y19zdGF0ZS0+cGlwZV9zcmNfaCA6IDA7Cj4gPiAgCj4g PiAgCWlmIChzdGF0ZS0+ZmIgJiYgZHJtX3JvdGF0aW9uXzkwX29yXzI3MChzdGF0ZS0+cm90YXRp b24pKSB7Cj4gCj4gSSdkIHB1bGwgdGhlc2UgY2hlY2tzIGludG8gdGhlIG5ldyBmdW5jdGlvbiBh cyB3ZWxsIChhcyBhbiBlYXJseQo+IHJldHVybiBzbyB0aGF0IHdlIGRvbid0IGhhdmUgdG8gbmVl ZGxlc3NseSBpbmRlbnQgdGhlIHdob2xlCj4gZnVuY3Rpb24gYm9keSkuIE90aGVyd2lzZSB0aGUg ZnVuY3Rpb24gbmFtZSBkb2Vzbid0IHJlYWxseSBtYXRjaAo+IHRoZSBpbXBsZW1lbnRhdGlvbi4K PiAKPiA+IC0JCXN0cnVjdCBkcm1fZm9ybWF0X25hbWVfYnVmIGZvcm1hdF9uYW1lOwo+ID4gLQo+ ID4gLQkJaWYgKHN0YXRlLT5mYi0+bW9kaWZpZXIgIT0gSTkxNV9GT1JNQVRfTU9EX1lfVElMRUQg JiYKPiA+IC0JCSAgICBzdGF0ZS0+ZmItPm1vZGlmaWVyICE9IEk5MTVfRk9STUFUX01PRF9ZZl9U SUxFRCkgewo+ID4gLQkJCURSTV9ERUJVR19LTVMoIlkvWWYgdGlsaW5nIHJlcXVpcmVkIGZvciA5 MC8yNzAhXG4iKTsKPiA+ICsJCWlmICghaW50ZWxfdmFsaWRfcm90YXRpb24oc3RhdGUpKQo+ID4g IAkJCXJldHVybiAtRUlOVkFMOwo+ID4gLQkJfQo+ID4gLQo+ID4gLQkJLyoKPiA+IC0JCSAqIDkw LzI3MCBpcyBub3QgYWxsb3dlZCB3aXRoIFJHQjY0IDE2OjE2OjE2OjE2LAo+ID4gLQkJICogUkdC IDE2LWJpdCA1OjY6NSwgYW5kIEluZGV4ZWQgOC1iaXQuCj4gPiAtCQkgKiBUQkQ6IEFkZCBSR0I2 NCBjYXNlIG9uY2UgaXRzIGFkZGVkIGluIHN1cHBvcnRlZCBmb3JtYXQgbGlzdC4KPiA+IC0JCSAq Lwo+ID4gLQkJc3dpdGNoIChzdGF0ZS0+ZmItPmZvcm1hdC0+Zm9ybWF0KSB7Cj4gPiAtCQljYXNl IERSTV9GT1JNQVRfQzg6Cj4gPiAtCQljYXNlIERSTV9GT1JNQVRfUkdCNTY1Ogo+ID4gLQkJCURS TV9ERUJVR19LTVMoIlVuc3VwcG9ydGVkIHBpeGVsIGZvcm1hdCAlcyBmb3IgOTAvMjcwIVxuIiwK PiA+IC0JCQkgICAgICAgICAgICAgIGRybV9nZXRfZm9ybWF0X25hbWUoc3RhdGUtPmZiLT5mb3Jt YXQtPmZvcm1hdCwKPiA+IC0JCQkgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJmZv cm1hdF9uYW1lKSk7Cj4gPiAtCQkJcmV0dXJuIC1FSU5WQUw7Cj4gPiAtCj4gPiAtCQlkZWZhdWx0 Ogo+ID4gLQkJCWJyZWFrOwo+ID4gLQkJfQo+ID4gIAl9Cj4gPiAgCj4gPiAgCS8qIENIViBpZ25v cmVzIHRoZSBtaXJyb3IgYml0IHdoZW4gdGhlIHJvdGF0ZSBiaXQgaXMgc2V0IDooICovCj4gPiAt LSAKPiA+IDIuNy40Cj4gPiAKPiA+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCj4gPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gPiBJbnRlbC1nZnhAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCj4gPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2ludGVsLWdmeAo+IAo+IC0tIAo+IFZpbGxlIFN5cmrDpGzDpAo+IEludGVs IE9UQwoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1n ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==