From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Reserve powerctx for chv from the stolen allocator
Date: Mon, 6 Nov 2017 16:43:12 +0200 [thread overview]
Message-ID: <20171106144312.GK10981@intel.com> (raw)
In-Reply-To: <150997877020.31443.547952710579042795@mail.alporthouse.com>
On Mon, Nov 06, 2017 at 02:32:50PM +0000, Chris Wilson wrote:
> Quoting Ville Syrjälä (2017-11-06 14:23:24)
> > On Sat, Nov 04, 2017 at 09:43:38PM +0000, Chris Wilson wrote:
> > > Ensure that we do not overwrite the cherryview power context by
> > > reserving its range in the stolen allocator; exactly like how we handle
> > > the same reservation for valleyview.
> >
> > IIRC CHV pctx must live inside the "reserved" region. So this
> > should never happen.
>
> It's supposed to. Otoh, the duplication for no good reason is inane.
Well, it's not really duplication because it allocates the object in a
different place. VLV wants it below the reserved region, CHV wants it
inside the reserved region. Given that the reserved region isn't part of
the mm we can't use the VLV code to allocate the pctx correctly for CHV.
> Then to complete the picture, we should be able to merge this with ilk
> powerctx, should we resurrect it.
> -Chris
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-11-06 14:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-04 21:43 [PATCH] drm/i915: Reserve powerctx for chv from the stolen allocator Chris Wilson
2017-11-04 22:02 ` ✗ Fi.CI.BAT: failure for " Patchwork
2017-11-06 14:23 ` [PATCH] " Ville Syrjälä
2017-11-06 14:32 ` Chris Wilson
2017-11-06 14:43 ` Ville Syrjälä [this message]
2017-11-06 14:50 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171106144312.GK10981@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).