From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: Prevent unbounded wm results in g4x_compute_wm() Date: Tue, 7 Nov 2017 15:55:09 +0200 Message-ID: <20171107135509.GS10981@intel.com> References: <20171107125623.26300-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 633236E088 for ; Tue, 7 Nov 2017 13:55:12 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20171107125623.26300-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBOb3YgMDcsIDIwMTcgYXQgMTI6NTY6MjNQTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IFNtYXRjaCB3YXJucyBvZgo+IAo+IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bt LmM6MTE2MSBnNHhfY29tcHV0ZV93bSgpIHdhcm46IHNpZ25lZG5lc3MgYnVnIHJldHVybmluZyAn KC0zMzU1NDQzMCknCj4gCj4gd2hpY2ggaXMgYSByZXN1bHQgb2YgaXQgYmVsaWV2aW5nIHRoYXQg d20gbWF5IGJlIElOVF9NQVggZm9sbG93aW5nCj4gZzR4X3RsYl9taXNzX3dhKCkuIEp1c3QgZGVj bGFyaW5nIGc0eF90bGJfbWlzc193YSgpIGFzIHJldHVybmluZyBhbgo+IHVuc2lnbmVkIGludGVn ZXIgaXMgbm90IHN1ZmZpY2llbnQsIHdlIG5lZWQgdG8gdGVsbCBzbWF0Y2ggdGhhdCB3bSBpdHNl bGYKPiBpcyB1bnNpZ25lZCBmb3IgaXQgdG8gbm90IHdvcnJ5LiBTbyBtYXJrIHVwIHRoZSBsb2Nh bHMgd2UgZXhwZWN0IHRvIGJlCj4gbm9uLW5lZ2F0aXZlLCBhbmQgc28gc2lsZW5jZSBzbWF0Y2gu Cj4gCj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28u dWs+Cj4gQ2M6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+ Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMgfCAxMCArKysrKy0tLS0t Cj4gIDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCj4gCj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9wbS5jCj4gaW5kZXggNmUxMzU4ZDRlNzY0Li40MDMwOTc2MDYzMjIg MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcG0uYwo+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMKPiBAQCAtOTI4LDcgKzkyOCw3IEBAIHN0YXRp YyB2b2lkIHBpbmV2aWV3X3VwZGF0ZV93bShzdHJ1Y3QgaW50ZWxfY3J0YyAqdW51c2VkX2NydGMp Cj4gICAqICBhbmQgdGhlIHNpemUgb2YgOCB3aG9sZSBsaW5lcy4gVGhpcyBhZGp1c3RtZW50IGlz IGFsd2F5cyBwZXJmb3JtZWQKPiAgICogIGluIHRoZSBhY3R1YWwgcGl4ZWwgZGVwdGggcmVnYXJk bGVzcyBvZiB3aGV0aGVyIEZCQyBpcyBlbmFibGVkIG9yIG5vdC4iCj4gICAqLwo+IC1zdGF0aWMg aW50IGc0eF90bGJfbWlzc193YShpbnQgZmlmb19zaXplLCBpbnQgd2lkdGgsIGludCBjcHApCj4g K3N0YXRpYyB1bnNpZ25lZCBpbnQgZzR4X3RsYl9taXNzX3dhKGludCBmaWZvX3NpemUsIGludCB3 aWR0aCwgaW50IGNwcCkKPiAgewo+ICAJaW50IHRsYl9taXNzID0gZmlmb19zaXplICogNjQgLSB3 aWR0aCAqIGNwcCAqIDg7CgpZZXAuIFRoaXMgc2hvdWxkIGJlIHRoZSBvbmx5IHBhcnQgd2hlcmUg d2UgZGVwZW5kIG9uIHNpZ25lZCBtYXRoLApzbyB0aGUgcGF0Y2ggbGd0bS4KClJldmlld2VkLWJ5 OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgoKSSdkIGxp a2UgdG8gc2VlIHRoZSB2bHYgY29kZSBjaGFuZ2VkIGluIHRoZSBzYW1lIHdheSB0aG91Z2gsCmZv ciBjb25zaXN0ZW5jeS4KCj4gIAo+IEBAIC0xMTA1LDggKzExMDUsOCBAQCBzdGF0aWMgdWludDE2 X3QgZzR4X2NvbXB1dGVfd20oY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3Rh dGUsCj4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KHBsYW5l LT5iYXNlLmRldik7Cj4gIAljb25zdCBzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqYWRqdXN0ZWRf bW9kZSA9Cj4gIAkJJmNydGNfc3RhdGUtPmJhc2UuYWRqdXN0ZWRfbW9kZTsKPiAtCWludCBjbG9j aywgaHRvdGFsLCBjcHAsIHdpZHRoLCB3bTsKPiAtCWludCBsYXRlbmN5ID0gZGV2X3ByaXYtPndt LnByaV9sYXRlbmN5W2xldmVsXSAqIDEwOwo+ICsJdW5zaWduZWQgaW50IGxhdGVuY3kgPSBkZXZf cHJpdi0+d20ucHJpX2xhdGVuY3lbbGV2ZWxdICogMTA7Cj4gKwl1bnNpZ25lZCBpbnQgY2xvY2ss IGh0b3RhbCwgY3BwLCB3aWR0aCwgd207Cj4gIAo+ICAJaWYgKGxhdGVuY3kgPT0gMCkKPiAgCQly ZXR1cm4gVVNIUlRfTUFYOwo+IEBAIC0xMTQ1LDcgKzExNDUsNyBAQCBzdGF0aWMgdWludDE2X3Qg ZzR4X2NvbXB1dGVfd20oY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUs Cj4gIAkJICAgbGV2ZWwgPT0gRzRYX1dNX0xFVkVMX05PUk1BTCkgewo+ICAJCXdtID0gaW50ZWxf d21fbWV0aG9kMShjbG9jaywgY3BwLCBsYXRlbmN5KTsKPiAgCX0gZWxzZSB7Cj4gLQkJaW50IHNt YWxsLCBsYXJnZTsKPiArCQl1bnNpZ25lZCBpbnQgc21hbGwsIGxhcmdlOwo+ICAKPiAgCQlzbWFs bCA9IGludGVsX3dtX21ldGhvZDEoY2xvY2ssIGNwcCwgbGF0ZW5jeSk7Cj4gIAkJbGFyZ2UgPSBp bnRlbF93bV9tZXRob2QyKGNsb2NrLCBodG90YWwsIHdpZHRoLCBjcHAsIGxhdGVuY3kpOwo+IEBA IC0xMTU4LDcgKzExNTgsNyBAQCBzdGF0aWMgdWludDE2X3QgZzR4X2NvbXB1dGVfd20oY29uc3Qg c3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUsCj4gIAo+ICAJd20gPSBESVZfUk9V TkRfVVAod20sIDY0KSArIDI7Cj4gIAo+IC0JcmV0dXJuIG1pbl90KGludCwgd20sIFVTSFJUX01B WCk7Cj4gKwlyZXR1cm4gbWluX3QodW5zaWduZWQgaW50LCB3bSwgVVNIUlRfTUFYKTsKPiAgfQo+ ICAKPiAgc3RhdGljIGJvb2wgZzR4X3Jhd19wbGFuZV93bV9zZXQoc3RydWN0IGludGVsX2NydGNf c3RhdGUgKmNydGNfc3RhdGUsCj4gLS0gCj4gMi4xNS4wCgotLSAKVmlsbGUgU3lyasOkbMOkCklu dGVsIE9UQwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK