From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] HAX: WARN_ON(crtc->crc.opened during disable)
Date: Wed, 8 Nov 2017 13:20:48 +0200 [thread overview]
Message-ID: <20171108112048.GU10981@intel.com> (raw)
In-Reply-To: <20171108111130.44197-1-maarten.lankhorst@linux.intel.com>
On Wed, Nov 08, 2017 at 12:11:30PM +0100, Maarten Lankhorst wrote:
> ---
> drivers/gpu/drm/i915/intel_display.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 39d1f30cd0c4..436374b08b69 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -12176,6 +12176,7 @@ static void intel_atomic_commit_tail(struct drm_atomic_state *state)
>
> if (old_crtc_state->active) {
> intel_crtc_disable_planes(crtc, old_crtc_state->plane_mask);
> + WARN_ON(crtc->crc.opened);
Why? I actually want to keep crc capture alive across a modeset to be
able to observe every crc coming out of the hardware. Without that there
is no good way to figure out which crcs are good and which are bad.
> dev_priv->display.crtc_disable(to_intel_crtc_state(old_crtc_state), state);
> intel_crtc->active = false;
> intel_fbc_disable(intel_crtc);
> --
> 2.15.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-11-08 11:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-08 11:11 [PATCH] HAX: WARN_ON(crtc->crc.opened during disable) Maarten Lankhorst
2017-11-08 11:20 ` Ville Syrjälä [this message]
2017-11-08 13:06 ` Jani Nikula
2017-11-08 14:59 ` Chris Wilson
2017-11-08 15:27 ` Jani Nikula
2017-11-08 15:38 ` Tomi Sarvela
2017-11-08 15:59 ` Jani Nikula
2017-11-08 16:15 ` Martin Peres
2017-11-09 9:09 ` Jani Nikula
2017-11-09 8:39 ` Tomi Sarvela
2017-11-08 14:39 ` ✗ Fi.CI.BAT: warning for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171108112048.GU10981@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox