From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>,
Tomi Sarvela <tomi.p.sarvela@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Remove support for legacy debugfs crc interface
Date: Wed, 8 Nov 2017 13:25:59 +0200 [thread overview]
Message-ID: <20171108112559.GW10981@intel.com> (raw)
In-Reply-To: <44a16936-9b52-0901-76f2-f9197ae187e2@linux.intel.com>
On Wed, Nov 08, 2017 at 11:40:19AM +0100, Maarten Lankhorst wrote:
> Op 02-11-17 om 17:11 schreef Ville Syrjälä:
> > On Thu, Nov 02, 2017 at 05:19:07PM +0200, Jani Nikula wrote:
> >> On Thu, 02 Nov 2017, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> >>> On Thu, Nov 02, 2017 at 02:56:51PM +0100, Maarten Lankhorst wrote:
> >>>> This interface is deprecated, and has been replaced by the upstream
> >>>> drm crc interface.
> >>> Before we nuke this I would like to see an option in the new interface
> >>> to not filter out the "bad" CRCs. When analyzing how the hardware
> >>> behaves seeing every CRC can be valuable. And I'm not at all convinced
> >>> we should be dropping as many CRCs as we are currently.
> >> I'm not against it, but do you have a concrete proposal on how that
> >> option would look like?
> > Some kind of of filter_bad_crcs file with a bool value perhaps?
>
> You can set sources, might as well add a nofilter option.. But I don't see what it has to do
> with this patch? This problem existed since before the api was introduced.. Only difference
> is kernel eats possibly corrupt CRCs now instead of IGT.
I don't use igt for this.
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-11-08 11:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 13:56 [PATCH] drm/i915: Remove support for legacy debugfs crc interface Maarten Lankhorst
2017-11-02 14:27 ` Ville Syrjälä
2017-11-02 15:19 ` Jani Nikula
2017-11-02 16:11 ` Ville Syrjälä
2017-11-08 10:40 ` Maarten Lankhorst
2017-11-08 11:25 ` Ville Syrjälä [this message]
2017-11-21 10:39 ` Maarten Lankhorst
2017-11-21 14:07 ` Ville Syrjälä
2017-11-02 14:46 ` ✗ Fi.CI.BAT: warning for " Patchwork
2017-11-21 11:51 ` Patchwork
-- strict thread matches above, loose matches on Subject: below --
2018-03-08 18:34 [PATCH] " Maarten Lankhorst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171108112559.GW10981@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=tomi.p.sarvela@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox