From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: sync dp link status checks against atomic commmits Date: Wed, 8 Nov 2017 15:04:58 +0200 Message-ID: <20171108130458.GA10981@intel.com> References: <20171108105450.20339-2-daniel.vetter@ffwll.ch> <20171108125750.1663-1-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20171108125750.1663-1-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: Daniel Vetter , Intel Graphics Development , DRI Development List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBOb3YgMDgsIDIwMTcgYXQgMDE6NTc6NTBQTSArMDEwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBUd28gYml0czoKPiAtIGNoZWNrIGFjdHVhbCBhdG9taWMgc3RhdGUsIHRoZSBsZWdh Y3kgc3R1ZmYgY2FuIG9ubHkgYmUgbG9va2VkIGF0Cj4gICBmcm9tIHdpdGhpbiB0aGUgYXRvbWlj X2NvbW1pdF90YWlsIGZ1bmN0aW9uLCBzaW5jZSBpdCdzIG9ubHkKPiAgIHByb3RlY3RlZCBieSBv cmRlcmluZyBhbmQgbm90IGJ5IGFueSBsb2Nrcy4KPiAKPiAtIE1ha2Ugc3VyZSB3ZSBkb24ndCB3 cmVhayB0aGUgd29yayBhbiBvbmdvaW5nIG5vbmJsb2NraW5nIGNvbW1pdCBpcwo+ICAgZG9pbmcu CgpJIHN0aWxsIHRoaW5rIHdlIG5lZWQgdG8gbW92ZSB0aGUgcmV0cmFpbmluZyB0byB0aGUgaG90 cGx1ZyB3b3JrLgoKPiAKPiB2MjogV2UgbmVlZCB0aGUgY3J0YyBsb2NrIHRvbywgYmVjYXVzZSBh IHBsYW5lIHVwZGF0ZSBtaWdodCBjaGFuZ2UgaXQKPiB3aXRob3V0IGhhdmluZyB0byBhY3F1aXJl IHRoZSBjb25uZWN0aW9uX211dGV4IChNYWFydGVuKS4gVXNlCj4gTWFhcnRlbidzIGNoYW5nZXMg Zm9yIHRoaXMgbG9ja2luZywgd2hpbGUga2VlcGluZyB0aGUgbG9naWMgdGhhdCB1c2VzCj4gdGhl IGNvbm5lY3Rpb24tPmNvbW1pdC0+aHdfZG9uZSBzaWduYWwgZm9yIHN5bmNpbmcgd2l0aCBub25i bG9ja2luZwo+IGNvbW1pdHMuCj4gCj4gQ2M6IE1hbmFzaSBOYXZhcmUgPG1hbmFzaS5kLm5hdmFy ZUBpbnRlbC5jb20+Cj4gQ2M6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBs aW51eC5pbnRlbC5jb20+Cj4gQ2M6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51 eC5pbnRlbC5jb20+Cj4gUmVmZXJlbmNlczogaHR0cHM6Ly9idWdzLmZyZWVkZXNrdG9wLm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTAzMzM2Cj4gQnVnemlsbGE6IGh0dHBzOi8vYnVncy5mcmVlZGVza3Rv cC5vcmcvc2hvd19idWcuY2dpP2lkPTk5MjcyCj4gU2lnbmVkLW9mZi1ieTogRGFuaWVsIFZldHRl ciA8ZGFuaWVsLnZldHRlckBpbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2RwLmMgfCA1NiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0t LQo+ICAxIGZpbGUgY2hhbmdlZCwgNTAgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKPiAK PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiBpbmRleCBkMjdjMDE0NWFjOTEuLjdjZDdhYjRmYjQz MSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+IEBAIC00MzE5LDYgKzQzMTksOCBAQCBz dGF0aWMgdm9pZAo+ICBpbnRlbF9kcF9jaGVja19saW5rX3N0YXR1cyhzdHJ1Y3QgaW50ZWxfZHAg KmludGVsX2RwKQo+ICB7Cj4gIAlzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqaW50ZWxfZW5jb2RlciA9 ICZkcF90b19kaWdfcG9ydChpbnRlbF9kcCktPmJhc2U7Cj4gKwlzdHJ1Y3QgZHJtX2Nvbm5lY3Rv cl9zdGF0ZSAqY29ubl9zdGF0ZSA9Cj4gKwkJaW50ZWxfZHAtPmF0dGFjaGVkX2Nvbm5lY3Rvci0+ YmFzZS5zdGF0ZTsKPiAgCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBpbnRlbF9kcF90b19kZXYo aW50ZWxfZHApOwo+ICAJdTggbGlua19zdGF0dXNbRFBfTElOS19TVEFUVVNfU0laRV07Cj4gIAo+ IEBAIC00MzI5LDEwICs0MzMxLDE1IEBAIGludGVsX2RwX2NoZWNrX2xpbmtfc3RhdHVzKHN0cnVj dCBpbnRlbF9kcCAqaW50ZWxfZHApCj4gIAkJcmV0dXJuOwo+ICAJfQo+ICAKPiAtCWlmICghaW50 ZWxfZW5jb2Rlci0+YmFzZS5jcnRjKQo+ICsJaWYgKCFjb25uX3N0YXRlLT5jcnRjKQo+ICAJCXJl dHVybjsKPiAgCj4gLQlpZiAoIXRvX2ludGVsX2NydGMoaW50ZWxfZW5jb2Rlci0+YmFzZS5jcnRj KS0+YWN0aXZlKQo+ICsJV0FSTl9PTighZHJtX21vZGVzZXRfaXNfbG9ja2VkKCZjb25uX3N0YXRl LT5jcnRjLT5tdXRleCkpOwo+ICsKPiArCWlmICghY29ubl9zdGF0ZS0+Y3J0Yy0+c3RhdGUtPmFj dGl2ZSkKPiArCQlyZXR1cm47Cj4gKwo+ICsJaWYgKCF0cnlfd2FpdF9mb3JfY29tcGxldGlvbigm Y29ubl9zdGF0ZS0+Y29tbWl0LT5od19kb25lKSkKPiAgCQlyZXR1cm47Cj4gIAo+ICAJLyoKPiBA QCAtNDM2OCw3ICs0Mzc1LDYgQEAgaW50ZWxfZHBfY2hlY2tfbGlua19zdGF0dXMoc3RydWN0IGlu dGVsX2RwICppbnRlbF9kcCkKPiAgc3RhdGljIGJvb2wKPiAgaW50ZWxfZHBfc2hvcnRfcHVsc2Uo c3RydWN0IGludGVsX2RwICppbnRlbF9kcCkKPiAgewo+IC0Jc3RydWN0IGRybV9kZXZpY2UgKmRl diA9IGludGVsX2RwX3RvX2RldihpbnRlbF9kcCk7Cj4gIAlzdHJ1Y3QgaW50ZWxfZW5jb2RlciAq aW50ZWxfZW5jb2RlciA9ICZkcF90b19kaWdfcG9ydChpbnRlbF9kcCktPmJhc2U7Cj4gIAl1OCBz aW5rX2lycV92ZWN0b3IgPSAwOwo+ICAJdTggb2xkX3NpbmtfY291bnQgPSBpbnRlbF9kcC0+c2lu a19jb3VudDsKPiBAQCAtNDQwOCw5ICs0NDE0LDggQEAgaW50ZWxfZHBfc2hvcnRfcHVsc2Uoc3Ry dWN0IGludGVsX2RwICppbnRlbF9kcCkKPiAgCQkJRFJNX0RFQlVHX0RSSVZFUigiQ1Agb3Igc2lu ayBzcGVjaWZpYyBpcnEgdW5oYW5kbGVkXG4iKTsKPiAgCX0KPiAgCj4gLQlkcm1fbW9kZXNldF9s b2NrKCZkZXYtPm1vZGVfY29uZmlnLmNvbm5lY3Rpb25fbXV0ZXgsIE5VTEwpOwo+ICAJaW50ZWxf ZHBfY2hlY2tfbGlua19zdGF0dXMoaW50ZWxfZHApOwo+IC0JZHJtX21vZGVzZXRfdW5sb2NrKCZk ZXYtPm1vZGVfY29uZmlnLmNvbm5lY3Rpb25fbXV0ZXgpOwo+ICsKPiAgCWlmIChpbnRlbF9kcC0+ Y29tcGxpYW5jZS50ZXN0X3R5cGUgPT0gRFBfVEVTVF9MSU5LX1RSQUlOSU5HKSB7Cj4gIAkJRFJN X0RFQlVHX0tNUygiTGluayBUcmFpbmluZyBDb21wbGlhbmNlIFRlc3QgcmVxdWVzdGVkXG4iKTsK PiAgCQkvKiBTZW5kIGEgSG90cGx1ZyBVZXZlbnQgdG8gdXNlcnNwYWNlIHRvIHN0YXJ0IG1vZGVz ZXQgKi8KPiBAQCAtNDg2MCw4ICs0ODY1LDE5IEBAIGludGVsX2RwX2RldGVjdChzdHJ1Y3QgZHJt X2Nvbm5lY3RvciAqY29ubmVjdG9yLAo+ICAJCSAgICAgIGNvbm5lY3Rvci0+YmFzZS5pZCwgY29u bmVjdG9yLT5uYW1lKTsKPiAgCj4gIAkvKiBJZiBmdWxsIGRldGVjdCBpcyBub3QgcGVyZm9ybWVk IHlldCwgZG8gYSBmdWxsIGRldGVjdCAqLwo+IC0JaWYgKCFpbnRlbF9kcC0+ZGV0ZWN0X2RvbmUp Cj4gKwlpZiAoIWludGVsX2RwLT5kZXRlY3RfZG9uZSkgewo+ICsJCXN0cnVjdCBkcm1fY3J0YyAq Y3J0YzsKPiArCQlpbnQgcmV0Owo+ICsKPiArCQljcnRjID0gY29ubmVjdG9yLT5zdGF0ZS0+Y3J0 YzsKPiArCQlpZiAoY3J0Yykgewo+ICsJCQlyZXQgPSBkcm1fbW9kZXNldF9sb2NrKCZjcnRjLT5t dXRleCwgY3R4KTsKPiArCQkJaWYgKHJldCkKPiArCQkJCXJldHVybiByZXQ7Cj4gKwkJfQo+ICsK PiAgCQlzdGF0dXMgPSBpbnRlbF9kcF9sb25nX3B1bHNlKGludGVsX2RwLT5hdHRhY2hlZF9jb25u ZWN0b3IpOwo+ICsJfQo+ICAKPiAgCWludGVsX2RwLT5kZXRlY3RfZG9uZSA9IGZhbHNlOwo+ICAK PiBAQCAtNTE0NiwxMCArNTE2MiwzOCBAQCBpbnRlbF9kcF9ocGRfcHVsc2Uoc3RydWN0IGludGVs X2RpZ2l0YWxfcG9ydCAqaW50ZWxfZGlnX3BvcnQsIGJvb2wgbG9uZ19ocGQpCj4gIAl9Cj4gIAo+ ICAJaWYgKCFpbnRlbF9kcC0+aXNfbXN0KSB7Cj4gKwkJc3RydWN0IGRybV9tb2Rlc2V0X2FjcXVp cmVfY3R4IGN0eDsKPiArCQlzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yID0gJmludGVs X2RwLT5hdHRhY2hlZF9jb25uZWN0b3ItPmJhc2U7Cj4gKwkJc3RydWN0IGRybV9jcnRjICpjcnRj Owo+ICsJCWludCBpcmV0Owo+ICsKPiArCQlkcm1fbW9kZXNldF9hY3F1aXJlX2luaXQoJmN0eCwg MCk7Cj4gK3JldHJ5Ogo+ICsJCWlyZXQgPSBkcm1fbW9kZXNldF9sb2NrKCZkZXYtPm1vZGVfY29u ZmlnLmNvbm5lY3Rpb25fbXV0ZXgsICZjdHgpOwo+ICsJCWlmIChpcmV0KQo+ICsJCQlnb3RvIGVy cjsKPiArCj4gKwkJY3J0YyA9IGNvbm5lY3Rvci0+c3RhdGUtPmNydGM7Cj4gKwkJaWYgKGNydGMp IHsKPiArCQkJaXJldCA9IGRybV9tb2Rlc2V0X2xvY2soJmNydGMtPm11dGV4LCAmY3R4KTsKPiAr CQkJaWYgKGlyZXQpCj4gKwkJCQlnb3RvIGVycjsKPiArCQl9Cj4gKwo+ICAJCWlmICghaW50ZWxf ZHBfc2hvcnRfcHVsc2UoaW50ZWxfZHApKSB7Cj4gIAkJCWludGVsX2RwLT5kZXRlY3RfZG9uZSA9 IGZhbHNlOwo+ICAJCQlnb3RvIHB1dF9wb3dlcjsKPiAgCQl9Cj4gKwo+ICtlcnI6Cj4gKwkJaWYg KGlyZXQgPT0gLUVERUFETEspIHsKPiArCQkJZHJtX21vZGVzZXRfYmFja29mZigmY3R4KTsKPiAr CQkJZ290byByZXRyeTsKPiArCQl9Cj4gKwo+ICsJCWRybV9tb2Rlc2V0X2Ryb3BfbG9ja3MoJmN0 eCk7Cj4gKwkJZHJtX21vZGVzZXRfYWNxdWlyZV9maW5pKCZjdHgpOwo+ICsJCVdBUk4oaXJldCwg IkFjcXVpcmluZyBtb2Rlc2V0IGxvY2tzIGZhaWxlZCB3aXRoICVpXG4iLCBpcmV0KTsKPiAgCX0K PiAgCj4gIAlyZXQgPSBJUlFfSEFORExFRDsKPiAtLSAKPiAyLjE1LjAKCi0tIApWaWxsZSBTeXJq w6Rsw6QKSW50ZWwgT1RDCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVs LWdmeAo=