From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v2 2/6] drm/i915: Handle adjust better in intel_pipe_config_compare Date: Thu, 9 Nov 2017 19:04:50 +0200 Message-ID: <20171109170450.GU10981@intel.com> References: <20171109162458.50681-1-maarten.lankhorst@linux.intel.com> <20171109162458.50681-2-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 562686E935 for ; Thu, 9 Nov 2017 17:05:04 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20171109162458.50681-2-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBOb3YgMDksIDIwMTcgYXQgMDU6MjQ6NTRQTSArMDEwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gU29tZSBwYXJhbWV0ZXJzIHVzZSBDSEVDS19JLCBidXQgc2hvdWxkIHJlYWxs eSB1c2UgQ0hFQ0tfQk9PTC4KPiBDb252ZXJ0IGFsbCBib29vbHMgdG8gdXNlIENIRUNLX0JPT0ws IGFuZCBhbHNvIGNyZWF0ZSBhCj4gQ0hFQ0tfQk9PTF9JTkNPTVBMRVRFIGZvciBoYXNfYXVkaW8g YW5kIGhhc19pbmZvZnJhbWUsIHdlCj4gY2Fubm90IGN1cnJlbnRseSBjaGVjayB3aGV0aGVyIHRo ZSBpbmhlcml0ZWQgaW5mb2ZyYW1lcyBhbmQKPiBhdWRpbyBhcmUgc2V0IHVwIGNvcnJlY3RseS4K Ck1heWJlIHNwbGl0IHRoZSByZWd1bGFyIEJPT0wgdGhpbmsgaW50byBwcmVwIHBhdGNoIHNvIHRo YXQgd2UgZG9uJ3QKaW50cm9kdWNlIGZ1bmN0aW9uYWwgY2hhbmdlcyB3aXRoIGl0PwoKPiAKPiBB bHNvIGRvIG5vdCBjaGVjayBpcHNfZW5hYmxlZCwgaXQgd2lsbCBub3QgYmUgZW5hYmxlZCBpZiB0 aGUKPiBwcmltYXJ5IHBsYW5lIGlzbid0LiBJdCdzIG9ubHkgYSBmbGFnIGluZGljYXRpbmcgSVBT IGNhbiBiZQo+IGVuYWJsZWQuIFRoaXMgd2FzIGFjdHVhbGx5IGNhdXNpbmcgYSBmYWlsdXJlIG9u IGYyLWhzdy00MDEwdQo+IHdpdGgga21zX2F0b21pY190cmFuc2l0aW9ucy4KPiAKPiBTaWduZWQt b2ZmLWJ5OiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwu Y29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCA0OSAr KysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDM1 IGluc2VydGlvbnMoKyksIDE0IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9kaXNwbGF5LmMKPiBpbmRleCAxNzY2NWVlMDZjOWEuLmY1OTMzYjA3MTljOSAxMDA2NDQKPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBAQCAtMTEwNzYsNiArMTEwNzYsOSBAQCBp bnRlbF9waXBlX2NvbmZpZ19jb21wYXJlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp diwKPiAgCQkJICBib29sIGFkanVzdCkKPiAgewo+ICAJYm9vbCByZXQgPSB0cnVlOwo+ICsJYm9v bCBmaXh1cF9pbmhlcml0ZWQgPSBhZGp1c3QgJiYKPiArCQkoY3VycmVudF9jb25maWctPmJhc2Uu bW9kZS5wcml2YXRlX2ZsYWdzICYgSTkxNV9NT0RFX0ZMQUdfSU5IRVJJVEVEKSAmJgo+ICsJCSEo cGlwZV9jb25maWctPmJhc2UubW9kZS5wcml2YXRlX2ZsYWdzICYgSTkxNV9NT0RFX0ZMQUdfSU5I RVJJVEVEKTsKPiAgCj4gICNkZWZpbmUgUElQRV9DT05GX0NIRUNLX1gobmFtZSkJXAo+ICAJaWYg KGN1cnJlbnRfY29uZmlnLT5uYW1lICE9IHBpcGVfY29uZmlnLT5uYW1lKSB7IFwKPiBAQCAtMTEw OTUsNiArMTEwOTgsMjYgQEAgaW50ZWxfcGlwZV9jb25maWdfY29tcGFyZShzdHJ1Y3QgZHJtX2k5 MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAkJcmV0ID0gZmFsc2U7IFwKPiAgCX0KPiAgCj4gKyNk ZWZpbmUgUElQRV9DT05GX0NIRUNLX0JPT0wobmFtZSkJXAo+ICsJaWYgKGN1cnJlbnRfY29uZmln LT5uYW1lICE9IHBpcGVfY29uZmlnLT5uYW1lKSB7IFwKPiArCQlwaXBlX2NvbmZpZ19lcnIoYWRq dXN0LCBfX3N0cmluZ2lmeShuYW1lKSwgXAo+ICsJCQkgICIoZXhwZWN0ZWQgJXMsIGZvdW5kICVz KVxuIiwgXAo+ICsJCQkgIHllc25vKGN1cnJlbnRfY29uZmlnLT5uYW1lKSwgXAo+ICsJCQkgIHll c25vKHBpcGVfY29uZmlnLT5uYW1lKSk7IFwKPiArCQlyZXQgPSBmYWxzZTsgXAo+ICsJfQo+ICsK PiArI2RlZmluZSBQSVBFX0NPTkZfQ0hFQ0tfQk9PTF9JTkNPTVBMRVRFKG5hbWUpIFwKPiArCWlm ICghZml4dXBfaW5oZXJpdGVkIHx8ICghY3VycmVudF9jb25maWctPm5hbWUgJiYgIXBpcGVfY29u ZmlnLT5uYW1lKSkgeyBcCj4gKwkJUElQRV9DT05GX0NIRUNLX0JPT0wobmFtZSk7IFwKPiArCX0g ZWxzZSB7IFwKPiArCQlwaXBlX2NvbmZpZ19lcnIoYWRqdXN0LCBfX3N0cmluZ2lmeShuYW1lKSwg XAo+ICsJCQkgICJ1bmFibGUgdG8gdmVyaWZ5IHdoZXRoZXIgc3RhdGUgbWF0Y2hlcyBleGFjdGx5 LCBmb3JjaW5nIG1vZGVzZXQgKGV4cGVjdGVkICVzLCBmb3VuZCAlcylcbiIsIFwKPiArCQkJICB5 ZXNubyhjdXJyZW50X2NvbmZpZy0+bmFtZSksIFwKPiArCQkJICB5ZXNubyhwaXBlX2NvbmZpZy0+ bmFtZSkpOyBcCj4gKwkJcmV0ID0gZmFsc2U7IFwKPiArCX0KPiArCj4gICNkZWZpbmUgUElQRV9D T05GX0NIRUNLX1AobmFtZSkJXAo+ICAJaWYgKGN1cnJlbnRfY29uZmlnLT5uYW1lICE9IHBpcGVf Y29uZmlnLT5uYW1lKSB7IFwKPiAgCQlwaXBlX2NvbmZpZ19lcnIoYWRqdXN0LCBfX3N0cmluZ2lm eShuYW1lKSwgXAo+IEBAIC0xMTE4MCw3ICsxMTIwMyw3IEBAIGludGVsX3BpcGVfY29uZmlnX2Nv bXBhcmUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAKPiAgCVBJUEVfQ09O Rl9DSEVDS19JKGNwdV90cmFuc2NvZGVyKTsKPiAgCj4gLQlQSVBFX0NPTkZfQ0hFQ0tfSShoYXNf cGNoX2VuY29kZXIpOwo+ICsJUElQRV9DT05GX0NIRUNLX0JPT0woaGFzX3BjaF9lbmNvZGVyKTsK PiAgCVBJUEVfQ09ORl9DSEVDS19JKGZkaV9sYW5lcyk7Cj4gIAlQSVBFX0NPTkZfQ0hFQ0tfTV9O KGZkaV9tX24pOwo+ICAKPiBAQCAtMTEyMTIsMTcgKzExMjM1LDE3IEBAIGludGVsX3BpcGVfY29u ZmlnX2NvbXBhcmUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAJUElQRV9D T05GX0NIRUNLX0koYmFzZS5hZGp1c3RlZF9tb2RlLmNydGNfdnN5bmNfZW5kKTsKPiAgCj4gIAlQ SVBFX0NPTkZfQ0hFQ0tfSShwaXhlbF9tdWx0aXBsaWVyKTsKPiAtCVBJUEVfQ09ORl9DSEVDS19J KGhhc19oZG1pX3NpbmspOwo+ICsJUElQRV9DT05GX0NIRUNLX0JPT0woaGFzX2hkbWlfc2luayk7 Cj4gIAlpZiAoKElOVEVMX0dFTihkZXZfcHJpdikgPCA4ICYmICFJU19IQVNXRUxMKGRldl9wcml2 KSkgfHwKPiAgCSAgICBJU19WQUxMRVlWSUVXKGRldl9wcml2KSB8fCBJU19DSEVSUllWSUVXKGRl dl9wcml2KSkKPiAtCQlQSVBFX0NPTkZfQ0hFQ0tfSShsaW1pdGVkX2NvbG9yX3JhbmdlKTsKPiAr CQlQSVBFX0NPTkZfQ0hFQ0tfQk9PTChsaW1pdGVkX2NvbG9yX3JhbmdlKTsKPiAgCj4gLQlQSVBF X0NPTkZfQ0hFQ0tfSShoZG1pX3NjcmFtYmxpbmcpOwo+IC0JUElQRV9DT05GX0NIRUNLX0koaGRt aV9oaWdoX3RtZHNfY2xvY2tfcmF0aW8pOwo+IC0JUElQRV9DT05GX0NIRUNLX0koaGFzX2luZm9m cmFtZSk7Cj4gLQlQSVBFX0NPTkZfQ0hFQ0tfSSh5Y2JjcjQyMCk7Cj4gKwlQSVBFX0NPTkZfQ0hF Q0tfQk9PTChoZG1pX3NjcmFtYmxpbmcpOwo+ICsJUElQRV9DT05GX0NIRUNLX0JPT0woaGRtaV9o aWdoX3RtZHNfY2xvY2tfcmF0aW8pOwo+ICsJUElQRV9DT05GX0NIRUNLX0JPT0xfSU5DT01QTEVU RShoYXNfaW5mb2ZyYW1lKTsKPiArCVBJUEVfQ09ORl9DSEVDS19CT09MKHljYmNyNDIwKTsKPiAg Cj4gLQlQSVBFX0NPTkZfQ0hFQ0tfSShoYXNfYXVkaW8pOwo+ICsJUElQRV9DT05GX0NIRUNLX0JP T0xfSU5DT01QTEVURShoYXNfYXVkaW8pOwo+ICAKPiAgCVBJUEVfQ09ORl9DSEVDS19GTEFHUyhi YXNlLmFkanVzdGVkX21vZGUuZmxhZ3MsCj4gIAkJCSAgICAgIERSTV9NT0RFX0ZMQUdfSU5URVJM QUNFKTsKPiBAQCAtMTEyNDgsNyArMTEyNzEsNyBAQCBpbnRlbF9waXBlX2NvbmZpZ19jb21wYXJl KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCQlQSVBFX0NPTkZfQ0hFQ0tf SShwaXBlX3NyY193KTsKPiAgCQlQSVBFX0NPTkZfQ0hFQ0tfSShwaXBlX3NyY19oKTsKPiAgCj4g LQkJUElQRV9DT05GX0NIRUNLX0kocGNoX3BmaXQuZW5hYmxlZCk7Cj4gKwkJUElQRV9DT05GX0NI RUNLX0JPT0wocGNoX3BmaXQuZW5hYmxlZCk7Cj4gIAkJaWYgKGN1cnJlbnRfY29uZmlnLT5wY2hf cGZpdC5lbmFibGVkKSB7Cj4gIAkJCVBJUEVfQ09ORl9DSEVDS19YKHBjaF9wZml0LnBvcyk7Cj4g IAkJCVBJUEVfQ09ORl9DSEVDS19YKHBjaF9wZml0LnNpemUpOwo+IEBAIC0xMTI1OCwxMSArMTEy ODEsNyBAQCBpbnRlbF9waXBlX2NvbmZpZ19jb21wYXJlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICpkZXZfcHJpdiwKPiAgCQlQSVBFX0NPTkZfQ0hFQ0tfQ0xPQ0tfRlVaWlkocGl4ZWxfcmF0ZSk7 Cj4gIAl9Cj4gIAo+IC0JLyogQkRXKyBkb24ndCBleHBvc2UgYSBzeW5jaHJvbm91cyB3YXkgdG8g cmVhZCB0aGUgc3RhdGUgKi8KPiAtCWlmIChJU19IQVNXRUxMKGRldl9wcml2KSkKPiAtCQlQSVBF X0NPTkZfQ0hFQ0tfSShpcHNfZW5hYmxlZCk7Cj4gLQo+IC0JUElQRV9DT05GX0NIRUNLX0koZG91 YmxlX3dpZGUpOwo+ICsJUElQRV9DT05GX0NIRUNLX0JPT0woZG91YmxlX3dpZGUpOwo+ICAKPiAg CVBJUEVfQ09ORl9DSEVDS19QKHNoYXJlZF9kcGxsKTsKPiAgCVBJUEVfQ09ORl9DSEVDS19YKGRw bGxfaHdfc3RhdGUuZHBsbCk7Cj4gQEAgLTExMzAwLDYgKzExMzE5LDggQEAgaW50ZWxfcGlwZV9j b25maWdfY29tcGFyZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAo+ICAj dW5kZWYgUElQRV9DT05GX0NIRUNLX1gKPiAgI3VuZGVmIFBJUEVfQ09ORl9DSEVDS19JCj4gKyN1 bmRlZiBQSVBFX0NPTkZfQ0hFQ0tfQk9PTAo+ICsjdW5kZWYgUElQRV9DT05GX0NIRUNLX0JPT0xf SU5DT01QTEVURQo+ICAjdW5kZWYgUElQRV9DT05GX0NIRUNLX1AKPiAgI3VuZGVmIFBJUEVfQ09O Rl9DSEVDS19GTEFHUwo+ICAjdW5kZWYgUElQRV9DT05GX0NIRUNLX0NMT0NLX0ZVWlpZCj4gLS0g Cj4gMi4xNS4wCj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v aW50ZWwtZ2Z4CgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0Cklu dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK