From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH v3 09/11] drm/i915: Handle ips_enabled in
 fastset, v2.
Date: Fri, 10 Nov 2017 22:06:30 +0200
Message-ID: <20171110200630.GH10981@intel.com>
References: <20171110113503.16253-1-maarten.lankhorst@linux.intel.com>
 <20171110113503.16253-9-maarten.lankhorst@linux.intel.com>
 <20171110131504.lw4agtg6nyptpciy@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 9DD936EB48
 for <intel-gfx@lists.freedesktop.org>; Fri, 10 Nov 2017 20:06:34 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20171110131504.lw4agtg6nyptpciy@phenom.ffwll.local>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gRnJpLCBOb3YgMTAsIDIwMTcgYXQgMDI6MTU6MDRQTSArMDEwMCwgRGFuaWVsIFZldHRlciB3
cm90ZToKPiBPbiBGcmksIE5vdiAxMCwgMjAxNyBhdCAxMjozNTowMVBNICswMTAwLCBNYWFydGVu
IExhbmtob3JzdCB3cm90ZToKPiA+IHByZV9wbGFuZV9kaXNhYmxlIGFuZCBwb3N0X3BsYW5lX2Vu
YWJsZSBoYW5kbGUgc2V0IGlwcyBjb3JyZWN0bHksCj4gPiBidXQgaWYgdGhlcmUgaXMgbm8gbW9k
ZXNldCBhbmQgdGhlIGlwc19lbmFibGVkIHZhbHVlIGNoYW5nZXMKPiA+IGJlY2F1c2Ugb2YgZm9y
Y2UgZGlzYWJsaW5nIGZvciBjcmMsIG9yIGh3IHN0YXRlIHJlYWRvdXQsIHRoZW4gd2UKPiA+IGRv
bid0IHRvZ2dsZSBpcHMgY29ycmVjdGx5LiBIYW5kbGUgdGhpcyBzcGVjaWFsIGNhc2UsIHdoaWNo
IHByZXZlbnRzCj4gPiB1cyBmcm9tIGhhdmluZyB0byBkbyBhIGZ1bGwgbW9kZXNldCB3aGVuIGNv
bGxlY3RpbmcgcGlwZSBjcmMuCj4gPiAKPiA+IENoYW5nZXMgc2luY2UgdjE6Cj4gPiAtIFNpbXBs
aWZ5IGNvbmRpdGlvbnMuCj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IE1hYXJ0ZW4gTGFua2hvcnN0
IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4gCj4gSG0geWVhaCwgbW9yZSBo
aW50cyB0aGF0IG1heWJlIGlwcyBzaG91bGQgYmUgYSBwbGFuZSwgb3IgYXQgbGVhc3QgYSB3bQo+
IHN0YXRlIHRoaW5nPwoKSSB0aGluayB3ZSB3b3VsZCBoYXZlIHRvIHdyaXRlIHRoaXMgYXMgc29t
ZXRoaW5nIGxpa2U6CgpwcmVfcGxhbmVfdXBkYXRlKCkKaWYgKG9sZF9jcnRjX3N0YXRlLT5pcHMg
JiYgb2xkX2NydGNfc3RhdGUtPmFjdGl2ZV9wbGFuZXMgIT0gMCAmJgogICAgKCFuZXdfY3J0Y19z
dGF0ZS0+aXBzIHx8IG5ld19jcnRjX3N0YXRlLT5hY3RpdmVfcGxhbmVzID09IDApCiAgICBkaXNh
YmxlX2lwcygpOwogCnBvc3RfcGxhbmVfdXBkYXRlKCkKaWYgKCghb2xkX2NydGNfc3RhdGUtPmlw
cyB8fCBvbGRfY3J0Y19zdGF0ZS0+YWN0aXZlX3BsYW5lcyA9PSAwKSAmJgogICAgbmV3X2NydGNf
c3RhdGUtPmlwcyAmJiBuZXdfY3J0Y19zdGF0ZS0+YWN0aXZlX3BsYW5lcyAhPSAwKQogICAgZW5h
YmxlX2lwcygpOwoKUHJvYmFibHkgbmVlZHMgYSBmZXcgbW9kZSBuZWVkc19tb2Rlc2V0KCkgYW5k
IGNydGNfc3RhdGUtPmFjdGl2ZQpjaGVja3MgZXRjLiB0byBhY2NvdW50IGZvciBhbGwgdGhlIGRp
c2FibGluZyBwaXBlLCBlbmFibGluZyBwaXBlLAp0b2dnbGluZyBwaXBlLCBhbmQgZG9pbmcgbm90
aGluZyB0byB0aGUgcGlwZSBjYXNlcy4KClRvIHNpbXBsaWZ5IG1heWJlIHdlIHNob3VsZCBwcm9i
YWJseSBqdXN0IGFjY291bnQgZm9yIGFjdGl2ZV9wbGFuZXMKaW4gY3J0Y19zdGF0ZS0+aXBzX2Vu
YWJsZWQgYWxyZWFkeS4gSWUuIGNhbGwgaHN3X2NvbXB1dGVfaXBzX2NvbmZpZygpCmV2ZW4gaWYg
d2UgZG9uJ3QgZG8gYSBtb2Rlc2V0LgoKV2UnZCBoYXZlIHRvIGNoYW5nZSB0aGUgYmR3IGNkY2xr
IHZzLiBpcHMgd29ya2Fyb3VuZCB0byB3b3JrIHRoZQpvdGhlciB3YXkgYXJvdW5kIHRob3VnaCBz
aW5jZSBjdXJyZW50bHkgaHN3X2NvbXB1dGVfaXBzX2NvbmZpZygpIGFzc3VtZXMKdGhhdCB3ZSBj
YW4gZG8gYSBtb2Rlc2V0IHRvIGluY3JlYXNlIGNkY2xrIChhc3N1bWluZyBpdCdzIG5vdCBhbHJl
YWR5Cm1heGVkIG91dCkuIEJ1dCBJIHRoaW5rIGl0IHdvdWxkIGJlIGEgd29ydGh3aWxlIGNoYW5n
ZSB0byBtYWtlIHRoZSBjb2RlCmxlc3MgY29udm9sdXRlZC4KCj4gCj4gVGhpcyB0dXJucyBhIGJp
dCBpbnRvIGEgcmFiYml0IGhvbGUsIHNvIGlmIFZpbGxlIHRoaW5rcyB0aGlzIGlzIGFsbCBzdGls
bAo+IHJlYXNvbmFibHkgY2xlYW4taXNoIEkgdGhpbmsgd2UgY2FuIGdvIHdpdGggdGhpcyBoZXJl
IHRvbyAuLi4gSSdtIGp1c3QKPiB3b25kZXJpbmcgYSBiaXQuCj4gLURhbmllbAo+IAo+ID4gLS0t
Cj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jICB8IDYgKysrKysrCj4g
PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcGlwZV9jcmMuYyB8IDIgKy0KPiA+ICAyIGZp
bGVzIGNoYW5nZWQsIDcgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+ID4gCj4gPiBkaWZm
IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9n
cHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPiBpbmRleCA0YWEwMmUyNzk4NWQuLjFiNzVh
Zjc3M2VmNyAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3Bs
YXkuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPiBA
QCAtNTA0MCw2ICs1MDQwLDkgQEAgc3RhdGljIHZvaWQgaW50ZWxfcG9zdF9wbGFuZV91cGRhdGUo
c3RydWN0IGludGVsX2NydGNfc3RhdGUgKm9sZF9jcnRjX3N0YXRlKQo+ID4gIAkJICAgIChuZWVk
c19tb2Rlc2V0KCZwaXBlX2NvbmZpZy0+YmFzZSkgfHwKPiA+ICAJCSAgICAgIW9sZF9wcmltYXJ5
X3N0YXRlLT5iYXNlLnZpc2libGUpKQo+ID4gIAkJCWludGVsX3Bvc3RfZW5hYmxlX3ByaW1hcnko
JmNydGMtPmJhc2UsIHBpcGVfY29uZmlnKTsKPiA+ICsJCWVsc2UgaWYgKHBpcGVfY29uZmlnLT51
cGRhdGVfcGlwZSkKPiA+ICsJCQkvKiBJUFMgdHVybmVkIG9uIGFmdGVyIGZhc3RzZXQgb3IgQ1JD
IGNvbGxlY3Rpb24gZGlzYWJsZS4gKi8KPiA+ICsJCQloc3dfZW5hYmxlX2lwcyhwaXBlX2NvbmZp
Zyk7Cj4gPiAgCX0KPiA+ICB9Cj4gPiAgCj4gPiBAQCAtNTA2OSw2ICs1MDcyLDkgQEAgc3RhdGlj
IHZvaWQgaW50ZWxfcHJlX3BsYW5lX3VwZGF0ZShzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqb2xk
X2NydGNfc3RhdGUsCj4gPiAgCQlpZiAob2xkX3ByaW1hcnlfc3RhdGUtPmJhc2UudmlzaWJsZSAm
Jgo+ID4gIAkJICAgIChtb2Rlc2V0IHx8ICFwcmltYXJ5X3N0YXRlLT5iYXNlLnZpc2libGUpKQo+
ID4gIAkJCWludGVsX3ByZV9kaXNhYmxlX3ByaW1hcnkoJmNydGMtPmJhc2UsIG9sZF9jcnRjX3N0
YXRlKTsKPiA+ICsJCWVsc2UgaWYgKHBpcGVfY29uZmlnLT51cGRhdGVfcGlwZSAmJiAhcGlwZV9j
b25maWctPmlwc19lbmFibGVkKQo+ID4gKwkJCS8qIElQUyB0dXJuZWQgb2ZmIGZvciBDUkMsIGRp
c2FibGUgaXQuICovCj4gPiArCQkJaHN3X2Rpc2FibGVfaXBzKG9sZF9jcnRjX3N0YXRlKTsKPiA+
ICAJfQo+ID4gIAo+ID4gIAkvKgo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1
L2ludGVsX3BpcGVfY3JjLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9waXBlX2NyYy5j
Cj4gPiBpbmRleCA4OTk4MzlmMmY3YzYuLmNiOTJiZWZjMTZkNyAxMDA2NDQKPiA+IC0tLSBhL2Ry
aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BpcGVfY3JjLmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1
L2RybS9pOTE1L2ludGVsX3BpcGVfY3JjLmMKPiA+IEBAIC01NDIsNyArNTQyLDcgQEAgc3RhdGlj
IHZvaWQgaHN3X3BpcGVfQV9jcmNfd2Eoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2
LAo+ID4gIAkJICovCj4gPiAgCQlwaXBlX2NvbmZpZy0+aXBzX2ZvcmNlX2Rpc2FibGUgPSBlbmFi
bGU7Cj4gPiAgCQlpZiAocGlwZV9jb25maWctPmlwc19lbmFibGVkID09IGVuYWJsZSkKPiA+IC0J
CQlwaXBlX2NvbmZpZy0+YmFzZS5jb25uZWN0b3JzX2NoYW5nZWQgPSB0cnVlOwo+ID4gKwkJCXBp
cGVfY29uZmlnLT5iYXNlLm1vZGVfY2hhbmdlZCA9IHRydWU7Cj4gPiAgCX0KPiA+ICAKPiA+ICAJ
aWYgKElTX0hBU1dFTEwoZGV2X3ByaXYpKSB7Cj4gPiAtLSAKPiA+IDIuMTUuMAo+ID4gCj4gPiBf
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ID4gSW50ZWwt
Z2Z4IG1haWxpbmcgbGlzdAo+ID4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4g
aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK
PiAKPiAtLSAKPiBEYW5pZWwgVmV0dGVyCj4gU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBv
cmF0aW9uCj4gaHR0cDovL2Jsb2cuZmZ3bGwuY2gKPiBfX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1n
ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv
bWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwgT1RD
Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdm
eCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xp
c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=