From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v3 04/11] drm/i915: Handle adjust better in intel_pipe_config_compare Date: Mon, 13 Nov 2017 19:24:22 +0200 Message-ID: <20171113172422.GU10981@intel.com> References: <20171110113503.16253-1-maarten.lankhorst@linux.intel.com> <20171110113503.16253-4-maarten.lankhorst@linux.intel.com> <20171110130245.qxdjzdnoqprb4hq6@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id EC45F6E6DD for ; Mon, 13 Nov 2017 17:24:25 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20171110130245.qxdjzdnoqprb4hq6@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBOb3YgMTAsIDIwMTcgYXQgMDI6MDI6NDVQTSArMDEwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBPbiBGcmksIE5vdiAxMCwgMjAxNyBhdCAxMjozNDo1NlBNICswMTAwLCBNYWFydGVu IExhbmtob3JzdCB3cm90ZToKPiA+IFNvbWUgcGFyYW1ldGVycyB1c2UgQ0hFQ0tfQk9PTEwsIGJ1 dCBzaG91bGQgcmVhbGx5IHVzZQo+ID4gQ0hFQ0tfQk9PTF9JTkNPTVBMRVRFLiBXZSBjYW5ub3Qg Y3VycmVudGx5IGNoZWNrIHdoZXRoZXIKPiA+IHRoZSBpbmhlcml0ZWQgaW5mb2ZyYW1lcyBhbmQg YXVkaW8gYXJlIHNldCB1cCBjb3JyZWN0bHkuCj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IE1hYXJ0 ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4gPiAtLS0K PiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCAxOSArKysrKysrKysr KysrKysrKy0tCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDE3IGluc2VydGlvbnMoKyksIDIgZGVsZXRp b25zKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k aXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+IGluZGV4 IDQyNTE2N2RhNTYwYi4uZjU5MzNiMDcxOWM5IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kaXNwbGF5LmMKPiA+IEBAIC0xMTA3Niw2ICsxMTA3Niw5IEBAIGludGVsX3BpcGVfY29u ZmlnX2NvbXBhcmUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ID4gIAkJCSAg Ym9vbCBhZGp1c3QpCj4gPiAgewo+ID4gIAlib29sIHJldCA9IHRydWU7Cj4gPiArCWJvb2wgZml4 dXBfaW5oZXJpdGVkID0gYWRqdXN0ICYmCj4gPiArCQkoY3VycmVudF9jb25maWctPmJhc2UubW9k ZS5wcml2YXRlX2ZsYWdzICYgSTkxNV9NT0RFX0ZMQUdfSU5IRVJJVEVEKSAmJgo+ID4gKwkJIShw aXBlX2NvbmZpZy0+YmFzZS5tb2RlLnByaXZhdGVfZmxhZ3MgJiBJOTE1X01PREVfRkxBR19JTkhF UklURUQpOwo+ID4gIAo+ID4gICNkZWZpbmUgUElQRV9DT05GX0NIRUNLX1gobmFtZSkJXAo+ID4g IAlpZiAoY3VycmVudF9jb25maWctPm5hbWUgIT0gcGlwZV9jb25maWctPm5hbWUpIHsgXAo+ID4g QEAgLTExMTA0LDYgKzExMTA3LDE3IEBAIGludGVsX3BpcGVfY29uZmlnX2NvbXBhcmUoc3RydWN0 IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ID4gIAkJcmV0ID0gZmFsc2U7IFwKPiA+ICAJ fQo+ID4gIAo+IAo+IE1heWJlIGFkZCBhIGNvbW1lbnQgaGVyZSBsaWtlCj4gCj4gLyoKPiAgKiBD aGVja3Mgc3RhdGUgd2hlcmUgd2Ugb25seSByZWFkIG91dCB0aGUgZW5hYmxpbmcsIGJ1dCBub3Qg dGhlIGVudGlyZQo+ICAqIHN0YXRlIGl0c2VsZiAobGlrZSBmdWxsIGluZm9mcmFtZXMgb3IgRUxE IGZvciBhdWRpbykuIFRoZXNlIHN0YXRlcwo+ICAqIHJlcXVpcmUgYSBmdWxsIG1vZGVzZXQgb24g Ym9vdHVwIHRvIGZpeCB1cC4KCmhhc19hdWRpbyBzaG91bGRuJ3QgbmVlZCB0aGUgRUxELiBJZiBh dWRpbyBpcyBlbmFibGVkIHRoZW4gaXQncyBlbmFibGVkLApvdGhlcndpc2UgaXQncyBub3QuCgpT byBJIGd1ZXNzIGlmIHRoZSBCSU9TIGRvZXNuJ3QgZW5hYmxlIGF1ZGlvLCB0aGVuIHdoYXQgd2Ug cmVhbGx5IG5lZWQgaXMKYSB3YXkgdG8gZW5hYmxlIGl0IHdpdGhvdXQgYSBmdWxsIG1vZGVzZXQu IEFuZCBJIGNhbid0IGltbWVkaWF0ZWx5CnJlY2FsbCBpZiB3ZSBjYW4gZG8gdGhhdCBvciBub3Qu CgpJJ20gd29ycmllZCB0aGF0IGlnbm9yaW5nIHRoZSBpc3N1ZSB3aWxsIGp1c3QgbGVhZCB0byBw aWxlcyBvZiBidWdzCndoZXJlIHBlb3BsZSBjb21wbGFpbiB0aGF0IHRoZWlyIGF1ZGlvIGRvZXNu J3Qgd29yay4KCj4gICovCj4gCj4gV2l0aCB0aGF0Ogo+IAo+IFJldmlld2VkLWJ5OiBEYW5pZWwg VmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgo+IAo+ID4gKyNkZWZpbmUgUElQRV9DT05G X0NIRUNLX0JPT0xfSU5DT01QTEVURShuYW1lKSBcCj4gPiArCWlmICghZml4dXBfaW5oZXJpdGVk IHx8ICghY3VycmVudF9jb25maWctPm5hbWUgJiYgIXBpcGVfY29uZmlnLT5uYW1lKSkgeyBcCj4g PiArCQlQSVBFX0NPTkZfQ0hFQ0tfQk9PTChuYW1lKTsgXAo+ID4gKwl9IGVsc2UgeyBcCj4gPiAr CQlwaXBlX2NvbmZpZ19lcnIoYWRqdXN0LCBfX3N0cmluZ2lmeShuYW1lKSwgXAo+ID4gKwkJCSAg InVuYWJsZSB0byB2ZXJpZnkgd2hldGhlciBzdGF0ZSBtYXRjaGVzIGV4YWN0bHksIGZvcmNpbmcg bW9kZXNldCAoZXhwZWN0ZWQgJXMsIGZvdW5kICVzKVxuIiwgXAo+ID4gKwkJCSAgeWVzbm8oY3Vy cmVudF9jb25maWctPm5hbWUpLCBcCj4gPiArCQkJICB5ZXNubyhwaXBlX2NvbmZpZy0+bmFtZSkp OyBcCj4gPiArCQlyZXQgPSBmYWxzZTsgXAo+ID4gKwl9Cj4gPiArCj4gPiAgI2RlZmluZSBQSVBF X0NPTkZfQ0hFQ0tfUChuYW1lKQlcCj4gPiAgCWlmIChjdXJyZW50X2NvbmZpZy0+bmFtZSAhPSBw aXBlX2NvbmZpZy0+bmFtZSkgeyBcCj4gPiAgCQlwaXBlX2NvbmZpZ19lcnIoYWRqdXN0LCBfX3N0 cmluZ2lmeShuYW1lKSwgXAo+ID4gQEAgLTExMjI4LDEwICsxMTI0MiwxMCBAQCBpbnRlbF9waXBl X2NvbmZpZ19jb21wYXJlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiA+ICAK PiA+ICAJUElQRV9DT05GX0NIRUNLX0JPT0woaGRtaV9zY3JhbWJsaW5nKTsKPiA+ICAJUElQRV9D T05GX0NIRUNLX0JPT0woaGRtaV9oaWdoX3RtZHNfY2xvY2tfcmF0aW8pOwo+ID4gLQlQSVBFX0NP TkZfQ0hFQ0tfQk9PTChoYXNfaW5mb2ZyYW1lKTsKPiA+ICsJUElQRV9DT05GX0NIRUNLX0JPT0xf SU5DT01QTEVURShoYXNfaW5mb2ZyYW1lKTsKPiA+ICAJUElQRV9DT05GX0NIRUNLX0JPT0woeWNi Y3I0MjApOwo+ID4gIAo+ID4gLQlQSVBFX0NPTkZfQ0hFQ0tfQk9PTChoYXNfYXVkaW8pOwo+ID4g KwlQSVBFX0NPTkZfQ0hFQ0tfQk9PTF9JTkNPTVBMRVRFKGhhc19hdWRpbyk7Cj4gPiAgCj4gPiAg CVBJUEVfQ09ORl9DSEVDS19GTEFHUyhiYXNlLmFkanVzdGVkX21vZGUuZmxhZ3MsCj4gPiAgCQkJ ICAgICAgRFJNX01PREVfRkxBR19JTlRFUkxBQ0UpOwo+ID4gQEAgLTExMzA2LDYgKzExMzIwLDcg QEAgaW50ZWxfcGlwZV9jb25maWdfY29tcGFyZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2 X3ByaXYsCj4gPiAgI3VuZGVmIFBJUEVfQ09ORl9DSEVDS19YCj4gPiAgI3VuZGVmIFBJUEVfQ09O Rl9DSEVDS19JCj4gPiAgI3VuZGVmIFBJUEVfQ09ORl9DSEVDS19CT09MCj4gPiArI3VuZGVmIFBJ UEVfQ09ORl9DSEVDS19CT09MX0lOQ09NUExFVEUKPiA+ICAjdW5kZWYgUElQRV9DT05GX0NIRUNL X1AKPiA+ICAjdW5kZWYgUElQRV9DT05GX0NIRUNLX0ZMQUdTCj4gPiAgI3VuZGVmIFBJUEVfQ09O Rl9DSEVDS19DTE9DS19GVVpaWQo+ID4gLS0gCj4gPiAyLjE1LjAKPiA+IAo+ID4gX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiA+IEludGVsLWdmeCBtYWls aW5nIGxpc3QKPiA+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiA+IGh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cj4gCj4gLS0g Cj4gRGFuaWVsIFZldHRlcgo+IFNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgo+ IGh0dHA6Ly9ibG9nLmZmd2xsLmNoCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGlu ZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK