From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH 1/2] drm/i915: Move rotation validity check
 into its own function
Date: Tue, 14 Nov 2017 16:25:15 +0200
Message-ID: <20171114142515.GF10981@intel.com>
References: <1510229160-329-1-git-send-email-juhapekka.heikkila@gmail.com>
 <1510229160-329-2-git-send-email-juhapekka.heikkila@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 7472789E7B
 for <intel-gfx@lists.freedesktop.org>; Tue, 14 Nov 2017 14:25:19 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <1510229160-329-2-git-send-email-juhapekka.heikkila@gmail.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gVGh1LCBOb3YgMDksIDIwMTcgYXQgMDI6MDU6NTlQTSArMDIwMCwgSnVoYS1QZWtrYSBIZWlr
a2lsYSB3cm90ZToKPiBUaGlzIG1ha2VzIGludGVsX3BsYW5lX2F0b21pY19jaGVja193aXRoX3N0
YXRlKCkgZ2VuZXJhbGx5IHNob3J0ZXIuCj4gCj4gdjI6IChWaWxsZSBTeXJqw6Rsw6QpIG1vdmUg
YWxsIHJvdGF0aW9uIHJlbGF0ZWQgY2hlY2tzIGZyb20gCj4gCWludGVsX3BsYW5lX2F0b21pY19j
aGVja193aXRoX3N0YXRlIGludG8gbmV3IGZ1bmN0aW9uCj4gCWFuZCBkb24ndCBwYXNzIGRldl9w
cml2IHBvaW50ZXIgYXJvdW5kLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEp1aGEtUGVra2EgSGVpa2tp
bGEgPGp1aGFwZWtrYS5oZWlra2lsYUBnbWFpbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2Ry
bS9pOTE1L2ludGVsX2F0b21pY19wbGFuZS5jIHwgODEgKysrKysrKysrKysrKysrKysrLS0tLS0t
LS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNDggaW5zZXJ0aW9ucygrKSwgMzMgZGVsZXRpb25z
KC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2F0b21pY19w
bGFuZS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYXRvbWljX3BsYW5lLmMKPiBpbmRl
eCA4ZTZkYzE1Li5mZmQzNmZiIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu
dGVsX2F0b21pY19wbGFuZS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYXRv
bWljX3BsYW5lLmMKPiBAQCAtMTA3LDYgKzEwNyw1MyBAQCBpbnRlbF9wbGFuZV9kZXN0cm95X3N0
YXRlKHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lLAo+ICAJZHJtX2F0b21pY19oZWxwZXJfcGxhbmVf
ZGVzdHJveV9zdGF0ZShwbGFuZSwgc3RhdGUpOwo+ICB9Cj4gIAo+ICtzdGF0aWMgYm9vbCBpbnRl
bF92YWxpZF9yb3RhdGlvbihjb25zdCBzdHJ1Y3QgZHJtX3BsYW5lX3N0YXRlICpwbGFuZV9zdGF0
ZSkKCk1heWJlICJpbnRlbF9wbGFuZV92YWxpZF9yb3RhdGlvbiIgdG8gbWFrZSBpdCBtb3JlIG9i
dmlvdXMgd2hhdCB3ZSdyZQpjaGVja2luZyBoZXJlLgoKPiArewo+ICsJc3RydWN0IGludGVsX3Bs
YW5lICpwbGFuZSA9IHRvX2ludGVsX3BsYW5lKHBsYW5lX3N0YXRlLT5wbGFuZSk7Cj4gKwlzdHJ1
Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KHBsYW5lLT5iYXNlLmRldik7
Cj4gKwo+ICsJaWYgKHBsYW5lX3N0YXRlLT5mYiAmJgo+ICsJCQlkcm1fcm90YXRpb25fOTBfb3Jf
MjcwKHBsYW5lX3N0YXRlLT5yb3RhdGlvbikpIHsKICAgICAgICAgICAgXl5eXl5eXl5eXl5eCgpN
ZXNzZWQgdXAgYWxpZ25tZW50LgoKPiArCQlzdHJ1Y3QgZHJtX2Zvcm1hdF9uYW1lX2J1ZiBmb3Jt
YXRfbmFtZTsKPiArCj4gKwkJaWYgKHBsYW5lX3N0YXRlLT5mYi0+bW9kaWZpZXIgIT0gSTkxNV9G
T1JNQVRfTU9EX1lfVElMRUQgJiYKPiArCQkgICAgcGxhbmVfc3RhdGUtPmZiLT5tb2RpZmllciAh
PSBJOTE1X0ZPUk1BVF9NT0RfWWZfVElMRUQpIHsKPiArCQkJRFJNX0RFQlVHX0tNUygiWS9ZZiB0
aWxpbmcgcmVxdWlyZWQgZm9yIDkwLzI3MCFcbiIpOwo+ICsJCQlyZXR1cm4gZmFsc2U7Cj4gKwkJ
fQo+ICsKPiArCQkvKgo+ICsJCSAqIDkwLzI3MCBpcyBub3QgYWxsb3dlZCB3aXRoIFJHQjY0IDE2
OjE2OjE2OjE2LAo+ICsJCSAqIFJHQiAxNi1iaXQgNTo2OjUsIGFuZCBJbmRleGVkIDgtYml0Lgo+
ICsJCSAqIFRCRDogQWRkIFJHQjY0IGNhc2Ugb25jZSBpdHMgYWRkZWQgaW4gc3VwcG9ydGVkIGZv
cm1hdAo+ICsJCSAqIGxpc3QuCj4gKwkJICovCj4gKwkJc3dpdGNoIChwbGFuZV9zdGF0ZS0+ZmIt
PmZvcm1hdC0+Zm9ybWF0KSB7Cj4gKwkJY2FzZSBEUk1fRk9STUFUX0M4Ogo+ICsJCWNhc2UgRFJN
X0ZPUk1BVF9SR0I1NjU6Cj4gKwkJCURSTV9ERUJVR19LTVMoCj4gKwkJCQkiVW5zdXBwb3J0ZWQg
cGl4ZWwgZm9ybWF0ICVzIGZvciA5MC8yNzAhXG4iLAo+ICsJCQkJZHJtX2dldF9mb3JtYXRfbmFt
ZSgKPiArCQkJCQlwbGFuZV9zdGF0ZS0+ZmItPmZvcm1hdC0+Zm9ybWF0LAo+ICsJCQkJCSZmb3Jt
YXRfbmFtZSkpOwoKSGVyZSB0b28uCgo+ICsJCQlyZXR1cm4gZmFsc2U7Cj4gKwkJZGVmYXVsdDoK
PiArCQkJYnJlYWs7Cj4gKwkJfQo+ICsJfQo+ICsKPiArCS8qIENIViBpZ25vcmVzIHRoZSBtaXJy
b3IgYml0IHdoZW4gdGhlIHJvdGF0ZSBiaXQgaXMgc2V0IDooICovCj4gKwlpZiAoSVNfQ0hFUlJZ
VklFVyhkZXZfcHJpdikgJiYKPiArCSAgICBwbGFuZV9zdGF0ZS0+cm90YXRpb24gJiBEUk1fTU9E
RV9ST1RBVEVfMTgwICYmCj4gKwkgICAgcGxhbmVfc3RhdGUtPnJvdGF0aW9uICYgRFJNX01PREVf
UkVGTEVDVF9YKSB7Cj4gKwkJRFJNX0RFQlVHX0tNUygiQ2Fubm90IHJvdGF0ZSBhbmQgcmVmbGVj
dCBhdCB0aGUgc2FtZSB0aW1lXG4iKTsKPiArCQlyZXR1cm4gZmFsc2U7Cj4gKwl9Cj4gKwo+ICsJ
cmV0dXJuIHRydWU7Cj4gKwoKRW1wdHkgbGluZS4gSUlSQyAnY2hlY2twYXRjaC5wbCAtLXN0cmlj
dCcgc2hvdWxkIGNhdGNoIHRoZXNlIGZvciB5b3UuCgo+ICt9Cj4gKwo+ICBpbnQgaW50ZWxfcGxh
bmVfYXRvbWljX2NoZWNrX3dpdGhfc3RhdGUoY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUg
Km9sZF9jcnRjX3N0YXRlLAo+ICAJCQkJCXN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0
YXRlLAo+ICAJCQkJCWNvbnN0IHN0cnVjdCBpbnRlbF9wbGFuZV9zdGF0ZSAqb2xkX3BsYW5lX3N0
YXRlLAo+IEBAIC0xMzcsNDAgKzE4NCw4IEBAIGludCBpbnRlbF9wbGFuZV9hdG9taWNfY2hlY2tf
d2l0aF9zdGF0ZShjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqb2xkX2NydGNfCj4gIAlp
bnRlbF9zdGF0ZS0+Y2xpcC55MiA9Cj4gIAkJY3J0Y19zdGF0ZS0+YmFzZS5lbmFibGUgPyBjcnRj
X3N0YXRlLT5waXBlX3NyY19oIDogMDsKPiAgCj4gLQlpZiAoc3RhdGUtPmZiICYmIGRybV9yb3Rh
dGlvbl85MF9vcl8yNzAoc3RhdGUtPnJvdGF0aW9uKSkgewo+IC0JCXN0cnVjdCBkcm1fZm9ybWF0
X25hbWVfYnVmIGZvcm1hdF9uYW1lOwo+IC0KPiAtCQlpZiAoc3RhdGUtPmZiLT5tb2RpZmllciAh
PSBJOTE1X0ZPUk1BVF9NT0RfWV9USUxFRCAmJgo+IC0JCSAgICBzdGF0ZS0+ZmItPm1vZGlmaWVy
ICE9IEk5MTVfRk9STUFUX01PRF9ZZl9USUxFRCkgewo+IC0JCQlEUk1fREVCVUdfS01TKCJZL1lm
IHRpbGluZyByZXF1aXJlZCBmb3IgOTAvMjcwIVxuIik7Cj4gLQkJCXJldHVybiAtRUlOVkFMOwo+
IC0JCX0KPiAtCj4gLQkJLyoKPiAtCQkgKiA5MC8yNzAgaXMgbm90IGFsbG93ZWQgd2l0aCBSR0I2
NCAxNjoxNjoxNjoxNiwKPiAtCQkgKiBSR0IgMTYtYml0IDU6Njo1LCBhbmQgSW5kZXhlZCA4LWJp
dC4KPiAtCQkgKiBUQkQ6IEFkZCBSR0I2NCBjYXNlIG9uY2UgaXRzIGFkZGVkIGluIHN1cHBvcnRl
ZCBmb3JtYXQgbGlzdC4KPiAtCQkgKi8KPiAtCQlzd2l0Y2ggKHN0YXRlLT5mYi0+Zm9ybWF0LT5m
b3JtYXQpIHsKPiAtCQljYXNlIERSTV9GT1JNQVRfQzg6Cj4gLQkJY2FzZSBEUk1fRk9STUFUX1JH
QjU2NToKPiAtCQkJRFJNX0RFQlVHX0tNUygiVW5zdXBwb3J0ZWQgcGl4ZWwgZm9ybWF0ICVzIGZv
ciA5MC8yNzAhXG4iLAo+IC0JCQkgICAgICAgICAgICAgIGRybV9nZXRfZm9ybWF0X25hbWUoc3Rh
dGUtPmZiLT5mb3JtYXQtPmZvcm1hdCwKPiAtCQkJICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICZmb3JtYXRfbmFtZSkpOwo+IC0JCQlyZXR1cm4gLUVJTlZBTDsKPiAtCj4gLQkJZGVm
YXVsdDoKPiAtCQkJYnJlYWs7Cj4gLQkJfQo+IC0JfQo+IC0KPiAtCS8qIENIViBpZ25vcmVzIHRo
ZSBtaXJyb3IgYml0IHdoZW4gdGhlIHJvdGF0ZSBiaXQgaXMgc2V0IDooICovCj4gLQlpZiAoSVNf
Q0hFUlJZVklFVyhkZXZfcHJpdikgJiYKPiAtCSAgICBzdGF0ZS0+cm90YXRpb24gJiBEUk1fTU9E
RV9ST1RBVEVfMTgwICYmCj4gLQkgICAgc3RhdGUtPnJvdGF0aW9uICYgRFJNX01PREVfUkVGTEVD
VF9YKSB7Cj4gLQkJRFJNX0RFQlVHX0tNUygiQ2Fubm90IHJvdGF0ZSBhbmQgcmVmbGVjdCBhdCB0
aGUgc2FtZSB0aW1lXG4iKTsKPiArCWlmICghaW50ZWxfdmFsaWRfcm90YXRpb24oc3RhdGUpKQo+
ICAJCXJldHVybiAtRUlOVkFMOwo+IC0JfQo+ICAKPiAgCWludGVsX3N0YXRlLT5iYXNlLnZpc2li
bGUgPSBmYWxzZTsKPiAgCXJldCA9IGludGVsX3BsYW5lLT5jaGVja19wbGFuZShpbnRlbF9wbGFu
ZSwgY3J0Y19zdGF0ZSwgaW50ZWxfc3RhdGUpOwo+IC0tIAo+IDIuNy40Cj4gCj4gX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGlu
ZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMu
ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKVmlsbGUgU3ly
asOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3Rv
cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRl
bC1nZngK