From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Mika Kahola <mika.kahola@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH FOR CI v2] drm/i915: Generalize transcoder looping
Date: Tue, 14 Nov 2017 16:26:36 +0200 [thread overview]
Message-ID: <20171114142636.GH10981@intel.com> (raw)
In-Reply-To: <1510216670-16848-1-git-send-email-mika.kahola@intel.com>
On Thu, Nov 09, 2017 at 10:37:50AM +0200, Mika Kahola wrote:
> To make looping through transcoders in intel_ddi.c more generic, let's switch
> to use 'for_each_pipe()' macro to do this.
>
> v2: Add a notion that we are dealing with transcoders instead of pipes (Jani)
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Mika Kahola <mika.kahola@intel.com>
Pushed to dinq. Thanks for the patch.
> ---
> drivers/gpu/drm/i915/intel_ddi.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index ace674c..31ef376 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -1681,8 +1681,8 @@ bool intel_ddi_get_hw_state(struct intel_encoder *encoder,
> struct drm_device *dev = encoder->base.dev;
> struct drm_i915_private *dev_priv = to_i915(dev);
> enum port port = encoder->port;
> + enum pipe p;
> u32 tmp;
> - int i;
> bool ret;
>
> if (!intel_display_power_get_if_enabled(dev_priv,
> @@ -1717,15 +1717,17 @@ bool intel_ddi_get_hw_state(struct intel_encoder *encoder,
> goto out;
> }
>
> - for (i = TRANSCODER_A; i <= TRANSCODER_C; i++) {
> - tmp = I915_READ(TRANS_DDI_FUNC_CTL(i));
> + for_each_pipe(dev_priv, p) {
> + enum transcoder cpu_transcoder = (enum transcoder) p;
> +
> + tmp = I915_READ(TRANS_DDI_FUNC_CTL(cpu_transcoder));
>
> if ((tmp & TRANS_DDI_PORT_MASK) == TRANS_DDI_SELECT_PORT(port)) {
> if ((tmp & TRANS_DDI_MODE_SELECT_MASK) ==
> TRANS_DDI_MODE_SELECT_DP_MST)
> goto out;
>
> - *pipe = i;
> + *pipe = p;
> ret = true;
>
> goto out;
> --
> 2.7.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2017-11-14 14:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-09 8:37 [PATCH FOR CI v2] drm/i915: Generalize transcoder looping Mika Kahola
2017-11-09 8:59 ` ✗ Fi.CI.BAT: warning for drm/i915: Generalize transcoder looping (rev3) Patchwork
2017-11-09 9:46 ` ✓ Fi.CI.IGT: success " Patchwork
2017-11-14 14:26 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171114142636.GH10981@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kahola@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox