From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v3 2/4] drm/i915: fix 64bit divide Date: Tue, 14 Nov 2017 16:27:04 +0200 Message-ID: <20171114142704.GI10981@intel.com> References: <20171113233455.12085-1-lionel.g.landwerlin@intel.com> <20171113233455.12085-3-lionel.g.landwerlin@intel.com> <20171114073041.GB17613@emusial-desk.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 40FF86E02E for ; Tue, 14 Nov 2017 14:27:10 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20171114073041.GB17613@emusial-desk.ger.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ewelina Musial Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBOb3YgMTQsIDIwMTcgYXQgMDg6MzA6NDFBTSArMDEwMCwgRXdlbGluYSBNdXNpYWwg d3JvdGU6Cj4gT24gTW9uLCBOb3YgMTMsIDIwMTcgYXQgMTE6MzQ6NTNQTSArMDAwMCwgTGlvbmVs IExhbmR3ZXJsaW4gd3JvdGU6Cj4gPiBFUlJPUjogIl9fdWRpdmRpMyIgW2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTUua29dIHVuZGVmaW5lZCEKPiA+IEVSUk9SOiAiX19kaXZkaTMiIFtkcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1LmtvXSB1bmRlZmluZWQhCj4gPiAKPiA+IFN0b3JlIHRoZSBmcmVx dWVuY3kgaW4ga0h6IGFuZCBkcm9wIDY0Yml0IGRpdmlzaW9ucy4KPiA+IAo+ID4gdjI6IFVzZSBk aXY2NF91NjQgKE1hdHRoZXcpCj4gPiAKPiA+IHYzOiBzdG9yZSBmcmVxdWVuY3kgaW4ga0h6IHRv IGF2b2lkIDY0Yml0IGRpdnMgKENocmlzL1ZpbGxlKQo+ID4gCj4gPiBGaXhlczogZGFiOTE3ODMz MyAoImRybS9pOTE1OiBleHBvc2UgY29tbWFuZCBzdHJlYW0gdGltZXN0YW1wIGZyZXF1ZW5jeSB0 byB1c2Vyc3BhY2UiKQo+ID4gUmVwb3J0ZWQtYnk6IE1hdHRoZXcgQXVsZCA8bWF0dGhldy5hdWxk QGludGVsLmNvbT4KPiA+IFNpZ25lZC1vZmYtYnk6IExpb25lbCBMYW5kd2VybGluIDxsaW9uZWwu Zy5sYW5kd2VybGluQGludGVsLmNvbT4KPiBSZXZpZXdlZC1ieTogRXdlbGluYSBNdXNpYWwgPGV3 ZWxpbmEubXVzaWFsQGludGVsLmNvbT4KClB1c2hlZCB0byBkaW5xLiBUaGFua3MgZm9yIHRoZSBw YXRjaCBhbmQgcmV2aWV3LgoKPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf ZGVidWdmcy5jICAgICAgfCAgNCArKy0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9k cnYuYyAgICAgICAgICB8ICAyICstCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYu aCAgICAgICAgICB8ICAyICstCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGV2aWNl X2luZm8uYyB8IDI5ICsrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tCj4gPiAgNCBmaWxlcyBj aGFuZ2VkLCAxOCBpbnNlcnRpb25zKCspLCAxOSBkZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMKPiA+IGluZGV4IDgyZmYxODYxMDhmMS4uNmJhMDhiMGMx YzIyIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMK PiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jCj4gPiBAQCAtMzI2 OSw4ICszMjY5LDggQEAgc3RhdGljIGludCBpOTE1X2VuZ2luZV9pbmZvKHN0cnVjdCBzZXFfZmls ZSAqbSwgdm9pZCAqdW51c2VkKQo+ID4gIAkJICAgeWVzbm8oZGV2X3ByaXYtPmd0LmF3YWtlKSk7 Cj4gPiAgCXNlcV9wcmludGYobSwgIkdsb2JhbCBhY3RpdmUgcmVxdWVzdHM6ICVkXG4iLAo+ID4g IAkJICAgZGV2X3ByaXYtPmd0LmFjdGl2ZV9yZXF1ZXN0cyk7Cj4gPiAtCXNlcV9wcmludGYobSwg IkNTIHRpbWVzdGFtcCBmcmVxdWVuY3k6ICVsbHUgSHpcbiIsCj4gPiAtCQkgICBkZXZfcHJpdi0+ aW5mby5jc190aW1lc3RhbXBfZnJlcXVlbmN5KTsKPiA+ICsJc2VxX3ByaW50ZihtLCAiQ1MgdGlt ZXN0YW1wIGZyZXF1ZW5jeTogJXUga0h6XG4iLAo+ID4gKwkJICAgZGV2X3ByaXYtPmluZm8uY3Nf dGltZXN0YW1wX2ZyZXF1ZW5jeV9raHopOwo+ID4gIAo+ID4gIAlwID0gZHJtX3NlcV9maWxlX3By aW50ZXIobSk7Cj4gPiAgCWZvcl9lYWNoX2VuZ2luZShlbmdpbmUsIGRldl9wcml2LCBpZCkKPiA+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5jIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9kcnYuYwo+ID4gaW5kZXggNDI4MTNmNDI0N2UyLi4xNzFiODZmMzc4 NzggMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5jCj4gPiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5jCj4gPiBAQCAtNDIwLDcgKzQyMCw3 IEBAIHN0YXRpYyBpbnQgaTkxNV9nZXRwYXJhbShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB2b2lk ICpkYXRhLAo+ID4gIAkJCXJldHVybiAtRU5PREVWOwo+ID4gIAkJYnJlYWs7Cj4gPiAgCWNhc2Ug STkxNV9QQVJBTV9DU19USU1FU1RBTVBfRlJFUVVFTkNZOgo+ID4gLQkJdmFsdWUgPSBJTlRFTF9J TkZPKGRldl9wcml2KS0+Y3NfdGltZXN0YW1wX2ZyZXF1ZW5jeTsKPiA+ICsJCXZhbHVlID0gMTAw MCAqIElOVEVMX0lORk8oZGV2X3ByaXYpLT5jc190aW1lc3RhbXBfZnJlcXVlbmN5X2toejsKPiA+ ICAJCWJyZWFrOwo+ID4gIAlkZWZhdWx0Ogo+ID4gIAkJRFJNX0RFQlVHKCJVbmtub3duIHBhcmFt ZXRlciAlZFxuIiwgcGFyYW0tPnBhcmFtKTsKPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X2Rydi5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+ID4g aW5kZXggYjUzOGRmNzQwYWMzLi4yMTU4YTc1OGExN2QgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X2Rydi5oCj4gPiBAQCAtODg1LDcgKzg4NSw3IEBAIHN0cnVjdCBpbnRlbF9kZXZpY2VfaW5m byB7Cj4gPiAgCS8qIFNsaWNlL3N1YnNsaWNlL0VVIGluZm8gKi8KPiA+ICAJc3RydWN0IHNzZXVf ZGV2X2luZm8gc3NldTsKPiA+ICAKPiA+IC0JdTY0IGNzX3RpbWVzdGFtcF9mcmVxdWVuY3k7Cj4g PiArCXUzMiBjc190aW1lc3RhbXBfZnJlcXVlbmN5X2toejsKPiA+ICAKPiA+ICAJc3RydWN0IGNv bG9yX2x1dHMgewo+ID4gIAkJdTE2IGRlZ2FtbWFfbHV0X3NpemU7Cj4gPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGV2aWNlX2luZm8uYyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2RldmljZV9pbmZvLmMKPiA+IGluZGV4IDc4YmY3Mzc0ZmJkZC4uZjNlNDk0 MGZlZDQ5IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGV2aWNl X2luZm8uYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGV2aWNlX2luZm8u Ywo+ID4gQEAgLTMyOSwyOSArMzI5LDI4IEBAIHN0YXRpYyB2b2lkIGJyb2Fkd2VsbF9zc2V1X2lu Zm9faW5pdChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gPiAgCXNzZXUtPmhh c19ldV9wZyA9IDA7Cj4gPiAgfQo+ID4gIAo+ID4gLXN0YXRpYyB1NjQgcmVhZF9yZWZlcmVuY2Vf dHNfZnJlcShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gPiArc3RhdGljIHUz MiByZWFkX3JlZmVyZW5jZV90c19mcmVxKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp dikKPiA+ICB7Cj4gPiAgCXUzMiB0c19vdmVycmlkZSA9IEk5MTVfUkVBRChHRU45X1RJTUVTVEFN UF9PVkVSUklERSk7Cj4gPiAtCXU2NCBiYXNlX2ZyZXEsIGZyYWNfZnJlcTsKPiA+ICsJdTMyIGJh c2VfZnJlcSwgZnJhY19mcmVxOwo+ID4gIAo+ID4gIAliYXNlX2ZyZXEgPSAoKHRzX292ZXJyaWRl ICYgR0VOOV9USU1FU1RBTVBfT1ZFUlJJREVfVVNfQ09VTlRFUl9ESVZJREVSX01BU0spID4+Cj4g PiAgCQkgICAgIEdFTjlfVElNRVNUQU1QX09WRVJSSURFX1VTX0NPVU5URVJfRElWSURFUl9TSElG VCkgKyAxOwo+ID4gLQliYXNlX2ZyZXEgKj0gMTAwMDAwMDsKPiA+ICsJYmFzZV9mcmVxICo9IDEw MDA7Cj4gPiAgCj4gPiAgCWZyYWNfZnJlcSA9ICgodHNfb3ZlcnJpZGUgJgo+ID4gIAkJICAgICAg R0VOOV9USU1FU1RBTVBfT1ZFUlJJREVfVVNfQ09VTlRFUl9ERU5PTUlOQVRPUl9NQVNLKSA+Pgo+ ID4gIAkJICAgICBHRU45X1RJTUVTVEFNUF9PVkVSUklERV9VU19DT1VOVEVSX0RFTk9NSU5BVE9S X1NISUZUKTsKPiA+IC0JaWYgKGZyYWNfZnJlcSAhPSAwKQo+ID4gLQkJZnJhY19mcmVxID0gMTAw MDAwMCAvIChmcmFjX2ZyZXEgKyAxKTsKPiA+ICsJZnJhY19mcmVxID0gMTAwMCAvIChmcmFjX2Zy ZXEgKyAxKTsKPiA+ICAKPiA+ICAJcmV0dXJuIGJhc2VfZnJlcSArIGZyYWNfZnJlcTsKPiA+ICB9 Cj4gPiAgCj4gPiAtc3RhdGljIHU2NCByZWFkX3RpbWVzdGFtcF9mcmVxdWVuY3koc3RydWN0IGRy bV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ID4gK3N0YXRpYyB1MzIgcmVhZF90aW1lc3RhbXBf ZnJlcXVlbmN5KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiA+ICB7Cj4gPiAt CXU2NCBmMTJfNV9taHogPSAxMjUwMDAwMDsKPiA+IC0JdTY0IGYxOV8yX21oeiA9IDE5MjAwMDAw Owo+ID4gLQl1NjQgZjI0X21oeiA9IDI0MDAwMDAwOwo+ID4gKwl1MzIgZjEyXzVfbWh6ID0gMTI1 MDA7Cj4gPiArCXUzMiBmMTlfMl9taHogPSAxOTIwMDsKPiA+ICsJdTMyIGYyNF9taHogPSAyNDAw MDsKPiA+ICAKPiA+ICAJaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPD0gNCkgewo+ID4gIAkJLyog UFJNcyBzYXk6Cj4gPiBAQCAtMzYwLDcgKzM1OSw3IEBAIHN0YXRpYyB1NjQgcmVhZF90aW1lc3Rh bXBfZnJlcXVlbmN5KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiA+ICAJCSAq ICAgICAgaGNsa3MuIiAodGhyb3VnaCB0aGUg4oCcQ2xvY2tpbmcgQ29uZmlndXJhdGlvbuKAnQo+ ID4gIAkJICogICAgICAo4oCcQ0xLQ0ZH4oCdKSBNQ0hCQVIgcmVnaXN0ZXIpCj4gPiAgCQkgKi8K PiA+IC0JCXJldHVybiAoZGV2X3ByaXYtPnJhd2Nsa19mcmVxICogMTAwMCkgLyAxNjsKPiA+ICsJ CXJldHVybiBkZXZfcHJpdi0+cmF3Y2xrX2ZyZXEgLyAxNjsKPiA+ICAJfSBlbHNlIGlmIChJTlRF TF9HRU4oZGV2X3ByaXYpIDw9IDgpIHsKPiA+ICAJCS8qIFBSTXMgc2F5Ogo+ID4gIAkJICoKPiA+ IEBAIC0zNzEsNyArMzcwLDcgQEAgc3RhdGljIHU2NCByZWFkX3RpbWVzdGFtcF9mcmVxdWVuY3ko c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ID4gIAkJcmV0dXJuIGYxMl81X21o ejsKPiA+ICAJfSBlbHNlIGlmIChJTlRFTF9HRU4oZGV2X3ByaXYpIDw9IDkpIHsKPiA+ICAJCXUz MiBjdGNfcmVnID0gSTkxNV9SRUFEKENUQ19NT0RFKTsKPiA+IC0JCXU2NCBmcmVxID0gMDsKPiA+ ICsJCXUzMiBmcmVxID0gMDsKPiA+ICAKPiA+ICAJCWlmICgoY3RjX3JlZyAmIENUQ19TT1VSQ0Vf UEFSQU1FVEVSX01BU0spID09IENUQ19TT1VSQ0VfRElWSURFX0xPR0lDKSB7Cj4gPiAgCQkJZnJl cSA9IHJlYWRfcmVmZXJlbmNlX3RzX2ZyZXEoZGV2X3ByaXYpOwo+ID4gQEAgLTM4OSw3ICszODgs NyBAQCBzdGF0aWMgdTY0IHJlYWRfdGltZXN0YW1wX2ZyZXF1ZW5jeShzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSAqZGV2X3ByaXYpCj4gPiAgCQlyZXR1cm4gZnJlcTsKPiA+ICAJfSBlbHNlIGlmIChJ TlRFTF9HRU4oZGV2X3ByaXYpIDw9IDEwKSB7Cj4gPiAgCQl1MzIgY3RjX3JlZyA9IEk5MTVfUkVB RChDVENfTU9ERSk7Cj4gPiAtCQl1NjQgZnJlcSA9IDA7Cj4gPiArCQl1MzIgZnJlcSA9IDA7Cj4g PiAgCQl1MzIgcnBtX2NvbmZpZ19yZWcgPSAwOwo+ID4gIAo+ID4gIAkJLyogRmlyc3QgZmlndXJl IG91dCB0aGUgcmVmZXJlbmNlIGZyZXF1ZW5jeS4gVGhlcmUgYXJlIDIgd2F5cwo+ID4gQEAgLTU1 Myw3ICs1NTIsNyBAQCB2b2lkIGludGVsX2RldmljZV9pbmZvX3J1bnRpbWVfaW5pdChzdHJ1Y3Qg ZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gPiAgCQlnZW4xMF9zc2V1X2luZm9faW5pdChk ZXZfcHJpdik7Cj4gPiAgCj4gPiAgCS8qIEluaXRpYWxpemUgY29tbWFuZCBzdHJlYW0gdGltZXN0 YW1wIGZyZXF1ZW5jeSAqLwo+ID4gLQlpbmZvLT5jc190aW1lc3RhbXBfZnJlcXVlbmN5ID0gcmVh ZF90aW1lc3RhbXBfZnJlcXVlbmN5KGRldl9wcml2KTsKPiA+ICsJaW5mby0+Y3NfdGltZXN0YW1w X2ZyZXF1ZW5jeV9raHogPSByZWFkX3RpbWVzdGFtcF9mcmVxdWVuY3koZGV2X3ByaXYpOwo+ID4g IAo+ID4gIAlEUk1fREVCVUdfRFJJVkVSKCJzbGljZSBtYXNrOiAlMDR4XG4iLCBpbmZvLT5zc2V1 LnNsaWNlX21hc2spOwo+ID4gIAlEUk1fREVCVUdfRFJJVkVSKCJzbGljZSB0b3RhbDogJXVcbiIs IGh3ZWlnaHQ4KGluZm8tPnNzZXUuc2xpY2VfbWFzaykpOwo+ID4gQEAgLTU3MCw2ICs1NjksNiBA QCB2b2lkIGludGVsX2RldmljZV9pbmZvX3J1bnRpbWVfaW5pdChzdHJ1Y3QgZHJtX2k5MTVfcHJp dmF0ZSAqZGV2X3ByaXYpCj4gPiAgCQkJIGluZm8tPnNzZXUuaGFzX3N1YnNsaWNlX3BnID8gInki IDogIm4iKTsKPiA+ICAJRFJNX0RFQlVHX0RSSVZFUigiaGFzIEVVIHBvd2VyIGdhdGluZzogJXNc biIsCj4gPiAgCQkJIGluZm8tPnNzZXUuaGFzX2V1X3BnID8gInkiIDogIm4iKTsKPiA+IC0JRFJN X0RFQlVHX0RSSVZFUigiQ1MgdGltZXN0YW1wIGZyZXF1ZW5jeTogJWxsdVxuIiwKPiA+IC0JCQkg aW5mby0+Y3NfdGltZXN0YW1wX2ZyZXF1ZW5jeSk7Cj4gPiArCURSTV9ERUJVR19EUklWRVIoIkNT IHRpbWVzdGFtcCBmcmVxdWVuY3k6ICV1IGtIelxuIiwKPiA+ICsJCQkgaW5mby0+Y3NfdGltZXN0 YW1wX2ZyZXF1ZW5jeV9raHopOwo+ID4gIH0KPiA+IC0tIAo+ID4gMi4xNS4wCj4gPiAKPiA+IF9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gPiBJbnRlbC1n ZnggbWFpbGluZyBsaXN0Cj4gPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gPiBo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo+ IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAoKLS0g ClZpbGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vaW50ZWwtZ2Z4Cg==