* [PATCH i-g-t] igt/kms_rotation_crc: Add RGB565 90 degree test for gen>9
@ 2017-11-21 14:02 Juha-Pekka Heikkila
2017-11-21 14:02 ` Juha-Pekka Heikkila
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Juha-Pekka Heikkila @ 2017-11-21 14:02 UTC (permalink / raw)
To: intel-gfx
Add rgb565 90 degree test for gen10 onwards and do some house cleaning on
the same go.
/Juha-Pekka
Juha-Pekka Heikkila (1):
igt/kms_rotation_crc: Add RGB565 90 degree test for gen>9
tests/kms_rotation_crc.c | 58 ++++++++++++++++++++++++++----------------------
1 file changed, 32 insertions(+), 26 deletions(-)
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH i-g-t] igt/kms_rotation_crc: Add RGB565 90 degree test for gen>9 2017-11-21 14:02 [PATCH i-g-t] igt/kms_rotation_crc: Add RGB565 90 degree test for gen>9 Juha-Pekka Heikkila @ 2017-11-21 14:02 ` Juha-Pekka Heikkila 2017-11-28 11:53 ` Maarten Lankhorst 2017-11-21 14:22 ` ✓ Fi.CI.BAT: success for igt/kms_rotation_crc: Add RGB565 90 degree test for gen>9 (rev3) Patchwork 2017-11-21 16:34 ` ✗ Fi.CI.IGT: warning " Patchwork 2 siblings, 1 reply; 6+ messages in thread From: Juha-Pekka Heikkila @ 2017-11-21 14:02 UTC (permalink / raw) To: intel-gfx Gen10 onwards 90 and 270 degree rotations are supported for RGB565 format. v2 (Ville Syrjälä): As a side effect to keep bad-pixel-format test valid on all supported platforms it need to use DRM_FORMAT_C8 now. While at it clean up kms_rotation_crc test a bit, take out test_plane_rotation_ytiled_obj() function as test_plane_rotation() can basically do the same. v3 (Ville Syrjälä): repurpose test_plane_rotation_ytiled_obj() function for bad pixel testing with DRM_FORMAT_C8 as igt doesn't support this format. Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com> --- tests/kms_rotation_crc.c | 58 ++++++++++++++++++++++++++---------------------- 1 file changed, 32 insertions(+), 26 deletions(-) diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c index 27d1f80..1769264 100644 --- a/tests/kms_rotation_crc.c +++ b/tests/kms_rotation_crc.c @@ -376,10 +376,6 @@ static void test_plane_rotation(data_t *data, int plane_type) igt_plane_set_size(plane, data->fb.height, data->fb.width); ret = igt_display_try_commit2(display, commit); - if (data->override_fmt || data->override_tiling) { - igt_assert_eq(ret, -EINVAL); - continue; - } /* Verify commit was ok. */ igt_assert_eq(ret, 0); @@ -421,14 +417,13 @@ static void test_plane_rotation(data_t *data, int plane_type) igt_require_f(valid_tests, "no valid crtc/connector combinations found\n"); } -static void test_plane_rotation_ytiled_obj(data_t *data, +static void test_bad_pixel_format(data_t *data, igt_output_t *output, int plane_type) { igt_display_t *display = &data->display; uint64_t tiling = LOCAL_I915_FORMAT_MOD_Y_TILED; - uint32_t format = DRM_FORMAT_XRGB8888; - int bpp = igt_drm_format_to_bpp(format); + uint32_t format = DRM_FORMAT_C8; enum igt_commit_style commit = COMMIT_LEGACY; int fd = data->gfx_fd; igt_plane_t *plane; @@ -453,7 +448,7 @@ static void test_plane_rotation_ytiled_obj(data_t *data, w = mode->hdisplay; h = mode->vdisplay; - for (stride = 512; stride < (w * bpp / 8); stride *= 2) + for (stride = 512; stride < w; stride *= 2) ; for (size = 1024*1024; size < stride * h; size *= 2) ; @@ -482,7 +477,9 @@ static void test_plane_rotation_ytiled_obj(data_t *data, kmstest_restore_vt_mode(); igt_remove_fb(fd, &data->fb); - igt_assert_eq(ret, 0); + data->fb.fb_id = 0; + + igt_assert_eq(ret, -EINVAL); } static void test_plane_rotation_exhaust_fences(data_t *data, @@ -693,12 +690,25 @@ igt_main } igt_subtest_f("bad-pixel-format") { + enum pipe pipe; + igt_output_t *output; + int valid_tests = 0; + igt_require(gen >= 9); data.pos_x = 0, data.pos_y = 0; data.rotation = IGT_ROTATION_90; - data.override_fmt = DRM_FORMAT_RGB565; - test_plane_rotation(&data, DRM_PLANE_TYPE_PRIMARY); + + for_each_pipe_with_valid_output(&data.display, pipe, output) { + igt_output_set_pipe(output, pipe); + + test_bad_pixel_format(&data, output, DRM_PLANE_TYPE_PRIMARY); + + valid_tests++; + break; + } + + igt_require_f(valid_tests, "invalid pixel format accepted for rotation\n"); } igt_subtest_f("bad-tiling") { @@ -709,24 +719,20 @@ igt_main test_plane_rotation(&data, DRM_PLANE_TYPE_PRIMARY); } - igt_subtest_f("primary-rotation-90-Y-tiled") { - enum pipe pipe; - igt_output_t *output; - int valid_tests = 0; + igt_subtest_f("primary-rotation-90-Y-tiled-16bpp") { + igt_require(gen >= 10); + data.rotation = IGT_ROTATION_90; + data.override_fmt = DRM_FORMAT_RGB565; + data.override_tiling = LOCAL_I915_FORMAT_MOD_Y_TILED; + test_plane_rotation(&data, DRM_PLANE_TYPE_PRIMARY); + } + igt_subtest_f("primary-rotation-90-Y-tiled") { igt_require(gen >= 9); data.rotation = IGT_ROTATION_90; - - for_each_pipe_with_valid_output(&data.display, pipe, output) { - igt_output_set_pipe(output, pipe); - - test_plane_rotation_ytiled_obj(&data, output, DRM_PLANE_TYPE_PRIMARY); - - valid_tests++; - break; - } - - igt_require_f(valid_tests, "no valid crtc/connector combinations found\n"); + data.override_fmt = DRM_FORMAT_XRGB8888; + data.override_tiling = LOCAL_I915_FORMAT_MOD_Y_TILED; + test_plane_rotation(&data, DRM_PLANE_TYPE_PRIMARY); } igt_subtest_f("exhaust-fences") { -- 2.7.4 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH i-g-t] igt/kms_rotation_crc: Add RGB565 90 degree test for gen>9 2017-11-21 14:02 ` Juha-Pekka Heikkila @ 2017-11-28 11:53 ` Maarten Lankhorst 2017-11-29 13:54 ` Juha-Pekka Heikkila 0 siblings, 1 reply; 6+ messages in thread From: Maarten Lankhorst @ 2017-11-28 11:53 UTC (permalink / raw) To: Juha-Pekka Heikkila, intel-gfx Hey, Op 21-11-17 om 15:02 schreef Juha-Pekka Heikkila: > Gen10 onwards 90 and 270 degree rotations are supported for RGB565 format. > > v2 (Ville Syrjälä): > As a side effect to keep bad-pixel-format test valid on all supported > platforms it need to use DRM_FORMAT_C8 now. > > While at it clean up kms_rotation_crc test a bit, take out > test_plane_rotation_ytiled_obj() function as > test_plane_rotation() can basically do the same. > > v3 (Ville Syrjälä): > repurpose test_plane_rotation_ytiled_obj() function for > bad pixel testing with DRM_FORMAT_C8 as igt doesn't > support this format. > > Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com> At this point there is no correct order to apply the tests then. What I would like to see is the bad-pixel-format changes in a separate commit, so we can commit that first, and then commit kernel change, watch CI results for regressions and then add the new IGT test.. With that fixed the patches can be applied. :) ~Maarten _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH i-g-t] igt/kms_rotation_crc: Add RGB565 90 degree test for gen>9 2017-11-28 11:53 ` Maarten Lankhorst @ 2017-11-29 13:54 ` Juha-Pekka Heikkila 0 siblings, 0 replies; 6+ messages in thread From: Juha-Pekka Heikkila @ 2017-11-29 13:54 UTC (permalink / raw) To: Maarten Lankhorst, intel-gfx On 28.11.2017 13:53, Maarten Lankhorst wrote: > Hey, > > Op 21-11-17 om 15:02 schreef Juha-Pekka Heikkila: >> Gen10 onwards 90 and 270 degree rotations are supported for RGB565 format. >> >> v2 (Ville Syrjälä): >> As a side effect to keep bad-pixel-format test valid on all supported >> platforms it need to use DRM_FORMAT_C8 now. >> >> While at it clean up kms_rotation_crc test a bit, take out >> test_plane_rotation_ytiled_obj() function as >> test_plane_rotation() can basically do the same. >> >> v3 (Ville Syrjälä): >> repurpose test_plane_rotation_ytiled_obj() function for >> bad pixel testing with DRM_FORMAT_C8 as igt doesn't >> support this format. >> >> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com> > At this point there is no correct order to apply the tests then. > > What I would like to see is the bad-pixel-format changes in a separate commit, so we can commit that first, and then commit kernel change, watch CI results for regressions and then add the new IGT test.. > > With that fixed the patches can be applied. :) > Hei, thanks for the comment Maarten. I'll make the change and add you as cc once done. :) /Juha-Pekka _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
* ✓ Fi.CI.BAT: success for igt/kms_rotation_crc: Add RGB565 90 degree test for gen>9 (rev3) 2017-11-21 14:02 [PATCH i-g-t] igt/kms_rotation_crc: Add RGB565 90 degree test for gen>9 Juha-Pekka Heikkila 2017-11-21 14:02 ` Juha-Pekka Heikkila @ 2017-11-21 14:22 ` Patchwork 2017-11-21 16:34 ` ✗ Fi.CI.IGT: warning " Patchwork 2 siblings, 0 replies; 6+ messages in thread From: Patchwork @ 2017-11-21 14:22 UTC (permalink / raw) To: Juha-Pekka Heikkila; +Cc: intel-gfx == Series Details == Series: igt/kms_rotation_crc: Add RGB565 90 degree test for gen>9 (rev3) URL : https://patchwork.freedesktop.org/series/33132/ State : success == Summary == IGT patchset tested on top of latest successful build 538091ce7008b4281d912422d8bb676c541401a4 tools: Stop opening the driver just to find the debugfs with latest DRM-Tip kernel build CI_DRM_3368 f71044153bec drm-tip: 2017y-11m-21d-10h-48m-53s UTC integration manifest Testlist changes: +igt@kms_rotation_crc@primary-rotation-90-y-tiled-16bpp fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:443s fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:452s fi-blb-e6850 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:385s fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:539s fi-bwr-2160 total:289 pass:183 dwarn:0 dfail:0 fail:0 skip:106 time:278s fi-bxt-dsi total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:30 time:512s fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:509s fi-byt-j1900 total:289 pass:254 dwarn:0 dfail:0 fail:0 skip:35 time:508s fi-byt-n2820 total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:503s fi-cfl-s2 total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:611s fi-elk-e7500 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:442s fi-gdg-551 total:289 pass:178 dwarn:1 dfail:0 fail:1 skip:109 time:265s fi-glk-1 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:545s fi-hsw-4770 total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:432s fi-hsw-4770r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:441s fi-ilk-650 total:289 pass:228 dwarn:0 dfail:0 fail:0 skip:61 time:431s fi-ivb-3520m total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:485s fi-ivb-3770 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:463s fi-kbl-7500u total:289 pass:263 dwarn:1 dfail:0 fail:1 skip:24 time:482s fi-kbl-7560u total:289 pass:270 dwarn:0 dfail:0 fail:0 skip:19 time:535s fi-kbl-7567u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:475s fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:544s fi-pnv-d510 total:289 pass:222 dwarn:1 dfail:0 fail:0 skip:66 time:585s fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:453s fi-skl-6600u total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:548s fi-skl-6700hq total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:572s fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:528s fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:500s fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:462s fi-snb-2520m total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:562s fi-snb-2600 total:289 pass:249 dwarn:0 dfail:0 fail:0 skip:40 time:430s Blacklisted hosts: fi-cnl-y total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:561s fi-glk-dsi total:289 pass:181 dwarn:0 dfail:1 fail:0 skip:107 time:345s == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_516/ _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
* ✗ Fi.CI.IGT: warning for igt/kms_rotation_crc: Add RGB565 90 degree test for gen>9 (rev3) 2017-11-21 14:02 [PATCH i-g-t] igt/kms_rotation_crc: Add RGB565 90 degree test for gen>9 Juha-Pekka Heikkila 2017-11-21 14:02 ` Juha-Pekka Heikkila 2017-11-21 14:22 ` ✓ Fi.CI.BAT: success for igt/kms_rotation_crc: Add RGB565 90 degree test for gen>9 (rev3) Patchwork @ 2017-11-21 16:34 ` Patchwork 2 siblings, 0 replies; 6+ messages in thread From: Patchwork @ 2017-11-21 16:34 UTC (permalink / raw) To: Juha-Pekka Heikkila; +Cc: intel-gfx == Series Details == Series: igt/kms_rotation_crc: Add RGB565 90 degree test for gen>9 (rev3) URL : https://patchwork.freedesktop.org/series/33132/ State : warning == Summary == Test drv_selftest: Subgroup mock_sanitycheck: pass -> DMESG-WARN (shard-snb) fdo#103717 Test gem_userptr_blits: Subgroup dmabuf-unsync: pass -> DMESG-WARN (shard-hsw) fdo#103830 Test gem_exec_reloc: Subgroup basic-write-cpu-noreloc: incomplete -> PASS (shard-snb) Test kms_frontbuffer_tracking: Subgroup fbc-1p-offscren-pri-shrfb-draw-render: pass -> FAIL (shard-snb) fdo#101623 Subgroup fbc-1p-primscrn-cur-indfb-move: pass -> SKIP (shard-hsw) Subgroup fbc-rgb101010-draw-blt: pass -> SKIP (shard-hsw) Test kms_cursor_legacy: Subgroup cursora-vs-flipa-atomic-transitions: pass -> SKIP (shard-hsw) fdo#103172 Test kms_flip: Subgroup basic-flip-vs-dpms: pass -> SKIP (shard-hsw) fdo#102614 Test kms_chv_cursor_fail: Subgroup pipe-a-64x64-left-edge: pass -> SKIP (shard-hsw) Test kms_plane: Subgroup plane-position-covered-pipe-a-planes: pass -> SKIP (shard-hsw) fdo#103717 https://bugs.freedesktop.org/show_bug.cgi?id=103717 fdo#103830 https://bugs.freedesktop.org/show_bug.cgi?id=103830 fdo#101623 https://bugs.freedesktop.org/show_bug.cgi?id=101623 fdo#103172 https://bugs.freedesktop.org/show_bug.cgi?id=103172 fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614 shard-hsw total:2586 pass:1467 dwarn:3 dfail:1 fail:9 skip:1106 time:9302s shard-snb total:2586 pass:1257 dwarn:2 dfail:1 fail:12 skip:1314 time:7829s == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_516/shards.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-11-29 13:54 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-11-21 14:02 [PATCH i-g-t] igt/kms_rotation_crc: Add RGB565 90 degree test for gen>9 Juha-Pekka Heikkila 2017-11-21 14:02 ` Juha-Pekka Heikkila 2017-11-28 11:53 ` Maarten Lankhorst 2017-11-29 13:54 ` Juha-Pekka Heikkila 2017-11-21 14:22 ` ✓ Fi.CI.BAT: success for igt/kms_rotation_crc: Add RGB565 90 degree test for gen>9 (rev3) Patchwork 2017-11-21 16:34 ` ✗ Fi.CI.IGT: warning " Patchwork
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).