Re: [PATCH 2/2] drm/i915: Enable IPS with only sprite plane visible too, v4.

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Wed, Nov 22, 2017 at 07:39:06PM +0100, Maarten Lankhorst wrote:
> This comment predates atomic, and I think with the way we currently
> track IPS, it's safe to enable this for the case we switch too.
> 
> Changes since v1:
> - Keep IPS enabled when switching planes.
> Changes since v2:
> - Enable IPS when at least one plane is enabled. (Ville)
> Changes since v3:
> - Actually do what was advertised in v3, sigh! (Ville, CI)
> 
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> ---
>  drivers/gpu/drm/i915/intel_display.c | 9 ++-------
>  1 file changed, 2 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 95df5c2128b4..3b4ae922be3b 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -6246,13 +6246,8 @@ static bool hsw_compute_ips_config(struct intel_crtc_state *pipe_config)
>  	if (pipe_config->ips_force_disable)
>  		return false;
>  
> -	/*
> -	 * FIXME IPS should be fine as long as one plane is
> -	 * enabled, but in practice it seems to have problems
> -	 * when going from primary only to sprite only and vice
> -	 * versa.
> -	 */
> -	if (!(pipe_config->active_planes & BIT(PLANE_PRIMARY)))
> +	/* IPS should be fine as long as at least one plane is enabled. */
> +	if (!(pipe_config->active_planes & ~BIT(PLANE_CURSOR)))
>  		return false;

Yep, now it makes sense ;)

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

>  
>  	/* pixel rate mustn't exceed 95% of cdclk with IPS on BDW */
> -- 
> 2.15.0

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx