public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH 1/3] drm/i915: Disable DP audio for g4x
@ 2017-11-29 16:43 Ville Syrjala
  2017-11-29 16:43 ` [PATCH 2/3] drm/i915: Don't add the "force audio" property to DP connectors that don't support audio Ville Syrjala
                   ` (6 more replies)
  0 siblings, 7 replies; 12+ messages in thread
From: Ville Syrjala @ 2017-11-29 16:43 UTC (permalink / raw)
  To: intel-gfx

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Apparently g4x doesn't support audio over DP. Bspec lists the
bit as "Reserved for Audio Output Enable", and empirical evidence
tells us that the bit won't stick. So stop trying to enable DP
audio on g4x.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/i915/intel_dp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 957735c0b4c6..0e1a20e625e4 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -1643,7 +1643,7 @@ intel_dp_compute_config(struct intel_encoder *encoder,
 		pipe_config->has_pch_encoder = true;
 
 	pipe_config->has_drrs = false;
-	if (port == PORT_A)
+	if (IS_G4X(dev_priv) || port == PORT_A)
 		pipe_config->has_audio = false;
 	else if (intel_conn_state->force_audio == HDMI_AUDIO_AUTO)
 		pipe_config->has_audio = intel_dp->has_audio;
-- 
2.13.6

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2017-12-01 15:11 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-29 16:43 [PATCH 1/3] drm/i915: Disable DP audio for g4x Ville Syrjala
2017-11-29 16:43 ` [PATCH 2/3] drm/i915: Don't add the "force audio" property to DP connectors that don't support audio Ville Syrjala
2017-11-29 23:26   ` Rodrigo Vivi
2017-11-30  8:16     ` Daniel Vetter
2017-11-29 16:43 ` [PATCH 3/3] drm/i915: Fix has_audio readout for DDI A Ville Syrjala
2017-11-29 23:23   ` Rodrigo Vivi
2017-11-29 23:22 ` [PATCH 1/3] drm/i915: Disable DP audio for g4x Rodrigo Vivi
2017-12-01 15:11   ` Ville Syrjälä
2017-11-30  9:10 ` ✗ Fi.CI.BAT: failure for series starting with [1/3] " Patchwork
2017-11-30 11:40 ` ✓ Fi.CI.BAT: success " Patchwork
2017-11-30 14:23 ` ✗ Fi.CI.IGT: failure " Patchwork
2017-11-30 15:11 ` ✓ Fi.CI.BAT: success " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox