From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 1/3] drm/plane: Make framebuffer refcounting
 the responsibility of setplane_internal callers
Date: Wed, 20 Dec 2017 11:23:27 +0100
Message-ID: <20171220102327.GN26573@phenom.ffwll.local>
References: <20171220093545.613-1-maarten.lankhorst@linux.intel.com>
 <20171220093545.613-2-maarten.lankhorst@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com
 [IPv6:2a00:1450:400c:c09::244])
 by gabe.freedesktop.org (Postfix) with ESMTPS id C1810899E8
 for <intel-gfx@lists.freedesktop.org>; Wed, 20 Dec 2017 10:23:32 +0000 (UTC)
Received: by mail-wm0-x244.google.com with SMTP id f206so8675460wmf.5
 for <intel-gfx@lists.freedesktop.org>; Wed, 20 Dec 2017 02:23:32 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <20171220093545.613-2-maarten.lankhorst@linux.intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gV2VkLCBEZWMgMjAsIDIwMTcgYXQgMTA6MzU6NDNBTSArMDEwMCwgTWFhcnRlbiBMYW5raG9y
c3Qgd3JvdGU6Cj4gbG9ja19hbGxfY3R4IGluIHNldHBsYW5lX2ludGVybmFsIG1heSByZXR1cm4g
LUVJTlRSLCBhbmQKPiBfX3NldHBsYW5lX2ludGVybmFsIGNvdWxkIHJldHVybiAtRURFQURMSy4g
TWFraW5nIG1vcmUKPiBzcGVjaWFsIGNhc2VzIGZvciBmYiB3b3VsZCBtYWtlIHRoZSBjb2RlIGV2
ZW4gaGFyZGVyIHRvCj4gcmVhZCwgc28gdGhlIGVhc2llc3Qgc29sdXRpb24gaXMgbm90IHRha2lu
ZyBvdmVyIHRoZSBmYgo+IHJlZmNvdW50LCBhbmQgbWFraW5nIGNhbGxlcnMgcmVzcG9uc2libGUg
Zm9yIGRyb3BwaW5nCj4gdGhlIHJlZi4KPiAKPiBCdWd6aWxsYTogaHR0cHM6Ly9idWdzLmZyZWVk
ZXNrdG9wLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAyNzA3Cj4gRml4ZXM6IDEzNzM2YmEzYjM4YiAo
ImRybS9sZWdhY3k6IENvbnZlcnQgc2V0cGxhbmUgaW9jdGwgbG9ja2luZyB0byBpbnRlcnJ1cHRp
YmxlLiIpCj4gVGVzdGNhc2U6IGttc19hdG9taWNfaW50ZXJydXB0aWJsZQo+IFNpZ25lZC1vZmYt
Ynk6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+
CgpJIHRob3VnaHQgSSByZXZpZXdlZCB0aGlzIG9uZSBiZWZvcmUgYWxyZWFkeSwgYnV0IHByb2Jh
Ymx5IGp1c3QgYSBwYXN0ZQpzb21ld2hlcmUgb24gaXJjLgoKUmV2aWV3ZWQtYnk6IERhbmllbCBW
ZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0v
ZHJtX3BsYW5lLmMgfCA0MiArKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0KPiAgMSBmaWxlIGNoYW5nZWQsIDIwIGluc2VydGlvbnMoKyksIDIyIGRlbGV0aW9ucygtKQo+
IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX3BsYW5lLmMgYi9kcml2ZXJzL2dw
dS9kcm0vZHJtX3BsYW5lLmMKPiBpbmRleCAzN2E5M2NkZmZiNGEuLjJjOTA1MTk1NzZhMyAxMDA2
NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX3BsYW5lLmMKPiArKysgYi9kcml2ZXJzL2dw
dS9kcm0vZHJtX3BsYW5lLmMKPiBAQCAtNTU4LDExICs1NTgsMTAgQEAgaW50IGRybV9wbGFuZV9j
aGVja19waXhlbF9mb3JtYXQoY29uc3Qgc3RydWN0IGRybV9wbGFuZSAqcGxhbmUsIHUzMiBmb3Jt
YXQpCj4gIH0KPiAgCj4gIC8qCj4gLSAqIHNldHBsYW5lX2ludGVybmFsIC0gc2V0cGxhbmUgaGFu
ZGxlciBmb3IgaW50ZXJuYWwgY2FsbGVycwo+ICsgKiBfX3NldHBsYW5lX2ludGVybmFsIC0gc2V0
cGxhbmUgaGFuZGxlciBmb3IgaW50ZXJuYWwgY2FsbGVycwo+ICAgKgo+IC0gKiBOb3RlIHRoYXQg
d2UgYXNzdW1lIGFuIGV4dHJhIHJlZmVyZW5jZSBoYXMgYWxyZWFkeSBiZWVuIHRha2VuIG9uIGZi
LiAgSWYgdGhlCj4gLSAqIHVwZGF0ZSBmYWlscywgdGhpcyByZWZlcmVuY2Ugd2lsbCBiZSBkcm9w
cGVkIGJlZm9yZSByZXR1cm47IGlmIGl0IHN1Y2NlZWRzLAo+IC0gKiB0aGUgcHJldmlvdXMgZnJh
bWVidWZmZXIgKGlmIGFueSkgd2lsbCBiZSB1bnJlZmVyZW5jZWQgaW5zdGVhZC4KPiArICogVGhp
cyBmdW5jdGlvbiB3aWxsIHRha2UgYSByZWZlcmVuY2Ugb24gdGhlIG5ldyBmYiBmb3IgdGhlIHBs
YW5lCj4gKyAqIG9uIHN1Y2Nlc3MuCj4gICAqCj4gICAqIHNyY197eCx5LHcsaH0gYXJlIHByb3Zp
ZGVkIGluIDE2LjE2IGZpeGVkIHBvaW50IGZvcm1hdAo+ICAgKi8KPiBAQCAtNjMwLDE0ICs2Mjks
MTIgQEAgc3RhdGljIGludCBfX3NldHBsYW5lX2ludGVybmFsKHN0cnVjdCBkcm1fcGxhbmUgKnBs
YW5lLAo+ICAJaWYgKCFyZXQpIHsKPiAgCQlwbGFuZS0+Y3J0YyA9IGNydGM7Cj4gIAkJcGxhbmUt
PmZiID0gZmI7Cj4gLQkJZmIgPSBOVUxMOwo+ICsJCWRybV9mcmFtZWJ1ZmZlcl9nZXQocGxhbmUt
PmZiKTsKPiAgCX0gZWxzZSB7Cj4gIAkJcGxhbmUtPm9sZF9mYiA9IE5VTEw7Cj4gIAl9Cj4gIAo+
ICBvdXQ6Cj4gLQlpZiAoZmIpCj4gLQkJZHJtX2ZyYW1lYnVmZmVyX3B1dChmYik7Cj4gIAlpZiAo
cGxhbmUtPm9sZF9mYikKPiAgCQlkcm1fZnJhbWVidWZmZXJfcHV0KHBsYW5lLT5vbGRfZmIpOwo+
ICAJcGxhbmUtPm9sZF9mYiA9IE5VTEw7Cj4gQEAgLTY4NSw2ICs2ODIsNyBAQCBpbnQgZHJtX21v
ZGVfc2V0cGxhbmUoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgdm9pZCAqZGF0YSwKPiAgCXN0cnVj
dCBkcm1fcGxhbmUgKnBsYW5lOwo+ICAJc3RydWN0IGRybV9jcnRjICpjcnRjID0gTlVMTDsKPiAg
CXN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiID0gTlVMTDsKPiArCWludCByZXQ7Cj4gIAo+ICAJ
aWYgKCFkcm1fY29yZV9jaGVja19mZWF0dXJlKGRldiwgRFJJVkVSX01PREVTRVQpKQo+ICAJCXJl
dHVybiAtRUlOVkFMOwo+IEBAIC03MTcsMTUgKzcxNSwxNiBAQCBpbnQgZHJtX21vZGVfc2V0cGxh
bmUoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgdm9pZCAqZGF0YSwKPiAgCQl9Cj4gIAl9Cj4gIAo+
IC0JLyoKPiAtCSAqIHNldHBsYW5lX2ludGVybmFsIHdpbGwgdGFrZSBjYXJlIG9mIGRlcmVmJ2lu
ZyBlaXRoZXIgdGhlIG9sZCBvciBuZXcKPiAtCSAqIGZyYW1lYnVmZmVyIGRlcGVuZGluZyBvbiBz
dWNjZXNzLgo+IC0JICovCj4gLQlyZXR1cm4gc2V0cGxhbmVfaW50ZXJuYWwocGxhbmUsIGNydGMs
IGZiLAo+IC0JCQkJIHBsYW5lX3JlcS0+Y3J0Y194LCBwbGFuZV9yZXEtPmNydGNfeSwKPiAtCQkJ
CSBwbGFuZV9yZXEtPmNydGNfdywgcGxhbmVfcmVxLT5jcnRjX2gsCj4gLQkJCQkgcGxhbmVfcmVx
LT5zcmNfeCwgcGxhbmVfcmVxLT5zcmNfeSwKPiAtCQkJCSBwbGFuZV9yZXEtPnNyY193LCBwbGFu
ZV9yZXEtPnNyY19oKTsKPiArCXJldCA9IHNldHBsYW5lX2ludGVybmFsKHBsYW5lLCBjcnRjLCBm
YiwKPiArCQkJCXBsYW5lX3JlcS0+Y3J0Y194LCBwbGFuZV9yZXEtPmNydGNfeSwKPiArCQkJCXBs
YW5lX3JlcS0+Y3J0Y193LCBwbGFuZV9yZXEtPmNydGNfaCwKPiArCQkJCXBsYW5lX3JlcS0+c3Jj
X3gsIHBsYW5lX3JlcS0+c3JjX3ksCj4gKwkJCQlwbGFuZV9yZXEtPnNyY193LCBwbGFuZV9yZXEt
PnNyY19oKTsKPiArCj4gKwlpZiAoZmIpCj4gKwkJZHJtX2ZyYW1lYnVmZmVyX3B1dChmYik7Cj4g
Kwo+ICsJcmV0dXJuIHJldDsKPiAgfQo+ICAKPiAgc3RhdGljIGludCBkcm1fbW9kZV9jdXJzb3Jf
dW5pdmVyc2FsKHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiBAQCAtNzg4LDEzICs3ODcsMTIgQEAg
c3RhdGljIGludCBkcm1fbW9kZV9jdXJzb3JfdW5pdmVyc2FsKHN0cnVjdCBkcm1fY3J0YyAqY3J0
YywKPiAgCQlzcmNfaCA9IGZiLT5oZWlnaHQgPDwgMTY7Cj4gIAl9Cj4gIAo+IC0JLyoKPiAtCSAq
IHNldHBsYW5lX2ludGVybmFsIHdpbGwgdGFrZSBjYXJlIG9mIGRlcmVmJ2luZyBlaXRoZXIgdGhl
IG9sZCBvciBuZXcKPiAtCSAqIGZyYW1lYnVmZmVyIGRlcGVuZGluZyBvbiBzdWNjZXNzLgo+IC0J
ICovCj4gIAlyZXQgPSBfX3NldHBsYW5lX2ludGVybmFsKGNydGMtPmN1cnNvciwgY3J0YywgZmIs
Cj4gLQkJCQljcnRjX3gsIGNydGNfeSwgY3J0Y193LCBjcnRjX2gsCj4gLQkJCQkwLCAwLCBzcmNf
dywgc3JjX2gsIGN0eCk7Cj4gKwkJCQkgIGNydGNfeCwgY3J0Y195LCBjcnRjX3csIGNydGNfaCwK
PiArCQkJCSAgMCwgMCwgc3JjX3csIHNyY19oLCBjdHgpOwo+ICsKPiArCWlmIChmYikKPiArCQlk
cm1fZnJhbWVidWZmZXJfcHV0KGZiKTsKPiAgCj4gIAkvKiBVcGRhdGUgc3VjY2Vzc2Z1bDsgc2F2
ZSBuZXcgY3Vyc29yIHBvc2l0aW9uLCBpZiBuZWNlc3NhcnkgKi8KPiAgCWlmIChyZXQgPT0gMCAm
JiByZXEtPmZsYWdzICYgRFJNX01PREVfQ1VSU09SX01PVkUpIHsKPiAtLSAKPiAyLjE1LjEKPiAK
PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IGRyaS1k
ZXZlbCBtYWlsaW5nIGxpc3QKPiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0
cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwKCi0t
IApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRw
Oi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3Rv
cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRl
bC1nZngK