Re: [PATCH v2 3/8] drm/i915: Add the missing Y/Yf modifiers for SKL+ sprites

Ville Syrjälä
2018-01-17T20:01:14Z

On Wed, Jan 10, 2018 at 01:59:44PM +0100, Daniel Vetter wrote:
> On Fri, Dec 22, 2017 at 09:22:26PM +0200, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Y/Yf were dropped out from the SKL+ sprite modifier list on account
> > of some watermark issues Daniel Stone was having. My subsequent testing
> > seemed to indicate that things work better now, so add the modifiers
> > back in.
> >
> > v2: Update the commit message with a better explanation
> >
> > Cc: Ben Widawsky <ben@bwidawsk.net>
> > Cc: Jason Ekstrand <jason@jlekstrand.net>
> > Cc: Daniel Stone <daniels@collabora.com>
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Do we have coverage for this in igt? If yes, then

Not sure what test you're actually after here. This only changes
what we expose in the blobifier, but it doesn't change what kind
modifiers the user can actually use with the sprites. Ie. Y/Yf
tiled framebuffers are accepted even before this patch. I do
believe we have some Y/Yf tests on arbitrary planes in some
of the plane tests.

We have no specific tests for blobifiers I think. kms_ccs does use
them to check for CCS support though. We should probably add something
to igt_kms to use them for figuring out which format+modifier combos
are supported by each plane.

>
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> > ---
> > drivers/gpu/drm/i915/intel_sprite.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c
> > index dd485f59eb1d..51bd79ad647a 100644
> > --- a/drivers/gpu/drm/i915/intel_sprite.c
> > +++ b/drivers/gpu/drm/i915/intel_sprite.c
> > @@ -1162,6 +1162,8 @@ static uint32_t skl_plane_formats[] = {
> > };
> >
> > static const uint64_t skl_plane_format_modifiers[] = {
> > + I915_FORMAT_MOD_Yf_TILED,
> > + I915_FORMAT_MOD_Y_TILED,
> > I915_FORMAT_MOD_X_TILED,
> > DRM_FORMAT_MOD_LINEAR,
> > DRM_FORMAT_MOD_INVALID
> > --
> > 2.13.6
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch

--
Ville Syrjälä
Intel OTC