From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [RFC v2 4/8] drm/fb-helper: Ensure driver module is pinned in fb_open() Date: Tue, 9 Jan 2018 11:18:02 +0100 Message-ID: <20180109101802.GN26573@phenom.ffwll.local> References: <20180103222110.45855-1-noralf@tronnes.org> <20180103222110.45855-5-noralf@tronnes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6AA096E04D for ; Tue, 9 Jan 2018 10:18:06 +0000 (UTC) Received: by mail-wm0-x244.google.com with SMTP id f140so19473049wmd.2 for ; Tue, 09 Jan 2018 02:18:06 -0800 (PST) Content-Disposition: inline In-Reply-To: <20180103222110.45855-5-noralf@tronnes.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= Cc: daniel.vetter@ffwll.ch, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, laurent.pinchart@ideasonboard.com, dh.herrmann@gmail.com List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBKYW4gMDMsIDIwMTggYXQgMTE6MjE6MDZQTSArMDEwMCwgTm9yYWxmIFRyw7hubmVz IHdyb3RlOgo+IElmIHN0cnVjdCBmYl9vcHMgaXMgZGVmaW5lZCBpbiBhIGxpYnJhcnkgbGlrZSBj bWEsIGZiX29wZW4oKSBhbmQgZmJjb24KPiB0YWtlcyBhIHJlZiBvbiB0aGUgbGlicmFyeSBpbnN0 ZWFkIG9mIHRoZSBkcml2ZXIgbW9kdWxlLiBVc2UKPiBmYl9vcHMuZmJfb3Blbi9mYl9yZWxlYXNl IHRvIGVuc3VyZSB0aGF0IHRoZSBkcml2ZXIgbW9kdWxlIGlzIHBpbm5lZC4KPiAKPiBTaWduZWQt b2ZmLWJ5OiBOb3JhbGYgVHLDuG5uZXMgPG5vcmFsZkB0cm9ubmVzLm9yZz4KClJldmlld2VkLWJ5 OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgoKLi4uIEkgZ3Vlc3MgdGhl IHBhdGNoIHRvIHJvbGwgaXQgb3V0IHRvIHRoZSB2YXJpb3VzIHZmdW4gdGFibGVzIGFuZAptYWNy b3MgY29tZXMgbGF0ZXI/Ci1EYW5pZWwKCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fZmJf aGVscGVyLmMgfCA0MCArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4g IGluY2x1ZGUvZHJtL2RybV9mYl9oZWxwZXIuaCAgICAgfCAxMyArKysrKysrKysrKysrCj4gIDIg ZmlsZXMgY2hhbmdlZCwgNTMgaW5zZXJ0aW9ucygrKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vZHJtX2ZiX2hlbHBlci5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9mYl9oZWxwZXIu Ywo+IGluZGV4IDAzNTc4NGRkZDEzMy4uMmM2YWRmMWQ4MGMyIDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9kcm1fZmJfaGVscGVyLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2Zi X2hlbHBlci5jCj4gQEAgLTEyMDcsNiArMTIwNyw0NiBAQCB2b2lkIGRybV9mYl9oZWxwZXJfY2Zi X2ltYWdlYmxpdChzdHJ1Y3QgZmJfaW5mbyAqaW5mbywKPiAgfQo+ICBFWFBPUlRfU1lNQk9MKGRy bV9mYl9oZWxwZXJfY2ZiX2ltYWdlYmxpdCk7Cj4gIAo+ICsvKioKPiArICogZHJtX2ZiX2hlbHBl cl9mYl9vcGVuIC0gaW1wbGVtZW50YXRpb24gZm9yICZmYl9vcHMuZmJfb3Blbgo+ICsgKiBAaW5m bzogZmJkZXYgcmVnaXN0ZXJlZCBieSB0aGUgaGVscGVyCj4gKyAqIEB1c2VyOiAxPXVzZXJzcGFj ZSwgMD1mYmNvbgo+ICsgKgo+ICsgKiBJZiAmZmJfb3BzIGlzIHdyYXBwZWQgaW4gYSBsaWJyYXJ5 LCBwaW4gdGhlIGRyaXZlciBtb2R1bGUuCj4gKyAqLwo+ICtpbnQgZHJtX2ZiX2hlbHBlcl9mYl9v cGVuKHN0cnVjdCBmYl9pbmZvICppbmZvLCBpbnQgdXNlcikKPiArewo+ICsJc3RydWN0IGRybV9m Yl9oZWxwZXIgKmZiX2hlbHBlciA9IGluZm8tPnBhcjsKPiArCXN0cnVjdCBkcm1fZGV2aWNlICpk ZXYgPSBmYl9oZWxwZXItPmRldjsKPiArCj4gKwlpZiAoaW5mby0+ZmJvcHMtPm93bmVyICE9IGRl di0+ZHJpdmVyLT5mb3BzLT5vd25lcikgewo+ICsJCWlmICghdHJ5X21vZHVsZV9nZXQoZGV2LT5k cml2ZXItPmZvcHMtPm93bmVyKSkKPiArCQkJcmV0dXJuIC1FTk9ERVY7Cj4gKwl9Cj4gKwo+ICsJ cmV0dXJuIDA7Cj4gK30KPiArRVhQT1JUX1NZTUJPTChkcm1fZmJfaGVscGVyX2ZiX29wZW4pOwo+ ICsKPiArLyoqCj4gKyAqIGRybV9mYl9oZWxwZXJfZmJfcmVsZWFzZSAtIGltcGxlbWVudGF0aW9u IGZvciAmZmJfb3BzLmZiX3JlbGVhc2UKPiArICogQGluZm86IGZiZGV2IHJlZ2lzdGVyZWQgYnkg dGhlIGhlbHBlcgo+ICsgKiBAdXNlcjogMT11c2Vyc3BhY2UsIDA9ZmJjb24KPiArICoKPiArICog SWYgJmZiX29wcyBpcyB3cmFwcGVkIGluIGEgbGlicmFyeSwgdW5waW4gdGhlIGRyaXZlciBtb2R1 bGUuCj4gKyAqLwo+ICtpbnQgZHJtX2ZiX2hlbHBlcl9mYl9yZWxlYXNlKHN0cnVjdCBmYl9pbmZv ICppbmZvLCBpbnQgdXNlcikKPiArewo+ICsJc3RydWN0IGRybV9mYl9oZWxwZXIgKmZiX2hlbHBl ciA9IGluZm8tPnBhcjsKPiArCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBmYl9oZWxwZXItPmRl djsKPiArCj4gKwlpZiAoaW5mby0+ZmJvcHMtPm93bmVyICE9IGRldi0+ZHJpdmVyLT5mb3BzLT5v d25lcikKPiArCQltb2R1bGVfcHV0KGRldi0+ZHJpdmVyLT5mb3BzLT5vd25lcik7Cj4gKwo+ICsJ cmV0dXJuIDA7Cj4gK30KPiArRVhQT1JUX1NZTUJPTChkcm1fZmJfaGVscGVyX2ZiX3JlbGVhc2Up Owo+ICsKPiAgLyoqCj4gICAqIGRybV9mYl9oZWxwZXJfc2V0X3N1c3BlbmQgLSB3cmFwcGVyIGFy b3VuZCBmYl9zZXRfc3VzcGVuZAo+ICAgKiBAZmJfaGVscGVyOiBkcml2ZXItYWxsb2NhdGVkIGZi ZGV2IGhlbHBlciwgY2FuIGJlIE5VTEwKPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9kcm0vZHJtX2Zi X2hlbHBlci5oIGIvaW5jbHVkZS9kcm0vZHJtX2ZiX2hlbHBlci5oCj4gaW5kZXggYjA2OTQzM2U3 ZmMxLi5hNTkzZjAxZmY2OWUgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVkZS9kcm0vZHJtX2ZiX2hlbHBl ci5oCj4gKysrIGIvaW5jbHVkZS9kcm0vZHJtX2ZiX2hlbHBlci5oCj4gQEAgLTI5Nyw2ICsyOTcs OSBAQCB2b2lkIGRybV9mYl9oZWxwZXJfY2ZiX2NvcHlhcmVhKHN0cnVjdCBmYl9pbmZvICppbmZv LAo+ICB2b2lkIGRybV9mYl9oZWxwZXJfY2ZiX2ltYWdlYmxpdChzdHJ1Y3QgZmJfaW5mbyAqaW5m bywKPiAgCQkJCSBjb25zdCBzdHJ1Y3QgZmJfaW1hZ2UgKmltYWdlKTsKPiAgCj4gK2ludCBkcm1f ZmJfaGVscGVyX2ZiX29wZW4oc3RydWN0IGZiX2luZm8gKmluZm8sIGludCB1c2VyKTsKPiAraW50 IGRybV9mYl9oZWxwZXJfZmJfcmVsZWFzZShzdHJ1Y3QgZmJfaW5mbyAqaW5mbywgaW50IHVzZXIp Owo+ICsKPiAgdm9pZCBkcm1fZmJfaGVscGVyX3NldF9zdXNwZW5kKHN0cnVjdCBkcm1fZmJfaGVs cGVyICpmYl9oZWxwZXIsIGJvb2wgc3VzcGVuZCk7Cj4gIHZvaWQgZHJtX2ZiX2hlbHBlcl9zZXRf c3VzcGVuZF91bmxvY2tlZChzdHJ1Y3QgZHJtX2ZiX2hlbHBlciAqZmJfaGVscGVyLAo+ICAJCQkJ CWJvb2wgc3VzcGVuZCk7Cj4gQEAgLTQ3Myw2ICs0NzYsMTYgQEAgc3RhdGljIGlubGluZSB2b2lk IGRybV9mYl9oZWxwZXJfY2ZiX2ltYWdlYmxpdChzdHJ1Y3QgZmJfaW5mbyAqaW5mbywKPiAgewo+ ICB9Cj4gIAo+ICtzdGF0aWMgaW5saW5lIGludCBkcm1fZmJfaGVscGVyX2ZiX29wZW4oc3RydWN0 IGZiX2luZm8gKmluZm8sIGludCB1c2VyKQo+ICt7Cj4gKwlyZXR1cm4gLUVOT0RFVjsKPiArfQo+ ICsKPiArc3RhdGljIGlubGluZSBpbnQgZHJtX2ZiX2hlbHBlcl9mYl9yZWxlYXNlKHN0cnVjdCBm Yl9pbmZvICppbmZvLCBpbnQgdXNlcikKPiArewo+ICsJcmV0dXJuIC1FTk9ERVY7Cj4gK30KPiAr Cj4gIHN0YXRpYyBpbmxpbmUgdm9pZCBkcm1fZmJfaGVscGVyX3NldF9zdXNwZW5kKHN0cnVjdCBk cm1fZmJfaGVscGVyICpmYl9oZWxwZXIsCj4gIAkJCQkJICAgICBib29sIHN1c3BlbmQpCj4gIHsK PiAtLSAKPiAyLjE0LjIKPiAKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJ bnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVs LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK