From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [RFC v2 4/8] drm/fb-helper: Ensure driver module is pinned in fb_open() Date: Tue, 9 Jan 2018 11:22:24 +0100 Message-ID: <20180109102224.GQ26573@phenom.ffwll.local> References: <20180103222110.45855-1-noralf@tronnes.org> <20180103222110.45855-5-noralf@tronnes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id 931CC8938F for ; Tue, 9 Jan 2018 10:22:28 +0000 (UTC) Received: by mail-wm0-x242.google.com with SMTP id f206so19503880wmf.5 for ; Tue, 09 Jan 2018 02:22:28 -0800 (PST) Content-Disposition: inline In-Reply-To: <20180103222110.45855-5-noralf@tronnes.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= Cc: daniel.vetter@ffwll.ch, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, laurent.pinchart@ideasonboard.com, dh.herrmann@gmail.com List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBKYW4gMDMsIDIwMTggYXQgMTE6MjE6MDZQTSArMDEwMCwgTm9yYWxmIFRyw7hubmVz IHdyb3RlOgo+IElmIHN0cnVjdCBmYl9vcHMgaXMgZGVmaW5lZCBpbiBhIGxpYnJhcnkgbGlrZSBj bWEsIGZiX29wZW4oKSBhbmQgZmJjb24KPiB0YWtlcyBhIHJlZiBvbiB0aGUgbGlicmFyeSBpbnN0 ZWFkIG9mIHRoZSBkcml2ZXIgbW9kdWxlLiBVc2UKPiBmYl9vcHMuZmJfb3Blbi9mYl9yZWxlYXNl IHRvIGVuc3VyZSB0aGF0IHRoZSBkcml2ZXIgbW9kdWxlIGlzIHBpbm5lZC4KPiAKPiBTaWduZWQt b2ZmLWJ5OiBOb3JhbGYgVHLDuG5uZXMgPG5vcmFsZkB0cm9ubmVzLm9yZz4KPiAtLS0KPiAgZHJp dmVycy9ncHUvZHJtL2RybV9mYl9oZWxwZXIuYyB8IDQwICsrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysKPiAgaW5jbHVkZS9kcm0vZHJtX2ZiX2hlbHBlci5oICAgICB8IDEz ICsrKysrKysrKysrKysKPiAgMiBmaWxlcyBjaGFuZ2VkLCA1MyBpbnNlcnRpb25zKCspCj4gCj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZmJfaGVscGVyLmMgYi9kcml2ZXJzL2dw dS9kcm0vZHJtX2ZiX2hlbHBlci5jCj4gaW5kZXggMDM1Nzg0ZGRkMTMzLi4yYzZhZGYxZDgwYzIg MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9mYl9oZWxwZXIuYwo+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9kcm1fZmJfaGVscGVyLmMKPiBAQCAtMTIwNyw2ICsxMjA3LDQ2IEBAIHZv aWQgZHJtX2ZiX2hlbHBlcl9jZmJfaW1hZ2VibGl0KHN0cnVjdCBmYl9pbmZvICppbmZvLAo+ICB9 Cj4gIEVYUE9SVF9TWU1CT0woZHJtX2ZiX2hlbHBlcl9jZmJfaW1hZ2VibGl0KTsKPiAgCj4gKy8q Kgo+ICsgKiBkcm1fZmJfaGVscGVyX2ZiX29wZW4gLSBpbXBsZW1lbnRhdGlvbiBmb3IgJmZiX29w cy5mYl9vcGVuCj4gKyAqIEBpbmZvOiBmYmRldiByZWdpc3RlcmVkIGJ5IHRoZSBoZWxwZXIKPiAr ICogQHVzZXI6IDE9dXNlcnNwYWNlLCAwPWZiY29uCj4gKyAqCj4gKyAqIElmICZmYl9vcHMgaXMg d3JhcHBlZCBpbiBhIGxpYnJhcnksIHBpbiB0aGUgZHJpdmVyIG1vZHVsZS4KPiArICovCj4gK2lu dCBkcm1fZmJfaGVscGVyX2ZiX29wZW4oc3RydWN0IGZiX2luZm8gKmluZm8sIGludCB1c2VyKQo+ ICt7Cj4gKwlzdHJ1Y3QgZHJtX2ZiX2hlbHBlciAqZmJfaGVscGVyID0gaW5mby0+cGFyOwo+ICsJ c3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGZiX2hlbHBlci0+ZGV2Owo+ICsKPiArCWlmIChpbmZv LT5mYm9wcy0+b3duZXIgIT0gZGV2LT5kcml2ZXItPmZvcHMtPm93bmVyKSB7CgpBY3R1YWxseSBi aWtlc2hlZCBwb3RlbnRpYWwgaGVyZTogSSdkIGp1c3QgdW5jb25kaXRpb25hbGx5IGdyYWIgdGhl IG1vZHVsZQpyZWZlcmVuY2UsIG1ha2VzIHRoZSBjb2RlIHNpbXBsZXIuIE9yIGlzIHRoZXJlIGEg cmVhc29uIG5vdCB0bz8KLURhbmllbAoKPiArCQlpZiAoIXRyeV9tb2R1bGVfZ2V0KGRldi0+ZHJp dmVyLT5mb3BzLT5vd25lcikpCj4gKwkJCXJldHVybiAtRU5PREVWOwo+ICsJfQo+ICsKPiArCXJl dHVybiAwOwo+ICt9Cj4gK0VYUE9SVF9TWU1CT0woZHJtX2ZiX2hlbHBlcl9mYl9vcGVuKTsKPiAr Cj4gKy8qKgo+ICsgKiBkcm1fZmJfaGVscGVyX2ZiX3JlbGVhc2UgLSBpbXBsZW1lbnRhdGlvbiBm b3IgJmZiX29wcy5mYl9yZWxlYXNlCj4gKyAqIEBpbmZvOiBmYmRldiByZWdpc3RlcmVkIGJ5IHRo ZSBoZWxwZXIKPiArICogQHVzZXI6IDE9dXNlcnNwYWNlLCAwPWZiY29uCj4gKyAqCj4gKyAqIElm ICZmYl9vcHMgaXMgd3JhcHBlZCBpbiBhIGxpYnJhcnksIHVucGluIHRoZSBkcml2ZXIgbW9kdWxl Lgo+ICsgKi8KPiAraW50IGRybV9mYl9oZWxwZXJfZmJfcmVsZWFzZShzdHJ1Y3QgZmJfaW5mbyAq aW5mbywgaW50IHVzZXIpCj4gK3sKPiArCXN0cnVjdCBkcm1fZmJfaGVscGVyICpmYl9oZWxwZXIg PSBpbmZvLT5wYXI7Cj4gKwlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gZmJfaGVscGVyLT5kZXY7 Cj4gKwo+ICsJaWYgKGluZm8tPmZib3BzLT5vd25lciAhPSBkZXYtPmRyaXZlci0+Zm9wcy0+b3du ZXIpCj4gKwkJbW9kdWxlX3B1dChkZXYtPmRyaXZlci0+Zm9wcy0+b3duZXIpOwo+ICsKPiArCXJl dHVybiAwOwo+ICt9Cj4gK0VYUE9SVF9TWU1CT0woZHJtX2ZiX2hlbHBlcl9mYl9yZWxlYXNlKTsK PiArCj4gIC8qKgo+ICAgKiBkcm1fZmJfaGVscGVyX3NldF9zdXNwZW5kIC0gd3JhcHBlciBhcm91 bmQgZmJfc2V0X3N1c3BlbmQKPiAgICogQGZiX2hlbHBlcjogZHJpdmVyLWFsbG9jYXRlZCBmYmRl diBoZWxwZXIsIGNhbiBiZSBOVUxMCj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvZHJtL2RybV9mYl9o ZWxwZXIuaCBiL2luY2x1ZGUvZHJtL2RybV9mYl9oZWxwZXIuaAo+IGluZGV4IGIwNjk0MzNlN2Zj MS4uYTU5M2YwMWZmNjllIDEwMDY0NAo+IC0tLSBhL2luY2x1ZGUvZHJtL2RybV9mYl9oZWxwZXIu aAo+ICsrKyBiL2luY2x1ZGUvZHJtL2RybV9mYl9oZWxwZXIuaAo+IEBAIC0yOTcsNiArMjk3LDkg QEAgdm9pZCBkcm1fZmJfaGVscGVyX2NmYl9jb3B5YXJlYShzdHJ1Y3QgZmJfaW5mbyAqaW5mbywK PiAgdm9pZCBkcm1fZmJfaGVscGVyX2NmYl9pbWFnZWJsaXQoc3RydWN0IGZiX2luZm8gKmluZm8s Cj4gIAkJCQkgY29uc3Qgc3RydWN0IGZiX2ltYWdlICppbWFnZSk7Cj4gIAo+ICtpbnQgZHJtX2Zi X2hlbHBlcl9mYl9vcGVuKHN0cnVjdCBmYl9pbmZvICppbmZvLCBpbnQgdXNlcik7Cj4gK2ludCBk cm1fZmJfaGVscGVyX2ZiX3JlbGVhc2Uoc3RydWN0IGZiX2luZm8gKmluZm8sIGludCB1c2VyKTsK PiArCj4gIHZvaWQgZHJtX2ZiX2hlbHBlcl9zZXRfc3VzcGVuZChzdHJ1Y3QgZHJtX2ZiX2hlbHBl ciAqZmJfaGVscGVyLCBib29sIHN1c3BlbmQpOwo+ICB2b2lkIGRybV9mYl9oZWxwZXJfc2V0X3N1 c3BlbmRfdW5sb2NrZWQoc3RydWN0IGRybV9mYl9oZWxwZXIgKmZiX2hlbHBlciwKPiAgCQkJCQli b29sIHN1c3BlbmQpOwo+IEBAIC00NzMsNiArNDc2LDE2IEBAIHN0YXRpYyBpbmxpbmUgdm9pZCBk cm1fZmJfaGVscGVyX2NmYl9pbWFnZWJsaXQoc3RydWN0IGZiX2luZm8gKmluZm8sCj4gIHsKPiAg fQo+ICAKPiArc3RhdGljIGlubGluZSBpbnQgZHJtX2ZiX2hlbHBlcl9mYl9vcGVuKHN0cnVjdCBm Yl9pbmZvICppbmZvLCBpbnQgdXNlcikKPiArewo+ICsJcmV0dXJuIC1FTk9ERVY7Cj4gK30KPiAr Cj4gK3N0YXRpYyBpbmxpbmUgaW50IGRybV9mYl9oZWxwZXJfZmJfcmVsZWFzZShzdHJ1Y3QgZmJf aW5mbyAqaW5mbywgaW50IHVzZXIpCj4gK3sKPiArCXJldHVybiAtRU5PREVWOwo+ICt9Cj4gKwo+ ICBzdGF0aWMgaW5saW5lIHZvaWQgZHJtX2ZiX2hlbHBlcl9zZXRfc3VzcGVuZChzdHJ1Y3QgZHJt X2ZiX2hlbHBlciAqZmJfaGVscGVyLAo+ICAJCQkJCSAgICAgYm9vbCBzdXNwZW5kKQo+ICB7Cj4g LS0gCj4gMi4xNC4yCj4gCgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50 ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1n ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==