From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [RFC v2 5/8] drm/fb-helper: Don't restore if fbdev is not in use Date: Tue, 9 Jan 2018 11:28:12 +0100 Message-ID: <20180109102812.GR26573@phenom.ffwll.local> References: <20180103222110.45855-1-noralf@tronnes.org> <20180103222110.45855-6-noralf@tronnes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id 869686E01F for ; Tue, 9 Jan 2018 10:28:16 +0000 (UTC) Received: by mail-wm0-x244.google.com with SMTP id g75so19502500wme.0 for ; Tue, 09 Jan 2018 02:28:16 -0800 (PST) Content-Disposition: inline In-Reply-To: <20180103222110.45855-6-noralf@tronnes.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= Cc: daniel.vetter@ffwll.ch, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, laurent.pinchart@ideasonboard.com, dh.herrmann@gmail.com List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBKYW4gMDMsIDIwMTggYXQgMTE6MjE6MDdQTSArMDEwMCwgTm9yYWxmIFRyw7hubmVz IHdyb3RlOgo+IEtlZXAgdHJhY2sgb2YgZmJkZXYgdXNlcnMgYW5kIG9ubHkgcmVzdG9yZSBmYmRl diBpbgo+IGRybV9mYl9oZWxwZXJfcmVzdG9yZV9mYmRldl9tb2RlX3VubG9ja2VkKCkgd2hlbiBp biB1c2UuIFRoaXMgYXZvaWRzCj4gZmJkZXYgYmVpbmcgcmVzdG9yZWQgaW4gZHJtX2RyaXZlci5s YXN0X2Nsb3NlIHdoZW4gbm90aGluZyB1c2VzIGl0Lgo+IEFkZGl0aW9uYWxseSBmYmRldiBpcyB0 dXJuZWQgb2ZmIHdoZW4gdGhlIGxhc3QgdXNlciBpcyBjbG9zaW5nLgo+IGZiY29uIGlzIGEgdXNl ciBpbiB0aGlzIGNvbnRleHQuCj4gCj4gU2lnbmVkLW9mZi1ieTogTm9yYWxmIFRyw7hubmVzIDxu b3JhbGZAdHJvbm5lcy5vcmc+Cgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2hlbHBl ci5jIHwgMTUgKysrKysrKysrKysrKysrCj4gIGluY2x1ZGUvZHJtL2RybV9mYl9oZWxwZXIuaCAg ICAgfCAxNCArKysrKysrKysrKysrKwo+ICAyIGZpbGVzIGNoYW5nZWQsIDI5IGluc2VydGlvbnMo KykKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9mYl9oZWxwZXIuYyBiL2Ry aXZlcnMvZ3B1L2RybS9kcm1fZmJfaGVscGVyLmMKPiBpbmRleCAyYzZhZGYxZDgwYzIuLmY5ZGNj N2E1NzYxZiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2hlbHBlci5jCj4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9mYl9oZWxwZXIuYwo+IEBAIC01MjIsNiArNTIyLDkg QEAgaW50IGRybV9mYl9oZWxwZXJfcmVzdG9yZV9mYmRldl9tb2RlX3VubG9ja2VkKHN0cnVjdCBk cm1fZmJfaGVscGVyICpmYl9oZWxwZXIpCj4gIAlpZiAoUkVBRF9PTkNFKGZiX2hlbHBlci0+ZGVm ZXJyZWRfc2V0dXApKQo+ICAJCXJldHVybiAwOwo+ICAKPiArCWlmICghYXRvbWljX3JlYWQoJmZi X2hlbHBlci0+b3Blbl9jb3VudCkpCj4gKwkJcmV0dXJuIDA7Cj4gKwo+ICAJbXV0ZXhfbG9jaygm ZmJfaGVscGVyLT5sb2NrKTsKPiAgCXJldCA9IHJlc3RvcmVfZmJkZXZfbW9kZShmYl9oZWxwZXIp Owo+ICAKPiBAQCAtNzgxLDYgKzc4NCw3IEBAIHZvaWQgZHJtX2ZiX2hlbHBlcl9wcmVwYXJlKHN0 cnVjdCBkcm1fZGV2aWNlICpkZXYsIHN0cnVjdCBkcm1fZmJfaGVscGVyICpoZWxwZXIsCj4gIAlJ TklUX1dPUksoJmhlbHBlci0+cmVzdW1lX3dvcmssIGRybV9mYl9oZWxwZXJfcmVzdW1lX3dvcmtl cik7Cj4gIAlJTklUX1dPUksoJmhlbHBlci0+ZGlydHlfd29yaywgZHJtX2ZiX2hlbHBlcl9kaXJ0 eV93b3JrKTsKPiAgCWhlbHBlci0+ZGlydHlfY2xpcC54MSA9IGhlbHBlci0+ZGlydHlfY2xpcC55 MSA9IH4wOwo+ICsJYXRvbWljX3NldCgmaGVscGVyLT5vcGVuX2NvdW50LCAxKTsKPiAgCW11dGV4 X2luaXQoJmhlbHBlci0+bG9jayk7Cj4gIAloZWxwZXItPmZ1bmNzID0gZnVuY3M7Cj4gIAloZWxw ZXItPmRldiA9IGRldjsKPiBAQCAtMTIxMiw2ICsxMjE2LDcgQEAgRVhQT1JUX1NZTUJPTChkcm1f ZmJfaGVscGVyX2NmYl9pbWFnZWJsaXQpOwo+ICAgKiBAaW5mbzogZmJkZXYgcmVnaXN0ZXJlZCBi eSB0aGUgaGVscGVyCj4gICAqIEB1c2VyOiAxPXVzZXJzcGFjZSwgMD1mYmNvbgo+ICAgKgo+ICsg KiBJbmNyZWFzZSBmYmRldiB1c2UgY291bnQuCj4gICAqIElmICZmYl9vcHMgaXMgd3JhcHBlZCBp biBhIGxpYnJhcnksIHBpbiB0aGUgZHJpdmVyIG1vZHVsZS4KPiAgICovCj4gIGludCBkcm1fZmJf aGVscGVyX2ZiX29wZW4oc3RydWN0IGZiX2luZm8gKmluZm8sIGludCB1c2VyKQo+IEBAIC0xMjI0 LDYgKzEyMjksOCBAQCBpbnQgZHJtX2ZiX2hlbHBlcl9mYl9vcGVuKHN0cnVjdCBmYl9pbmZvICpp bmZvLCBpbnQgdXNlcikKPiAgCQkJcmV0dXJuIC1FTk9ERVY7Cj4gIAl9Cj4gIAo+ICsJYXRvbWlj X2luYygmZmJfaGVscGVyLT5vcGVuX2NvdW50KTsKPiArCj4gIAlyZXR1cm4gMDsKPiAgfQo+ICBF WFBPUlRfU1lNQk9MKGRybV9mYl9oZWxwZXJfZmJfb3Blbik7Cj4gQEAgLTEyMzMsNiArMTI0MCw3 IEBAIEVYUE9SVF9TWU1CT0woZHJtX2ZiX2hlbHBlcl9mYl9vcGVuKTsKPiAgICogQGluZm86IGZi ZGV2IHJlZ2lzdGVyZWQgYnkgdGhlIGhlbHBlcgo+ICAgKiBAdXNlcjogMT11c2Vyc3BhY2UsIDA9 ZmJjb24KPiAgICoKPiArICogRGVjcmVhc2UgZmJkZXYgdXNlIGNvdW50IGFuZCB0dXJuIG9mZiBp ZiB0aGVyZSBhcmUgbm8gdXNlcnMgbGVmdC4KPiAgICogSWYgJmZiX29wcyBpcyB3cmFwcGVkIGlu IGEgbGlicmFyeSwgdW5waW4gdGhlIGRyaXZlciBtb2R1bGUuCj4gICAqLwo+ICBpbnQgZHJtX2Zi X2hlbHBlcl9mYl9yZWxlYXNlKHN0cnVjdCBmYl9pbmZvICppbmZvLCBpbnQgdXNlcikKPiBAQCAt MTI0MCw2ICsxMjQ4LDEwIEBAIGludCBkcm1fZmJfaGVscGVyX2ZiX3JlbGVhc2Uoc3RydWN0IGZi X2luZm8gKmluZm8sIGludCB1c2VyKQo+ICAJc3RydWN0IGRybV9mYl9oZWxwZXIgKmZiX2hlbHBl ciA9IGluZm8tPnBhcjsKPiAgCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBmYl9oZWxwZXItPmRl djsKPiAgCj4gKwlpZiAoYXRvbWljX2RlY19hbmRfdGVzdCgmZmJfaGVscGVyLT5vcGVuX2NvdW50 KSAmJgo+ICsJICAgICFkcm1fZGV2X2lzX3VucGx1Z2dlZChmYl9oZWxwZXItPmRldikpCj4gKwkJ ZHJtX2ZiX2hlbHBlcl9ibGFuayhGQl9CTEFOS19QT1dFUkRPV04sIGluZm8pOwo+ICsKPiAgCWlm IChpbmZvLT5mYm9wcy0+b3duZXIgIT0gZGV2LT5kcml2ZXItPmZvcHMtPm93bmVyKQo+ICAJCW1v ZHVsZV9wdXQoZGV2LT5kcml2ZXItPmZvcHMtPm93bmVyKTsKPiAgCj4gQEAgLTE5MzYsNiArMTk0 OCw5IEBAIHN0YXRpYyBpbnQgZHJtX2ZiX2hlbHBlcl9zaW5nbGVfZmJfcHJvYmUoc3RydWN0IGRy bV9mYl9oZWxwZXIgKmZiX2hlbHBlciwKPiAgCWlmIChyZXQgPCAwKQo+ICAJCXJldHVybiByZXQ7 Cj4gIAo+ICsJaWYgKGZiX2hlbHBlci0+ZmJkZXYtPmZib3BzLT5mYl9vcGVuID09IGRybV9mYl9o ZWxwZXJfZmJfb3BlbikKPiArCQlhdG9taWNfc2V0KCZmYl9oZWxwZXItPm9wZW5fY291bnQsIDAp Owo+ICsKPiAgCXN0cmNweShmYl9oZWxwZXItPmZiLT5jb21tLCAiW2ZiY29uXSIpOwo+ICAJcmV0 dXJuIDA7Cj4gIH0KPiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9kcm0vZHJtX2ZiX2hlbHBlci5oIGIv aW5jbHVkZS9kcm0vZHJtX2ZiX2hlbHBlci5oCj4gaW5kZXggYTU5M2YwMWZmNjllLi4xNmQ4Nzcz YjYwZTMgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVkZS9kcm0vZHJtX2ZiX2hlbHBlci5oCj4gKysrIGIv aW5jbHVkZS9kcm0vZHJtX2ZiX2hlbHBlci5oCj4gQEAgLTIzMiw2ICsyMzIsMjAgQEAgc3RydWN0 IGRybV9mYl9oZWxwZXIgewo+ICAJICogU2VlIGFsc286IEBkZWZlcnJlZF9zZXR1cAo+ICAJICov Cj4gIAlpbnQgcHJlZmVycmVkX2JwcDsKPiArCj4gKwkvKioKPiArCSAqIEBvcGVuX2NvdW50Ogo+ ICsJICoKPiArCSAqIEtlZXBzIHRyYWNrIG9mIGZiZGV2IHVzZSB0byBrbm93IHdoZW4gdG8gbm90 IHJlc3RvcmUgZmJkZXYuCj4gKwkgKgo+ICsJICogRHJpdmVycyB0aGF0IHVzZSBkcm1fZmJfaGVs cGVyX2ZiX29wZW4oKSBhcyB0aGVpciBcLmZiX29wZW4KPiArCSAqIGNhbGxiYWNrIHdpbGwgZ2V0 IGFuIGluaXRpYWwgdmFsdWUgb2YgMCBhbmQgZ2V0IHJlc3RvcmUgYmFzZWQgb24KPiArCSAqIGFj dHVhbCB1c2UuIE90aGVycyB3aWxsIGdldCBhbiBpbml0aWFsIHZhbHVlIG9mIDEgd2hpY2ggbWVh bnMgdGhhdAo+ICsJICogZmJkZXYgd2lsbCBhbHdheXMgYmUgcmVzdG9yZWQuIERyaXZlcnMgdGhh dCBjYWxsCj4gKwkgKiBkcm1fZmJfaGVscGVyX2ZiX29wZW4oKSBpbiB0aGVpciBcLmZiX29wZW4s IHRodXMgbmVlZHMgdG8gc2V0IHRoZQo+ICsJICogaW5pdGlhbCB2YWx1ZSB0byAwIHRoZW1zZWx2 ZXMuCj4gKwkgKi8KPiArCWF0b21pY190IG9wZW5fY291bnQ7CgpEbyB3ZSByZWFsbHkgbmVlZCBh biBhdG9taWNfdCBoZXJlPyBFc3BlY2lhbGx5IHRoZSAiZGlzYWJsZSBzdHVmZiBvbiBsYXN0CmZi X2Nsb3NlIiB3b3VsZCBzdGlsbCBiZSByYWNlIHdpdGhvdXQgbW9yZSBsb2NraW5nLCBhbmQgZnJv bSBhIHF1aWNrIGxvb2sKYXQgdGhlIGZiZGV2IGNvcmUgY29kZSB3ZSdyZSBwcm90ZWN0ZWQgd2l0 aCBmYl9pbmZvLT5sb2NrLiBJIHRoaW5rIGFuCnVuc2lnbmVkIGlzIHBlcmZlY3RseSBmaW5lIGhl cmUuIEFuZCBpZiB3ZSByZWFsbHkgbmVlZCBhdG9taWNzLCB0aGVuCnJlZmNvdW50X3QgKGZvciB0 aGUgc2FmZXR5IGNoZWNrcyB0aGF0IHByb3ZpZGVzKS4KCldpdGggdGhhdCBjaGFuZ2VkOgoKUmV2 aWV3ZWQtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+CgpCdXQgYmVm b3JlIHdlIG1lcmdlIHRoaXMgd2UgZGVmaW5pdGVseSBuZWVkIHRvIHJvbGwgb3V0IGZiX29wZW4v Y2xvc2UgdG8KYWxsIGRyaXZlcnMuIEJ1dCBJIGd1ZXNzIHRoYXQncyB3aHkgdGhlIFJGQyBpbiB5 b3VyIHNlcmllcy4KCk9uIHRoYXQ6IFRoZXJlJ3Mgc29tZSBpbnRlcnN0aW5nIHJ1bnRpbWUgcG0g c3R1ZmYgZm9yCm5vdXZlYXUvYW1kL3JhZGVvbi4gSSBndWVzcyB3ZSdsbCBuZWVkIHRvIGtlZXAg dGhhdC4gUGx1cyB1ZGwgaGFzIHNvbWUKZGVmaW8gZnVuIDotLwotRGFuaWVsCgo+ICB9Owo+ICAK PiAgLyoqCj4gLS0gCj4gMi4xNC4yCj4gCgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdp bmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlz dApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==