Re: [PATCH i-g-t] lib/igt_kms.c: Unconditionally include poll.h

Rhys Kidd
2018-01-10T05:22:24Z

[-- Attachment #1.1: Type: text/plain, Size: 1250 bytes --]

On 9 January 2018 at 05:11, Petri Latvala <petri.latvala@intel.com> wrote:

> Commit 98c64b33a793 ("lib/igt_kms: Drop all stale events on first
> commit.") added a use of poll() to igt_kms.c, but that file only
> includes poll.h when HAVE_UDEV is defined. Move the include outside
> the UDEV conditional.
>
> Fixes: 98c64b33a793 ("lib/igt_kms: Drop all stale events on first commit.")
> Signed-off-by: Petri Latvala <petri.latvala@intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>

I have also hit this issue, and spun up locally the equivalent patch fix,
so also gets my:

Reviewed-by: Rhys Kidd <rhyskidd@gmail.com>

> ---
> lib/igt_kms.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index ec3b7167..069752ec 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -40,8 +40,8 @@
> #endif
> #ifdef HAVE_UDEV
> #include <libudev.h>
> -#include <poll.h>
> #endif
> +#include <poll.h>
> #include <errno.h>
> #include <time.h>
>
> --
> 2.14.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>

[-- Attachment #1.2: Type: text/html, Size: 2648 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]