From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [Intel-gfx] [PATCH 7/8] drm: Check that the plane supports the request format+modifier combo Date: Wed, 10 Jan 2018 14:04:57 +0100 Message-ID: <20180110130457.GR13066@phenom.ffwll.local> References: <20171222192231.17981-1-ville.syrjala@linux.intel.com> <20171222192231.17981-8-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20171222192231.17981-8-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ville Syrjala Cc: intel-gfx@lists.freedesktop.org, Ben Widawsky , dri-devel@lists.freedesktop.org, Daniel Stone List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBEZWMgMjIsIDIwMTcgYXQgMDk6MjI6MzBQTSArMDIwMCwgVmlsbGUgU3lyamFsYSB3 cm90ZToKPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwu Y29tPgo+IAo+IEN1cnJlbnRseSB3ZSBvbmx5IGNoZWNrIHRoYXQgdGhlIHBsYW5lIHN1cHBvcnRz IHRoZSBwaXhlbCBmb3JtYXQgb2YgdGhlCj4gZmIgd2UncmUgYWJvdXQgdG8gZmVlZCB0byBpdC4g RXh0ZW5kIGl0IHRvIGNoZWNrIGFsc28gdGhlIG1vZGlmaWVyLCBhbmQKPiBtb3JlIHNwZWNpZmlj YWxseSB0aGF0IHRoZSBjb21iaW5hdGlvbiBvZiB0aGUgZm9ybWF0IGFuZCBtb2RpZmllciBpcwo+ IHN1cHBvcnRlZC4KPiAKPiBDYzogZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IENj OiBCZW4gV2lkYXdza3kgPGJlbkBid2lkYXdzay5uZXQ+Cj4gQ2M6IEphc29uIEVrc3RyYW5kIDxq YXNvbkBqbGVrc3RyYW5kLm5ldD4KPiBDYzogRGFuaWVsIFN0b25lIDxkYW5pZWxzQGNvbGxhYm9y YS5jb20+Cj4gU2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxp bnV4LmludGVsLmNvbT4KClJldmlld2VkLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVy QGZmd2xsLmNoPgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWMuYyAgICAgICAg fCAxMCArKysrKystLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fY3J0Yy5jICAgICAgICAgIHwg MTAgKysrKysrLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2NydGNfaW50ZXJuYWwuaCB8ICA0 ICsrLS0KPiAgZHJpdmVycy9ncHUvZHJtL2RybV9wbGFuZS5jICAgICAgICAgfCAzMyArKysrKysr KysrKysrKysrKysrKysrKysrKy0tLS0tLS0KPiAgNCBmaWxlcyBjaGFuZ2VkLCA0MCBpbnNlcnRp b25zKCspLCAxNyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2RybV9hdG9taWMuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljLmMKPiBpbmRleCBiNzZk NDkyMThjZjEuLjZlNWMzZWExZTQzYiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJt X2F0b21pYy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWMuYwo+IEBAIC04ODIs MTIgKzg4MiwxNCBAQCBzdGF0aWMgaW50IGRybV9hdG9taWNfcGxhbmVfY2hlY2soc3RydWN0IGRy bV9wbGFuZSAqcGxhbmUsCj4gIAl9Cj4gIAo+ICAJLyogQ2hlY2sgd2hldGhlciB0aGlzIHBsYW5l IHN1cHBvcnRzIHRoZSBmYiBwaXhlbCBmb3JtYXQuICovCj4gLQlyZXQgPSBkcm1fcGxhbmVfY2hl Y2tfcGl4ZWxfZm9ybWF0KHBsYW5lLCBzdGF0ZS0+ZmItPmZvcm1hdC0+Zm9ybWF0KTsKPiArCXJl dCA9IGRybV9wbGFuZV9jaGVja19waXhlbF9mb3JtYXQocGxhbmUsIHN0YXRlLT5mYi0+Zm9ybWF0 LT5mb3JtYXQsCj4gKwkJCQkJICAgc3RhdGUtPmZiLT5tb2RpZmllcik7Cj4gIAlpZiAocmV0KSB7 Cj4gIAkJc3RydWN0IGRybV9mb3JtYXRfbmFtZV9idWYgZm9ybWF0X25hbWU7Cj4gLQkJRFJNX0RF QlVHX0FUT01JQygiSW52YWxpZCBwaXhlbCBmb3JtYXQgJXNcbiIsCj4gLQkJICAgICAgICAgICAg ICAgICBkcm1fZ2V0X2Zvcm1hdF9uYW1lKHN0YXRlLT5mYi0+Zm9ybWF0LT5mb3JtYXQsCj4gLQkJ ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICZmb3JtYXRfbmFtZSkpOwo+ICsJ CURSTV9ERUJVR19BVE9NSUMoIkludmFsaWQgcGl4ZWwgZm9ybWF0ICVzLCBtb2RpZmllciAweCVs bHhcbiIsCj4gKwkJCQkgZHJtX2dldF9mb3JtYXRfbmFtZShzdGF0ZS0+ZmItPmZvcm1hdC0+Zm9y bWF0LAo+ICsJCQkJCQkgICAgICZmb3JtYXRfbmFtZSksCj4gKwkJCQkgc3RhdGUtPmZiLT5tb2Rp Zmllcik7Cj4gIAkJcmV0dXJuIHJldDsKPiAgCX0KPiAgCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9kcm1fY3J0Yy5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9jcnRjLmMKPiBpbmRleCBm MDU1NmU2NTQxMTYuLjgxNmMzMGEwZjAzMCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v ZHJtX2NydGMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fY3J0Yy5jCj4gQEAgLTYyNSwx MiArNjI1LDE0IEBAIGludCBkcm1fbW9kZV9zZXRjcnRjKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYs IHZvaWQgKmRhdGEsCj4gIAkJICovCj4gIAkJaWYgKCFjcnRjLT5wcmltYXJ5LT5mb3JtYXRfZGVm YXVsdCkgewo+ICAJCQlyZXQgPSBkcm1fcGxhbmVfY2hlY2tfcGl4ZWxfZm9ybWF0KGNydGMtPnBy aW1hcnksCj4gLQkJCQkJCQkgICBmYi0+Zm9ybWF0LT5mb3JtYXQpOwo+ICsJCQkJCQkJICAgZmIt PmZvcm1hdC0+Zm9ybWF0LAo+ICsJCQkJCQkJICAgZmItPm1vZGlmaWVyKTsKPiAgCQkJaWYgKHJl dCkgewo+ICAJCQkJc3RydWN0IGRybV9mb3JtYXRfbmFtZV9idWYgZm9ybWF0X25hbWU7Cj4gLQkJ CQlEUk1fREVCVUdfS01TKCJJbnZhbGlkIHBpeGVsIGZvcm1hdCAlc1xuIiwKPiAtCQkJCSAgICAg ICAgICAgICAgZHJtX2dldF9mb3JtYXRfbmFtZShmYi0+Zm9ybWF0LT5mb3JtYXQsCj4gLQkJCQkg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJmZvcm1hdF9uYW1lKSk7Cj4gKwkJCQlE Uk1fREVCVUdfS01TKCJJbnZhbGlkIHBpeGVsIGZvcm1hdCAlcywgbW9kaWZpZXIgMHglbGx4XG4i LAo+ICsJCQkJCSAgICAgIGRybV9nZXRfZm9ybWF0X25hbWUoZmItPmZvcm1hdC0+Zm9ybWF0LAo+ ICsJCQkJCQkJCSAgJmZvcm1hdF9uYW1lKSwKPiArCQkJCQkgICAgICBmYi0+bW9kaWZpZXIpOwo+ ICAJCQkJZ290byBvdXQ7Cj4gIAkJCX0KPiAgCQl9Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9kcm1fY3J0Y19pbnRlcm5hbC5oIGIvZHJpdmVycy9ncHUvZHJtL2RybV9jcnRjX2ludGVy bmFsLmgKPiBpbmRleCBhZjAwZjQyYmEyNjkuLjg2MDk2OGE2NGFlNyAxMDA2NDQKPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vZHJtX2NydGNfaW50ZXJuYWwuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9kcm1fY3J0Y19pbnRlcm5hbC5oCj4gQEAgLTE5Niw4ICsxOTYsOCBAQCBpbnQgZHJtX21vZGVf YXRvbWljX2lvY3RsKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gIC8qIGRybV9wbGFuZS5jICov Cj4gIGludCBkcm1fcGxhbmVfcmVnaXN0ZXJfYWxsKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpOwo+ ICB2b2lkIGRybV9wbGFuZV91bnJlZ2lzdGVyX2FsbChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KTsK PiAtaW50IGRybV9wbGFuZV9jaGVja19waXhlbF9mb3JtYXQoY29uc3Qgc3RydWN0IGRybV9wbGFu ZSAqcGxhbmUsCj4gLQkJCQkgdTMyIGZvcm1hdCk7Cj4gK2ludCBkcm1fcGxhbmVfY2hlY2tfcGl4 ZWxfZm9ybWF0KHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lLAo+ICsJCQkJIHUzMiBmb3JtYXQsIHU2 NCBtb2RpZmllcik7Cj4gIAo+ICAvKiBkcm1fYnJpZGdlLmMgKi8KPiAgdm9pZCBkcm1fYnJpZGdl X2RldGFjaChzdHJ1Y3QgZHJtX2JyaWRnZSAqYnJpZGdlKTsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2RybV9wbGFuZS5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9wbGFuZS5jCj4gaW5k ZXggMmM5MDUxOTU3NmEzLi44YWMxOTM3OWZlOTkgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2RybV9wbGFuZS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9wbGFuZS5jCj4gQEAg LTU0NSwxNiArNTQ1LDMzIEBAIGludCBkcm1fbW9kZV9nZXRwbGFuZShzdHJ1Y3QgZHJtX2Rldmlj ZSAqZGV2LCB2b2lkICpkYXRhLAo+ICAJcmV0dXJuIDA7Cj4gIH0KPiAgCj4gLWludCBkcm1fcGxh bmVfY2hlY2tfcGl4ZWxfZm9ybWF0KGNvbnN0IHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lLCB1MzIg Zm9ybWF0KQo+ICtpbnQgZHJtX3BsYW5lX2NoZWNrX3BpeGVsX2Zvcm1hdChzdHJ1Y3QgZHJtX3Bs YW5lICpwbGFuZSwKPiArCQkJCSB1MzIgZm9ybWF0LCB1NjQgbW9kaWZpZXIpCj4gIHsKPiAgCXVu c2lnbmVkIGludCBpOwo+ICAKPiAgCWZvciAoaSA9IDA7IGkgPCBwbGFuZS0+Zm9ybWF0X2NvdW50 OyBpKyspIHsKPiAgCQlpZiAoZm9ybWF0ID09IHBsYW5lLT5mb3JtYXRfdHlwZXNbaV0pCj4gLQkJ CXJldHVybiAwOwo+ICsJCQlicmVhazsKPiArCX0KPiArCWlmIChpID09IHBsYW5lLT5mb3JtYXRf Y291bnQpCj4gKwkJcmV0dXJuIC1FSU5WQUw7Cj4gKwo+ICsJaWYgKCFwbGFuZS0+bW9kaWZpZXJf Y291bnQpCj4gKwkJcmV0dXJuIDA7Cj4gKwo+ICsJZm9yIChpID0gMDsgaSA8IHBsYW5lLT5tb2Rp Zmllcl9jb3VudDsgaSsrKSB7Cj4gKwkJaWYgKG1vZGlmaWVyID09IHBsYW5lLT5tb2RpZmllcnNb aV0pCj4gKwkJCWJyZWFrOwo+ICAJfQo+ICsJaWYgKGkgPT0gcGxhbmUtPm1vZGlmaWVyX2NvdW50 KQo+ICsJCXJldHVybiAtRUlOVkFMOwo+ICAKPiAtCXJldHVybiAtRUlOVkFMOwo+ICsJaWYgKHBs YW5lLT5mdW5jcy0+Zm9ybWF0X21vZF9zdXBwb3J0ZWQgJiYKPiArCSAgICAhcGxhbmUtPmZ1bmNz LT5mb3JtYXRfbW9kX3N1cHBvcnRlZChwbGFuZSwgZm9ybWF0LCBtb2RpZmllcikpCj4gKwkJcmV0 dXJuIC1FSU5WQUw7Cj4gKwo+ICsJcmV0dXJuIDA7Cj4gIH0KPiAgCj4gIC8qCj4gQEAgLTU5OCwx MiArNjE1LDE0IEBAIHN0YXRpYyBpbnQgX19zZXRwbGFuZV9pbnRlcm5hbChzdHJ1Y3QgZHJtX3Bs YW5lICpwbGFuZSwKPiAgCX0KPiAgCj4gIAkvKiBDaGVjayB3aGV0aGVyIHRoaXMgcGxhbmUgc3Vw cG9ydHMgdGhlIGZiIHBpeGVsIGZvcm1hdC4gKi8KPiAtCXJldCA9IGRybV9wbGFuZV9jaGVja19w aXhlbF9mb3JtYXQocGxhbmUsIGZiLT5mb3JtYXQtPmZvcm1hdCk7Cj4gKwlyZXQgPSBkcm1fcGxh bmVfY2hlY2tfcGl4ZWxfZm9ybWF0KHBsYW5lLCBmYi0+Zm9ybWF0LT5mb3JtYXQsCj4gKwkJCQkJ ICAgZmItPm1vZGlmaWVyKTsKPiAgCWlmIChyZXQpIHsKPiAgCQlzdHJ1Y3QgZHJtX2Zvcm1hdF9u YW1lX2J1ZiBmb3JtYXRfbmFtZTsKPiAtCQlEUk1fREVCVUdfS01TKCJJbnZhbGlkIHBpeGVsIGZv cm1hdCAlc1xuIiwKPiAtCQkgICAgICAgICAgICAgIGRybV9nZXRfZm9ybWF0X25hbWUoZmItPmZv cm1hdC0+Zm9ybWF0LAo+IC0JCSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAmZm9y bWF0X25hbWUpKTsKPiArCQlEUk1fREVCVUdfS01TKCJJbnZhbGlkIHBpeGVsIGZvcm1hdCAlcywg bW9kaWZpZXIgMHglbGx4XG4iLAo+ICsJCQkgICAgICBkcm1fZ2V0X2Zvcm1hdF9uYW1lKGZiLT5m b3JtYXQtPmZvcm1hdCwKPiArCQkJCQkJICAmZm9ybWF0X25hbWUpLAo+ICsJCQkgICAgICBmYi0+ bW9kaWZpZXIpOwo+ICAJCWdvdG8gb3V0Owo+ICAJfQo+ICAKPiAtLSAKPiAyLjEzLjYKPiAKPiBf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdm eCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApE YW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8v YmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2 ZWwK