Re: [PATCH v3] i915/drrs/debugfs: psr status info addition

Rodrigo Vivi
2017-11-21T20:56:11Z

On Mon, Nov 20, 2017 at 04:23:47AM +0000, Ramalingam C wrote:
> From: "C, Ramalingam" <ramalingam.c@intel.com>
>
> Existing debugfs entry i915_drrs_status is updated with whether PSR
> is the cause for DRRS disabled state.
>
> [v2]: Dropped the module parameter details as ctl moved from module
> parameter to debugfs. [Rodrigo]
>
> [v3]: Crtc ID information is dropped as there is no immediate usecase.
> [Rodrigo].
>
> Signed-off-by: C, Ramalingam <ramalingam.c@intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
> drivers/gpu/drm/i915/i915_debugfs.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index 0c1501fe4c9f..ea36d4e4d881 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -3567,7 +3567,10 @@ static void drrs_status_per_crtc(struct seq_file *m,
>
> /* disable_drrs() will make drrs->dp NULL */
> if (!drrs->dp) {
> - seq_puts(m, "Idleness DRRS: Disabled");
> + seq_puts(m, "Idleness DRRS: Disabled\n");
> + if (dev_priv->psr.enabled)
> + seq_puts(m,
> + "\tAs PSR is enabled, DRRS is not enabled\n");
> mutex_unlock(&drrs->mutex);
> return;
> }
> --
> 2.7.4
>