Re: [PATCH v2] drm/i915: Move LRC register offsets to a header file

Lucas De Marchi
2018-01-23T16:27:35Z

On Tue, Jan 23, 2018 at 05:18:36PM +0100, Michal Wajdeczko wrote:
> On Tue, 23 Jan 2018 17:06:16 +0100, Lucas De Marchi
> <lucas.demarchi@intel.com> wrote:
>
> > On Tue, Jan 23, 2018 at 08:48:01AM +0000, Chris Wilson wrote:
> > > Quoting Michel Thierry (2018-01-23 00:41:07)
> > > > On 1/22/2018 4:31 PM, Lucas De Marchi wrote:
> > > > > So for this file what I understand is that it should be:
> > > > >
> > > > > // SPDX-License-Identifier: MIT
> > > > > // Copyright (C) 2014-2018 Intel Corporation
> > > >
> > > > So be it.
> > >
> > > Oh no, we don't do C++ comments.
> >
> > We drm or we kernel devs?
> >
> > $ git grep "// SPDX"| wc -l
> > 4487
> >
>
> But on the other hand:
>
> $ git grep "/* SPDX" | wc -l
> 14087

Yes, because initially during the conversion it was thought // couldn't
be in headers, but in the end it was actually a build system bug.

Lucas De Marchi