From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: Fix DSI panels with v1 MIPI sequences without a DEASSERT sequence v2 Date: Fri, 26 Jan 2018 18:38:53 +0200 Message-ID: <20180126163853.GJ5453@intel.com> References: <20180126075207.311-1-hdegoede@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180126075207.311-1-hdegoede@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Hans de Goede Cc: Jan-Michael Brummer , intel-gfx , dri-devel@lists.freedesktop.org, Hans de Goede , Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBKYW4gMjYsIDIwMTggYXQgMDg6NTI6MDdBTSArMDEwMCwgSGFucyBkZSBHb2VkZSB3 cm90ZToKPiBTbyBmYXIgbW9kZWxzIG9mIHRoZSBEZWxsIFZlbnVlIDggUHJvLCB3aXRoIGEgcGFu ZWwgd2l0aCBNSVBJIHBhbmVsCj4gaW5kZXggPSAzLCBvbmUgb2Ygd2hpY2ggaGFzIGJlZW4ga2lu ZGx5IHByb3ZpZGVkIHRvIG1lIGJ5IEphbiBCcnVtbWVyLAo+IHdoZXJlIG5vdCB3b3JraW5nIHdp dGggdGhlIGk5MTUgZHJpdmVyLCBnaXZpbmcgYSBibGFjayBzY3JlZW4gb24gdGhlCj4gZmlyc3Qg bW9kZXNldC4KPiAKPiBUaGUgcHJvYmxlbSB3aXRoIGF0IGxlYXN0IHRoZXNlIERlbGxzIGlzIHRo YXQgdGhlaXIgVkJUIGRlZmluZXMgYSBNSVBJCj4gQVNTRVJUIHNlcXVlbmNlLCBidXQgbm90IGEg REVBU1NFUlQgc2VxdWVuY2UuIEluc3RlYWQgdGhleSBERUFTU0VSVCB0aGUKPiByZXNldCBpbiB0 aGVpciBJTklUX09UUCBzZXF1ZW5jZSwgYnV0IHRoZSBkZWFzc2VydCBtdXN0IGJlIGRvbmUgYmVm b3JlCj4gY2FsbGluZyBpbnRlbF9kc2lfZGV2aWNlX3JlYWR5KCksIHNvIHRoYXQgaXMgdG9vIGxh dGUuCj4gCj4gU2ltcGx5IGRvaW5nIHRoZSBJTklUX09UUCBzZXF1ZW5jZSBlYXJsaWVyIGlzIG5v dCBlbm91Z2ggdG8gZml4IHRoaXMsCj4gYmVjYXVzZSB0aGUgSU5JVF9PVFAgc2VxdWVuY2UgYWxz byBzZW5kcyB2YXJpb3VzIE1JUEkgcGFja2V0cyB0byB0aGUKPiBwYW5lbCwgd2hpY2ggY2FuIG9u bHkgaGFwcGVuIGFmdGVyIGNhbGxpbmcgaW50ZWxfZHNpX2RldmljZV9yZWFkeSgpLgo+IAo+IFRo aXMgY29tbWl0IGZpeGVzIHRoaXMgYnkgc3BsaXR0aW5nIHRoZSBJTklUX09UUCBzZXF1ZW5jZSBp bnRvIGV2ZXJ5dGhpbmcKPiBiZWZvcmUgdGhlIGZpcnN0IERTSSBwYWNrZXQgYW5kIGV2ZXJ5dGhp bmcgZWxzZSwgaW5jbHVkaW5nIHRoZSBmaXJzdCBEU0kKPiBwYWNrZXQuIFRoZSBmaXJzdCBwYXJ0 IChldmVyeXRoaW5nIGJlZm9yZSB0aGUgZmlyc3QgRFNJIHBhY2tldCkgaXMgdGhlbgo+IHVzZWQg YXMgZGVhc3NlcnQgc2VxdWVuY2UuCj4gCj4gQ2hhbmdlZCBpbiB2MjoKPiAtU3BsaXQgdGhlIGlu aXQgT1RQIHNlcXVlbmNlIGludG8gYSBkZWFzc2VydCByZXNldCBhbmQgdGhlIGFjdHVhbCBpbml0 Cj4gIE9UUCBzZXF1ZW5jZSwgaW5zdGVhZCBvZiBjYWxsaW5nIGl0IGVhcmxpZXIgYW5kIHRoZW4g aGF2aW5nIHRoZSBmaXJzdAo+ICBtaXBpX2V4ZWNfc2VuZF9wYWNrZXQoKSBjYWxsIGNhbGwgaW50 ZWxfZHNpX2RldmljZV9yZWFkeSgpLgo+IAo+IEJ1Z0xpbms6IGh0dHBzOi8vYnVncy5mcmVlZGVz a3RvcC5vcmcvc2hvd19idWcuY2dpP2lkPTgyODgwCj4gUmVsYXRlZDogaHR0cHM6Ly9idWdzLmZy ZWVkZXNrdG9wLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAxMjA1Cj4gQ2M6IEphbi1NaWNoYWVsIEJy dW1tZXIgPGphbi5icnVtbWVyQHRhYm9zLm9yZz4KPiBSZXBvcnRlZC1ieTogSmFuLU1pY2hhZWwg QnJ1bW1lciA8amFuLmJydW1tZXJAdGFib3Mub3JnPgo+IFRlc3RlZC1ieTogSGFucyBkZSBHb2Vk ZSA8aGRlZ29lZGVAcmVkaGF0LmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBIYW5zIGRlIEdvZWRlIDxo ZGVnb2VkZUByZWRoYXQuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k c2kuYyAgICAgfCAgMSArCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RzaS5oICAgICB8 ICAyICsKPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHNpX3ZidC5jIHwgODIgKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4gIDMgZmlsZXMgY2hhbmdlZCwgODUgaW5z ZXJ0aW9ucygrKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k c2kuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RzaS5jCj4gaW5kZXggZjY3ZDMyMTM3 NmU0Li5iNTllZjM0ZDI1ZjYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZHNpLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kc2kuYwo+IEBAIC0x NjQyLDYgKzE2NDIsNyBAQCBzdGF0aWMgdm9pZCBpbnRlbF9kc2lfZW5jb2Rlcl9kZXN0cm95KHN0 cnVjdCBkcm1fZW5jb2RlciAqZW5jb2RlcikKPiAgCWlmIChpbnRlbF9kc2ktPmdwaW9fcGFuZWwp Cj4gIAkJZ3Bpb2RfcHV0KGludGVsX2RzaS0+Z3Bpb19wYW5lbCk7Cj4gIAo+ICsJa2ZyZWUoaW50 ZWxfZHNpLT5kZWFzc2VydF9zZXEpOwo+ICAJaW50ZWxfZW5jb2Rlcl9kZXN0cm95KGVuY29kZXIp Owo+ICB9Cj4gIAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kc2ku aCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RzaS5oCj4gaW5kZXggN2FmZWI5NTgwZjQx Li41ODk1NTg4MTQ0YWQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZHNpLmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kc2kuaAo+IEBAIC00Niw2 ICs0Niw4IEBAIHN0cnVjdCBpbnRlbF9kc2kgewo+ICAKPiAgCXN0cnVjdCBpbnRlbF9jb25uZWN0 b3IgKmF0dGFjaGVkX2Nvbm5lY3RvcjsKPiAgCj4gKwl1OCAqZGVhc3NlcnRfc2VxOwo+ICsKClNo b3VsZCB0aGlzIHBlcmhhcHMgbGl2ZSBuZXh0IHRvIHRoZSBvdGhlciBEU0kgVkJUIHN0dWZmPyBJ IHRoaW5rIHRoYXQKbWlnaHQgbWFrZSBtb3JlIHNlbnNlLiBBbmQgc2hvdWxkIHByb2JhYmx5IGFs c28gbW92ZSB0aGUKaW50ZWxfZHNpX2ZpeHVwX2RzaV9zZXF1ZW5jZXMoKSBjYWxsIHRvIHBhcnNl X21pcGlfc2VxdWVuY2UoKSBhcyB3ZWxsCnNpbmNlIHdlJ3JlIGFjdHVhbGx5IG1vZGlmeWluZyBk ZXZfcHJpdi0+dmJ0LmRhdGEuIERvaW5nIHRoYXQgZnJvbSB0aGUKZW5jb2RlciBpbml0IGRvZXNu J3QgcmVhbGx5IGZlZWwgcmlnaHQgdG8gbWUuCgpKYW5pLCBhbnkgdGhvdWdodHM/Cgo+ICAJLyog Yml0IG1hc2sgb2YgcG9ydHMgYmVpbmcgZHJpdmVuICovCj4gIAl1MTYgcG9ydHM7Cj4gIAo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kc2lfdmJ0LmMgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kc2lfdmJ0LmMKPiBpbmRleCA5MWMwN2IwYzhkYjkuLjg0NjY0 Zjc5Y2JlZiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kc2lfdmJ0 LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kc2lfdmJ0LmMKPiBAQCAtNDk5 LDYgKzQ5OSw4NiBAQCBpbnQgaW50ZWxfZHNpX3ZidF9nZXRfbW9kZXMoc3RydWN0IGludGVsX2Rz aSAqaW50ZWxfZHNpKQo+ICAJcmV0dXJuIDE7Cj4gIH0KPiAgCj4gKy8qCj4gKyAqIEdldCBsZW4g b2YgcHJlLWZpeGVkIGRlYXNzZXJ0IGZyb20gaW5pdCBPVFAsIHNraXAgYWxsIGRlbGF5ICsgZ3Bp byBvcGVyYW5kcwo+ICsgKiBhbmQgc3RvcCBhdCB0aGUgZmlyc3QgRFNJIHBhY2tldCBvcC4KPiAr ICovCj4gK3N0YXRpYyBpbnQgaW50ZWxfdmJpX2dldF9kZWFzc2VydF9sZW4oY29uc3QgdTggKmRh dGEsIGludCB0b3RhbCkKPiArewo+ICsJaW50IGluZGV4LCBsZW47CgppZiAoV0FSTl9PTihzZXFf dmVyc2lvbiAhPSAxKSkKCXJldHVybiAwOwoKb3Igc29tZXRoaW5nIG1pZ2h0IGJlIG5pY2UgaGVy ZSB0byBkb2N1bWVudCB0aGUgcmVxdWlyZW1lbnRzIGFuZAp0byBkZXRlciBhbnlvbmUgZnJvbSB1 c2luZyB0aGlzIHdpdGggb3RoZXIgc2VxIHZlcnNpb25zLgoKPiArCj4gKwkvKiBpbmRleCA9IDEg dG8gc2tpcCBzZXF1ZW5jZSBieXRlICovCj4gKwlmb3IgKGluZGV4ID0gMTsgaW5kZXggPCB0b3Rh bDsgaW5kZXggKz0gbGVuKSB7Cj4gKwkJc3dpdGNoIChkYXRhW2luZGV4XSkgewo+ICsJCWNhc2Ug TUlQSV9TRVFfRUxFTV9TRU5EX1BLVDoKPiArCQkJcmV0dXJuIGluZGV4OwoKV2hhdCBpZiB0aGlz IGlzIHRoZSBmaXJzdCBlbGVtZW50PwoKSG1tLiBJdCBkb2VzIHNlZW0gdG8gd29yayBvdXQgaW4g dGhlIGVuZC4gV2UgZG8gZW5kIHVwIHdpdGgKYW4gZW1wdHkgZGVhc3NlcnQgc2VxdWVuY2UsIGJ1 dCBJIGd1ZXNzIGhhdCdzIGZpbmUuCgo+ICsJCWNhc2UgTUlQSV9TRVFfRUxFTV9ERUxBWToKPiAr CQkJbGVuID0gNTsgLyogMSBieXRlIGZvciBvcGVyYW5kICsgdWludDMyICovCj4gKwkJCWJyZWFr Owo+ICsJCWNhc2UgTUlQSV9TRVFfRUxFTV9HUElPOgo+ICsJCQlsZW4gPSAzOyAvKiAxIGJ5dGUg Zm9yIG9wLCAxIGZvciBncGlvX25yLCAxIGZvciB2YWx1ZSAqLwo+ICsJCQlicmVhazsKPiArCQlk ZWZhdWx0Ogo+ICsJCQlyZXR1cm4gMDsKPiArCQl9Cj4gKwl9Cj4gKwo+ICsJcmV0dXJuIDA7Cj4g K30KPiArCj4gKy8qCj4gKyAqIFNvbWUgdjEgVkJUIE1JUEkgc2VxdWVuY2VzIGRvIHRoZSBkZWFz c2VydCBpbiB0aGUgaW5pdCBPVFAgc2VxdWVuY2UuCj4gKyAqIFRoZSBkZWFzc2VydCBtdXN0IGJl IGRvbmUgYmVmb3JlIGNhbGxpbmcgaW50ZWxfZHNpX2RldmljZV9yZWFkeSwgc28gZm9yCj4gKyAq IHRoZXNlIGRldmljZXMgd2Ugc3BsaXQgdGhlIGluaXQgT1RQIHNlcXVlbmNlIGludG8gYSBkZWFz c2VydCBzZXF1ZW5jZSBhbmQKPiArICogdGhlIGFjdHVhbCBpbml0IE9UUCBwYXJ0Lgo+ICsgKi8K PiArc3RhdGljIHZvaWQgaW50ZWxfZHNpX2ZpeHVwX2RzaV9zZXF1ZW5jZXMoc3RydWN0IGludGVs X2RzaSAqaW50ZWxfZHNpKQo+ICt7Cj4gKwlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3By aXYgPSB0b19pOTE1KGludGVsX2RzaS0+YmFzZS5iYXNlLmRldik7Cj4gKwlpbnQgaW5pdF9vdHBf aW5kZXgsIGxlbjsKPiArCXU4ICppbml0X290cDsKPiArCj4gKwkvKiBMaW1pdCB0aGlzIHRvIFZM ViBmb3Igbm93LiAqLwo+ICsJaWYgKCFJU19WQUxMRVlWSUVXKGRldl9wcml2KSkKPiArCQlyZXR1 cm47CgpOb3Qgc3VyZSB2MSBzZXF1ZW5jZXMgZXZlbiBleGlzdCBvbiBvdGhlciBwbGF0Zm9ybXMu IEJ1dCBubwpoYXJtIGluIGhhdmluZyB0aGlzIGNoZWNrIGFueXdheS4KCj4gKwo+ICsJLyogTGlt aXQgdGhpcyB0byB2MSB2aWQtbW9kZSBzZXF1ZW5jZXMgKi8KPiArCWlmIChpbnRlbF9kc2ktPm9w ZXJhdGlvbl9tb2RlICE9IElOVEVMX0RTSV9WSURFT19NT0RFIHx8Cj4gKwkgICAgZGV2X3ByaXYt PnZidC5kc2kuc2VxX3ZlcnNpb24gIT0gMSkKPiArCQlyZXR1cm47Cj4gKwo+ICsJLyogT25seSBk byB0aGlzIGlmIHRoZXJlIGFyZSBvdHAgYW5kIGFzc2VydCBzZXFzIGFuZCBubyBkZWFzc2VydCBz ZXEgKi8KPiArCWlmICghZGV2X3ByaXYtPnZidC5kc2kuc2VxdWVuY2VbTUlQSV9TRVFfSU5JVF9P VFBdIHx8Cj4gKwkgICAgIWRldl9wcml2LT52YnQuZHNpLnNlcXVlbmNlW01JUElfU0VRX0FTU0VS VF9SRVNFVF0gfHwKPiArCSAgICBkZXZfcHJpdi0+dmJ0LmRzaS5zZXF1ZW5jZVtNSVBJX1NFUV9E RUFTU0VSVF9SRVNFVF0pCj4gKwkJcmV0dXJuOwo+ICsKPiArCS8qIFRoZSBkZWFzc2VydC1zZXF1 ZW5jZSBlbmRzIGF0IHRoZSBmaXJzdCBEU0kgcGFja2V0ICovCj4gKwlpbml0X290cF9pbmRleCA9 IGRldl9wcml2LT52YnQuZHNpLnNlcXVlbmNlW01JUElfU0VRX0lOSVRfT1RQXSAtCj4gKwkJCSAo Y29uc3QgdTggKilkZXZfcHJpdi0+dmJ0LmRzaS5kYXRhOwoKV2h5IHRoZSBjYXN0PwoKPiArCWlu aXRfb3RwID0gZGV2X3ByaXYtPnZidC5kc2kuZGF0YSArIGluaXRfb3RwX2luZGV4Owo+ICsJbGVu ID0gZGV2X3ByaXYtPnZidC5kc2kuc2l6ZSAtIGluaXRfb3RwX2luZGV4Owo+ICsJbGVuID0gaW50 ZWxfdmJpX2dldF9kZWFzc2VydF9sZW4oaW5pdF9vdHAsIGxlbik7Cj4gKwlpZiAoIWxlbikKPiAr CQlyZXR1cm47Cj4gKwo+ICsJRFJNX0RFQlVHX0tNUygiVXNpbmcgaW5pdCBPVFAgZnJhZ21lbnQg dG8gZGVhc3NlcnQgcmVzZXRcbiIpOwo+ICsKPiArCS8qIENvcHkgdGhlIGZyYWdtZW50LCB1cGRh dGUgc2VxIGJ5dGUgYW5kIHRlcm1pbmF0ZSBpdCAqLwo+ICsJaW50ZWxfZHNpLT5kZWFzc2VydF9z ZXEgPSBrbWVtZHVwKGluaXRfb3RwLCBsZW4gKyAxLCBHRlBfS0VSTkVMKTsKPiArCWlmICghaW50 ZWxfZHNpLT5kZWFzc2VydF9zZXEpCj4gKwkJcmV0dXJuOwo+ICsJaW50ZWxfZHNpLT5kZWFzc2Vy dF9zZXFbMF0gPSBNSVBJX1NFUV9ERUFTU0VSVF9SRVNFVDsKPiArCWludGVsX2RzaS0+ZGVhc3Nl cnRfc2VxW2xlbl0gPSBNSVBJX1NFUV9FTEVNX0VORDsKPiArCS8qIFVzZSB0aGUgY29weSBmb3Ig ZGVhc3NlcnQgKi8KPiArCWRldl9wcml2LT52YnQuZHNpLnNlcXVlbmNlW01JUElfU0VRX0RFQVNT RVJUX1JFU0VUXSA9Cj4gKwkJaW50ZWxfZHNpLT5kZWFzc2VydF9zZXE7Cj4gKwkvKiBSZXBsYWNl IHRoZSBsYXN0IGJ5dGUgb2YgdGhlIGZyYWdtZW50IHdpdGggaW5pdCBPVFAgc2VxIGJ5dGUgKi8K PiArCWluaXRfb3RwW2xlbiAtIDFdID0gTUlQSV9TRVFfSU5JVF9PVFA7Cj4gKwkvKiBBbmQgbWFr ZSBNSVBJX01JUElfU0VRX0lOSVRfT1RQIHBvaW50IHRvIGl0ICovCj4gKwlkZXZfcHJpdi0+dmJ0 LmRzaS5zZXF1ZW5jZVtNSVBJX1NFUV9JTklUX09UUF0gPSBpbml0X290cCArIGxlbiAtIDE7Cj4g K30KPiArCj4gIGJvb2wgaW50ZWxfZHNpX3ZidF9pbml0KHN0cnVjdCBpbnRlbF9kc2kgKmludGVs X2RzaSwgdTE2IHBhbmVsX2lkKQo+ICB7Cj4gIAlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gaW50 ZWxfZHNpLT5iYXNlLmJhc2UuZGV2Owo+IEBAIC03OTQsNSArODc0LDcgQEAgYm9vbCBpbnRlbF9k c2lfdmJ0X2luaXQoc3RydWN0IGludGVsX2RzaSAqaW50ZWxfZHNpLCB1MTYgcGFuZWxfaWQpCj4g IAkJbWlwaV9kc2lfYXR0YWNoKGludGVsX2RzaS0+ZHNpX2hvc3RzW3BvcnRdLT5kZXZpY2UpOwo+ ICAJfQo+ICAKPiArCWludGVsX2RzaV9maXh1cF9kc2lfc2VxdWVuY2VzKGludGVsX2RzaSk7Cj4g Kwo+ICAJcmV0dXJuIHRydWU7Cj4gIH0KPiAtLSAKPiAyLjE0LjMKCi0tIApWaWxsZSBTeXJqw6Rs w6QKSW50ZWwgT1RDCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZl bAo=