From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Weinehall <david.weinehall@linux.intel.com>
Subject: Re: [PATCH 3/9] drm/i915/psr: Extract PSR DPCD
 initialization and move it to intel_psr.c
Date: Wed, 31 Jan 2018 12:38:24 +0200
Message-ID: <20180131103824.GF13657@boom>
References: <20180127024923.3093-1-dhinakaran.pandiyan@intel.com>
 <20180127024923.3093-3-dhinakaran.pandiyan@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 0BE0B6E44C
 for <intel-gfx@lists.freedesktop.org>; Wed, 31 Jan 2018 10:38:17 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <20180127024923.3093-3-dhinakaran.pandiyan@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Cc: intel-gfx@lists.freedesktop.org, Rodrigo Vivi <rodrigo.vivi@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

T24gRnJpLCBKYW4gMjYsIDIwMTggYXQgMDY6NDk6MTdQTSAtMDgwMCwgRGhpbmFrYXJhbiBQYW5k
aXlhbiB3cm90ZToKPiBpbnRlbF9lZHBfaW5pdF9kcGNkKCkgaXMgY2x1dHRlcmVkIHdpdGggUFNS
IHNwZWNpZmljIERQQ0QgY2hlY2tzIGFuZAo+IGludGVsX2RwLmMgaXMgaHVnZS4KClllcyBwbGVh
c2UhICBHb29kIGlkZWEuCgo+IE5vIGZ1bmN0aW9uYWwgY2hhbmdlIGludGVuZGVkLgoKUmV2aWV3
ZWQtYnk6IERhdmlkIFdlaW5laGFsbCA8ZGF2aWQud2VpbmVoYWxsQGxpbnV4LmludGVsLmNvbT4K
Cj4gQ2M6IFJvZHJpZ28gVml2aSA8cm9kcmlnby52aXZpQGludGVsLmNvbT4KPiBTaWduZWQtb2Zm
LWJ5OiBEaGluYWthcmFuIFBhbmRpeWFuIDxkaGluYWthcmFuLnBhbmRpeWFuQGludGVsLmNvbT4K
PiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYyAgfCA2NCArLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs
X2Rydi5oIHwgIDEgKwo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wc3IuYyB8IDY4ICsr
KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKPiAgMyBmaWxlcyBjaGFuZ2Vk
LCA3MCBpbnNlcnRpb25zKCspLCA2MyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJp
dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs
X2RwLmMKPiBpbmRleCBhMmU4ODc5OTk5MTUuLjI0NTQzMjY2OTBmYiAxMDA2NDQKPiAtLS0gYS9k
cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5
MTUvaW50ZWxfZHAuYwo+IEBAIC0zMTM1LDM1ICszMTM1LDYgQEAgaW50ZWxfZHBfZ2V0X2xpbmtf
c3RhdHVzKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAsIHVpbnQ4X3QgbGlua19zdGF0dXNbRFBf
TElOS18KPiAgCQkJCURQX0xJTktfU1RBVFVTX1NJWkUpID09IERQX0xJTktfU1RBVFVTX1NJWkU7
Cj4gIH0KPiAgCj4gLXN0YXRpYyBib29sIGludGVsX2RwX2dldF95X2NvcmRfc3RhdHVzKHN0cnVj
dCBpbnRlbF9kcCAqaW50ZWxfZHApCj4gLXsKPiAtCXVpbnQ4X3QgcHNyX2NhcHMgPSAwOwo+IC0K
PiAtCWlmIChkcm1fZHBfZHBjZF9yZWFkYigmaW50ZWxfZHAtPmF1eCwgRFBfUFNSX0NBUFMsICZw
c3JfY2FwcykgIT0gMSkKPiAtCQlyZXR1cm4gZmFsc2U7Cj4gLQlyZXR1cm4gcHNyX2NhcHMgJiBE
UF9QU1IyX1NVX1lfQ09PUkRJTkFURV9SRVFVSVJFRDsKPiAtfQo+IC0KPiAtc3RhdGljIGJvb2wg
aW50ZWxfZHBfZ2V0X2NvbG9yaW1ldHJ5X3N0YXR1cyhzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2Rw
KQo+IC17Cj4gLQl1aW50OF90IGRwcnggPSAwOwo+IC0KPiAtCWlmIChkcm1fZHBfZHBjZF9yZWFk
YigmaW50ZWxfZHAtPmF1eCwgRFBfRFBSWF9GRUFUVVJFX0VOVU1FUkFUSU9OX0xJU1QsCj4gLQkJ
CSAgICAgICZkcHJ4KSAhPSAxKQo+IC0JCXJldHVybiBmYWxzZTsKPiAtCXJldHVybiBkcHJ4ICYg
RFBfVlNDX1NEUF9FWFRfRk9SX0NPTE9SSU1FVFJZX1NVUFBPUlRFRDsKPiAtfQo+IC0KPiAtc3Rh
dGljIGJvb2wgaW50ZWxfZHBfZ2V0X2FscG1fc3RhdHVzKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxf
ZHApCj4gLXsKPiAtCXVpbnQ4X3QgYWxwbV9jYXBzID0gMDsKPiAtCj4gLQlpZiAoZHJtX2RwX2Rw
Y2RfcmVhZGIoJmludGVsX2RwLT5hdXgsIERQX1JFQ0VJVkVSX0FMUE1fQ0FQLAo+IC0JCQkgICAg
ICAmYWxwbV9jYXBzKSAhPSAxKQo+IC0JCXJldHVybiBmYWxzZTsKPiAtCXJldHVybiBhbHBtX2Nh
cHMgJiBEUF9BTFBNX0NBUDsKPiAtfQo+IC0KPiAgLyogVGhlc2UgYXJlIHNvdXJjZS1zcGVjaWZp
YyB2YWx1ZXMuICovCj4gIHVpbnQ4X3QKPiAgaW50ZWxfZHBfdm9sdGFnZV9tYXgoc3RydWN0IGlu
dGVsX2RwICppbnRlbF9kcCkKPiBAQCAtMzcxNCw0MCArMzY4NSw3IEBAIGludGVsX2VkcF9pbml0
X2RwY2Qoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCkKPiAgCQlkZXZfcHJpdi0+bm9fYXV4X2hh
bmRzaGFrZSA9IGludGVsX2RwLT5kcGNkW0RQX01BWF9ET1dOU1BSRUFEXSAmCj4gIAkJCURQX05P
X0FVWF9IQU5EU0hBS0VfTElOS19UUkFJTklORzsKPiAgCj4gLQkvKiBDaGVjayBpZiB0aGUgcGFu
ZWwgc3VwcG9ydHMgUFNSICovCj4gLQlkcm1fZHBfZHBjZF9yZWFkKCZpbnRlbF9kcC0+YXV4LCBE
UF9QU1JfU1VQUE9SVCwKPiAtCQkJIGludGVsX2RwLT5wc3JfZHBjZCwKPiAtCQkJIHNpemVvZihp
bnRlbF9kcC0+cHNyX2RwY2QpKTsKPiAtCWlmIChpbnRlbF9kcC0+cHNyX2RwY2RbMF0gJiBEUF9Q
U1JfSVNfU1VQUE9SVEVEKSB7Cj4gLQkJZGV2X3ByaXYtPnBzci5zaW5rX3N1cHBvcnQgPSB0cnVl
Owo+IC0JCURSTV9ERUJVR19LTVMoIkRldGVjdGVkIEVEUCBQU1IgUGFuZWwuXG4iKTsKPiAtCX0K
PiAtCj4gLQlpZiAoSU5URUxfR0VOKGRldl9wcml2KSA+PSA5ICYmCj4gLQkgICAgKGludGVsX2Rw
LT5wc3JfZHBjZFswXSAmIERQX1BTUjJfSVNfU1VQUE9SVEVEKSkgewo+IC0JCXVpbnQ4X3QgZnJh
bWVfc3luY19jYXA7Cj4gLQo+IC0JCWRldl9wcml2LT5wc3Iuc2lua19zdXBwb3J0ID0gdHJ1ZTsK
PiAtCQlpZiAoZHJtX2RwX2RwY2RfcmVhZGIoJmludGVsX2RwLT5hdXgsCj4gLQkJCQkgICAgICBE
UF9TSU5LX0RFVklDRV9BVVhfRlJBTUVfU1lOQ19DQVAsCj4gLQkJCQkgICAgICAmZnJhbWVfc3lu
Y19jYXApICE9IDEpCj4gLQkJCWZyYW1lX3N5bmNfY2FwID0gMDsKPiAtCQlkZXZfcHJpdi0+cHNy
LmF1eF9mcmFtZV9zeW5jID0gZnJhbWVfc3luY19jYXAgPyB0cnVlIDogZmFsc2U7Cj4gLQkJLyog
UFNSMiBuZWVkcyBmcmFtZSBzeW5jIGFzIHdlbGwgKi8KPiAtCQlkZXZfcHJpdi0+cHNyLnBzcjJf
c3VwcG9ydCA9IGRldl9wcml2LT5wc3IuYXV4X2ZyYW1lX3N5bmM7Cj4gLQkJRFJNX0RFQlVHX0tN
UygiUFNSMiAlcyBvbiBzaW5rIiwKPiAtCQkJICAgICAgZGV2X3ByaXYtPnBzci5wc3IyX3N1cHBv
cnQgPyAic3VwcG9ydGVkIiA6ICJub3Qgc3VwcG9ydGVkIik7Cj4gLQo+IC0JCWlmIChkZXZfcHJp
di0+cHNyLnBzcjJfc3VwcG9ydCkgewo+IC0JCQlkZXZfcHJpdi0+cHNyLnlfY29yZF9zdXBwb3J0
ID0KPiAtCQkJCWludGVsX2RwX2dldF95X2NvcmRfc3RhdHVzKGludGVsX2RwKTsKPiAtCQkJZGV2
X3ByaXYtPnBzci5jb2xvcmltZXRyeV9zdXBwb3J0ID0KPiAtCQkJCWludGVsX2RwX2dldF9jb2xv
cmltZXRyeV9zdGF0dXMoaW50ZWxfZHApOwo+IC0JCQlkZXZfcHJpdi0+cHNyLmFscG0gPQo+IC0J
CQkJaW50ZWxfZHBfZ2V0X2FscG1fc3RhdHVzKGludGVsX2RwKTsKPiAtCQl9Cj4gLQo+IC0JfQo+
ICsJaW50ZWxfcHNyX2luaXRfZHBjZChpbnRlbF9kcCk7Cj4gIAo+ICAJLyoKPiAgCSAqIFJlYWQg
dGhlIGVEUCBkaXNwbGF5IGNvbnRyb2wgcmVnaXN0ZXJzLgo+IGRpZmYgLS1naXQgYS9kcml2ZXJz
L2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Ry
di5oCj4gaW5kZXggM2NlZTU0YmMwMzUyLi5hMzQwYmMwNGRhZDggMTAwNjQ0Cj4gLS0tIGEvZHJp
dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkx
NS9pbnRlbF9kcnYuaAo+IEBAIC0xODUxLDYgKzE4NTEsNyBAQCBib29sIGlzX2hkY3Bfc3VwcG9y
dGVkKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwgZW51bSBwb3J0IHBvcnQpOwo+
ICAKPiAgLyogaW50ZWxfcHNyLmMgKi8KPiAgI2RlZmluZSBDQU5fUFNSKGRldl9wcml2KSAoSEFT
X1BTUihkZXZfcHJpdikgJiYgZGV2X3ByaXYtPnBzci5zaW5rX3N1cHBvcnQpCj4gK3ZvaWQgaW50
ZWxfcHNyX2luaXRfZHBjZChzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwKTsKPiAgdm9pZCBpbnRl
bF9wc3JfZW5hYmxlKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAsCj4gIAkJICAgICAgY29uc3Qg
c3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUpOwo+ICB2b2lkIGludGVsX3Bzcl9k
aXNhYmxlKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAsCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv
Z3B1L2RybS9pOTE1L2ludGVsX3Bzci5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNy
LmMKPiBpbmRleCBjMTJhZjExMTg2NDcuLmExYjg3ODQ0OWU4MyAxMDA2NDQKPiAtLS0gYS9kcml2
ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wc3IuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1
L2ludGVsX3Bzci5jCj4gQEAgLTU2LDYgKzU2LDc0IEBACj4gICNpbmNsdWRlICJpbnRlbF9kcnYu
aCIKPiAgI2luY2x1ZGUgImk5MTVfZHJ2LmgiCj4gIAo+ICtzdGF0aWMgYm9vbCBpbnRlbF9kcF9n
ZXRfeV9jb3JkX3N0YXR1cyhzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwKQo+ICt7Cj4gKwl1aW50
OF90IHBzcl9jYXBzID0gMDsKPiArCj4gKwlpZiAoZHJtX2RwX2RwY2RfcmVhZGIoJmludGVsX2Rw
LT5hdXgsIERQX1BTUl9DQVBTLCAmcHNyX2NhcHMpICE9IDEpCj4gKwkJcmV0dXJuIGZhbHNlOwo+
ICsJcmV0dXJuIHBzcl9jYXBzICYgRFBfUFNSMl9TVV9ZX0NPT1JESU5BVEVfUkVRVUlSRUQ7Cj4g
K30KPiArCj4gK3N0YXRpYyBib29sIGludGVsX2RwX2dldF9jb2xvcmltZXRyeV9zdGF0dXMoc3Ry
dWN0IGludGVsX2RwICppbnRlbF9kcCkKPiArewo+ICsJdWludDhfdCBkcHJ4ID0gMDsKPiArCj4g
KwlpZiAoZHJtX2RwX2RwY2RfcmVhZGIoJmludGVsX2RwLT5hdXgsIERQX0RQUlhfRkVBVFVSRV9F
TlVNRVJBVElPTl9MSVNULAo+ICsJCQkgICAgICAmZHByeCkgIT0gMSkKPiArCQlyZXR1cm4gZmFs
c2U7Cj4gKwlyZXR1cm4gZHByeCAmIERQX1ZTQ19TRFBfRVhUX0ZPUl9DT0xPUklNRVRSWV9TVVBQ
T1JURUQ7Cj4gK30KPiArCj4gK3N0YXRpYyBib29sIGludGVsX2RwX2dldF9hbHBtX3N0YXR1cyhz
dHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwKQo+ICt7Cj4gKwl1aW50OF90IGFscG1fY2FwcyA9IDA7
Cj4gKwo+ICsJaWYgKGRybV9kcF9kcGNkX3JlYWRiKCZpbnRlbF9kcC0+YXV4LCBEUF9SRUNFSVZF
Ul9BTFBNX0NBUCwKPiArCQkJICAgICAgJmFscG1fY2FwcykgIT0gMSkKPiArCQlyZXR1cm4gZmFs
c2U7Cj4gKwlyZXR1cm4gYWxwbV9jYXBzICYgRFBfQUxQTV9DQVA7Cj4gK30KPiArCj4gK3ZvaWQg
aW50ZWxfcHNyX2luaXRfZHBjZChzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwKQo+ICt7Cj4gKwlz
dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPQo+ICsJCXRvX2k5MTUoZHBfdG9fZGln
X3BvcnQoaW50ZWxfZHApLT5iYXNlLmJhc2UuZGV2KTsKPiArCj4gKwlkcm1fZHBfZHBjZF9yZWFk
KCZpbnRlbF9kcC0+YXV4LCBEUF9QU1JfU1VQUE9SVCwgaW50ZWxfZHAtPnBzcl9kcGNkLAo+ICsJ
CQkgc2l6ZW9mKGludGVsX2RwLT5wc3JfZHBjZCkpOwo+ICsKPiArCWlmIChpbnRlbF9kcC0+cHNy
X2RwY2RbMF0gJiBEUF9QU1JfSVNfU1VQUE9SVEVEKSB7Cj4gKwkJZGV2X3ByaXYtPnBzci5zaW5r
X3N1cHBvcnQgPSB0cnVlOwo+ICsJCURSTV9ERUJVR19LTVMoIkRldGVjdGVkIEVEUCBQU1IgUGFu
ZWwuXG4iKTsKPiArCX0KPiArCj4gKwlpZiAoSU5URUxfR0VOKGRldl9wcml2KSA+PSA5ICYmCj4g
KwkgICAgKGludGVsX2RwLT5wc3JfZHBjZFswXSAmIERQX1BTUjJfSVNfU1VQUE9SVEVEKSkgewo+
ICsJCXVpbnQ4X3QgZnJhbWVfc3luY19jYXA7Cj4gKwo+ICsJCWRldl9wcml2LT5wc3Iuc2lua19z
dXBwb3J0ID0gdHJ1ZTsKPiArCQlpZiAoZHJtX2RwX2RwY2RfcmVhZGIoJmludGVsX2RwLT5hdXgs
Cj4gKwkJCQkgICAgICBEUF9TSU5LX0RFVklDRV9BVVhfRlJBTUVfU1lOQ19DQVAsCj4gKwkJCQkg
ICAgICAmZnJhbWVfc3luY19jYXApICE9IDEpCj4gKwkJCWZyYW1lX3N5bmNfY2FwID0gMDsKPiAr
CQlkZXZfcHJpdi0+cHNyLmF1eF9mcmFtZV9zeW5jID0gZnJhbWVfc3luY19jYXAgPyB0cnVlIDog
ZmFsc2U7Cj4gKwkJLyogUFNSMiBuZWVkcyBmcmFtZSBzeW5jIGFzIHdlbGwgKi8KPiArCQlkZXZf
cHJpdi0+cHNyLnBzcjJfc3VwcG9ydCA9IGRldl9wcml2LT5wc3IuYXV4X2ZyYW1lX3N5bmM7Cj4g
KwkJRFJNX0RFQlVHX0tNUygiUFNSMiAlcyBvbiBzaW5rIiwKPiArCQkJICAgICAgZGV2X3ByaXYt
PnBzci5wc3IyX3N1cHBvcnQgPyAic3VwcG9ydGVkIiA6ICJub3Qgc3VwcG9ydGVkIik7Cj4gKwo+
ICsJCWlmIChkZXZfcHJpdi0+cHNyLnBzcjJfc3VwcG9ydCkgewo+ICsJCQlkZXZfcHJpdi0+cHNy
LnlfY29yZF9zdXBwb3J0ID0KPiArCQkJCWludGVsX2RwX2dldF95X2NvcmRfc3RhdHVzKGludGVs
X2RwKTsKPiArCQkJZGV2X3ByaXYtPnBzci5jb2xvcmltZXRyeV9zdXBwb3J0ID0KPiArCQkJCWlu
dGVsX2RwX2dldF9jb2xvcmltZXRyeV9zdGF0dXMoaW50ZWxfZHApOwo+ICsJCQlkZXZfcHJpdi0+
cHNyLmFscG0gPQo+ICsJCQkJaW50ZWxfZHBfZ2V0X2FscG1fc3RhdHVzKGludGVsX2RwKTsKPiAr
CQl9Cj4gKwl9Cj4gK30KPiArCj4gIHN0YXRpYyBib29sIHZsdl9pc19wc3JfYWN0aXZlX29uX3Bp
cGUoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgaW50IHBpcGUpCj4gIHsKPiAgCXN0cnVjdCBkcm1f
aTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZGV2KTsKPiAtLSAKPiAyLjE0LjEKPiAK
PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVs
LWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0
cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1h
aWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu
ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==