From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 2/2] drm/i915: Fix DSI panels with v1 MIPI sequences without a DEASSERT sequence v3 Date: Fri, 2 Feb 2018 18:17:38 +0200 Message-ID: <20180202161738.GE5453@intel.com> References: <20180129144735.32412-1-hdegoede@redhat.com> <20180129144735.32412-2-hdegoede@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180129144735.32412-2-hdegoede@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Hans de Goede Cc: Jan-Michael Brummer , intel-gfx , dri-devel@lists.freedesktop.org, Hans de Goede , Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBKYW4gMjksIDIwMTggYXQgMDM6NDc6MzVQTSArMDEwMCwgSGFucyBkZSBHb2VkZSB3 cm90ZToKPiBTbyBmYXIgbW9kZWxzIG9mIHRoZSBEZWxsIFZlbnVlIDggUHJvLCB3aXRoIGEgcGFu ZWwgd2l0aCBNSVBJIHBhbmVsCj4gaW5kZXggPSAzLCBvbmUgb2Ygd2hpY2ggaGFzIGJlZW4ga2lu ZGx5IHByb3ZpZGVkIHRvIG1lIGJ5IEphbiBCcnVtbWVyLAo+IHdoZXJlIG5vdCB3b3JraW5nIHdp dGggdGhlIGk5MTUgZHJpdmVyLCBnaXZpbmcgYSBibGFjayBzY3JlZW4gb24gdGhlCj4gZmlyc3Qg bW9kZXNldC4KPiAKPiBUaGUgcHJvYmxlbSB3aXRoIGF0IGxlYXN0IHRoZXNlIERlbGxzIGlzIHRo YXQgdGhlaXIgVkJUIGRlZmluZXMgYSBNSVBJCj4gQVNTRVJUIHNlcXVlbmNlLCBidXQgbm90IGEg REVBU1NFUlQgc2VxdWVuY2UuIEluc3RlYWQgdGhleSBERUFTU0VSVCB0aGUKPiByZXNldCBpbiB0 aGVpciBJTklUX09UUCBzZXF1ZW5jZSwgYnV0IHRoZSBkZWFzc2VydCBtdXN0IGJlIGRvbmUgYmVm b3JlCj4gY2FsbGluZyBpbnRlbF9kc2lfZGV2aWNlX3JlYWR5KCksIHNvIHRoYXQgaXMgdG9vIGxh dGUuCj4gCj4gU2ltcGx5IGRvaW5nIHRoZSBJTklUX09UUCBzZXF1ZW5jZSBlYXJsaWVyIGlzIG5v dCBlbm91Z2ggdG8gZml4IHRoaXMsCj4gYmVjYXVzZSB0aGUgSU5JVF9PVFAgc2VxdWVuY2UgYWxz byBzZW5kcyB2YXJpb3VzIE1JUEkgcGFja2V0cyB0byB0aGUKPiBwYW5lbCwgd2hpY2ggY2FuIG9u bHkgaGFwcGVuIGFmdGVyIGNhbGxpbmcgaW50ZWxfZHNpX2RldmljZV9yZWFkeSgpLgo+IAo+IFRo aXMgY29tbWl0IGZpeGVzIHRoaXMgYnkgc3BsaXR0aW5nIHRoZSBJTklUX09UUCBzZXF1ZW5jZSBp bnRvIGV2ZXJ5dGhpbmcKPiBiZWZvcmUgdGhlIGZpcnN0IERTSSBwYWNrZXQgYW5kIGV2ZXJ5dGhp bmcgZWxzZSwgaW5jbHVkaW5nIHRoZSBmaXJzdCBEU0kKPiBwYWNrZXQuIFRoZSBmaXJzdCBwYXJ0 IChldmVyeXRoaW5nIGJlZm9yZSB0aGUgZmlyc3QgRFNJIHBhY2tldCkgaXMgdGhlbgo+IHVzZWQg YXMgZGVhc3NlcnQgc2VxdWVuY2UuCj4gCj4gQ2hhbmdlZCBpbiB2MjoKPiAtU3BsaXQgdGhlIGlu aXQgT1RQIHNlcXVlbmNlIGludG8gYSBkZWFzc2VydCByZXNldCBhbmQgdGhlIGFjdHVhbCBpbml0 Cj4gIE9UUCBzZXF1ZW5jZSwgaW5zdGVhZCBvZiBjYWxsaW5nIGl0IGVhcmxpZXIgYW5kIHRoZW4g aGF2aW5nIHRoZSBmaXJzdAo+ICBtaXBpX2V4ZWNfc2VuZF9wYWNrZXQoKSBjYWxsIGNhbGwgaW50 ZWxfZHNpX2RldmljZV9yZWFkeSgpLgo+IAo+IENoYW5nZXMgaW4gdjM6Cj4gLU1vdmUgdGhlIHdo b2xlIHNoZWJhbmcgdG8gaW50ZWxfYmlvcy5jCj4gCj4gQnVnTGluazogaHR0cHM6Ly9idWdzLmZy ZWVkZXNrdG9wLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODI4ODAKCkJ1Z3ppbGxhOgoKPiBSZWxhdGVk OiBodHRwczovL2J1Z3MuZnJlZWRlc2t0b3Aub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDEyMDUKClJl ZmVyZW5jZXM6Cgo+IENjOiBKYW4tTWljaGFlbCBCcnVtbWVyIDxqYW4uYnJ1bW1lckB0YWJvcy5v cmc+Cj4gUmVwb3J0ZWQtYnk6IEphbi1NaWNoYWVsIEJydW1tZXIgPGphbi5icnVtbWVyQHRhYm9z Lm9yZz4KPiBUZXN0ZWQtYnk6IEhhbnMgZGUgR29lZGUgPGhkZWdvZWRlQHJlZGhhdC5jb20+Cj4g U2lnbmVkLW9mZi1ieTogSGFucyBkZSBHb2VkZSA8aGRlZ29lZGVAcmVkaGF0LmNvbT4KClRoaXMg b25lIHNlZW1zIGdvb2QgdG8gbWUsIGFuZCBKYW5pIGhhc24ndCBjb21wbGFpbmVkIGFib3V0IGFu eXRoaW5nIHNvClJldmlld2VkLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGlu dXguaW50ZWwuY29tPgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCAg IHwgIDEgKwo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9iaW9zLmMgfCA4MyArKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKPiAgMiBmaWxlcyBjaGFuZ2VkLCA4NCBp bnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf ZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gaW5kZXggMDgxMTkwZGEw ODE4Li4xZjM0NjI2Njk1NmIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkx NV9kcnYuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiBAQCAtMTM0 OSw2ICsxMzQ5LDcgQEAgc3RydWN0IGludGVsX3ZidF9kYXRhIHsKPiAgCQl1MzIgc2l6ZTsKPiAg CQl1OCAqZGF0YTsKPiAgCQljb25zdCB1OCAqc2VxdWVuY2VbTUlQSV9TRVFfTUFYXTsKPiArCQl1 OCAqZGVhc3NlcnRfc2VxOyAvKiBVc2VkIGJ5IGZpeHVwX21pcGlfc2VxdWVuY2VzKCkgKi8KPiAg CX0gZHNpOwo+ICAKPiAgCWludCBjcnRfZGRjX3BpbjsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfYmlvcy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYmlv cy5jCj4gaW5kZXggNjRhMGQ1NWRmMjhlLi5jY2E2MjBmOGRlYjYgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYmlvcy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfYmlvcy5jCj4gQEAgLTk0Nyw2ICs5NDcsODYgQEAgc3RhdGljIGludCBnb3RvX25l eHRfc2VxdWVuY2VfdjMoY29uc3QgdTggKmRhdGEsIGludCBpbmRleCwgaW50IHRvdGFsKQo+ICAJ cmV0dXJuIDA7Cj4gIH0KPiAgCj4gKy8qCj4gKyAqIEdldCBsZW4gb2YgcHJlLWZpeGVkIGRlYXNz ZXJ0IGZyYWdtZW50IGZyb20gYSB2MSBpbml0IE9UUCBzZXF1ZW5jZSwKPiArICogc2tpcCBhbGwg ZGVsYXkgKyBncGlvIG9wZXJhbmRzIGFuZCBzdG9wIGF0IHRoZSBmaXJzdCBEU0kgcGFja2V0IG9w Lgo+ICsgKi8KPiArc3RhdGljIGludCBnZXRfaW5pdF9vdHBfZGVhc3NlcnRfZnJhZ21lbnRfbGVu KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiArewo+ICsJY29uc3QgdTggKmRh dGEgPSBkZXZfcHJpdi0+dmJ0LmRzaS5zZXF1ZW5jZVtNSVBJX1NFUV9JTklUX09UUF07Cj4gKwlp bnQgaW5kZXgsIGxlbjsKPiArCj4gKwlpZiAoV0FSTl9PTighZGF0YSB8fCBkZXZfcHJpdi0+dmJ0 LmRzaS5zZXFfdmVyc2lvbiAhPSAxKSkKPiArCQlyZXR1cm4gMDsKPiArCj4gKwkvKiBpbmRleCA9 IDEgdG8gc2tpcCBzZXF1ZW5jZSBieXRlICovCj4gKwlmb3IgKGluZGV4ID0gMTsgZGF0YVtpbmRl eF0gIT0gTUlQSV9TRVFfRUxFTV9FTkQ7IGluZGV4ICs9IGxlbikgewo+ICsJCXN3aXRjaCAoZGF0 YVtpbmRleF0pIHsKPiArCQljYXNlIE1JUElfU0VRX0VMRU1fU0VORF9QS1Q6Cj4gKwkJCXJldHVy biBpbmRleCA9PSAxID8gMCA6IGluZGV4Owo+ICsJCWNhc2UgTUlQSV9TRVFfRUxFTV9ERUxBWToK PiArCQkJbGVuID0gNTsgLyogMSBieXRlIGZvciBvcGVyYW5kICsgdWludDMyICovCj4gKwkJCWJy ZWFrOwo+ICsJCWNhc2UgTUlQSV9TRVFfRUxFTV9HUElPOgo+ICsJCQlsZW4gPSAzOyAvKiAxIGJ5 dGUgZm9yIG9wLCAxIGZvciBncGlvX25yLCAxIGZvciB2YWx1ZSAqLwo+ICsJCQlicmVhazsKPiAr CQlkZWZhdWx0Ogo+ICsJCQlyZXR1cm4gMDsKPiArCQl9Cj4gKwl9Cj4gKwo+ICsJcmV0dXJuIDA7 Cj4gK30KPiArCj4gKy8qCj4gKyAqIFNvbWUgdjEgVkJUIE1JUEkgc2VxdWVuY2VzIGRvIHRoZSBk ZWFzc2VydCBpbiB0aGUgaW5pdCBPVFAgc2VxdWVuY2UuCj4gKyAqIFRoZSBkZWFzc2VydCBtdXN0 IGJlIGRvbmUgYmVmb3JlIGNhbGxpbmcgaW50ZWxfZHNpX2RldmljZV9yZWFkeSwgc28gZm9yCj4g KyAqIHRoZXNlIGRldmljZXMgd2Ugc3BsaXQgdGhlIGluaXQgT1RQIHNlcXVlbmNlIGludG8gYSBk ZWFzc2VydCBzZXF1ZW5jZSBhbmQKPiArICogdGhlIGFjdHVhbCBpbml0IE9UUCBwYXJ0Lgo+ICsg Ki8KPiArc3RhdGljIHZvaWQgZml4dXBfbWlwaV9zZXF1ZW5jZXMoc3RydWN0IGRybV9pOTE1X3By aXZhdGUgKmRldl9wcml2KQo+ICt7Cj4gKwl1OCAqaW5pdF9vdHA7Cj4gKwlpbnQgbGVuOwo+ICsK PiArCS8qIExpbWl0IHRoaXMgdG8gVkxWIGZvciBub3cuICovCj4gKwlpZiAoIUlTX1ZBTExFWVZJ RVcoZGV2X3ByaXYpKQo+ICsJCXJldHVybjsKPiArCj4gKwkvKiBMaW1pdCB0aGlzIHRvIHYxIHZp ZC1tb2RlIHNlcXVlbmNlcyAqLwo+ICsJaWYgKGRldl9wcml2LT52YnQuZHNpLmNvbmZpZy0+aXNf Y21kX21vZGUgfHwKPiArCSAgICBkZXZfcHJpdi0+dmJ0LmRzaS5zZXFfdmVyc2lvbiAhPSAxKQo+ ICsJCXJldHVybjsKPiArCj4gKwkvKiBPbmx5IGRvIHRoaXMgaWYgdGhlcmUgYXJlIG90cCBhbmQg YXNzZXJ0IHNlcXMgYW5kIG5vIGRlYXNzZXJ0IHNlcSAqLwo+ICsJaWYgKCFkZXZfcHJpdi0+dmJ0 LmRzaS5zZXF1ZW5jZVtNSVBJX1NFUV9JTklUX09UUF0gfHwKPiArCSAgICAhZGV2X3ByaXYtPnZi dC5kc2kuc2VxdWVuY2VbTUlQSV9TRVFfQVNTRVJUX1JFU0VUXSB8fAo+ICsJICAgIGRldl9wcml2 LT52YnQuZHNpLnNlcXVlbmNlW01JUElfU0VRX0RFQVNTRVJUX1JFU0VUXSkKPiArCQlyZXR1cm47 Cj4gKwo+ICsJLyogVGhlIGRlYXNzZXJ0LXNlcXVlbmNlIGVuZHMgYXQgdGhlIGZpcnN0IERTSSBw YWNrZXQgKi8KPiArCWxlbiA9IGdldF9pbml0X290cF9kZWFzc2VydF9mcmFnbWVudF9sZW4oZGV2 X3ByaXYpOwo+ICsJaWYgKCFsZW4pCj4gKwkJcmV0dXJuOwo+ICsKPiArCURSTV9ERUJVR19LTVMo IlVzaW5nIGluaXQgT1RQIGZyYWdtZW50IHRvIGRlYXNzZXJ0IHJlc2V0XG4iKTsKPiArCj4gKwkv KiBDb3B5IHRoZSBmcmFnbWVudCwgdXBkYXRlIHNlcSBieXRlIGFuZCB0ZXJtaW5hdGUgaXQgKi8K PiArCWluaXRfb3RwID0gKHU4ICopZGV2X3ByaXYtPnZidC5kc2kuc2VxdWVuY2VbTUlQSV9TRVFf SU5JVF9PVFBdOwo+ICsJZGV2X3ByaXYtPnZidC5kc2kuZGVhc3NlcnRfc2VxID0ga21lbWR1cChp bml0X290cCwgbGVuICsgMSwgR0ZQX0tFUk5FTCk7Cj4gKwlpZiAoIWRldl9wcml2LT52YnQuZHNp LmRlYXNzZXJ0X3NlcSkKPiArCQlyZXR1cm47Cj4gKwlkZXZfcHJpdi0+dmJ0LmRzaS5kZWFzc2Vy dF9zZXFbMF0gPSBNSVBJX1NFUV9ERUFTU0VSVF9SRVNFVDsKPiArCWRldl9wcml2LT52YnQuZHNp LmRlYXNzZXJ0X3NlcVtsZW5dID0gTUlQSV9TRVFfRUxFTV9FTkQ7Cj4gKwkvKiBVc2UgdGhlIGNv cHkgZm9yIGRlYXNzZXJ0ICovCj4gKwlkZXZfcHJpdi0+dmJ0LmRzaS5zZXF1ZW5jZVtNSVBJX1NF UV9ERUFTU0VSVF9SRVNFVF0gPQo+ICsJCWRldl9wcml2LT52YnQuZHNpLmRlYXNzZXJ0X3NlcTsK PiArCS8qIFJlcGxhY2UgdGhlIGxhc3QgYnl0ZSBvZiB0aGUgZnJhZ21lbnQgd2l0aCBpbml0IE9U UCBzZXEgYnl0ZSAqLwo+ICsJaW5pdF9vdHBbbGVuIC0gMV0gPSBNSVBJX1NFUV9JTklUX09UUDsK PiArCS8qIEFuZCBtYWtlIE1JUElfTUlQSV9TRVFfSU5JVF9PVFAgcG9pbnQgdG8gaXQgKi8KPiAr CWRldl9wcml2LT52YnQuZHNpLnNlcXVlbmNlW01JUElfU0VRX0lOSVRfT1RQXSA9IGluaXRfb3Rw ICsgbGVuIC0gMTsKPiArfQo+ICsKPiAgc3RhdGljIHZvaWQKPiAgcGFyc2VfbWlwaV9zZXF1ZW5j ZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAkJICAgIGNvbnN0IHN0cnVj dCBiZGJfaGVhZGVyICpiZGIpCj4gQEAgLTEwMTYsNiArMTA5Niw4IEBAIHBhcnNlX21pcGlfc2Vx dWVuY2Uoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAJZGV2X3ByaXYtPnZi dC5kc2kuc2l6ZSA9IHNlcV9zaXplOwo+ICAJZGV2X3ByaXYtPnZidC5kc2kuc2VxX3ZlcnNpb24g PSBzZXF1ZW5jZS0+dmVyc2lvbjsKPiAgCj4gKwlmaXh1cF9taXBpX3NlcXVlbmNlcyhkZXZfcHJp dik7Cj4gKwo+ICAJRFJNX0RFQlVHX0RSSVZFUigiTUlQSSByZWxhdGVkIFZCVCBwYXJzaW5nIGNv bXBsZXRlXG4iKTsKPiAgCXJldHVybjsKPiAgCj4gQEAgLTE1OTQsNiArMTY3Niw3IEBAIHZvaWQg aW50ZWxfYmlvc19pbml0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgICov Cj4gIHZvaWQgaW50ZWxfYmlvc19jbGVhbnVwKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZf cHJpdikKPiAgewo+ICsJa2ZyZWUoZGV2X3ByaXYtPnZidC5kc2kuZGVhc3NlcnRfc2VxKTsKPiAg CWtmcmVlKGRldl9wcml2LT52YnQuZHNpLmRhdGEpOwo+ICAJa2ZyZWUoZGV2X3ByaXYtPnZidC5k c2kucHBzKTsKPiAgCWtmcmVlKGRldl9wcml2LT52YnQuZHNpLmNvbmZpZyk7Cj4gLS0gCj4gMi4x NC4zCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZl bEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9kcmktZGV2ZWwK