Re: [PATCH 3/5] drm/i915: Call i915_pipe_update_start with uncore.lock held.

Chris Wilson
2018-02-10T09:05:20Z

Quoting Maarten Lankhorst (2018-02-10 08:46:14)
> Op 10-02-18 om 00:08 schreef James Ausmus:
> > On Fri, Feb 09, 2018 at 10:54:02AM +0100, Maarten Lankhorst wrote:
> >> +static u32 i915_get_vblank_counter(struct drm_device *dev, unsigned int pipe)
> >> +{
> >> + struct drm_i915_private *dev_priv = to_i915(dev);
> >> + unsigned long irqflags;
> >> + u32 ret;
> >> +
> >> + spin_lock_irqsave(&dev_priv->uncore.lock, irqflags);
> >> + ret = i915_get_vblank_counter(dev, pipe);
> > Shouldn't this be __i915_get_vblank_counter ?
> Good catch, it shouldn't have passed BAT. I guess we don't have a g4 or gen3 system there.

You killed them!
-Chris